From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.15332.1682583689763811110 for ; Thu, 27 Apr 2023 01:21:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=c0naXyOp; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682583689; x=1714119689; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2NZLd1UN1VeSRnPHjBP6AyXrPh7mbJKinmokXgZHFtc=; b=c0naXyOpCmGyp9Ib+zs+bajTZlI+YLGHqVR4V3We6YwgnL8Oi12wS7os nHa1RXBFuGTlAt4QFJQO7tvqzcL+1ChIHFXGVTN6TiP09Q8YT+nTEicum H8FqaO1GfV+1g5KH9L9SPwO67qjKWxba245Ast/eqtoPuu7UXQ5CbSwcM Ajf8p6gzgwGQLf2/j8OJKpqJbCPNr/wDUHGt+uhPlIZhKhXjU7KNxwP3O oNFHx8RlDk8xa6kNJovJwRD3Pe/sLNRZvaIviRdTZV8nwBfyZQJ0Ysa5I 8YBWePsFNQAHfN25MqcA9aPt9xgB3f+ho0WN5sF5HFesFqJ1y6plP1KZ7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="331619004" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="331619004" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 01:21:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="868609531" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="868609531" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 27 Apr 2023 01:21:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 01:21:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 01:21:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 01:21:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 01:21:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fePtNCh0gX7ODdf1E1xEklQ3v2oRFp2Nk+spitzIkRpi/tId8vholBI/Vx2VhjI/hZOj3ePs5yDLa8w4Y2svZtaml6mjlzRwpnCn0Ea72VArTAFH9qFXoY52VbHnr2A3LYRJ/71FakextIsw8zg7a75vPyOm14iMHEqxs0Nz20U3TbQUZs4kh9isDJor/Oo1Bw+zIY+NDpLKZq3xGAwQgD4n+ouVhIAPQKZlsBRYT2/y1grqwCo9ji2Unfu5je6nLK0yNT0NwpKs+9vyznQtnDTFrDJfW7pvGNF2UtD+ayrNN+ALT0McSqFfAzFsxX3zp6GlKMlcRjnqslUpZTkQEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WqJ2JJehDkfKqcIHIbT+d43QxaPRZAectOFmJleQEfU=; b=IJQdQNQ7ptvKrQQPvvO96/JHilfkvkb1uV78BO/m3hQ/kS17m3rUyMB1gyOVH80n5AvgUwNqAK5VkHDuJJqxbShU9bbICuXAyHEqNqfSuTwSH+HseoJ0gGkXhXxdecqfeCqg2B1ornop3s4SGuqP3zJ6xg2VeYAo8RB+VJyTdt0x2o4x0gZaMRSdgyHl8ujKVFVwrPgqdrpW/5f37/Mq83fOku26aAfFVcCUbcAM6+Ag44sWRXqaPgIWwI1syk9sqoaK/pBPPGBp1skWvANI5N7tvgxwSczHjwuz3gBRjjrnx4oOMZGWKQNalczIhJqklxwuyV5KTpCneKe/Aonf4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SA1PR11MB6942.namprd11.prod.outlook.com (2603:10b6:806:2bf::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 08:21:23 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388%6]) with mapi id 15.20.6319.022; Thu, 27 Apr 2023 08:21:23 +0000 From: "Yao, Jiewen" To: "Lu, Pen-ChunX" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Topic: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Index: AQHZeNXMJtPvBOVXr0GNyctV11trcq8+yAdAgAACU4CAAAYY4A== Date: Thu, 27 Apr 2023 08:21:23 +0000 Message-ID: References: <20230427065830.29735-1-pen-chunx.lu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SA1PR11MB6942:EE_ x-ms-office365-filtering-correlation-id: 1a4ee930-d7f0-489f-9bc9-08db46f86361 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zq5CDN+Sr7FaPgT+3L5xp0+NdTsG5HRoZ7HfVSJPmnWpeDW+2Ttzw4GH4k0qdyO2zvkRb4TXa1spMXUYZKimm7rN+OC24f1wr6b/X+z6poUHKScswov4H13ZhntDgWXz1xH/1FQMryXB7NRypuh9/arn1axqugZknBH5grqWSZ1XQZnJmCKZwoQc32zbe+F193z8H89l6sVDrerEN9AdrOWuUFpbslQp59SywuwfZObgAE2NRkWW90b9t9brGUfPdOH9J7W1wsZ/VCErAWsE987feqimf8wN0wVp+HMmYOzCQwpP2/6zzEhqoE+wCCMH6flfMnD6EHXNXFy766p5Qt1RVXabD0Jbi/WI2nN95gnxp55vdmuRhcEdH1plLNeDKEaznBNRF95HdyRPxwVT9SwJaksBuMIIua9aaCrBjqT6HirSz5q091VygMnjxdxNX7RUf52iuKC0NkfwANUEsyMmc8aRA3XwlxADYX1sMoiJCWzvZhNJLEVsG4+8JM/rZVl7VY7UEbGZ2X+F1JwVGXl63xJnxLYsoBHdwBtV/KPM2U+THC38qRgxSjGednwD+l10kq11LV5zd2h5srY3Yg0uPgBF4HMx5QIjAtJT9qG/IrZNUJGLjgPXgdR+BIZ5 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199021)(316002)(4326008)(66946007)(76116006)(64756008)(66476007)(66556008)(66446008)(110136005)(107886003)(7696005)(71200400001)(86362001)(478600001)(55016003)(186003)(33656002)(53546011)(6506007)(9686003)(26005)(5660300002)(82960400001)(52536014)(122000001)(41300700001)(15650500001)(2906002)(38100700002)(38070700005)(83380400001)(8936002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gi2yH97+qx2XzrvCw4dgjUkHbmN/YkDMYVWmkuHLB+SVtgXB2O350xp6gkYp?= =?us-ascii?Q?/E0EhZw0RoK8NX0weSrmzyGYQEsWHepu95x8DHtJ4rLkcY7gCmD/KDcxn/I7?= =?us-ascii?Q?QJ9GkwXnyDNxEXSxY90EmobbfpkDdzifwZ7KvPkoHPGb0zs3R8Z+0Mll5QRh?= =?us-ascii?Q?cGrUOVmIQiVdqV1Q7Ck4VXBjURyrbWVOH8adoYJT8hacL9pmuQd0LjRdZJht?= =?us-ascii?Q?LQV5gVBG0oiaTvsqxXfghKY+2UsIpOAM9vf0YfFdmiwUW4LrT80cJmmGJwfK?= =?us-ascii?Q?jnvgvFprpXMFhn4L9IJ7XGOIU9T17/l7sbaTkOxZn3rEMt+Sln9fftGte5lI?= =?us-ascii?Q?rrgqjkXCslwNXC+6LOC76A0CUVogMcbaqPwuH5ekYo9i8wCrwTZhEaZXQ4JB?= =?us-ascii?Q?DqjefjL3uOHCx9KgEvN55uerdx/coeiPwt0Ewb7R823HeKI9r0CzG327Yx/4?= =?us-ascii?Q?ZqhfrMH/1RACJaBVKikwvCV3jy9KWxqx0jMm6v+OEoPfp/V5F0vohUexDmTS?= =?us-ascii?Q?zbtqMrWcLcfj6/8PH98JpzIYPEbxxyDLrum3NUULjsclEK+ZAIvBJ7uVnPvU?= =?us-ascii?Q?K4aguu1t3XsTK2wnQVc+ptD280KzU/2b2SngA0TKnZOFOdyEI6xXqAiqXtZc?= =?us-ascii?Q?tKo4gM6lGfXQ01r54J0iOfzFVOLK0ffWbXV0YmQNDO4b6Rsyb1Frqklo/jTe?= =?us-ascii?Q?bKj0jB92mYJTIFEr4U71h13DyAdlYmATy/Vy5eNEm1UdcPbsDHIoDjwyoTsJ?= =?us-ascii?Q?AwBDs7t0PJ1qIXtQCcvkqyb2u2vVX0pPQRqhmqrPkXKKPgxZOta2ZLzW9TXN?= =?us-ascii?Q?fZYPGGCAinlO6q0NGzjVC1gePC9OFEcS6HwZ8rk4Qd8vXvsvaLPgVrbNwk2N?= =?us-ascii?Q?cHrAIgcNMD9PeL0X4IbG9PZuCe1MQRX4eQLT1yLLQRO0W6Q2RkLqq8zshXP4?= =?us-ascii?Q?Y9LF6jah+xHxte/rQMJ8TeStEF/sEBS/+Xp5WMz4SkvdtZudlztE+3zqM1HZ?= =?us-ascii?Q?rzz0OYV8rvMkkeOXPIEWnTBHTs8ArtCcGuXKhveTuKhgO7X+e/KJKfqQF7ni?= =?us-ascii?Q?wYbsRcVEZOEz9xXdAQshP05LwAZIA9TlLRQUM+zuAf/S5E/TO9QcI3HlvfWs?= =?us-ascii?Q?+S9dL5UuWYNRLFPy5KZzQkHBLX1/Ssvng2+B+l/IQpinquF7EyC6X7FAUK/K?= =?us-ascii?Q?JPWu5kTl6HFHZ4ggo8+9cMOcf/Kl/L643c55t0IKSkBcvSWJptBoqDdAb1f+?= =?us-ascii?Q?cZtZsU4h10d9XI4MTGzG6IIrg4O8OdVEiXeUQjaNczeYM9XGc5xNmTz3hlaW?= =?us-ascii?Q?U/7ClVFvpaNLk1ww4LJ8EGZ2a4P1IIhLXbLBk7TpQ9fwM5KXDTfpGLnJiSjg?= =?us-ascii?Q?zWmzlU3nV+YcZz9rfOWD/ZC73fMDnvJV6P/dkpORWK2ZucPIhaFlDu+SvzpL?= =?us-ascii?Q?1N59lRJ87jiD0eV0bLDw4lVnzfTMJG9cgdgUEeOyn2FuCDvGwg4kUb9+RLF2?= =?us-ascii?Q?SUiN9p/zuUnaJ1o6hwns9OatJzX7kfRqmoHYC9wDkKTYHjbgODXWiTTRvt5d?= =?us-ascii?Q?Ry+mQ5IR+DQdQbUvHEHh4Fnlp3xGoqNzv+n+cLrq?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4ee930-d7f0-489f-9bc9-08db46f86361 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 08:21:23.5638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iz4uXoRQa+L0tyoLeTsXRxIYybC9iN8FoleApEjm6bPtiJGG0E+YRIszpYV90LR/fRCzGHa0kDnZfnI4EY+j/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6942 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Could you please show me how this function returns *local variable*? return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, si= zeof (LocalHashInterfaceHob)); I don't understand the analysis. > -----Original Message----- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 3:58 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib >=20 > Hi, > It means the code might be possible return local variable address when w= e > used the function. > So I allocate a resource to local variable to avoid this. >=20 > Best Regards, > Joe Lu >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, April 27, 2023 3:51 PM > To: Lu, Pen-ChunX ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib >=20 > Hi > I am not sure if I can understand the patch. >=20 > Would you please clarify what the problem is in the original code? >=20 > > -----Original Message----- > > From: Lu, Pen-ChunX > > Sent: Thursday, April 27, 2023 2:59 PM > > To: devel@edk2.groups.io > > Cc: Lu, Pen-ChunX ; Yao, Jiewen > > ; Wang, Jian J > > Subject: [PATCH] Release build in GCC5 has warning message > > Wreturn-local- addr in HashPeiLib > > > > CC: Jiewen Yao > > CC: Jian J Wang > > Signed-off-by: JoeX Lu > > --- > > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > index eeb424b6c3..bf7a5fc65c 100644 > > --- > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > +++ > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > > EFI_GUID *Identifier > > ) > > { > > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > HASH_INTERFACE_HOB > > + *HobBuffer; > > > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > + HobBuffer =3D NULL; > > + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof > > (HASH_INTERFACE_HOB)); > > + if (LocalHashInterfaceHob =3D=3D NULL) { > > + return NULL; > > + } > > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > > + HobBuffer =3D (HASH_INTERFACE_HOB*) BuildGuidDataHob > > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > > (LocalHashInterfaceHob)); > > + if (LocalHashInterfaceHob !=3D NULL) { > > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > > } > > > > /** > > -- > > 2.31.1.windows.1