Re: [PATCH 2/2] SecurityPkg/HashLibTdx: Return EFI_UNSUPPORTED if it is not Tdx guest

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Sunday, June 12, 2022 7:25 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH 2/2] SecurityPkg/HashLibTdx: Return EFI_UNSUPPORTED if it is
> not Tdx guest
> 
> From: Min M Xu <min.m.xu@intel.com>
> 
> HashLibTdx is designed for the Tdx guest. So if is not a Tdx guest,
> return EFI_UNSUPPORTED in RegisterHashInterfaceLib.
> 
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
>  SecurityPkg/Library/HashLibTdx/HashLibTdx.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/Library/HashLibTdx/HashLibTdx.c
> b/SecurityPkg/Library/HashLibTdx/HashLibTdx.c
> index 75d96ee64b44..3cebbc70d3ec 100644
> --- a/SecurityPkg/Library/HashLibTdx/HashLibTdx.c
> +++ b/SecurityPkg/Library/HashLibTdx/HashLibTdx.c
> @@ -186,7 +186,13 @@ RegisterHashInterfaceLib (
>    IN HASH_INTERFACE  *HashInterface
>    )
>  {
> -  ASSERT (TdIsEnabled ());
> +  //
> +  // HashLibTdx is designed for Tdx guest. So if it is not Tdx guest,
> +  // return EFI_UNSUPPORTED.
> +  //
> +  if (!TdIsEnabled ()) {
> +    return EFI_UNSUPPORTED;
> +  }
> 
>    //
>    // Only SHA384 is allowed.
> --
> 2.29.2.windows.2