From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.11414.1654601863809275469 for ; Tue, 07 Jun 2022 04:37:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NeFhJBOA; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654601863; x=1686137863; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=www2J8u0njjJ/jEkj+o81CSp6Tjpy6hOYCY5UtXZ5mY=; b=NeFhJBOAKg9JEpo1buANV6/vnJItNFdEjn2LAEK8IP876FGnFhsU16GR Cy664yn1PPWGwtvmS6GFqWzLXkXrbY2sbjr9qEjWOz5JBeV6NhKL8P10w x2dgaLsJUrWBKSBGu4nA+ZfxG2XFGmwiagUYyNjazMVaMuEDgB+r+IzTw 35QcdfQv8FqExrB1gMy+QV8nhG03VO8ZKpXYWujQWJS5P+tKJ2U1UEqmq GzNrHBRi9fRBmFZQEb4fBb9dm0sdfmrP1dfHd8r+Btyti5Ihx6norNLsW PQzfbT7c5e30srwfDB8fgyAYKinljijdpJUqLgsXFI01BCOXtnnSO7FoP g==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="265097966" X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="265097966" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 04:37:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="669937661" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2022 04:37:42 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 04:37:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 04:37:41 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 04:37:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LrhumVTh5NLCKVcdnS7f2QGivkgoOCI6M1e0ZGGCsaCsV9M/dHCvjNsIbo+lLFtPlS5qIdDiT1PC973MLNYwROGMLh8Yej+yMzK7qS6uVJWl7/iHn3UEJxkhwBVy9fR/GxKcOdNjv6wzHabw2i3XfCGGF+mAqA0gJY1gD2kCKIO0G57f5Enupqk86jAoDCPezaIMRb38QEEdk92Xg+4x5EylLwjkMODf9Hxjcwl1w1b2CYlO4bX3JC7T6OAkX16hecNUsOxEqevECVAguoNnrLNAFFxJUqfWzNVBfoC/6qw4Pm24ksIHiC8ijJiq7UYmLLHYaJeDMkcysvesC+ymng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y6rAjdmtArGR3LMUKZ09TT0BZ4TrENzBlcaWKGMmemE=; b=KprrcYknBtjhI57pEwdjprRL1yFiMWRI27k0aerVAajGwdWD6WvNWpXqf3yk0yu5aE+dCv2QNYwUlnyn4IYX7DGl4Ly2UAr7ZlGdv3onu6cudlfY8YfJ1RJRHbdIFhbLlm4hbx6M/0rBM1NnZAb6hY1TngqNrfdmqc7HWmRtXWaoT4651yilfoBHiTRbZxwQomR0iZXhUHu5FUDGVReY1CVCWGekJKzFsSbDBLXJQanw98yprzEkZnTdslpd0y2M25omspFOEICP8kgAs/H/xPV016dD5UclnPuV4RchDOxyEoVxJqAk6O0mE4V90bDk+uJaTZyFBkUTcrsLzPWeJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MN2PR11MB3918.namprd11.prod.outlook.com (2603:10b6:208:151::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 11:37:39 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%5]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 11:37:39 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "Xu, Min M" CC: "devel@edk2.groups.io" , "Wang, Jian J" , "Aktas, Erdem" , "James Bottomley" , Tom Lendacky Subject: Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Topic: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Index: AQHYeHgEaWeph+dVlU+NIGI+XLaRZq1Dw3aAgAARMCA= Date: Tue, 7 Jun 2022 11:37:39 +0000 Message-ID: References: <20220607103443.l2dmwr36ducf4xxx@sirius.home.kraxel.org> In-Reply-To: <20220607103443.l2dmwr36ducf4xxx@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b611b097-7be5-4282-d8eb-08da487a203e x-ms-traffictypediagnostic: MN2PR11MB3918:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Fpz8oRURqKpWqYWZxiV0649clV8UZYEBMWBPTP+5Gm4K3A+pr8yfVCXRueBCqopN8kh1XC53l4GPIvv+tPyAlj56ZKWncHk0+Nf47g0nAJdUlKrHY7+PWf62GyM3WmIWKi5GArH3FBVuPEairx3bfiV3vDUKrACQJ2v9gi2H8CKq2tabpw0BfsFy3OvQUDWVeGIleO8iZimxuPNzisM3qHZ/8NEUK4mmITZ1CtAhF21+A67+ZXAbZIWii7TIWlT8ecayeFzHvZqJsj6g+m08y7D5ljVGl27tLjyUhmHqTTCc2cDtKjtst+zFdjBY02qVd+3oPMo+dv/5DSEsZ8sLz3eNi/8zjMOq98tfALjlu0Af4XPZiEa1sEsZaB4ns83nW5ICR0SN1jqPJLniyszUKT16aBknj9x3dSil8hG0+cEOgKrQSgdq4qVecTGgThr1Q+ElYRb92Z7sPJv0hkI/w/sxXFS0X8sg9O0b9v4T9+JlRadLUfNCkfhjkFUV8xLeVGqZz3w93tprOgW6GnfRza19V/pRoCCS3cxt0ErcoxtmGCNNmos4r5+EhmL1FhwYaDdJbDtz67OxV5yrT6mK2s/dgtdoMs29j3/d25N7eftQWbmbM+elzO0xFEzFtYlcRv9waadiLq9kHN772DUsHLg48rme0xy8BqeI3wCS0RrmL0/SRDQZfRyi8i4AjiQxpMrcsKGG8wzpjEd71oNA3C9yTtKg9qt6Iab1FH3vds= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6636002)(64756008)(5660300002)(8936002)(66946007)(4326008)(66446008)(55016003)(86362001)(66476007)(66556008)(316002)(110136005)(8676002)(76116006)(54906003)(38070700005)(122000001)(52536014)(71200400001)(82960400001)(2906002)(186003)(7696005)(53546011)(26005)(508600001)(6506007)(9686003)(33656002)(83380400001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IeP3nzJZhViFJ9Kool8glyD9V4ZbbHkYMdrvWZikAmtuYZnWEeaD52bMzKAS?= =?us-ascii?Q?sIU4h3NbiXCAMozBvYhp+L7c6TCrENv9VABfvK2bFsnUEFysu/GMj3DhFKEp?= =?us-ascii?Q?qfsdbqN4OxzTD1E41YPPm1oyLQ8NHeIK30HrnqG94VK9brXguHGO6BMfCDkY?= =?us-ascii?Q?cTkikwBYLcJ+kU6eTl+UGyghnmEUe1WLPHCfpLI11zihgLQ8rhZ/GV4rJjD9?= =?us-ascii?Q?hBtVYHxBtU/ZpBJLEuSsStaYbe87zsLvvkdQkseA+EG24nw1sLbeQpWuLkya?= =?us-ascii?Q?2d1XgwyJW2JOya9WEqku/5Y9aAlZGXEl7C8DuLfJqrh42uV1pQCWE6sqAV9d?= =?us-ascii?Q?KeEehSj90T5LUtZEV+3+qVRqdtMA7wkCsRE0xB3Tn6s7IZiB4t2amLFHzzq2?= =?us-ascii?Q?vTlyX+rBzOjGCXMfqEQg5qA0lcbiIBjR28xWP+qu3KCqiAMKrGrClCEkm/LR?= =?us-ascii?Q?ikyyM5fa5uwvS8sgPZLY3QsackhC7FE3toiKVoSq32GvXGb6wrYOOyElZAwC?= =?us-ascii?Q?so+5Hn4Y18tX66VaZvBYTJ/UeCu9Zc4mIQ/a4AAy07pMGAvO8FPm5xji1hEc?= =?us-ascii?Q?L770TYEKay67VysOYkDG45d7SepkyourynSKeyc+AdhgqyyiTJDrzYcjfADT?= =?us-ascii?Q?0zEKIGTIwY6VcoC/6asf4F6Yovj9ZmMYUxR54MxbZojctHubYz6GDpH8rJ+3?= =?us-ascii?Q?1E3mFD8JVrSdy78Rkdv/vH8t6b6nQd41oxIEWXrDA0g28kAj7ETHQ3TWnCBY?= =?us-ascii?Q?I3jG5gPrOmna/sQPqflsnfjLn+dsR/gom2/XpfjBL37xy9gbO/M1Ydx8vFNh?= =?us-ascii?Q?/5wHhijdL6L/AyCDItSnrzmaWW9HsavzRpXZ2LpGBfQFIRrs/kI8zVy/+4oX?= =?us-ascii?Q?Yu+ZZBYupjD5X2gtLR6tGm/oPGSmPpmzFScCwP7JeM4KxpaqieKxI+OuldUb?= =?us-ascii?Q?jNz90u22ZMcCMHIl4KMydkAqER+wY7e5WuJSncQhr9OBCGyTK6D08bJ3wY1T?= =?us-ascii?Q?b6uZzOxItElw6AR+xBq7Gvy8YIvkwzV+yUK2FF4XMztunb/XN1OnrgSgnjTr?= =?us-ascii?Q?7InmNYFzCPETixtNARKYUU6dLsDvJvwWthSmBcHedH6izqQZr29GhdCoHuRa?= =?us-ascii?Q?TDJizrpllAsmcLcoxtBGHjLP50H6btOhtT73Lc0khowdFeScqZGIEsHdK7jB?= =?us-ascii?Q?0/dm8F/HfCanUX0eOW6twB6MhkZf2D8fbPPMxaLdIQDwm8RJ76bQrwbGPcJ3?= =?us-ascii?Q?GhJ/j8YAiDUlhYDuMQyCqBUS7x27FHKYVNqYHIzToQ5KyV+SmcI1rO0jv+iN?= =?us-ascii?Q?cYU2DVwiDqvhf3VH6fj3T4SS6OdjSngAiVSAc7yeZSwXHIRRQenzk3rKMV/i?= =?us-ascii?Q?QFdowd1M9M7oCnMvJrqUa+Ax81YpUAgQ5fZjciHJdpMaXvTshGFwThB4qvem?= =?us-ascii?Q?nnNCuWBePFuV8SUBexaWSk7Lng4G918nclRAv2vIlhIFs5JU3x34yLn0i7UD?= =?us-ascii?Q?mv6OKqT/pFsQGvrk6bUXu4eVMsaMF8AypQnzmxpUJRrCS7pJwS1WCmRBTPUl?= =?us-ascii?Q?Ky7pmzSifAzhqxR+kJGlxbdp2ycI0MyApXZluNrejF6gWn2/noEusE65byJ9?= =?us-ascii?Q?E0h7zC7Kg8LVgc9c88MZ8fHX54TmZ9sTlIchTcvhT0ZUuxi9n9CdH633lqu7?= =?us-ascii?Q?XQOMpG59nzIh2uzJl7cuXQyUxVfGmrDNetfRWFmR8KX1FJHsahih6jryvTWy?= =?us-ascii?Q?CsUAzKykhQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b611b097-7be5-4282-d8eb-08da487a203e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 11:37:39.0233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Xmxeu1cgMMbtBMiIT7BXskSo7J02mLHiTYMN8wkvHB0TQCa0u3qRbbHJTidfkE9ERDUEvQPeTH2e4kbLfFkaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3918 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The previous patch created a new instance SecTpmMeasurementLibTdx, which is= not a best idea. If we can use the existing instance, there is no need to create a new one. = Just create a new instance. Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, June 7, 2022 6:35 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian = J > ; Aktas, Erdem ; James > Bottomley ; Tom Lendacky > Subject: Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx >=20 > On Sun, Jun 05, 2022 at 09:02:45AM +0800, Min Xu wrote: > > SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC > phase. > > It provides RTMR based measurement functions for Intel Tdx guest. > > > > Commit a708536dce introduces SecMeasurementLibTdx which provides the > same > > functions. But it is not an instance of TpmMeasurementLib. > > We have updated DxeTpmMeasurementLib (which is an instance of > > TpmMeasurementLib) to support RTMR based measurement. To make the > design > > consistent, SecTpmMeasurementLibTdx is introduced. After that > > SecMeasurementLibTdx is removed. >=20 > So, what is the difference? Just make the calling convention compatible > with TpmMeasurementLib? >=20 > take care, > Gerd