From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8CB5D9417B6 for ; Wed, 17 Apr 2024 13:21:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SJPwnBtxojaF5qqWfo7eKUDC+ndfVv8cd8KnY/T/ZsE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713360062; v=1; b=SUb2wwPp1eUoKVPrrJFXnEOm/81o8U11ZZ9tBYEXVrz+dLQcTTizrmFLTb5a3yCtATKI9Qyy ES2suJQWkB1SXwEMe1Pd8uGrSDFRJsrSRh+EfuURz1pBKkFzHxgXYf6VD429xZzkRW3rHSJ7ftz wsOSRlvYQ9Jq0VlTAliqHVAIKQukeTimHFaRRuCZlPhWUGGroizbdH7WcQK3ZdUOqoO+OQEQWkR qxqSZQQmoFDh6JRF61wEip3B8afFVGIIwExcFNVOjF8rkIgelHKbx6xNmbRyW6dVt1wfB0QzjUG 4OoaukAt8JfOAcsmNLMiKQNE885/L2mt12MmSWJ9w0M9w== X-Received: by 127.0.0.2 with SMTP id N99AYY7687511xKXbzsec0LE; Wed, 17 Apr 2024 06:21:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web11.12691.1713360060998492808 for ; Wed, 17 Apr 2024 06:21:01 -0700 X-CSE-ConnectionGUID: FxrNBgAYT8qilBAzMki0qQ== X-CSE-MsgGUID: gOPVtvlLROKns1qkNKO8iA== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="19408807" X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="19408807" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 06:21:01 -0700 X-CSE-ConnectionGUID: 0tlyXFyAQyubpCfHmPLNag== X-CSE-MsgGUID: U2BT2An0Q4iB3I5C622/7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="27261117" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Apr 2024 06:21:00 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 06:20:59 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 17 Apr 2024 06:20:59 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 06:20:59 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MN2PR11MB4551.namprd11.prod.outlook.com (2603:10b6:208:269::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26; Wed, 17 Apr 2024 13:20:57 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7472.027; Wed, 17 Apr 2024 13:20:57 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , Ard Biesheuvel , "jiewen@dobby.home.kraxel.org" CC: Oliver Steffen , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH 0/4] OvmfPkg: Add VirtHstiDxe driver Thread-Topic: [edk2-devel] [PATCH 0/4] OvmfPkg: Add VirtHstiDxe driver Thread-Index: AQHafGWtHNg/9O1RfUWmfgvml7zJG7FsRr+AgABRqoA= Date: Wed, 17 Apr 2024 13:20:57 +0000 Message-ID: References: <20240322142735.1749388-1-kraxel@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|MN2PR11MB4551:EE_ x-ms-office365-filtering-correlation-id: 76fa7b64-f57b-4450-8863-08dc5ee13781 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 0tcMaxcJWi0hr0FoBID7qeIzleE22tsVpIAGpSAEdzodJU9uREXBY6q2C8ebSf5w4bymKX3Wj3UMIzNSiZ1fVd6XaM+X8hAGWGd2L4XT49pujkK88VvbbMB+of13oP1Xlo1adxL+qvcmBfekOnOpcRZdQpa8Bn+x1PQUwqZeQANqT+uz4lNGBjzprMr4in3cC65UzFLT+D4rHjs3Hb1yu2MEXnWLi8J03kxd32ECL2t3U47ZVp2HzKafkUdHPxZjYJklE4AGlrJrFBzYravsn6SJbjEd+9+5poJW/zlFCiSiYfTlgVybIomPW5Hj4myyGyxy0eOSrga6SXEullyLKbfLrAO/URUNsRkqfyewlfNLrTotaV0l4iQoaHiqkbf6zqp/zuSoFf3q5n5W98emsCdA1srcuKdRk1SRJhHxq2Vi27IEGO13y+Aa2Lu+4/7ZqinhYNwOXph2xhRWR8+Olnkq7VMp9i0dHZwOkId5x/ehCMpMvVNaLta8UFrXGnPJHN4xKpqcdKdveeOywuiei4SJbGoHLxtjDNgsGve0sqdk8uMDJBog3yiuWq4eK7ahodQKR+JSrrcLd7tkOVnQgIIwiqVB8tBoJj/1J4FmNYdFXXkX2cl3iXMbEHzr0yEC36bkpIRgbM5fZDm39+3cItPgL95ilekmA2lSa8BMwnlibgtAjkNrmDcYSq9bODnctWBZejb0tJlkHdg0BzJ6pbvSLaV1/wBxqPjH1Wrylyg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RqOxPZXGK8Eo/N+4IWoAQXicM+yChgIya7g18hxWtIYg1N/887AKlnYgRr56?= =?us-ascii?Q?ez7W/dxHP6Dx+CEHFmrW6wilOJaj/FSAAJkyTbGBZs3UOBLA3SIvhJPeijxz?= =?us-ascii?Q?CpaWYL0FbggXIKpdtI7cBNT6sZCneVW20Aaq2HlIPfqN7oZoIWC8nzzPvhQX?= =?us-ascii?Q?UFJPPcfnuiLNtVEWIcefdYZth+N9DF2L2p9CQjYJBnTrH8r1AWftkP9Yz84M?= =?us-ascii?Q?JRkswlD1JZX0dj6SGnsvAXtLh7Yff81/7eDIB2GFYbp+DPYKqGTeDKnoEGYp?= =?us-ascii?Q?9klFwJbN9v1pKy/8Heg9a8HJWcBYc9F/X6i9+GVng/JCjDYvJlU+BuSDH1V3?= =?us-ascii?Q?PU44rBrNxGgI78VUo2beuGeTwEQFwMXjE4H5ggm4sNn3a/lcRWRfPsNV5sJR?= =?us-ascii?Q?rTkXRNqkZtsioVmKlE15x+wd12J4ABQPhc78bLCH2zhGiQCUux7+U/e0YA0I?= =?us-ascii?Q?0m87UMKj4oxgxBAxj9/UqevJjXHGKkt6WHV7bnzt1TQOccZ4PryJAogL6jea?= =?us-ascii?Q?Sryl1g09OaXqWuncXUJpkKAbhSoiNvMHzBf55UPZf827zf1PPC0olnt3+A19?= =?us-ascii?Q?9jGKK/9mCOm6RtGl44mq5S4nC5+KZ4/iz4hD4nViMJS2QEiZck9Sx3ppkQ6y?= =?us-ascii?Q?61znrReL+rwQn1dF3M/mmKzGLByy53s3jnOVFF9U5nyUklQcGhxWi2o/r5tq?= =?us-ascii?Q?QTHdOS4Yl4wUVdU8y5XRNqSj7Vr4jSEeUHrWxCcHMC1A8Fbov/xNWk08HDtA?= =?us-ascii?Q?17vnX+bA3MPiNFV2w81vr46tdm1LPZkQa6XCMCHH5SK6/a3wyw1cxpsYTXkE?= =?us-ascii?Q?VN8Dp8vbkB3TQndyV+pEDfXsVasDb0t+6V7AE6J6rEv0eQzWLuHAROeFdCdo?= =?us-ascii?Q?zpZwC+hrkUKfkzMXRarnKNg2LpB2naeJAhgnHyLcJxsqjyYpP/scC7lgX2F0?= =?us-ascii?Q?Q4I8ywbukHewV5eLZxZrKBZ2dwCG/MsFvKPguncnR5uPRr+zDw/NicppdwZZ?= =?us-ascii?Q?J5MKBXo9VbfiGvwLiWQSLsS/NGn7Zth9KcvvuM0IJGi/q7pZ5YHKgJr37Jy6?= =?us-ascii?Q?6UZWZMRmpro2r3/7C7CmlclkJmCry53lRS+RJagGW3OKWQ1XcAc/Z8TlHnSK?= =?us-ascii?Q?3TFTcOVMFg5+oSx3ea39OVZd77doOKjoQ8/dOR3GIa76XtlTKBgYGRf881/k?= =?us-ascii?Q?gPKf86eNPiBhpf03bqzQca08Yw7B40ByHx3OXDRtI3a7VaoP6sbFWgg8JNE/?= =?us-ascii?Q?f60513QwF2kHQ9NZLpUjhOH6oYhaAKqFs44llMVviYB+Ftes8oMLxDi0gAcB?= =?us-ascii?Q?ZoBKOZwGiheEk6qsXQSu5JFyQxPnS3DnaaTfUkkX8IbvblN5fHivH9diztPT?= =?us-ascii?Q?mJdk5Rjvj5X3JJy7RSnei/boETOS9YGEsduaE0X4f1aQI4RhZB589D9YTV6B?= =?us-ascii?Q?CpGMuDsadNd/H12VhFt2clKprQE1ftbH9YUgw0Hwar/LX+z7vnHd+W0xrYdd?= =?us-ascii?Q?IBUrempQcCTKfGkMV4wVhLG2wA05KyPfSH+6JYxYokrcuhr06PTEqqUV7k2z?= =?us-ascii?Q?u6vOrJrinIi7ROQTI8FU7ACccIfaaXBvniHAfQea?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76fa7b64-f57b-4450-8863-08dc5ee13781 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 13:20:57.1304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u+PZxEhQVbJvfqowExp7KQGkeG5TMBDFhPbxkSzw0+4LeL1nswg2/iUpaga9a3GUZlRJfN7V66TUOsOXi1yp3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4551 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 06:21:01 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: l131Ww373pJyRcxSVVi3PRDcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=SUb2wwPp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io That is good start. The SMRAM lock and Flash lock seem good to me. Comment: 1) Do we really need to add "Q35" for the policy? #define VIRT_HSTI_BYTE0_Q35_SMM_SMRAM_LOCK BIT0 #define VIRT_HSTI_BYTE0_Q35_SMM_SECURE_VARS_FLASH BIT1 I feel we had better remove it, since SMM_SMRAM_LOCK and SMM_SECURE_VARS_FL= ASH are common features for almost all X86 platforms. 2) Would you please let me know what "READONLY_CODE_FLASH" really means? #define VIRT_HSTI_BYTE0_Q35_SMM_SECURE_VARS_FLASH BIT1 #define VIRT_HSTI_BYTE0_READONLY_CODE_FLASH BIT2 Does READONLY_CODE_FLASH mean NO write to flash even in SMM mode? Or does it just mean NO write in normal operation mode, but still writable = in SMM mode? Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Wednesday, April 17, 2024 4:18 PM > To: devel@edk2.groups.io; Ard Biesheuvel ; > jiewen@dobby.home.kraxel.org > Cc: Oliver Steffen > Subject: Re: [edk2-devel] [PATCH 0/4] OvmfPkg: Add VirtHstiDxe driver >=20 > On Fri, Mar 22, 2024 at 03:27:31PM +0100, Gerd Hoffmann wrote: > > > > > > Gerd Hoffmann (2): > > OvmfPkg/VirtHstiDxe: add varstore flash check > > OvmfPkg/VirtHstiDxe: add code flash check > > > > Konstantin Kostiuk (2): > > OvmfPkg: Add VirtHstiDxe driver > > OvmfPkg: Add VirtHstiDxe to OVMF firmware build >=20 > Ping. Any comments on this series? >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117919): https://edk2.groups.io/g/devel/message/117919 Mute This Topic: https://groups.io/mt/105086174/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-