From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.7232.1639753776189407141 for ; Fri, 17 Dec 2021 07:09:36 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=R3uSjwlI; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639753776; x=1671289776; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7asAY2qige8FGb6gEIOw6mvsDRaG9vAX1THr30JslWA=; b=R3uSjwlIlJyuwI6CCZSNjeaHRX33eP6l9I1kTjnts2qfToTIgobr+cN9 2lNKgTPkDwEI9FdEwAP5lTmQZMelVuYZggshbSDQk1jfw2eSNPTsIrN0k aEa2v9tI7t9XBQ1NOrVm2Reww/qVFBQbBwplq/JFNyFH/VNQ6CZ/3Qhd8 4ZBO8ave/PVl1PcxYSBjPcK1APzSl9OGgtoKltmZubQan/zpld3tQusVJ f6THrvtiNVF+Ve62PPa8PXadibXevbNYqdC6TIRYXYxM+XBempPfls6r1 QoUvNEsE2GAnnm756grLW/GXyQwUrru/krLVOrJNYDVq6KxKri2QM/55z w==; X-IronPort-AV: E=McAfee;i="6200,9189,10200"; a="303144889" X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="303144889" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2021 07:09:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="615582821" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 17 Dec 2021 07:09:35 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 17 Dec 2021 07:09:34 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 17 Dec 2021 07:09:34 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 17 Dec 2021 07:09:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXVYh65DwBm64EXEgg/U+fnFPXgJ6yiIv7ZibrdbQzuULpymS0briAIGjKTbmkb0FN7JgP7TTw9iuEbOstKuc/QSdAlMIdbFK+Dupz+w/GPzVKxNOa8WwQ6BsXVERKyW8LP9dctVAC6FhAAYMQ1fIpBB5PjDO8otg4n1fn9xO2yMd3LHHbHfG0mY1Ga177W2QLg0GeoZlVvp7YuE2Lsk/lLHjIG9HjT9g92c36jx5YnPtbOt7XyPKFHqCAIlnx/en1DnAQnMs25Bu6A4PnYt1DYl5Hi5k3kmzDrG7MFk/R8+GQeamSpcAhWJZafQbVu0GRIQdOstYsfVpBGI9FGA7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dN5GdBTWNzjnbf+2figP2KeGr7VQkwBRw0ucgz8vLWM=; b=emDqG20N4jJyXmi4bt1yX6WZXSRK028UnWiBXVEoqBasPIcW3AzbvmkCM0vtSo+YN96cjYd56g5Dc9OnztXdffOfEHrUwuLktqEYmDKIr98Vcbl7g9+UYvC6KTubvp9sEtrbT5YLLspvVtM/iuo4uAXlW80vydRRc1/qE129lFcJogihhTzuzvs+OfePJw9OFHF5RW5SIClem4DukryECpzBeklodlVixjv0JD09uasFx4gc7/AndcQAZChEEJ/qsz6ptfWvRlmu5PXc+5dNsJuTiPzbMDUkqAyxKI4V/GK3aSRoNLAiw3lqBxAnHF5XPOPTUWWp02EaqbM5KHDuCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CO1PR11MB5011.namprd11.prod.outlook.com (2603:10b6:303:6d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 15:09:30 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae%7]) with mapi id 15.20.4801.015; Fri, 17 Dec 2021 15:09:30 +0000 From: "Yao, Jiewen" To: "Gonzalez Del Cueto, Rodrigo" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion Thread-Topic: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion Thread-Index: AQHX8vCHc3T/A4FcLkWk0PU4sA4GV6w2ykVg Date: Fri, 17 Dec 2021 15:09:30 +0000 Message-ID: References: <20211217024759.653-1-rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: <20211217024759.653-1-rodrigo.gonzalez.del.cueto@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a5e8c68-7807-4fad-acbb-08d9c16f39ef x-ms-traffictypediagnostic: CO1PR11MB5011:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qxcrjW+ZUUPwhFtvwpb9Qi6R8YkikaHuoKlUrVBvMHibVSW/6f6fhs/QHuOqXZaQ+ZFgUI/P/93yS8iVv9gWgkNzxQAx3KtIjTKMZv/PXGnYVliNGF1dmJZslWpxODixmrgCh9IMECOpsao/8Frf9QArOx8lFa5dON9pG9oX0oenIHqUZBye3GHEDWefPD0w2U9y3WDPpsf2dnhFPy2fvdpWpZHPFD8mc86a2Cv2GssUsEkvpNiGPr8tWReu7JJmi40ZaamjJ/dfjWnsAP+g+1kWA8I7FcIBzoUVZQ6aAaKrcjou/Tg5tftLIyybXqULR3ZWxOownlDmFOsek0sYOoj45elilrO/TkGRFch41elcBOtdxaNliNp2RE/1hthdzHTcouPMk8B9aPKXrBC85gKfDNQxZNJr9WlJ+ov8kz3QQyYVe0GgYTNj32buiBb34Wx+hzfwkA0XYJsS09udoj1Z0dBTA+146FqwjK9wXuvPZHS3kqOxSU8FzzYX5mVmET24+ChrntIPZbMiFkSi1+oZQvwxgQ1SmVNspq1DWs3D5hLX9/0zE2KsvZDOX6cmNH4x5t0U28Wh0oJFh4pvL73a2HtO6lSYNUZJqWN1xql5dptsa8APA75dl+N2KLAA39VPhmja8qMVetB9A+bj0eU7OnPR8tRvqOF0NZTSUQpeL3QfFivlmtY+y6qFbBenprmbGlnrqf39ZXQxL0tBFgqfviabyRHo/6xwCurC6BdhKmLgRFajfH8qKvEBCLmyTHCZO0WQCQjub3Tgq1TncUdEBUjt6fK5N/mctwLxie0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(38100700002)(107886003)(186003)(26005)(64756008)(9686003)(45080400002)(15650500001)(38070700005)(76116006)(966005)(66476007)(2906002)(66946007)(66556008)(71200400001)(7696005)(8676002)(4326008)(66446008)(122000001)(8936002)(53546011)(83380400001)(19627235002)(5660300002)(316002)(33656002)(55016003)(86362001)(110136005)(6506007)(52536014)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BCc4tqGpSjtDAtKOgik/7qi5jFSV2axrUYOtfZL0swSew7MV6Q9wNitKz6bK?= =?us-ascii?Q?eq5AzXV+PlReNabgwT5hNYwqsJ2epRpxdzGOpjqwIlR9yOEJ+CBbfT3IVN1w?= =?us-ascii?Q?i3IMTSswtBKZS2ITA3qwpyeKoAJp6iLUc3LAMXosfCPxEMNP0X+0/at14rYm?= =?us-ascii?Q?xbuko3z+PzqnX7rCiW7hqBE9TgxOYTxX8i04mL79HOUgUyvllxV9XuwLJF6k?= =?us-ascii?Q?UcUo/6jcMhcPZ4W0lsocmXWIHqFAlXOhypVTnGJm6nmFQro7icGoZ7gh+RYV?= =?us-ascii?Q?WktUy19fPf5XPLC+D3Enyn/vtlTRpHHeiQN7jyhKXV8DQILiZn7LTwRr95Rg?= =?us-ascii?Q?jHlxeUvIjc4EaMTSujwHqsurcCoJfJu8tpE85msSajlirdirrfp+8jh9dT0f?= =?us-ascii?Q?i9OLgKZsmgk7SDvcp6zLU0Ee/DqLa/3lvHVtbZlZ60ZKQOvRraV1XBLleIpk?= =?us-ascii?Q?eW1esPZ0UR6S1Dt59EYL1nvd2nOh14WrLhPINx7MgBKTVx8w94JXtNSNsRDH?= =?us-ascii?Q?OB7sxmsiVP2YCHyV+ECOG1TJzSoZ+xh1OZODeYYghIWsBL7YzqNc69jT3FDK?= =?us-ascii?Q?5W5ReIgpEouOA9bdAKYYIkZW+zHjnb+ul+PJrZYQDltVFKkcn++8vgEnKALo?= =?us-ascii?Q?JMUw6lCJFeVpfBkV1v3fRpa30pBgzcthXtwkeBHugMy3genCTTzbhP0yI3o7?= =?us-ascii?Q?xjxiYiXGC7FlTzirZVzmr1F1IrfYD806kYRi7dUSW+OluLf0mEWTqQf8l/Xs?= =?us-ascii?Q?5BJLrD4F0kQXq7C4mcbv61BK34RaKdy2I3NwVboZCCxOUa8kekFrnAq+NwHi?= =?us-ascii?Q?yfydsKX8VP+F6PTu77uBPMzbiDMFZjvZeJfKaB+qnp1O9r1huSkA+v4MsDGh?= =?us-ascii?Q?Nwxuop7fZrx8hnhjJ2QYbXKFRim3y4ThOEz/oXUCtwhSEZF6qmgBpAvetDnR?= =?us-ascii?Q?LjqL2JBSSbE44StaFR0MRUIaTPdkxyfI+al9mKYBdQSpHqI2RqF07dNpcQrM?= =?us-ascii?Q?iqLo0lWKTMK7ghbTu8RhUJAIh2Ju4vPFLqhBvHkW/LnQuKqvpofdbqwRFmxH?= =?us-ascii?Q?ofokZclFIifQAwRim0MKc5sH9TgX4VDYfN02hRa1rYapsdxxAYKPUPtcxtKY?= =?us-ascii?Q?Sez+BU6rJR32KkZXBUFegQ4L52EF5lvrWKpBTgi+xzRONaW4jTBrLRRbuCy0?= =?us-ascii?Q?k9LBw2AIT8xMrx9zN7fre4gelG91zBekMlQSyFrb1888rS1Aeqgmywq2NjGd?= =?us-ascii?Q?NNEf2zYDocPLM1UP5kZP/jYge4TziPzlIwmCtT5iQ9NFkDzWhfsaE56cUjGp?= =?us-ascii?Q?mWIJWBSRoBokTOIaRtLJUOGn8prbULihgJ57Hy48XBHzv4yODHLT6WDrp/n8?= =?us-ascii?Q?/OAPV/IY7x+Zeh3NTigcKJVgo3Tf045lKw3GRFMqOrcKL2W/ZHk9PTshXRjl?= =?us-ascii?Q?Ye6+xqYQ9WxxkNxM5srN7fXp6/GZYGpwCpxexGi71VZp3mTAt9X1Al+pxVGu?= =?us-ascii?Q?HGCxkZ6aaOMhG6PlWW1Q+76UAbjOdNNqQZkEF/w7d4GV3acXuf8Bq5La3JUV?= =?us-ascii?Q?k3zVAIMU6ozSTXO5I4sPaCYEWrZv3lxX2tzK7gk+4ndm24LOE5agHJ6yhgUl?= =?us-ascii?Q?b0h9yO6qf+8fbHiGamTgadc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5e8c68-7807-4fad-acbb-08d9c16f39ef X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 15:09:30.5925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fa+Y+z0DADM5f1ZsXJNLtKu72Gby3QTRw/JVrRHlhWpsJU0pHWIstfUFkiNyLb7Bhv8MRWv/kvX0e38nx8bHXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5011 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1 > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > Sent: Friday, December 17, 2021 10:48 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Wang, Jian J ; Yao, Jiewen > Subject: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command > completion >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3463 >=20 > In V2: Fixed patch format and uncrustify cleanup >=20 > In V1: To follow the TCG CRB protocol specification, on every CRB TPM > command completion the TPM should return to Idle state, regardless of > the CRB Idle Bypass capability reported by the TPM device. >=20 > See: TCG PC Client Device Driver Design Principles for TPM 2.0, > Version 1.0, Rev 0.27 >=20 > Signed-off-by: Rodrigo Gonzalez del Cueto > > Cc: Jian J Wang > Cc: Jiewen Yao > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index 40ab998004..1d99beaa10 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -1,7 +1,7 @@ > /** @file > PTP (Platform TPM Profile) CRB (Command Response Buffer) interface use= d by > dTPM2.0 library. >=20 > -Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
> Copyright (c), Microsoft Corporation. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -320,7 +320,7 @@ PtpCrbTpmCommand ( > // Command completed, but buffer is not enough > // > Status =3D EFI_BUFFER_TOO_SMALL; > - goto GoReady_Exit; > + goto GoIdle_Exit; > } >=20 > *SizeOut =3D TpmOutSize; > @@ -340,16 +340,6 @@ PtpCrbTpmCommand ( > DEBUG ((DEBUG_VERBOSE, "\n")); > DEBUG_CODE_END (); >=20 > -GoReady_Exit: > - // > - // Goto Ready State if command is completed successfully and TPM suppo= rt > IdleBypass > - // If not supported. flow down to GoIdle > - // > - if (GetCachedIdleByPass () =3D=3D 1) { > - MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, > PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY); > - return Status; > - } > - > // > // Do not wait for state transition for TIMEOUT_C > // This function will try to wait 2 TIMEOUT_C at the beginning in next= call. > -- > 2.26.2.windows.1