Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to NvVarStoreFV HeaderLength

["Yao, Jiewen" <jiewen.yao@intel.com>]

Merged https://github.com/tianocore/edk2/pull/3694

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Thursday, December 1, 2022 2:27 PM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> Cc: Aktas, Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Gerd Hoffmann <kraxel@redhat.com>; Tom
> Lendacky <thomas.lendacky@amd.com>
> Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add
> check to NvVarStoreFV HeaderLength
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Sunday, November 27, 2022 3:00 PM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Aktas, Erdem
> > <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Yao,
> > Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> > Tom Lendacky <thomas.lendacky@amd.com>
> > Subject: [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to
> > NvVarStoreFV HeaderLength
> >
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > There should be a check that the FV HeaderLength cannot be an odd
> > number. Otherwise in the following CalculateSum16 there would be an
> > ASSERT.
> >
> > In
> ValidateFvHeader@QemuFlashFvbServicesRuntimeDxe/FwBlockServices.c
> > there a is similar check to the FwVolHeader->HeaderLength.
> >
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> >  OvmfPkg/Library/PlatformInitLib/Platform.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/Library/PlatformInitLib/Platform.c
> > b/OvmfPkg/Library/PlatformInitLib/Platform.c
> > index 2582689ffe35..77f22de046f2 100644
> > --- a/OvmfPkg/Library/PlatformInitLib/Platform.c
> > +++ b/OvmfPkg/Library/PlatformInitLib/Platform.c
> > @@ -653,6 +653,7 @@ PlatformValidateNvVarStore (
> >        (!CompareGuid (&FvHdrGUID, &NvVarStoreFvHeader-
> >FileSystemGuid))
> > ||
> >        (NvVarStoreFvHeader->Signature != EFI_FVH_SIGNATURE) ||
> >        (NvVarStoreFvHeader->Attributes != 0x4feff) ||
> > +      ((NvVarStoreFvHeader->HeaderLength & 0x01) != 0) ||
> >        (NvVarStoreFvHeader->Revision != EFI_FVH_REVISION) ||
> >        (NvVarStoreFvHeader->FvLength != NvVarStoreSize)
> >        )
> > --
> > 2.29.2.windows.2
> 
> 
> 
> 
>