From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.64181.1669944850882280714 for ; Thu, 01 Dec 2022 17:34:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nZUp1xLf; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669944850; x=1701480850; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fMolF+mXGmW0lf/OXlqWpyVq1eHr5OhH1B2bTpH1zMA=; b=nZUp1xLf6Nv+/Easwi1Z2tQAex8UD0yQeF8IC4kNZxjmi4HiPFthApeh EtFduJv3SdbDjFKa4w3wvJb1cK26IuNP/kCUxd3dmnrnz24uxl5Ns0uom DzQ7/Er+ha5ebISQX77AC7BDH7s3BQghYPciqfySEx7D0KOAyHJP2iRE0 bR1mh3NPa6K0KSpR6xbWbAsOmIr/Qm3X3nkz+m8NaLOsMKsN+mLWEZoLZ 5W4EscloliEnUtv15hC2/zf8YJxMn4/NyeJqCAxeAD1voifS7k28+E7wO MOn2Lx2/8d5OXbpcNYrN0Eq68wm3W2fk7rR8Nd90A0ix/cn4VXTriMfP/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10548"; a="296198833" X-IronPort-AV: E=Sophos;i="5.96,210,1665471600"; d="scan'208";a="296198833" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2022 17:34:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10548"; a="751058809" X-IronPort-AV: E=Sophos;i="5.96,210,1665471600"; d="scan'208";a="751058809" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 01 Dec 2022 17:34:09 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 1 Dec 2022 17:34:08 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 1 Dec 2022 17:34:08 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 1 Dec 2022 17:34:08 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 1 Dec 2022 17:34:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hIxavsRLeVSygJ4ws04PhDfis/1rLEU+ROktd2iDz8Dqz23hjc+vPeREr530+snxI50tjalJqyRvYCaZWBFmcnbWtEdJ1PSVSnYc2C8NQ3BaWgPkAe0r87j27Cf74eb012ve2YVa3gA+1eQ+4sZBr4o10o93UjOt6dYUklLtwfNreDNQuGqJRMig+w5ADluCwqbjII3aPDEhjoMdKDUvp23rsMD72KpaWu+Y3kM/APlZtku+IG8WndVbEeDlr+HyewEWHwHhhOYLDGc9oT3gAA1yZULMgR5YJZ4Q5Olw/b5pg8N6WoD4I5RrlQ+j+V5MyhWbDieyjl+iGgDz26HYSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9sQSYHjxDKUdFMaP4Cb2WJ3oGuI/KNQU+PuuK4YveM=; b=iO0eDNkT4Qlfk/FKFKpYTaZzQ1Qdo1btVGUPTI67WnrOiNchxVETbR+8QdknVtejxdJ4hvImycLEFaytNhzuKzeBUd6r7MyeK7m/iJt5UvoxIVQ4jOWmbIJAnILnxIQAVtW8tgZK4iiVPbPorki8v5u7BHZuSuFs5rcNPPYsRhhHeQdala9V1BTIxT7r7alIrknbp+tn5karvnEp0KeAQ9g3eu8kTTvgNjD9Ovc4pg9dOXeAZ2vvV+I/4NCNICVNsTkL8VMQu7EOP6bLwqp0X9YHH3dofw2kBE5Us3O1ubnz7mQSs33g6mAQxi/gWHde8fAgb6Porfoxyr83NxlD+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM4PR11MB6263.namprd11.prod.outlook.com (2603:10b6:8:a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Fri, 2 Dec 2022 01:34:01 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::e9dd:f205:1970:4edb]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::e9dd:f205:1970:4edb%9]) with mapi id 15.20.5857.023; Fri, 2 Dec 2022 01:34:01 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Xu, Min M" CC: "Aktas, Erdem" , James Bottomley , Gerd Hoffmann , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to NvVarStoreFV HeaderLength Thread-Topic: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to NvVarStoreFV HeaderLength Thread-Index: AQHZAi3+i9HnFeWUqUWN2mB2zeVZfa5Yl0pAgAFAn5A= Date: Fri, 2 Dec 2022 01:34:00 +0000 Message-ID: References: <20221127070014.479-1-min.m.xu@intel.com> <172C97603AF93BB4.27320@groups.io> In-Reply-To: <172C97603AF93BB4.27320@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM4PR11MB6263:EE_ x-ms-office365-filtering-correlation-id: 93773efe-e9d9-4a83-d498-08dad4054a1c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XNJHlmqxnd64Jr5vQnFz8RAwsh6+ri2Tsm+aBrrDdd23hcEnD8UlqtvTr0vOnyMnMhPG7QhfwAYS20/8dwdBCVdBs33i0tzDvcJBnKQws0IXaT8XXh3aLbCmk+mnoz+q/Qczx8leDJ1xYnq1+5hKMolCgWVBXeZrKFmjQCgc48RnilfIHUfw4nO2Koeyu1ouptJ2OD+IybwxBiXOXlqUT1mqRc8tIYwS9gETutDGDsvcMp93QocN+h7T/nOQkY7qNwC7L8ICo3IUlWaP5seOofL14bLP3eVMxq7gijy98PZ0mHW6L7EYBPkGg3hQa9SU7+QV0OoqXMAB+9JjcNMhnLyRAodTPfSgywAPdbBcF0VZANMuLbEjX9y8O5G8XuN7PKohIOIDDde6M0bzfKF4dOcr3+bb24sR0RtQi5DOG3mHBoZ+iezEZ/p/VoAnDxlyGTb6kP7BpAYieIZBYkrgFYQp/wE/PcJzC62OKpG9UvFNn6iunB3A1mfGh6hT3ZKONZw3EIqOjU27gL+e+Qjp4tgLb4tbs3+DpKuqFaRZWlLy3e3AOdHNb7nvceJ4E60FxMn+rFwaUB7USs6F2cHGoIG8DEwEZ6ceD0/XyQ9NuyFs2MYJ9VqDGhTVLbiK3trhkgqfChfIg2LcewG7mnlXUKrp8gsu+rHgOEFLS8WJ6y24FI88rBTw4cSFQoLBcbGdhvuSTXZvVL7wRxoCotmy0DRez1ngM41FAmHk0raZfSBQupZ0OngWPXsdPuAP53wk9yHQMx8VnPh+iQdS041Gew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199015)(33656002)(66899015)(76116006)(55016003)(2906002)(7696005)(6506007)(966005)(9686003)(86362001)(38070700005)(122000001)(82960400001)(478600001)(26005)(41300700001)(186003)(52536014)(8676002)(38100700002)(83380400001)(4326008)(53546011)(5660300002)(71200400001)(6636002)(8936002)(66446008)(66476007)(316002)(64756008)(110136005)(66556008)(66946007)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mA1Cwju+3SCLsVB9oZAvqkZagXPSbdZCo8wQhRznJZMkxTF44Buy2sTPqAfS?= =?us-ascii?Q?3N15WB0qInqWzn4H/SSBgpxzNPWWU6WCUuAwKjXvk3zGiqU9r0fRujlZJn3b?= =?us-ascii?Q?1Oe6K87XN7p7Wkn1u5/eMcomO8uxEnjKjl/APdmBfVgVPx92HVjd9OGJIaa3?= =?us-ascii?Q?xoWhxt7y1OL8iEL2C3QQkroeMyQE6srB/nL7PuwQHcFwDY2DI9DoloTB++0C?= =?us-ascii?Q?EnKum8NFXVOPVrmmSPH/tZwq+ksDgngkTPHA/2SMDHhkPpHRaqbvDKtPxjQf?= =?us-ascii?Q?QiB+zfou3gdPrQbn918Sqayql8ShVw0zbVE++4ZEWPhsk8flgwWVrNqgw5la?= =?us-ascii?Q?Vq+u32QWm61ynDAdijM7mw9QpEYuTLwmw/Q5FNgBWo51C5NH/s1yy553lT2N?= =?us-ascii?Q?JAschxtDN0iwqS4fIFpYbef8SE4baQEd2fOJlYzf8qBe6zb4njaD1t2oJ9yD?= =?us-ascii?Q?63ZHc99kNm1lCBuMcCj2gpdvTp0alThWs5MTI8EO5HA+nXT2WBRz/9q/CYE3?= =?us-ascii?Q?Gpb/PMh5CMMDc5DeZ9Qjzs8CfpaO/+u0h6OzlvJw/MQj0tbd73pqV+1BdGeF?= =?us-ascii?Q?gf0PK6Py8d9esJJM9WnWkfBp5FuD2RhLJ2oTzyQxcA1A9mratjcZ7mBH0AJe?= =?us-ascii?Q?Vprx5tzgajEroS+78WZip59HG6AXJCaIzsBlGCzLUogrnqooWgglqlTV+2ZL?= =?us-ascii?Q?ntnqstEEqjBbQUwXpZRwhzVMW4f5c49TwS3y8LrmSGThCCsk+sHqAtL3NXMd?= =?us-ascii?Q?+oV92eRzEapyQ26gHIW/12GKe9dcYGLlFwS4gW8TidE4YOY/Lzb08T9beWXP?= =?us-ascii?Q?twnOGoKfHn9vA+o9BI0PZyQCgj6Pc3w3M68YhFXoSrY1FKD468FNilOXwPDW?= =?us-ascii?Q?s0u0pty3AbcujxUWuBXnePLDpeNLai/+BUBZAHUOzu8FujdZTvJK6+8MCz6b?= =?us-ascii?Q?O4w5gd0yZ9TuV9IpV6kkix5B54q8l0g9TBZAuLHTglBVwyvC0/AZknfHv3ky?= =?us-ascii?Q?wTPCQVubp4YWSC5NGo0wNRpPVoGXn26hQRhUs8fvfZ6Lf8idxXHqEiIuAhag?= =?us-ascii?Q?lP+f2gSLEQXCKLCjzifiOBk2CuOU2/qoTdftw38AZsK8dtLb3rXvR3grs/e8?= =?us-ascii?Q?E83M3Z1XT/8h3lAb9GrZ16WIXQ0Sx4FkDRTCnqcXaDExIHPJnTCtudHf5YTD?= =?us-ascii?Q?Wso8NEU7/5qxpnF0kFDyAHTxdcuhZBBeXXu4kD5Bwp4c+Jf0P4lZ148VR92t?= =?us-ascii?Q?MflbSyRR8eah9DvOXYI3ldQcoMR3bN0vinWMyLauGPuGHOS1cLcXFn56L2s8?= =?us-ascii?Q?uvqeGK7cmAc/vd74jTeOYOY0bhthyCPRRXf9WNctmYrP2e7v2iNGxYrmBJfw?= =?us-ascii?Q?rDSTG/OzVC7MhAbCBGdHkqUVZazwj0Wqgf5q/+r+V/+rioLAxs4DXDD112UE?= =?us-ascii?Q?wU5XXny4sZrz0gUG1IqLKeyQO3ALaZfOKjtQte2SCVWiLpFMXVL0+zdl0ZWt?= =?us-ascii?Q?YDenzt4IVTccYsqfweVALIlQwny6hhzGUV+7PBVeamo093wCnu/qWpJj5wWO?= =?us-ascii?Q?atASkEpuz8rms5VMGNASwCd0FUzXdLYmzUfDhwOk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93773efe-e9d9-4a83-d498-08dad4054a1c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 01:34:00.9207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ur6bfR7ytXRGCS8glfkF8SFHjANItTvkGI8E27TUEeBP+Q177xDFbhM8gOrPW7YjjR2OTcv0oBDkUnakEI8ohw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6263 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3694 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Thursday, December 1, 2022 2:27 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Aktas, Erdem ; James Bottomley > ; Gerd Hoffmann ; Tom > Lendacky > Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add > check to NvVarStoreFV HeaderLength >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Sunday, November 27, 2022 3:00 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Aktas, Erdem > > ; James Bottomley ; > Yao, > > Jiewen ; Gerd Hoffmann ; > > Tom Lendacky > > Subject: [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to > > NvVarStoreFV HeaderLength > > > > From: Min M Xu > > > > There should be a check that the FV HeaderLength cannot be an odd > > number. Otherwise in the following CalculateSum16 there would be an > > ASSERT. > > > > In > ValidateFvHeader@QemuFlashFvbServicesRuntimeDxe/FwBlockServices.c > > there a is similar check to the FwVolHeader->HeaderLength. > > > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Gerd Hoffmann > > Cc: Tom Lendacky > > Signed-off-by: Min Xu > > --- > > OvmfPkg/Library/PlatformInitLib/Platform.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/OvmfPkg/Library/PlatformInitLib/Platform.c > > b/OvmfPkg/Library/PlatformInitLib/Platform.c > > index 2582689ffe35..77f22de046f2 100644 > > --- a/OvmfPkg/Library/PlatformInitLib/Platform.c > > +++ b/OvmfPkg/Library/PlatformInitLib/Platform.c > > @@ -653,6 +653,7 @@ PlatformValidateNvVarStore ( > > (!CompareGuid (&FvHdrGUID, &NvVarStoreFvHeader- > >FileSystemGuid)) > > || > > (NvVarStoreFvHeader->Signature !=3D EFI_FVH_SIGNATURE) || > > (NvVarStoreFvHeader->Attributes !=3D 0x4feff) || > > + ((NvVarStoreFvHeader->HeaderLength & 0x01) !=3D 0) || > > (NvVarStoreFvHeader->Revision !=3D EFI_FVH_REVISION) || > > (NvVarStoreFvHeader->FvLength !=3D NvVarStoreSize) > > ) > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20