From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9919.1672996752472731406 for ; Fri, 06 Jan 2023 01:19:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iNSTQnqg; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672996752; x=1704532752; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VAdLETrmE2WCMHJffMDvsgfRnqmTc1TsD+RN1iJ/DN8=; b=iNSTQnqgxEucmHbP2wa8Ig8avb16q+pA/8D3nuoml3j0Qthlv5jI+/Ov vKhUe9lVqDtN94W1IV9dmfHjpteQf4JrA1IHiEz7/M4zINHbuSRFnp5Yz Pw2L3BgLVnHhKhDXAPD+VXIvZTou+irHbWJMzYr0xJ6f+FpfqjyAowrTp S74ihCd5KQRC++2//78pu0ZzLr9pia9tXej8zubkqQJX/S6BV5ZuxSSPV GLEcoCBcvCd/A46axv3SXJT8c5NcBJwptgv+FmR7Dyo3FndzeXvQBTnD2 ysBdON9C+9VLx7Nv4GBxtN8Q6AvV/TdinadeUBeK2ITPn+W3QDKjEgmNY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="302806964" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="302806964" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 01:19:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="605852468" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="605852468" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 06 Jan 2023 01:19:11 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 6 Jan 2023 01:19:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 6 Jan 2023 01:19:11 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 6 Jan 2023 01:19:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZBkEWp4WJwMnjcigEOFiHntb0k5lWSUqosmsy2cRqTIHlri2XtRe4EyA4z5L/w+cjnqWUnvK8H/akErbefNWO80/N1YSQrUNpulkkhUuBktkGjt+CXwQT8Xgls8viVz/jaXcjcDJn3FqkShEFJi+QW4Qsz7HPNQEpFueYn7lqtTTt6rxiP5/2KRUXg+GXtwX8ZaQ1GfrisjgSyQNpWcBgoY4/IoSRMa6daAmKS6NLa+8MV9Q7MjNgyoBMkB+2w/lV9ykJFN0aa4tFjnqYKiuXmo7ExNa4vB0YSRjM5UugmyhEUwT9iqqaepc4HuNVBBE2fTcszrBdyISUd9XrtHnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pd8vufnc/aaF+oYjXKqgW44zVKFcurJzht1NWsYzlcE=; b=mHPaR9l1LMyr55MychhTgmKiGOq9hnXR10xzElGF2/MoC+vjKtHTVo9OVRoUW3Lee5jarjJ+94ru8PFULA72JfDOZMhN+lgnQmB5A/Wp8LGUr1wz3F+TLUPvmtHZhueMWSiVcLNuvQqMy+o8m1nVEuw1oCT55swkevytoFwXm2vAY0wAVJKqV6goGr61rv0lAxg+pfvQlVSWK/lQNnyqwHGzTy4+MfsxUDK8/kY5G0OqtnAUggHUMW/FVsGrTjoYrPEETM3uCdGiERuNs4/RfKHX3zTqdSJYsssJaZhBbnk6hmZF5kh8V0NKhqeLzEbiColQyDMmg/G2pPVRPtdMyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BN9PR11MB5259.namprd11.prod.outlook.com (2603:10b6:408:134::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 09:19:09 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%9]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 09:19:08 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Michael.Roth@amd.com" CC: Tom Lendacky , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the PcdSevSnpSecretsAddress PCD during PEI phase Thread-Topic: [edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the PcdSevSnpSecretsAddress PCD during PEI phase Thread-Index: AQHZFYJ7ZnRrpw11U0qY/xrunclMTa6RNMcg Date: Fri, 6 Jan 2023 09:19:08 +0000 Message-ID: References: <20221221155047.180912-1-michael.roth@amd.com> <20221221155047.180912-4-michael.roth@amd.com> In-Reply-To: <20221221155047.180912-4-michael.roth@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BN9PR11MB5259:EE_ x-ms-office365-filtering-correlation-id: 1a54b96c-c26f-44a8-16ab-08daefc710ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eNrMJaz6wxsvzBPgnyjK4SMQJeeF04akkahNbJDe/kTpY2jqTZUt0n1k0Tq23jMcBH3pGG839ns83CcZih9tKpIkJ1bmUbdmOpM2scdb0ygW2BqVDavb+bieOm3bbn66hz53pYKr5I5kGy589DydrMtEgJuSzujj1g9aBbjbKGcFOVXGs2+Slcug9SvEkIEcV9XWSSFUkVlk2OusqwXaYgjjZ7Iwq4tVuN6FYxuKyBzOMglSVdD0zqUHHb2XxGB7MQOAb3B2sEnl5v9sMthgiA5LGD4G++Yd+kl00xYYtDjmPmL8HtjMF/B/HJwP4JHoHONFF7I0hcsxruyDgnrrGkZe6+HVvH1wc/1VuPePd2q1LUMQ5uGTb91KDiFEN731BR7fiv14yvhI5Dkme7nqe4R0qabpcdbr/Pf6MGpDD9NXnAu8xlEU+JS10KDI3jcXo9+rvl4xYgz7MMvSY49O81IVJkEGiwFo2VbHqtkDVHkbgn7zNH+eZaydYYZhJfjWGeaR8EUAWw8eS6wowragUEROcOoIsf9/UdI3+aNpJLB0y14lmIQASO5YGqTfWJOUgXc3C1RCR+rdkbh0q/SkgIMOK9d9xn3LuGyl1CRmBJ0+b9+xGAL0CWemA8NKo8jzTLjDTY7qEMD7685K4jQyD902wHBUklvN4kYEOvT9tY4IT0xkj8M4LcdQbjfCtz+bGax+cwKnZMMVctLt/d5QImxml9bJzyHhUk4/dlpnndHuChO1bdH2m1W6RsWniQWtRBqNpAGZSKJfARaP+IIbVdxObMLBAlav7pb1W9XVV/s= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199015)(76116006)(5660300002)(4326008)(41300700001)(66946007)(8676002)(64756008)(8936002)(66476007)(66899015)(66556008)(54906003)(316002)(110136005)(52536014)(66446008)(26005)(71200400001)(7696005)(6506007)(966005)(53546011)(478600001)(186003)(9686003)(107886003)(2906002)(122000001)(86362001)(55016003)(83380400001)(38100700002)(82960400001)(38070700005)(19627235002)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mqdSQuo6lrd/6gOIuTang4EvVBk2Io66rvUCGa/4vl28hojSXPYT2vdu1yc4?= =?us-ascii?Q?YZVMxiWhODzP3jnze5VX8f6ITG3St56gcXshhzvQrpfIyQd7IF0JwFgkr0Ua?= =?us-ascii?Q?B3nBfkIa2m8t0E4yiMh+Fwvfn30OBPXXEwdMeySnBa7Q85xakQEs2S4q+f+4?= =?us-ascii?Q?spb6YGkG72Sxa6nAkGwwbtx2eG2ZSFsrSv6eS//3NKZG2DPOexahmRYkJ0aE?= =?us-ascii?Q?KaXB4tZ0qzYQO6xXrB4WISrb+Y9ReS1pz6bCEyLvsQT5p3epCd7vFCHPnTyO?= =?us-ascii?Q?95+UnR8sI/8ihJZJQE0rRvUxK/nUvA96eGtMp11Za5IjhW/nCxv9Gi9PcXql?= =?us-ascii?Q?NfYdx8183Yfacb2djLcS4o6e+NAmJcDawLYfIue8t8fuZ59FJdPNpb+qNUnw?= =?us-ascii?Q?SY3obWjZwhXtAuQsyGCy6JzmjkPDwZ+liu3Iunrd1Ya6X/wGfBxk3O1Xvt0F?= =?us-ascii?Q?OEjlGqCVR34eG9qDviPYa9XQcduf5NLaD3aLXMm1uDY7247HJuW6ESUEyzFC?= =?us-ascii?Q?anNJ2bwkVWO1TLTtNt52dv/ZcBs8+PIy9YLMYPs7k6ahRgxMLN6s84UoGUvM?= =?us-ascii?Q?HvOWIa9e69S+kgZ0qGpOpculwDCox7Br5lIXnsVIl1nTw1xRJfhrtjVC0Vqf?= =?us-ascii?Q?82MjniUzhf+o5GeY9PxalcVEAPaWdgyfNNa3LfpKTzbpJnyq36mJI5gyD9E9?= =?us-ascii?Q?VGVf6J9dnIa92FDyNkiGpsxDaB9AhBJUJh1Z5O6ud58ZGu7I471LhFFoJaua?= =?us-ascii?Q?QwOUP8cEeeJHaoXmuYZomgr9FHBLyfAF2fxQrh9wf1RFAmvyyjaGQcOammE9?= =?us-ascii?Q?cnJuUQWSvmjItQjA/81+QhLrGpMV2tT0SRVmI1WGkb5R/iQjo974N4A2fRjv?= =?us-ascii?Q?P+nxw7YrAGPqGDsOf6zxbBIAawf8O3c51F8q8cX66XmF7EIoY2Z7Vio+7CZn?= =?us-ascii?Q?vKycPfkMxLH7VqrU27dbZhhTIc/Ype2JGkD5uZ4G54wZAq8yCmTtvpKXy/9P?= =?us-ascii?Q?mmyJV6wiMY6fhC98w98QrCCS9RMMOFRHexqwzLNOeUkA+D0kWTd66u54owOm?= =?us-ascii?Q?0uUP+5vPD+h2nN9+95zhbz0Jj2iDZpdRwPSpu/skvE1kMcra3bxciDWAC3+7?= =?us-ascii?Q?nhO29Ox7YtUQz8t2ZldKJYtkBuIRlTTWB82zr1IHVG7HRUydDiz2nJAc5CQo?= =?us-ascii?Q?ZCPDPPFALc609jAOebkHv7fVc7kH5JIdnZelA7UhdRUzDLXb3fGXfFq9D8gW?= =?us-ascii?Q?eDe8jECeJttYDIuLqbPj45gmO0VvRXug/sM0GIAUZQ8NlxZd0YLVLjub48xX?= =?us-ascii?Q?MUcubM9UMV6CEwwm0Eyq2BMKJZvdiViVK+XC0A32HkQuUQIXPEn9SfGTEKBb?= =?us-ascii?Q?kkJoat+bWi0nCuNOXMufkCE1SwdA3KJdgha2MnC5ykikv41Ykor9N7CftkfG?= =?us-ascii?Q?ceZq57Cza5tuRH9ck8w3aRuIaeE2TF3jRCc24HrryrYoaPO6eHcfdMd2MnIW?= =?us-ascii?Q?3csKMyiVXHLCp+Q5MuUBB62hgU+RPO+HanUi5l27xbyPjfz28QmUaSi7mMgI?= =?us-ascii?Q?f8REC/92LGZyNKYIoVZSjQRc8im7Jh/YtHX0s54w?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a54b96c-c26f-44a8-16ab-08daefc710ff X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 09:19:08.8392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TkOw3K+z+x5xKIp8ux1Rz5BzJyJlxo616j0z6NppeXqO2Ld6PVg6MoDoiJVpQWCXEx03/tUw7S9PvQzUJW0K3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5259 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Roth, > Michael via groups.io > Sent: Wednesday, December 21, 2022 11:51 PM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Ni, Ray > Subject: [edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the > PcdSevSnpSecretsAddress PCD during PEI phase >=20 > This needs to be set so that UefiCpuPkg can locate the SEV-SNP secrets > page later to set the AP Jump Table address. >=20 > Reviewed-by: Tom Lendacky > Signed-off-by: Michael Roth > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ > OvmfPkg/CloudHv/CloudHvX64.dsc | 3 +++ > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 3 +++ > OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > OvmfPkg/PlatformPei/AmdSev.c | 5 +++++ > OvmfPkg/PlatformPei/PlatformPei.inf | 1 + > 9 files changed, 27 insertions(+) >=20 > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc > b/OvmfPkg/AmdSev/AmdSevX64.dsc > index bb91e8c734..6c3b78d424 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -528,6 +528,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 > !include OvmfPkg/Include/Dsc/OvmfTpmPcds.dsc.inc >=20 >=20 >=20 > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 >=20 > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc > b/OvmfPkg/CloudHv/CloudHvX64.dsc > index 4d7107fd19..2cc73981b2 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -640,6 +640,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 > [PcdsDynamicHii] >=20 > !include OvmfPkg/Include/Dsc/OvmfTpmPcdsHii.dsc.inc >=20 >=20 >=20 > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > index ea538fd783..b264eb9fc3 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > @@ -527,6 +527,9 @@ >=20 >=20 > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 >=20 > ################################################################ > ################ >=20 > # >=20 > # Components Section - list of all EDK II Modules needed by this Platfor= m. >=20 > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc > b/OvmfPkg/Microvm/MicrovmX64.dsc > index 285ba50671..b2eaa11a85 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.dsc > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc > @@ -644,6 +644,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 >=20 > ################################################################ > ################ >=20 > # >=20 > # Components Section - list of all EDK II Modules needed by this Platfor= m. >=20 > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index dcf46d207d..2e04a3f8b1 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -666,6 +666,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 > !if $(CSM_ENABLE) =3D=3D FALSE >=20 > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 >=20 > !endif >=20 > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index d0746cb72b..4ebf2aff34 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -675,6 +675,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 > !if $(CSM_ENABLE) =3D=3D FALSE >=20 > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 >=20 > !endif >=20 > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 2caa4d2ecc..6f8f368977 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -703,6 +703,9 @@ > # Set ConfidentialComputing defaults >=20 > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 >=20 >=20 >=20 > + # Set SEV-SNP Secrets page address default >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress|0 >=20 > + >=20 > !if $(CSM_ENABLE) =3D=3D FALSE >=20 > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 >=20 > !endif >=20 > diff --git a/OvmfPkg/PlatformPei/AmdSev.c > b/OvmfPkg/PlatformPei/AmdSev.c > index e4e7b72e67..fa88c9ebd8 100644 > --- a/OvmfPkg/PlatformPei/AmdSev.c > +++ b/OvmfPkg/PlatformPei/AmdSev.c > @@ -422,6 +422,11 @@ AmdSevInitialize ( > // >=20 > if (MemEncryptSevSnpIsEnabled ()) { >=20 > PcdStatus =3D PcdSet64S (PcdConfidentialComputingGuestAttr, > CCAttrAmdSevSnp); >=20 > + ASSERT_RETURN_ERROR (PcdStatus); >=20 > + PcdStatus =3D PcdSet64S ( >=20 > + PcdSevSnpSecretsAddress, >=20 > + (UINT64)(UINTN)PcdGet32 (PcdOvmfSnpSecretsBase) >=20 > + ); >=20 > } else if (MemEncryptSevEsIsEnabled ()) { >=20 > PcdStatus =3D PcdSet64S (PcdConfidentialComputingGuestAttr, > CCAttrAmdSevEs); >=20 > } else { >=20 > diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf > b/OvmfPkg/PlatformPei/PlatformPei.inf > index 1fadadeb55..851af81248 100644 > --- a/OvmfPkg/PlatformPei/PlatformPei.inf > +++ b/OvmfPkg/PlatformPei/PlatformPei.inf > @@ -115,6 +115,7 @@ > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr >=20 > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask >=20 > + gEfiMdePkgTokenSpaceGuid.PcdSevSnpSecretsAddress >=20 >=20 >=20 > [FixedPcd] >=20 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidBase >=20 > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20