From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.20834.1661407339527452685 for ; Wed, 24 Aug 2022 23:02:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=j1hdVJWd; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661407339; x=1692943339; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=573hUo2OBvYV4MhqySEDINBPiRgNXUsLtJht9SswJxQ=; b=j1hdVJWdNY2tX9e+ESoxkQXnARr1b/PErhlzXQ3bPCBlJ2T0kv6NBMOj N+ANKjYE21HfXhXqdT+uT0Gberr8YX2xXanzh7OYUcTTClRlbDXAL8t2O cmpOfHyP34y+JHB4nhGX/y4qSO1QPhNzMdlS4OeU4n6HcMPAGOx9ywIkb 2lbJNAr2bYy8HjmuKw3VcuyKOwJgHF4wQUZhyYiO0Z+hJFDIDgCq/IT9/ XroBnaE14Lm0yajvvQujE55QyoyeEf42qaARfGSXF9qPh4GOcE0wfZD/e 4AYilusNCBOqE1EmMsZd4rsDxO4LErc6mHNlEa49NnG4hJmE4G0GGVjy5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10449"; a="292899528" X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="292899528" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2022 23:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="670830842" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 24 Aug 2022 23:02:17 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 24 Aug 2022 23:02:17 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 24 Aug 2022 23:02:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 24 Aug 2022 23:02:17 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 24 Aug 2022 23:02:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cp5sMBHWTaZbK7BTzzcELyFRfGKs3w/xEnPUBY/RBbMMAWF8MEJmLjd5RQLkpFHZ9QqH978VZfOH4aF+qX7LyqZIzczE+LIo7ll8p3YPLmuyF+A9hDiA+/5TBgwoBFFBNk4qv2T+TTSzdDsg8DYrnFsWGtGYEjom6YSaGTz6bfqJ8/CZNRBPoWCoLvQXOq4+KsAw8+L1oHToUesQE8to0cFjtdbwqH2JaOuOCh3PPG/uqeDc5u/0dkE9Dq6CEUkIqnhhbA7hbDxEeIlmqCKBYr+YperZRJFxaB2sYMN6MRgKDS7aut2Sv2xMLiF+A3Id0eHnWnUEV1MMG1dykej+zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMVX+Bh2qTZVJv5yNlzmxhEtODMY18B5FEpkDWKagbw=; b=Pmzg0A+t/rgGhkxY8nrLA1HAUIpCI3I/wYLAItWrG3B5BxAdRgqndtp7csDvY1kaCqbx6pu0y4GVIyqLl8/QCB8m2ZnNn3vgga8aCusjXyxCZwg9/8WP93Gl4yiAjyTnzgvQFwz/IxJEPK0e7Wg+kKTD6U0LImKXnlVv2Jjji3ciPP4J7mKvXtZMFO3+eFTW6Da2N7b73j+u4hp9+Fy2hffn+zbwj1vhbdOPF0Oxrd8CxmRPHadCodurRnYT4MvQQyZJCBPUh5aRC8cyZHeQgLTmPmJK08Jx1tJUUO8MKb5rtAUoDLyxSDl2uysCFsxR9dAPrAulutwQx0Glr0LFjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ0PR11MB5597.namprd11.prod.outlook.com (2603:10b6:a03:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Thu, 25 Aug 2022 06:02:15 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fd1b:7b1e:ffad:2f96]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fd1b:7b1e:ffad:2f96%7]) with mapi id 15.20.5566.015; Thu, 25 Aug 2022 06:02:15 +0000 From: "Yao, Jiewen" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul R" Subject: Re: [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Thread-Topic: [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Thread-Index: AQHYuDW3XLtjFvy8jk2ESJsQUU/vx62/H/oA Date: Thu, 25 Aug 2022 06:02:15 +0000 Message-ID: References: <20220825034824.4044-1-mikuback@linux.microsoft.com> <20220825034824.4044-6-mikuback@linux.microsoft.com> In-Reply-To: <20220825034824.4044-6-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17ad0201-e510-40f9-81cf-08da865f5c5b x-ms-traffictypediagnostic: SJ0PR11MB5597:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a9gED9rRQ33SGcbhZmO34y+DtAEzsVG5DJVeP5rnXBLGx2/n1QXfJXpmkoVANCAIOWYQoY+FQ4u9Eir8Bs+IqB1QibpwyNgz9BYksn8PJ/s0YUW5tRZRhDhM5p5R4bbdvIdabVlweVMPI/kzbJEmN4q9oEsKlmqU1j3pab9Xj81NUnpXMg7xWA4TEtWwk9Ez4+4qEOhMsONqm7JLFyjjrOZLDZSOwlsdHEw201zdK5iWwJELYfl4HARpyY2kb1cViqc+yOxXLChyTe5R0u0JOHYL2v3CNcISIRdOvjnPsDC3GHz45ai8+K+fpGofaTCJzmGE5mfQW7ltfGCDKFvGeQpEOTdPNducrv4YKDGwWxAsD1lNzHSx+iu/3C4ePHIiRlsMLpQmm6Qj6JKF6Rb3jAgr9VYQMXqxdZt7jvnPlfrORsYy5f2ZSh6O+LXVPmREU/krk+k5zy9pkFDwtB5DcXd/VyXtLXE1UNvNkCHRCDKyZprIerq3eoXEj3TJTKrDVWh0/GQT77lTWSM+Qj7thLuq8KGuZZk+LAp9bGl8mbGbL1odDXjRGd4Ck8fD/EwhI83GfvHo7LNDjnFbZ24PkndejKGOhGzWsyzOt1+9nGi2tNtb+0Z57XP6bKT/l7ZornfVb2xeAzKqCyFy5rhVvXamEWl2B7gBY2FcmzsY4x926AP9083DlrBFcksuRiraO6hxKzgnujfEGcHgdN/rM0/pvQ+L5ZTfnkOjtJH8vIJgQZ/YLR2pOG8NXc/V9Sh2skx+NtJR/oB5Kue/V/JBWA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(376002)(39860400002)(346002)(366004)(122000001)(7696005)(8936002)(54906003)(15650500001)(71200400001)(26005)(53546011)(107886003)(83380400001)(6506007)(5660300002)(66946007)(76116006)(66446008)(66476007)(316002)(9686003)(52536014)(8676002)(110136005)(66556008)(4326008)(64756008)(86362001)(55016003)(38100700002)(38070700005)(82960400001)(41300700001)(478600001)(33656002)(186003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?piPPFTdERZwZMRcW6bIQZpBFqQU7IgE9wZQ3NTOQB3knlRvahUHcATjdhjhW?= =?us-ascii?Q?m7DjEv/n1PGxziFGyfHk5nV5RapM/HprLfgtrqNTQryak+NDk+oQH121Uw9b?= =?us-ascii?Q?yB2K7ZN4VHgdBvD08WJFn4SGCJgbVs9on/oOa6rA1ZCKbso18zwdBd3qcCF8?= =?us-ascii?Q?TWnXQPvFs1SKBV9JZ5L4TcU9LSASzdb7w5lSR0Q408e8QpWJgsNVNkerL5wI?= =?us-ascii?Q?7aZZLm+zQ9yjkM7aLa3pJJBSzQXd/wVj8ZnP3XG6GXLyJxxP23N63yuV2RNB?= =?us-ascii?Q?hBC+96SrZ7azFZILXPeBPakHMNWh7F2Gva+fIi9d9+rTEfQQtileOhMoLmNQ?= =?us-ascii?Q?0BXhpAEARVDjyTlisBHzFU6Sy1LX/vhTSqjRX5XrXH2W/oxqrgyebjHIeDxo?= =?us-ascii?Q?gmL6+tlO/4GBibaLKtzYkIwXLjY7S2F+PF37pKrn9O7N4BrYsPgIhLapT6E3?= =?us-ascii?Q?RW/Y3F6kUr9zadviFGy191gon6sm/rWKfHybRiPdQ7qQssmFNnCFVDQRJo2Y?= =?us-ascii?Q?XqSarbODqWvCI8ZAlz4wPckb3mUanH3yyCkRwk7NFc7ZzCtPqWFzgODuQXaC?= =?us-ascii?Q?7yX92c4sqrIJng9GIC78/vuVyq7l+RPbKYBNRb+5uLbm5oaTXr48W+WdrT5P?= =?us-ascii?Q?vE3bkOz+lN/qJ3iD8Oh3c7oMrJu1IRJbrQR7ySsPqQDAW2nuTjiGWt0UGE8Q?= =?us-ascii?Q?1bFue5+OH6r5+WOBbvs1UpbJpCyxNKOX+IfE1S5dnkUg1HUZfA9EN6YA/D0I?= =?us-ascii?Q?PTh0m1/SJUAud3RlnIJ1LkIuQxyg7kEYLKIcq52d7Sn9SW39SDdIsPmW6fzx?= =?us-ascii?Q?ElAQypSxRK3Yf4E8zooeVbGzjM24HbYcSVROxXW3niGWyJPHlxWERqPDFAXa?= =?us-ascii?Q?I5ljEkddR4+BJsA+o9LwV18NzKfEfBMF7ZHpi/fa0rbLmLv+Ka+lJvj6OxAo?= =?us-ascii?Q?Xq2NP5cnrDXKMh0WLSwtuXkzUqhKIRazNDcD39an7I9c/wvw3dTzpZ9f8JLI?= =?us-ascii?Q?VumufN4FplrQWUuj5co/h7X6r27JJnE/+tIZs31QOd+TLBpl+XklhJ0gDlnQ?= =?us-ascii?Q?XWGM5oBEJOIliYyV0H83S7QnK7f2dlKV7GOeRgVV1UReYOwrf52Oz9xOOsdA?= =?us-ascii?Q?ns33hMF0wwbO90RX0qf5R5mC5ac19sXl2+PRoiL9rE6us7+1TfrtFfOItG7A?= =?us-ascii?Q?99pX10Nw9tCiXYy6DDIGqp30nAkEWSxNXQDJLjx150sO4c9tKEfqTNL3lwmP?= =?us-ascii?Q?o2/dd4GwiL3iRvQoTTZEXXPw+xSyVFxLID0H8r87vN4tKudJ4TzeKueQ4vVl?= =?us-ascii?Q?n8vNWdh+BwPXgSIuvFjs6ViXhOF4I9SVd4SgkqEZBUDvKA86C6C8aSds56Go?= =?us-ascii?Q?90IYInMpW+x0x8QvpphAtOR3i1SGRNtFoftyQj+4DHd990h6OeMaahAWjDWq?= =?us-ascii?Q?LTlkV9CKmcy6lhZsIrDffeuQKb97itGT9ZbRhE/1njdAe2EYxVAi/iueBIWE?= =?us-ascii?Q?dbfVim2BYfBkozpCJUuJnXfr4RwF3OBBW9+uGBbsU1p0dFw5cnUiz8oWMBm8?= =?us-ascii?Q?H9EYFvh27LGVunZ4KBe8w7shtDdr1XkSsGXYm8Ri?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17ad0201-e510-40f9-81cf-08da865f5c5b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2022 06:02:15.5550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EvjMooIddwJSj2zqUxpb8GgvIDCwH1mrjYxTuB2pR1vnqw+EsTSxs5DtpRn0e0KHlWLkN+0U4jXIrVHHk/vcCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 25, 2022 11:48 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul R ; > Yao, Jiewen > Subject: [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missi= ng > debug print specifier >=20 > From: Michael Kubacki >=20 > The debug macro modified in this change was missing a print specifier > for a debug message argument given. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Signed-off-by: Michael Kubacki > Reviewed-by: Jiewen Yao > --- >=20 > SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLib > Common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > index 1fbfc00547cd..f2ab4f125007 100644 > --- > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > +++ > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > @@ -176,7 +176,7 @@ > Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( > // Sync PPRQ/PPRM from PP Variable if PP submission fails > // > if (ReturnCode !=3D TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { > - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable.\n", Status)); > + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable. Status =3D %r\n", Status)); > DataSize =3D sizeof (EFI_TCG2_PHYSICAL_PRESENCE); > ZeroMem (&PpData, DataSize); > Status =3D mTcg2PpSmmVariable->SmmGetVariable ( > -- > 2.28.0.windows.1