From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.7507.1674013728716029135 for ; Tue, 17 Jan 2023 19:48:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QosDIsy5; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674013728; x=1705549728; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YneydYUTM4bpGKmHWMvlazkmdk8nvtrI6xTk395d0a8=; b=QosDIsy5ssvYzMkzYGVsVVRY2OGQbqN6OCsjiJ0JB3NWyrteAyI6Z0aI 0iKjELcaptFICa3jau1gwIbDIqCuNJx+9T4kdwa8P0fkbX+6Jmdqx8H8j 3/PIftUysTsGVvGSvnr9uh36j+2JTOgkofXJiRnsxm89y5ClBY4QdfPS4 O6j1YjZmtks6xBInYkH2whIwvCfAplwpXYDYxh6TF6Ze5L89M0NLFQI6k rE/9lonmVNSYVqOM2q8ab88rPAI/zahwggMmur+MeeGe55aokT56Jzt1b p4gLJ0VCbt+Pj98h87aJ69+BY9hhlhwS9szf0DKnFr2ZWRAwUDwPv/1rh g==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="326967786" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="326967786" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 19:48:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="652760545" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="652760545" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 17 Jan 2023 19:48:45 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 19:48:44 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 19:48:44 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 19:48:44 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 19:48:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbEgicvfMICA/LTjExr4WuoHwKIX6LIC1Zl8DDlJ1dQETbD39uXhOBUu1Goe9N07oJx6FmDhCstdQUKjvQbc+RB3HwsbhyVolHk/y6+v4Jiq0/enBCOs8k2d+p5FP8IK9vcdTxrmfP5JRVcafttFRfuwGWM6sB8V/MLhrYHMmj/uwUMPAigDOXbZw2OKppQht+HsltuPpL3fS23mV0EMwAUaX7LSPacBLWNSzrh2erf36exXkO38gb8kKu84/AU1ShS/GpVk99C2p88H+8PasRUuTVdm6kIIT1U8En3JvZHZKNB8MXG+ZiE/BYdjMhJ8Wd8VujFl4nygylDKKPqPwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oY+Sq/tt7YIr4iYdpU8mNBe6FpvRNlgt6XruW2SygOo=; b=oOj+j3gPsmgtXc1Ne5c2YKAgTi9GwvpZcDvLwaZrwQQ+olPIbzeFhAbvEIODa1874CHqWQCdW5pLm4jAJd70OZfYLwpwTGnYrvu6xZ+owdzQzXTHkrKdwIVWpHWuv+iRC+ruxnIKNqOpEaC1qaECxugFi5mKVaHRrd/PGKozOz2xp4HspCSkr7InSIk1yeiLNy7bFTNKZ2Re2cwUt++tIsRN5UMCOBLA0gSxLh6bUBijPdxErj/g7ZEkG0mEAgzpEsb8IsWb7+oMb/VC22TOaH8thiNtTi07lPtWJUgNV6rL1U4/oyll6JTC8AxEnZdXECKgpezc2W1C2AMrI5l2Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Wed, 18 Jan 2023 03:48:41 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Wed, 18 Jan 2023 03:48:41 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Xu, Min M" CC: "Aktas, Erdem" , James Bottomley , Tom Lendacky , "Afranji, Ryan" Subject: Re: [edk2-devel] [PATCH V3 0/2] [PATCH V1 0/2] Refactor TDX MmioExit Thread-Topic: [edk2-devel] [PATCH V3 0/2] [PATCH V1 0/2] Refactor TDX MmioExit Thread-Index: AQHZKkdzdR9b7mtsvE2ZminsnDshuK6iemcAgAEQazA= Date: Wed, 18 Jan 2023 03:48:40 +0000 Message-ID: References: <20230117074330.1058-1-min.m.xu@intel.com> <20230117113312.2kw727uhdt323lal@sirius.home.kraxel.org> In-Reply-To: <20230117113312.2kw727uhdt323lal@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH0PR11MB4887:EE_ x-ms-office365-filtering-correlation-id: 9ba2ba79-d271-4f82-cd86-08daf906e385 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /N3Jmn2oIPcaLNw44VBa+5OFtdUYLVCUmQ0d4TQlk4mDbp0JGD505YRGnVueg2Cv74gsQOWqKfFk4tJu53rxmTfvRdvDkASuQqle4GjGyt9mUJM3DqZ4PN4tTuOnUjCtuHBMVdfvQhzgaglhm4h9NOrjXP3HI+qllZ+nQiunbqq1STxiy6ZBGeNCVIFmOjUnRV0J0c2m5Z6FUq52G2GEVm+ad9qPT8TDPnavi93mkTkEe3NrHDDew0iot9rSBqm76KWXZKhZC2kmHXhdlj26tT40SQFqqneONIetipZ4oJJ6++7Ku77ibt456PRkSfQx9v3HL0mRk7ElO2UV/s9/OGXqlS1V1YzYPNrJyBN00ezaPeUbXnyBnzAomFjflX40brCXoo8WspGxd1FMZeinbDk4G2sxqZV5evOG+1wGaqB/0krDnWkp1eqw9HyFx5wvYap9FYv3kuJW2MmZYqatXpPhPhRM8WThVyY3bN5KmrTYaVaM1PO3l+fIJgqh9ubQZHEm/ZfE/6Mv+brBYfcEvQcQfuKCInpulpr8DYjXPDaTkMLAqBdkQ68C6DJMw3QaBjzoLvyQxXH/OEctsBjzfXjP+JQrA0gifcD3BvC+Nr82cidzlgrqhOTkdU092xWr89DRr6iUeoeSrUuVH4OVV48kGAva/sQ0ZBZh17UvW7ilGNVfL1R5waQKVQ1dFy/uddUPocthy2O3TJjWv3vlh0suF0mmXEr01iiq/SxnnHGiMkD7ML+1MzTe1ugshLxsYlfiwyY2aPxx2SWE72yQ0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(66899015)(38100700002)(8936002)(86362001)(38070700005)(66946007)(66476007)(8676002)(66556008)(64756008)(66446008)(76116006)(55016003)(5660300002)(2906002)(52536014)(4326008)(83380400001)(82960400001)(122000001)(33656002)(110136005)(71200400001)(478600001)(6636002)(54906003)(7696005)(966005)(316002)(41300700001)(9686003)(53546011)(6506007)(26005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u5RP3d6w2xi0Es77rbLWws8LNAKxkdywg9QYGZSDsnh4yz52hhbEfujBxK6+?= =?us-ascii?Q?7gTes8LcWKPOapvzH0lj2Zq6ur3//TzSJnYHlwTYGt8sITuTOtDehxFkDa3n?= =?us-ascii?Q?rhsHmtUM7Gh1ke7DV30njm4AfXEN9BdmylXhv2CcZpwkqvk5/yUz5agNt4Km?= =?us-ascii?Q?Ivt+qVxKEqHAZbKOuPM62Cupy7h9+yayIBmnecp11GU/OCvix0daORiPunKY?= =?us-ascii?Q?y6TSk8OGRBeuk7AL31OsAMLl3hZKxUgRhcExkh3VirPW6J1D0/uWcOBCKOfr?= =?us-ascii?Q?GNXn4I9xRXJyhBN2IZ9M2Jss+SJ5zEBNR/GgBVc9ovpwz7fSspYjJHHUzYhz?= =?us-ascii?Q?7T93I3Va/tlVcmRIXHLGII61WCNRpiSzVxcojh61Y/yVupoj0LG3l4HI9JYz?= =?us-ascii?Q?zmirPfXl+Sa5sitLnmEktQBbCtdLro6LOh6BnVX0YzDUT1jEODz40U/vQGyY?= =?us-ascii?Q?9kH4AkVhSJXRQfirygvp7odsQoNTMReHUHs7lKAIljwzU4duFm/+fTRESVjf?= =?us-ascii?Q?reYCbj5/QhxWrlF8V9P/9sD9QIAndC1yTumz66Uds7Kbqt4neDMaAMPgD6I1?= =?us-ascii?Q?u9DZPkmKfFzD7uVvq3pl1rASaqwZHx6c/8xlsOUrzGHE/mBa8X8sYyBA5YeL?= =?us-ascii?Q?3fuxkuhFNU7J/xF38x3ElvYZyotZJBJN6vIA6Epcgje00vJvHArZeZR9rvGM?= =?us-ascii?Q?5zErp5L/FC92L7uuEWyZnnQcNMrCB3iE3aaOq5/lu1+sf7T5YDUxK+hswzQu?= =?us-ascii?Q?nzK4wK1CYJzEBIzMC6C1FMtvdV+Cdq33dPSZq17kS2v01+qsUr+w5sei05YY?= =?us-ascii?Q?aYaz1Mxl9lpO2VpXrXE4Pwz8B3lGwO4MB1V7/ThDH9qmytcdnN6JUfTYThG+?= =?us-ascii?Q?moGtJS6cBaPUhIWThrEfJNWNK6jy+Gn/7gIQCE39euQkpq6T3ufrqunKMjtk?= =?us-ascii?Q?E62yUNRpQWrXDLdh3hgZf3uiVL0ziEzZn7o1oPYagEBF+Ep6Zg+8kCv1FaaG?= =?us-ascii?Q?Ctl0WHd2Bxv4Ph4nRKod0OzuEJUXrv1Mz8pc465DZV4CoFoCX5+SzM4YIxU+?= =?us-ascii?Q?8RNn/V5RDB2GEDaw3qZTfnJ9bMFtjZzproK8U3i+jK60xqfnUBU0Y6xD9M5f?= =?us-ascii?Q?At4Pdvo3LsJm8mBFAMoNe4O3cFnDCrGAStG+wdJVicTSN8VY2rnaap5/7/Zk?= =?us-ascii?Q?fU3TsuES3AJV2GEK1DPkv/R5B7GSaghXkrvbaD8snhj66q4lCkq1rRjdIYse?= =?us-ascii?Q?Te7+YD1WFUiE1qq1AVJ6cVE/nUAXhtF4YL9/fyfB43ppW9RgZyeutI4Yv6Xq?= =?us-ascii?Q?FDfaX5BJUzoIsmTjGJQ1UXdssA1V5ic709orirbRbrME3wGwmg31x4/p0GbY?= =?us-ascii?Q?baACj0hdIbEYWcxomFt/lhftb/b8UE8gYSPdiYIZP1ChfbFqeTdnraL7/lFm?= =?us-ascii?Q?W722HiuirWisOYUd+8/t+PuLd/52yhVfLggJk3p54SPLwmXc3SRT99sWTMGY?= =?us-ascii?Q?LThRPoRmsT0HE1+c1DLRc7vMzqYYXK2ty6/aYSqFr2upOoZFmApR/vOAsMNE?= =?us-ascii?Q?fALGzCE6+vNsNUBLTkbRY/k4OKslSKSb3VvFQMtj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba2ba79-d271-4f82-cd86-08daf906e385 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 03:48:40.8038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TyGgPgXEuev1W16LCsdjn18BqUORdjBPulKrPKlpyeqXDNZ1uVrjFUMZUteUMjvFGGoJu1yioBLtZ5voxOa+Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3918 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, January 17, 2023 7:33 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky ; Afranji, Ryan > Subject: Re: [edk2-devel] [PATCH V3 0/2] [PATCH V1 0/2] Refactor TDX > MmioExit >=20 > On Tue, Jan 17, 2023 at 03:43:28PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4169 > > > > The previous TDX MmioExit doesn't handle the Mmio instructions correctl= y > > in some scenarios. This patch-set refactors the implementation to fix t= he > > issues. > > > > Before the refactoring, common X86 instruction codes in CcExitVcHandler= .c > > are moved to separate files (CcInstruction.h / CcInstruction.c) so that > > these codes can be re-used in TDX. > > > > Code: https://github.com/mxu9/edk2/tree/TdxMmioExit.v3 > > > > v3 changes: > > - Handle the error if an error is returned from TdxMmioReadWrite. > > - Add more check in ParseMmioExitInstructions. > > > > v2 changes: > > - Add CpuDeadLoop () after each TDVMCALL(HALT) in VE handler. Because > > TDVMCALL(HALT) is not trusted. > > - Other minor changes such as deleting ASSERT in VE handler. Because > > any error in VE handler will trigger CpuDeadLoop (). So ASSERT is no= t > > needed any more. >=20 > Series: > Acked-by: Gerd Hoffmann >=20 >=20 >=20 >=20 >=20