From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85A7BD800EA for ; Tue, 16 Apr 2024 15:40:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pAl25LAj443VgjCJK2sytqvHv+QSJ8ME3c5XUhVU6x4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713282016; v=1; b=sPLteqGryfYS/6S09A4Y6STKvYhMsd/d6l54cmCTHicSWR6mWfv7O+curX13p31NH7jWm76Z kI/5Twfyx6n3Fvr9q64oaY21akK8BWBzfKKOs7VXh8ra7jD0G8ODmjDwG7gB5bzgwUO3vBTWBZN gfhkC8/eHmXIMwFzYEsyyyu7Q2mt4zE93F8+1tH6QUJp/bT+d5+ZNvrYp1vv9VW/WE7Xl4ylP8Y O3micQkkskJ64qeCoTzagO6UtURAP09wdg2ov8u2qg5YpuKe4shHs8sw+ALrncgWCwcZ1OO+5na 7ETbvZRvomzZfYRgz2+GHsD0a9F5L676emgMM0CnNnkng== X-Received: by 127.0.0.2 with SMTP id glTIYY7687511x8sR8hA2v1L; Tue, 16 Apr 2024 08:40:16 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web10.24301.1713282015211532143 for ; Tue, 16 Apr 2024 08:40:15 -0700 X-CSE-ConnectionGUID: u3mQXgQdTMadWvRfV+V5ZQ== X-CSE-MsgGUID: 0h9s4VbsRZSCdoQAkpQNcQ== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="8593670" X-IronPort-AV: E=Sophos;i="6.07,206,1708416000"; d="scan'208";a="8593670" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 08:40:13 -0700 X-CSE-ConnectionGUID: c/DpqJ9tSS+ZDs5VLAVDFw== X-CSE-MsgGUID: ncfINsBcS9CjcF+oBMxRgA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,206,1708416000"; d="scan'208";a="53288293" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 08:40:12 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 08:40:11 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 08:40:11 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 08:40:11 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL3PR11MB6506.namprd11.prod.outlook.com (2603:10b6:208:38d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26; Tue, 16 Apr 2024 15:40:08 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 15:40:08 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" , "Xu, Min M" CC: Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Thread-Topic: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Thread-Index: AQHajwpr1QjfEYCpX0Oq46ZMYZOE17FqsAaAgABZWXA= Date: Tue, 16 Apr 2024 15:40:08 +0000 Message-ID: References: <20240415075555.499-1-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BL3PR11MB6506:EE_ x-ms-office365-filtering-correlation-id: a1da918c-9e08-417f-2b91-08dc5e2b7ec3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /M4C2CkeH1WK3Sxxn/Y76yXp7+hqrSlVvR9kOnBF5qDqd9mvLfwXvIljxIfzGT271K9kh0dEcUzsXXPCll+NoNDYHOW7CoN6ykvNHLrDOvDs09yrj1vM76uoDfS01ZpiGBn/Ry1ewjF/PIO5/DGYJxPrak9NnB4GX73t1TFDveOFaU5fU7QSjOQSCWFoeRkkjBauT+PUs6CxuwQB05s8JLxTORTevn9k1uGZVPsMq/KeATCuHOvtH8iYIIZ+WbFRNk0VbAUNxwaJ2f+YeZd6qy8dCerS9ElNC2bZWDDO9tKgZpEcK19OBWuPtnHZFkVyTE7XchSsjX1TY4k3F4ddOSO7jIH0rkrqoBEjtjRPzBX9AFNmnnExFnA8OtgaNK8KC61GPl+ku0ROegUrQuiTWE4L0hQr7Hk7Y/MdBNyYSqyY/Tos6Qz/D0GsdAaXNL4Wk7kTEbThBSiO1TE0X1pPhJnyZ38Dx67x48yDczG0RdjEYycdQJAL9ZyVS/9BF70SBZrmhPfBt+l263h9jVBJya51NhR1oXoGTkPRbFFF/YXa4rfOOdlHpqBQhSMnqT5I0ooOvOhfxi9LWdPG1tkk2uBWm6IPjpuyEYGPwU23gVZW/imHRuamKgHWVZxN7TI4/uyz3b6DKSlExWdRHtewhHzP3L9huT8CkGV2s8UnWRk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R/+UYe62P+U9qKCbiopeAibw92vzIsKHprd5ZJTSnp8cP0xS3sUk1zwWdkWX?= =?us-ascii?Q?raDGlAc1rV/vID+FszNBrtYilJJ3TotuWLMXhy4mb0AlQthouyAogycadjUX?= =?us-ascii?Q?SILIo+odl82c0mz9LOTW/AeN2cSUp59GlOf7PO+93t22dounFZzYFH+IlMuX?= =?us-ascii?Q?T/R365K8Ft2j9x+8nSnJpmVHMIeCMDkZ4oa2w+Bs8r3/Nl8P+nzeTz5YCw5c?= =?us-ascii?Q?qMXkpkpeC1yKnXxl7uIGlqqFqpxHT6ASedgD1HVMd/nvho2CDYenSLtbWZu6?= =?us-ascii?Q?BsbbeW0LODZdZYbEXLuNHUyEpm4SHvMiyYvWJw6D7+EYlKPICHt2EUn0GpS+?= =?us-ascii?Q?NmK0FneF35At305Hcx+4Fu8w0QvX/OV6pDsWeF5H5CuThyboaKFJjsuShJ7H?= =?us-ascii?Q?yeATlTXL+arbkjpdsnehtpmkmqfoaLL+rKGh3HsusdyTRsSBjNZNpAevg59j?= =?us-ascii?Q?RVGKtYqZTNd8EPfDY3FtpTFEEKm+Tu1Pm+uobrIpdAlWYewOY9uHgIF2TWWw?= =?us-ascii?Q?W2bgFqhGwOzxJbz9nW6TcPRrnAowflv6s9QtCtdLPyUhIhp9VXItVlzRD9lw?= =?us-ascii?Q?JxwLX8fD6UWXCdPnauAydTO7c++qJpejsCQjMkhtSU9VwAQW1H4oPmzQnLiB?= =?us-ascii?Q?eXBpYhqNmjk5LylTRVfwZWSL8kRG1LyKwt4gmXp7JajSihS+DJjBVJ4ips7O?= =?us-ascii?Q?6nZkDI8p3WmkgCe/acAW9gKNzPYfeDUtMgYCQJK5PHIsBT4AyNNEuQ2sKnb2?= =?us-ascii?Q?lk6/feCRMnO69Tv5PZTcAmVi6TGz8YYZAeAN06CeGoVwgZ8RwtRQTkGEZwiU?= =?us-ascii?Q?JSI2Ov7bFwTwO0a2royYA0fA1T72SqgfDrf+2njVERslH1kIMZeT1nn3eaYN?= =?us-ascii?Q?dBGfmkHLWYGOmD4+VOBszN+17iJZW5ee+SEsiJgA9r9sPQcxfZ87ZfSqBJXr?= =?us-ascii?Q?UZjabSvQpCBmTamq0jFFbPhg9NuEnnMzJcJT9ZpSl/RhHajaf0A1KltcNgh1?= =?us-ascii?Q?JW83j0JSMYe9uaA2W7D1gJ2xE70/L+r7JQUTv56VNRr904RY/KUuGXnfEq1v?= =?us-ascii?Q?T/fW0i/rhKg8VpGgrSPyvXNUkfIV9j/zXcajSC05BFKpXRjrRU/ktFppBsUz?= =?us-ascii?Q?Sp6CiNqfx6+6k80bjsxgJ3dUET22+tdy4bl5675NfiihWBQmMfr1pMVvXfnE?= =?us-ascii?Q?MOhm3kVuDNpcbWcoDAc6zP8GOd9pEwJXDtP02dN5eUsFaTKZf2FNYnj2VI+/?= =?us-ascii?Q?argNGFDCbmTA7pMDLJGUemb09WWyVE+45f8mFjKiK5vMMxFY9EFUDnO3lCRM?= =?us-ascii?Q?2vV0HseAVE9N9xDAEeXpVxKV+5q8JrJJaXS2/yIvfSY8QLv1eH47q9DGp9m9?= =?us-ascii?Q?VR6PBmqrvs+2Z5wjSU4E3U07W1eu1No77sRG1uXjHodEnjA7VVbcIXDWPqLK?= =?us-ascii?Q?F4C3KrFm7L/pJ+EOyVCZd3rR5z/prF3i2D3yOibflifIA0CsKNRVPxjXUUTP?= =?us-ascii?Q?BcXoehvkKfRKqes2n4TC43BOE3HoFQ5VtZA8go2j23KHG1wP+k+xOuL4schF?= =?us-ascii?Q?FdDIVWK2pgeClqz48kckawKl3dPYdq3a96YRxj2u?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1da918c-9e08-417f-2b91-08dc5e2b7ec3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 15:40:08.3027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: guum/QBdw1qnkecRJcGTA1ZOherM6WFUmOpsOk9XEHN/8Vcc2yevalVzMIHSvFilc6716nTxS0lyI5vT3Ca6SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6506 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 08:40:15 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OPTaUfw2SVh4fz7kejkVtHkzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=sPLteqGr; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Yeah, I also considered that before. But after look at current code structu= re, I give up. Since following SEV component are NOT in AmdSev directory (especially the T= CG one), I do not see a strong reason to put them to IntelTdx dir. https://github.com/tianocore/edk2/tree/master/OvmfPkg/AmdSevDxe https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDecrypt= Pei https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncryp= tSevLib I think we can follow the existing code structure in this patch set. Thank you Yao, Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, April 16, 2024 6:16 PM > To: devel@edk2.groups.io; Xu, Min M > Cc: Ard Biesheuvel ; Yao, Jiewen > > Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from Secur= ityPkg > to OvmfPkg >=20 > On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4752 > > > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > > > SecTpmMeasurementLibTdx is not used anymore. So it is deleted in this > > patch-set. > > >=20 > > rename {SecurityPkg =3D> OvmfPkg}/Library/HashLibTdx/HashLibTdx.c (100= %) > > rename {SecurityPkg =3D> OvmfPkg}/Library/HashLibTdx/HashLibTdx.inf (1= 00%) > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/MeasureBootPeCoff.c > (100%) > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.c (100%) > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.inf (100%) >=20 > Better place them in OvmfPkg/IntelTdx ? >=20 > Otherwise looks fine to me. >=20 > take care, > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117887): https://edk2.groups.io/g/devel/message/117887 Mute This Topic: https://groups.io/mt/105531957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-