public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Xu, Min M" <min.m.xu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH V1 0/3] Fix TDVF issues
Date: Mon, 16 Jan 2023 00:44:58 +0000	[thread overview]
Message-ID: <MW4PR11MB5872ABDA38175FA3D0B7B7848CC19@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230115232739.415-1-min.m.xu@intel.com>

>From process perspective, I see no reason to combine them into one patch set, because each patch is individual, and they are handling different problem.
Also, there is no reason to mix the fix in SecurityPkg with the fix in OvmfPkg, if they are not related.

Please split them into 3 different patches.

With comment above, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Thank you
Yao, Jiewen

> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Monday, January 16, 2023 7:28 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Michael Roth <michael.roth@amd.com>
> Subject: [PATCH V1 0/3] Fix TDVF issues
> 
> This patch-set fix below TDVF issues:
> Patch#1: Initialize Status in IoExit
> Patch#2: Extend EFI boot variable to PCR[1] according to TCG PC Client
>          PFP spec.
> Patch#3: Refactor error handle of SetOrClearSharedBit so that the caller
>          can handle the returned error.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Min M Xu (3):
>   OvmfPkg/CcExitLib: Initialize Status in IoExit
>   SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1]
>   OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of
>     SetOrClearSharedBit
> 
>  .../BaseMemEncryptTdxLib/MemoryEncryption.c   | 48 +++++++++++++++----
>  OvmfPkg/Library/CcExitLib/CcExitVeHandler.c   |  9 ++--
>  SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c         |  6 +--
>  3 files changed, 46 insertions(+), 17 deletions(-)
> 
> --
> 2.29.2.windows.2


  parent reply	other threads:[~2023-01-16  0:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 23:27 [PATCH V1 0/3] Fix TDVF issues Min Xu
2023-01-15 23:27 ` [PATCH V1 1/3] OvmfPkg/CcExitLib: Initialize Status in IoExit Min Xu
2023-01-15 23:27 ` [PATCH V1 2/3] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Min Xu
2023-01-15 23:27 ` [PATCH V1 3/3] OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of SetOrClearSharedBit Min Xu
2023-01-16  0:44 ` Yao, Jiewen [this message]
2023-01-17 23:54   ` [PATCH V1 0/3] Fix TDVF issues Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872ABDA38175FA3D0B7B7848CC19@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox