From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.155320.1673829907621250035 for ; Sun, 15 Jan 2023 16:45:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nq8b1jSQ; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673829907; x=1705365907; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cFk1K5ma86xJULyqjvzJ+wEvlBK8ydgPLAZ5eXuuvQg=; b=nq8b1jSQslrpFPtjRgo+MttW8OuXtitrHp5x2c/8oHj5mc2xqTUQ+ZES JAMZcGtZu0fQ0SBHoCFsrCyW9t5hWefxd72J0jgaQVFnYlCMGgTl3fwjg sQqxcr64as4ChWKGlowx5Ybae0mnhQWC0B/uIWuNIL5rNAG9S9H+cNcbi B/85AGqEGrp3BGddQPrTJS429k0P+97iVOckkSh/UkTDW0+ob6ktlyazW lUiSivQ9LORUqJZ4fuqeSttMgC74UYbnSW4WMSUa+xfN5tnoI3wpmvlzV N+OqvT8yhHFmkgPYKzVONScFym7vHkGk+S/zKuFkvs4cKdjAaao3AbsAK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="326416802" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208,223";a="326416802" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 16:45:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="658838181" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208,223";a="658838181" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 15 Jan 2023 16:45:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 16:45:06 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 15 Jan 2023 16:45:06 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 15 Jan 2023 16:45:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DPUPyxcMLIacutOtRfrRie1am5eFFRUclXd9Hx9cxidK01Ip7Z/ZaWQkyRf6mnFC5lbX6IN7/EKD5oWW32AULJtP5E/P9QzIfnGWRcrPCUxaCRhyhMAx6WrzZOwZcFVVxQNR+i6Pn1lemQ6DW+uMcfdmmL2SBpBRlQMq4g+nYP2apeQQB7Phtu/gnD9r1iQA+MgFwXwPo58ZseRBHehf+rdyWOwFh6KnOjc/I1BuaJUiWremjB5KiJ3piyBaAdFcgGR2yXwpRg/t357Yu0dys/ULTRcyEXIh8kHHAZoCcCMX8ItFXT3oGTS/aUiAKPE5EseQ7X2CxEWtAp1cb+l+sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/GJ39jcTDiE9Bjk/DP2enbAOvDin8RFxqSVn8JWNpk=; b=HvPgF8uVf+fyH4fhZRjmgVuMXjJGrDrpVV9FV2nGhEZS803Me5HjTiDSt1peFPSfBeLdLjABY+AchDyDdCqQwGBoQBF6g+1gARhwJuU1VTlGruvugbvLigBW75sUw1aI2I0JBWTDkB8goqFRhr/ErrfybL+i8trvlkRTRn0pUmwSxykFZUZH44lIjEyX+q1stwvTbC70xHrl5uxgfEO3JZ3kqDcQf7VU7dC5Qc4PdKGA0tGKn+SHvYzZr2gPUiMNlBa/QyO054tVRsZCtMmJnKMWn1UDTAyesMxb9p2EjPbk8zEU8P7QSiR4PH6KCZBTbsQ07hqev5u/V8S+2z+Zqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB4740.namprd11.prod.outlook.com (2603:10b6:5:2ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 16 Jan 2023 00:44:58 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Mon, 16 Jan 2023 00:44:58 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Aktas, Erdem" , James Bottomley , Gerd Hoffmann , Tom Lendacky , Michael Roth , "Yao, Jiewen" Subject: Re: [PATCH V1 0/3] Fix TDVF issues Thread-Topic: [PATCH V1 0/3] Fix TDVF issues Thread-Index: AQHZKTkA9q3SfnbZskKLghf28SOrk66gMacQ Date: Mon, 16 Jan 2023 00:44:58 +0000 Message-ID: References: <20230115232739.415-1-min.m.xu@intel.com> In-Reply-To: <20230115232739.415-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM6PR11MB4740:EE_ x-ms-office365-filtering-correlation-id: aa5adbc6-5cde-4d04-2fce-08daf75ae4c3 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z+pZ7RnC5OAL2pb4TKnyJieYXkKK0RDHa8NRYF2msIiKfy3euBCei2kxcjpN73CRFYprRaCi7X90st2fwYQz1rcS0bLaY0X1NPmhqg8igm50MP/FEEBqhch98qEWZHdMEm/S/9Blv+6pT7KfSHuEzfa9iICzB0ZH40avASveQtts876BAUfZUYE9ByIVl0MBsu3GqjosItFJA0cov9t0gtnjJ95uAL40jgv6CopdQhBktIRPrRW6FdAJTNtyllPk6b6C4dHmb7aTvTrvY44vYsbtll2s4nJnJVhdYqfspqkxC2MXOJbeBp0wefuKfxuwbjM6ERGzjjNkX2FKRGBQgLrDwHSo+WLtJ+Uewz9eBV2Wue2t7Ee+OFnlMh84a3YdKHmTX5GjSNguBIr85c71mNuKi0FByORnZgu8zPnz4LWA2inqgOUlzIZGeePQHfDCfe93SuqV0rG9YDFCODl98l7UdMTYNtj7LskoVach0MaNv0UPDePS5sLSTGwHz+OIGkMdI+pEARGWCEu7JjisbHhGTSK8/7jJWH1BI96hc8ZOg5fuR/Z3U/6SMQ4p3kxh77aMISla6QPxX1reUJEPJH2Wk3wRw1rYy0nNkasPvpUYynHWzd1pFucJgIaXhPw/23ToPtoJdH68OmF3bSEnK0ol0OUfDmL3f3B7apCMXLIVrMAadYOPHs1f5w+pa1RBbFK8DspE7HCrQ64tegwsbw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(2906002)(83380400001)(33656002)(316002)(478600001)(9686003)(64756008)(186003)(5660300002)(66946007)(66476007)(66556008)(55016003)(66446008)(52536014)(107886003)(122000001)(8936002)(53546011)(26005)(6506007)(7696005)(41300700001)(38100700002)(76116006)(8676002)(86362001)(54906003)(110136005)(19627235002)(38070700005)(71200400001)(4326008)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GTOzwY3tY8IY17zUU1zoVMY9DOTK6vsQ9JWgX0Sn/gzmwIUavwXVoDV3x9pv?= =?us-ascii?Q?RUyKJJ32glhFzkiA8xrUYg9XuzDSNkD4+DFkU6Tiyrh3PKs2IJG3nWvywtp+?= =?us-ascii?Q?tKWC7dH0JX4muROvWnECD8QNvV9mGDQSYN5/4cwg+eikMToxpV92xKOwwtD2?= =?us-ascii?Q?6FYysga1P9rqwDspPwQN+4DyfcfLJnkjSq/K92H8HuFQTkCGQbLvMeVuYyiI?= =?us-ascii?Q?tkUEm2mi/ByYsM2foFLhRiBs+VdIS2sFIewGMkRZBmQbQAhoSlyBxSb1berC?= =?us-ascii?Q?E39gHmZ+VRxykKi+dHxxxi+7kB+DzKhyqoNRWIPlxVuPQCFu3PZMpV25nOZ7?= =?us-ascii?Q?TT8vlGtUbeAMkhRs8oyfs2TH2eYSIWBM23N5wY/xnaO9h6narzeThyyEFIKN?= =?us-ascii?Q?fRPUqzVcp4CiDH6+2S0FQCdkXsbthB4fVWCYbFT/uvwH/tX/E2HSzbkrbtq5?= =?us-ascii?Q?TnB3HRkTy2YdjT9dnHGNxQEVEF0k2Qa+uI62Z5WEfBgoCZjHrshfIagcfifz?= =?us-ascii?Q?Xjna7QdFUJDnFoXxjmhG1Pf7W8bbUOL0HUTomCgRkuxeNcwIp+KcU8R636Rz?= =?us-ascii?Q?gI8F86QhxArqwWiZYokQoxI9StK802ix2u1butd2EEyW6HMbnsetUIxGxFAG?= =?us-ascii?Q?/71XwjUtTM7MGu22Di9KW5+HzJeD4+uaIRwzzMWGFcX42SDIiRoATgwimB1E?= =?us-ascii?Q?0BQYShPbA8EwIKq8/avNcueYfSYc5c6IZRjBGSmzzyBlwYIZTSxLTPBfPgdZ?= =?us-ascii?Q?/v1pbRfDCQ9pGJGpt/5963j+o4Fb/XsHWFUTY5IBqRC/Ya17I9cRWDXSv0g8?= =?us-ascii?Q?8QXPOjZvKu7LkpOE9Eu7/taeHYzlI6EXm0+NfW4ojqUy9NIkfhSZLg0+i3wy?= =?us-ascii?Q?LRbjIEamcT60gugqRXY2QPuvqhvgVnB5UgKdJT56tlD7XjgyGGfSAeB77IhR?= =?us-ascii?Q?sK2yA69W2v2/CGLEXlZRXMxYIHCvz42GOheJN3uKOpdQEmTaUbJSa8Ov34TU?= =?us-ascii?Q?hYKdgjhukLxg6Gc632t4kwAIOBSlXTbidzf00THlDOBCkzcpZvN93MvPriPB?= =?us-ascii?Q?6CY/ReP+dSfBFhnPBWI95zFFQ87J/rMKXjteAkG7o4LGoB4iq1F2NHej7BO/?= =?us-ascii?Q?Xn5YGqIFlq/sT91o1uftPaQpvPFUEEem8Wl8I0AH6W2RJb2bJvAUJNz5tGNO?= =?us-ascii?Q?ikvZzJaCDbPFXUZEGctqre7A0QRQuFWddY+M2YfuxfmQVz9laKhZEy4ozKT2?= =?us-ascii?Q?sJTMTyybSWIpUuxH2r/VuFI6BOhLb/EWkmGYx1LcsXbBiWPJGDlAg0WdGDen?= =?us-ascii?Q?fITadY6KZlUVwIi4gM0CmsqGvCueOTQJPfxLQyRRw9Fj94viAeWtJH6twnF7?= =?us-ascii?Q?vNtu0UUV63x6SOqLtbjGfEzP9qB1yPd81DB1Sdk00RBnStUKW5jYuRBfKIB7?= =?us-ascii?Q?cxlcL2o3w/jvvGzeD2wd6unCjtT+liZOA1UuTGWTfNyPaABmOK/KCzst1vbC?= =?us-ascii?Q?9ASM6hSj1T2WodCdQbSv/IMyfgiXMdQt7UxbOyc6zI0geFPv0WlLhEzP6Fzv?= =?us-ascii?Q?+hN81BPKdUAYtJAoWRS33y7i4pweplD67Xr0XRlb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa5adbc6-5cde-4d04-2fce-08daf75ae4c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 00:44:58.2992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cA2RHM6ejHne5FFqbkzAlDiQd4O6vk3wXXiQ2AX4jIwrv6gkKkMWj/FrcsFXxtqDYFzMlTms1Pp7L2QMf7L6/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4740 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >>From process perspective, I see no reason to combine them into one patch se= t, because each patch is individual, and they are handling different proble= m. Also, there is no reason to mix the fix in SecurityPkg with the fix in Ovmf= Pkg, if they are not related. Please split them into 3 different patches. With comment above, reviewed-by: Jiewen Yao Thank you Yao, Jiewen > -----Original Message----- > From: Xu, Min M > Sent: Monday, January 16, 2023 7:28 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J ; Aktas, Erdem > ; James Bottomley ; Gerd > Hoffmann ; Tom Lendacky > ; Michael Roth > Subject: [PATCH V1 0/3] Fix TDVF issues >=20 > This patch-set fix below TDVF issues: > Patch#1: Initialize Status in IoExit > Patch#2: Extend EFI boot variable to PCR[1] according to TCG PC Client > PFP spec. > Patch#3: Refactor error handle of SetOrClearSharedBit so that the caller > can handle the returned error. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Michael Roth > Signed-off-by: Min Xu >=20 > Min M Xu (3): > OvmfPkg/CcExitLib: Initialize Status in IoExit > SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] > OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of > SetOrClearSharedBit >=20 > .../BaseMemEncryptTdxLib/MemoryEncryption.c | 48 +++++++++++++++---- > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 ++-- > SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +-- > 3 files changed, 46 insertions(+), 17 deletions(-) >=20 > -- > 2.29.2.windows.2