From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.125289.1671074464469045326 for ; Wed, 14 Dec 2022 19:21:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RqV7VEz1; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671074464; x=1702610464; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F6YCvWmuoEcDOa7IWOKaZ+MCgp9Sg8qbigdSNy7Mw9k=; b=RqV7VEz1YDF2VmuV6SQv8pszGzIqLumvOg5BoSqqNKOPpEPfJwFDU8Ay b3nQQX7EmnBZ9KAPTYyjFKCg8vT8x3/GV7309j31W5B5YVKwKXO5jmtTb 9P9C3cA7hefwy7OjSeJpi2HhicNiARmoHiof5B3TqDcqy8RnE+VtCkQMi iiv4skfwQCF6q6/80h7HjIFQVZgT6f5eCnUlyTbRkBkCnSK5+QYRWs7KG 2qOVWSw1DeNnukC437rZq6DvQSxYoBvrrtku3VZHgqESwHgLAzaOAUcY8 hvQjgZTN8KJGyZe+BCrkb1V2R6P8IEW601MRNFyX689RSh3sPo/mEe8Ye Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="298916869" X-IronPort-AV: E=Sophos;i="5.96,246,1665471600"; d="scan'208";a="298916869" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 19:21:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="642750029" X-IronPort-AV: E=Sophos;i="5.96,246,1665471600"; d="scan'208";a="642750029" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 14 Dec 2022 19:21:03 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 14 Dec 2022 19:21:03 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 14 Dec 2022 19:21:03 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 14 Dec 2022 19:21:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlYOLxtLOjnyzkOLpsBgYqSxN8uEQMa0Rk9Z09jT25wJAPasXONb3Iqii7HSi7pHGp6pDMm5SrrpdEVzNkBGf+w3Ul5j4/CcM9Nly64qyMYfoPNB9dHxNg/34JAP6UDYrp6MeZr6r0uDsUbXH7u3mN8bpWh5XutA6Y1kKhRBkRJNVsvg0O0NLWZGa3G093l174c6cIAWEZg9tZg4puu7e93L7Ia084cnFSSxuYhLQeATJZjxaXfAhKx7YHCG04t/VnWn8wtkpUEVjOic7kUDQuhADzlCVoxS226kGLLdKP4HDxRwJOhP1j5fCIPV6I/PNzeWXbP6qNWJCu63JtkHng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gvAY+X2/koFM4fNan/iu8c0jQtH7I/6R2gOLz3v7us=; b=bLU50HL1xhfoPVcvvIeF86I0vHrRIO1PGkP926A0uny56rnf/JllEEgtUgETnk0x2BdNH4XdXNkIhxUfXY40YuteQoUY4IjOrRufh0YHUze2z1hZ4f7FBNPsncA1yYB3/okqSevVrWvcfFV5V5A3u/YNiRc29gvUp53bSwj25dWWtVmZejhhdPxS+1u5mrlHd5s7sTVTbY3PrWxgW2OvaLacjeJHBPBy/q4KuTbpBc+CEv+xLbtfb607C4nbau1jJ0K9xpWkg2fxOLeKFj142xZ/kHYjYBzouuZWS4jL6M27xWxnC4lzYbk4Ft8ZhjvsIZ4Sa18UIbZbzPeC6kl8tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CO1PR11MB5185.namprd11.prod.outlook.com (2603:10b6:303:6e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Thu, 15 Dec 2022 03:20:59 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%9]) with mapi id 15.20.5880.019; Thu, 15 Dec 2022 03:20:59 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Xu, Min M" CC: "Aktas, Erdem" , James Bottomley , Tom Lendacky , Arti Gupta Subject: Re: [edk2-devel] [PATCH V1 0/3] Fix incorrect implementation in CcMeasurement Thread-Topic: [edk2-devel] [PATCH V1 0/3] Fix incorrect implementation in CcMeasurement Thread-Index: AQHZD4vZQpYZq6acZ0C7rgb2GsgMV65tkfiggAC3XqA= Date: Thu, 15 Dec 2022 03:20:59 +0000 Message-ID: References: <20221214071419.1813-1-min.m.xu@intel.com> <1730B590101EA428.23954@groups.io> In-Reply-To: <1730B590101EA428.23954@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CO1PR11MB5185:EE_ x-ms-office365-filtering-correlation-id: 14842f31-4669-41ec-3ab3-08dade4b6319 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bQZwh6ASkP5QJKUHS081mvr1rVIhPzeKr9ddU+C5uu9e/F66XnyoIGDq9AOUcxnt7k12et5lbRJN9IZCVFKQDSfXR/SYU1RcHGaZP3my1f8gTzn1KY73XAIyjXgJ56xe7aS7pgUTffex/c69S41CRIVytt4F8MyWdiHZ/+sQ+smKzZ7YtFTnD8Rcz47V2D5ke2QqfU6Sc3KMXuE8NlptjFtaOTwpCUor/iXPMz6pg61qWK6tDY6ih+OtTb8MFVR8rgUwufV1JkcFzCAuhB5SEIZgGXRO4eIyDIENOITUWwo+mM9mygO7qnMNsLK/krXaydNgQI5BLzCFJAv4e2sAl75iXdCyeawcLwmbTrLtHj1sFv0xUS49O8TlO4uyVDHXrMFsv/ieICcUprSV4cPL1GZmHYvnKgqBYkPkJ4kMP6zB9AL2g8NpjhIrkpQRWcwGHk8WrgrE9yLx6a4CKA164itAVJ4nFOHUz5RfmuXhmUTf+xxBTz3j4Oiqqu84seiIl7s+vE+H4OlOysGQ7fGycBL8Ul+skex4cl4Sd30KQkDIfPxfCSzt8unA/P4FkjN/IurgkuO8AhLsCwKKV1D+eIhJ8+6QCyB67MLWMvaz0zetmcSnrnK0MkImGAgT+tPHMFbrwajEO+9xhpYwSCHzwlwyPYfp8OFKRqOFGIVxD5z5P3TFlMyTDTSffmxtRbgpbVsLcksXLzM/CZ0lM4PQg1fEtKrNQIaKE1cRwj8EFje574Cy9lN+1u1+xUuv8HSjYA24fT5C2JsoJ5inrfr2yg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(86362001)(122000001)(64756008)(66556008)(55016003)(66446008)(316002)(38100700002)(83380400001)(54906003)(66476007)(6636002)(19627235002)(82960400001)(66946007)(110136005)(76116006)(8676002)(52536014)(2906002)(5660300002)(8936002)(41300700001)(71200400001)(186003)(9686003)(478600001)(4326008)(26005)(7696005)(38070700005)(6506007)(966005)(66899015)(53546011)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bVHWCIkXpkXDZdeI84FSPFFZJkOH1RvmCamHXB7GHOxiA59If91Smw7UaAZF?= =?us-ascii?Q?6pmqqteB7ay1KOaE4uT3474x0f9qC/90dGFP/twYFhvN9nqHj7VxNVucIJ1z?= =?us-ascii?Q?ux7GEBEDsHtKkHeclIDj3jrGr6zqPEM9GGA4QF6IaOB0v0Ydl/pSrgThww3h?= =?us-ascii?Q?gJmkv1RZ/opiezt+046k8l5AfKxMzK2BrTwzCdrEY9Z1qyJOY3AYFDFlOzIm?= =?us-ascii?Q?tM3ewxhpA403dESUfd5EiYZlwVWIcOJqYkGuDK6SLplHVdTrUdxvDz+rbgJF?= =?us-ascii?Q?lZxU9+U+M1+Zdp3WmC2kzojcFeDU5LOVh64OrtDsy9KsrwNwE6U9OkGblrnO?= =?us-ascii?Q?tLY8UbLOq59js1jx4XYucS5I5ZgJZOnW4kvpTOICMzoSKPNzelpqqrKSwT0C?= =?us-ascii?Q?/Glo9vzypX2KQI5gmd7S1WyF5iVzQpCExhicgOehaTMxjPMhqkM8HIoYOve+?= =?us-ascii?Q?dqSnUnSx1LdRP2RcKoc1BCwd4wKeZjs1nJroHxft7kMsnwoJRiSxJKeyr3D1?= =?us-ascii?Q?YbpY4Hv6dyGq8Fc+2oL35Vvu+uiGj1sbaGwZhfNGkpcUR2rZBrScW3GIUhdz?= =?us-ascii?Q?uc2Y59DJ+L97ID8GbGKCyLZFGUtzKQ4ME0+vE6/Z0C2P3oj0xgyQNCnMjrFd?= =?us-ascii?Q?N7uPjxd+JZwMyntgB6QVjZ80xeYRWBvNa38Rl9pkOLBR9UPYslVDr3DxJY8g?= =?us-ascii?Q?lo+AwYx9QV9rgfggtKrWRCMnA4ka2CdrWvrEDyl81wV2M1O3itaQQXFB0zz8?= =?us-ascii?Q?RpSHTypKl/LL402cVvQXjajrBNBU2hlyAtj3ZJ4vYBjFjwa56fbpjEvbIkvA?= =?us-ascii?Q?htJX0tyBshos/ympvlJblxzbBMWP4ImH9SVZhHUBDL4DZpJlyHokN65zQVVA?= =?us-ascii?Q?lgmG0Rr8E6Ongo6kOFIWQxzu+E0HmQhfB8Mxce52MlNvcAIuIh4cYDPSRhoK?= =?us-ascii?Q?mFTqy7a+v6Id7zrgP21RaQH1/irh+kwBL0z4tr7OcViGnRRF49sGP7jjgJ2u?= =?us-ascii?Q?m25D6sDVdQMm1rGokvtcw+wrw/hYqs7ZodXuh1R98/gstCBk4GaU4sclNFQV?= =?us-ascii?Q?76lMvtFoBngB74d0TfZF48aPsEr+rYVEkX3VaV124DF/CQYc2Uv0lM4571sn?= =?us-ascii?Q?vLPM+MrSFt4yjH7gZVORTKFC8qpRX9Wuf6Nh3vhWnY/yeNPsBhznhIb/wCCl?= =?us-ascii?Q?I3FIsH12jlcfhAwXpA/w4aQPujX3LKXDObfdzoe30ud+kg1GPPedNsIK9YSq?= =?us-ascii?Q?sf/gI6PEOzRgjwkaqkLNthvoFan4U4d7IN1FU54KbbctgXTWVnzeoMt/Lv93?= =?us-ascii?Q?oOlrOG5WFGDknfRRi5YMGrBnpRkYRmTu6ill/hXuMTGI1gVQH1YdYsW+AYfl?= =?us-ascii?Q?Z70j2BcDwFwCb/6v1WHazGBfoJxlqEUFaAZTLn1pIjE+spMKFsW5lsQkIrrH?= =?us-ascii?Q?QbPZiwi0YIM8vLp3gKcBEa10g0hDImKmbYWLwxGQNqwZKZaqzcqajH621aAN?= =?us-ascii?Q?jQTZyz5BQLGNZ8+jzohLVJ9zrZ9OFaXIXlKszfVMtzW6vAt/3/GIqEM2CUUA?= =?us-ascii?Q?xS6X/aiQOkvZvw79f/y6TAuZHrOb0QVunySdLfbO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14842f31-4669-41ec-3ab3-08dade4b6319 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2022 03:20:59.2232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mY5vAY4EgF/PqYv6jXiETqsm6fsyxApMh5noWkrwhVOkBKEqY0t8k8aKVV2Kp1J9EsW+pjaMIjqfyr8cwHnIDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5185 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3773 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Thursday, December 15, 2022 12:25 AM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Aktas, Erdem ; James Bottomley > ; Tom Lendacky ; Arti > Gupta > Subject: Re: [edk2-devel] [PATCH V1 0/3] Fix incorrect implementation in > CcMeasurement >=20 > All Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Wednesday, December 14, 2022 3:14 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Aktas, Erdem > > ; James Bottomley ; Yao, > > Jiewen ; Tom Lendacky > > ; Arti Gupta > > Subject: [PATCH V1 0/3] Fix incorrect implementation in CcMeasurement > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4179 > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4184 > > > > This patch-set fix the incorrect implementation in CcMeasurement. > > > > Patch#1: > > Incorrect protocol and structure version > > > > Patch#2/3: > > Incorrect mapping between TPM PCR index and TDX Measurement > Register > > index. > > > > Code: https://github.com/mxu9/edk2/tree/CcMapping.v1 > > > > Cc: Erdem Aktas [ruleof2] > > Cc: James Bottomley [jejb] > > Cc: Jiewen Yao [jyao1] > > Cc: Tom Lendacky [tlendacky] > > Cc: Arti Gupta > > Reported-by: Arti Gupta > > Signed-off-by: Min Xu > > > > Min M Xu (3): > > OvmfPkg/TdTcg2Dxe: Fix incorrect protocol and structure version > > OvmfPkg/TdTcg2Dxe: Fix the mapping error between PCR index and MR > > index > > OvmfPkg/SecTpmMeasurementLib: Fix the mapping error of PCR and > RTMR > > index > > > > OvmfPkg/IntelTdx/TdTcg2Dxe/TdTcg2Dxe.c | 93 ++++++++++++------- > > .../SecTpmMeasurementLibTdx.c | 7 +- > > 2 files changed, 65 insertions(+), 35 deletions(-) > > > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20