From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AFE8B740041 for ; Fri, 1 Mar 2024 15:05:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Vz4MDNBDrj3hK14JKjdWpVvYfoGP+E1xE/iyYR/GG/w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709305514; v=1; b=Qy/SQd5MyTWdE6T2PTXRF8mAEsrr1i9N3ScjH7LhE/wj6VavxerK/7Ef21//2qDRvczYNY5p qJBWofCvXX1fpJ8GGykDeNmvfReaJJeIOfge+OfpNMlLipenfCY+XeVe+a7m3TYwfRQ+M/os3RD 68blY5vuR5FxE/iftk9W4K54= X-Received: by 127.0.0.2 with SMTP id 2cv7YY7687511xWUHzIBID82; Fri, 01 Mar 2024 07:05:14 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.25339.1709305513589497559 for ; Fri, 01 Mar 2024 07:05:13 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="3696900" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="3696900" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 07:04:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="12767772" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Mar 2024 07:04:41 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 07:04:40 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 1 Mar 2024 07:04:40 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 1 Mar 2024 07:04:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqzD06v0gnqmsCX07kVyVNgiBzZxQrsnM5BjBrttSeIpb68G2/g0sZwdvM1Zfhs84192xZApjW7RYCGqYfZ7l1yqpAVCbwiEvPuhH55tyEaCVazBXk+qHGysfCzHBtb6eBoHnSb2RjIcS/DrpGdDY+Gqb2w6oBCvJVgfPxPmj3XyM2+uySz24jI9WGgKTutpC9vG5d/EOwTsjLfKiEx3qWfzr7fuyrj15M0tVjGpusY4RRFL5NTnajdySw5zPiq7svTKIsR8J2oPnlt0u1a6FUYSq/wYm+THU1usRLB6kp+7BNiSNPW6y8bm/QwzDRxAesNKlZTML+UjEZwCccboow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNKUpWgu8UYB9kLqYZvc/ynht2Xs7Ri8omO1lc/Y+8c=; b=R+SKI5X2o2DYPxtMtW2nkyASRbaK9d7rJDQcyaQQ+Qjq5gYECROHk6m6+fuGO+0QIFA0FTypwYScaBQ1bNfOrEvoHb5KUDwLw3Jv4Hbx0h3DREwiW6QZVrHeLU5ggbNDzUhQJN9LrVR+tvk7Q87RGxAevRMTuhsIxl64JzNIKjAy3fg+rOhQmCosIEO9ATKMSgtGKr5klcbww+ypIckJORrOoBPtSqXu62nu4jxXR7+KBx94KdSWG8+nd6yHK/93TcgmOCz61UMcCqaLiloKCsk1gqeZLfZDnd+Geo7mrLmVRO0LIV+PyrtFYpY7JcBuZ/MLJkq9Htu2V0cHRQVsZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA1PR11MB7941.namprd11.prod.outlook.com (2603:10b6:208:3ff::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25; Fri, 1 Mar 2024 15:04:37 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::92a7:f6a2:9262:d150]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::92a7:f6a2:9262:d150%3]) with mapi id 15.20.7339.024; Fri, 1 Mar 2024 15:04:37 +0000 From: "Yao, Jiewen" To: Leif Lindholm , Pierre Gondois , "devel@edk2.groups.io" CC: Ard Biesheuvel , Liming Gao , "Kinney, Michael D" , Sami Mujawar , "Liu, Zhiguang" Subject: Re: [edk2-devel] [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg Thread-Topic: [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg Thread-Index: AQHaW2zd8/J7V2CILkCmun+Z0kdnLbEG+diAgAADp4CAGzJnEIAAtQgAgAA3RuA= Date: Fri, 1 Mar 2024 15:04:37 +0000 Message-ID: References: <20231121164228.766299-1-quic_llindhol@quicinc.com> <4951c86b-ecd8-4253-95e7-ceb00b8192b9@arm.com> <725dcaa0-8365-46d8-a6fe-f95b1d495518@arm.com> <128c59bc-dd86-4b26-81f7-ecc07f4c72ed@quicinc.com> <58a4fbc9-36a0-4ebd-93a4-0e00fff7d293@quicinc.com> In-Reply-To: <58a4fbc9-36a0-4ebd-93a4-0e00fff7d293@quicinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|IA1PR11MB7941:EE_ x-ms-office365-filtering-correlation-id: c11cfc85-6c4e-4b41-7d3f-08dc3a00e9dc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nY7E5bgNwY61JlpXfkyXRjUbj8s8yslSHbEzxrJwyetyperB5mhnwEsqfjXKOt8JK7/WgxbTfbi+EoFSO12qVZ6KS5I9VHXLzf0OONZ4fVgQ4TmpowrqrwXsY309GSIxsAZv7Kcpxw58dyy8++0/3JZb1rfk5TnF0pGsafEk6JLdNwq3bem1XvCc6mrBa34/Bp6VKeJcXLSIu74U1Lc0JzL2ImxlzZP2hI1SyPXZLwrQgxy0z74CaAJ9jh6q4eiyO9Nc39tISfX8YOAaqjtdItgiTRzzBNc9izt663vBJjqCeVbUTfmJyD5IyAd4OW39VJ3rponA3rcjg9GmKuJhpUD3tTZxb/ggtuFJJfdKbzYHFjnWOruRbWG4ss3/5UUDbxIj/ftZABiEcxdROn6b5nDPoQfuwvHNxoVbd6xZHbArkNT2Pkn5OvaRwlHGPGKxhBNef1j1LL5KQB+Abv078//yAjbsnDBzXcuuT0bliKlzwlnqzw1KsyOltwibvOv78azq5XzzjMSG9dL+CdtDibvTZQdl1Quj51sGTrsSvIiemhuGkhJM6058YAyJqIyEgu8iOzJUUEYP0DFznxLPMiRjjBlazW6tuWcNwrnUT0HbUHH4jLsoHdDE0Tc2OiNLwYOIdhC7Buvwf6lL/Bri06tujw06zhZ/0WpgljOtd9Vc3W48WS5A3KQlkgrgfIq3 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EH+BX3OO3d8B7LSeWF1WTehfLBcSAXjJlFhuPJJQoG18d4O/tTvzrzMBeE?= =?iso-8859-1?Q?SNcpUWUGw+dl7q47n6MvzYSUY+6Ii/NsZMHsP3oII7QiAQ91yzUgPr/GYL?= =?iso-8859-1?Q?dY7tOQ1lCMnZ/1p28k69CWiNHpcWXkyus/vw0/OtomFkHSz+wwOR0cKRaA?= =?iso-8859-1?Q?6NmtvbEshj5yIbFmJq8ldhE5j3PyshJaYux8RRiOtUza8ivt7ielD2m9uv?= =?iso-8859-1?Q?V++DdnqghwWJ6HdpaN1nqqmrGAbSeQ3Yqm8SV91w8jMSsYzJwwLt+tpnTv?= =?iso-8859-1?Q?o96WXmihTySQGksRX3tYP+a/Tyzk9+pN0mnOaSyUeHVHAjyA2hDWaOaXda?= =?iso-8859-1?Q?SgOBZPcE/umuQc895IbHLgQqcwZOggEE2Kth31DHyZt3TE26w71/p0LnTk?= =?iso-8859-1?Q?95HPnQYMOajIO4gm4+3zMiBjNC5Vy7XqzsuyOe9i4QKcEvTpFsujT8cqO3?= =?iso-8859-1?Q?I3gxi9IiCa1jhUUHwvnysdCPOGW6n8YHj2qebN9wezz5zFp3YfQVKJXHPT?= =?iso-8859-1?Q?qP9pyEOAOxxq8awGu7LTeCr+oLqWP+u0g+1f+20ZiAvXPx/16gcMWX1Q8e?= =?iso-8859-1?Q?mgY4ytFGkjEUeuAPzJi5A2rS9ieUlVc+FrPIan/p9kArFDum0L234SO/eQ?= =?iso-8859-1?Q?YxRwP/izcG9RmjLN4EMMeeCSdhGxPC2ortZpOdaG0koNYHVEWTLOJAoNCW?= =?iso-8859-1?Q?2rFasc+zBVqwNL+OFXr6xD/icpLJCPq1WVFFjeucvSk0mhrkjcmprFpr0V?= =?iso-8859-1?Q?qMZdgvItsjWfXchbZjC28vT5KQfPQqKdtk8deCdGyR3MGuilO3oZRVLwpl?= =?iso-8859-1?Q?vkzuiHnElnCYHiQEwHFC59lCPYgRS1wKEef01669+b9GU/LNYf44D0y0nN?= =?iso-8859-1?Q?Y1Iije6NJPOe5bE73tSx4hvfZXgIjRSSW1dQ6B3qaYV4jpdPaU6s28nMLi?= =?iso-8859-1?Q?mZsau2J/gnOcnfZ8M3gO8GYtWTktWr+avFchcmbfm/tBLoy9Vk3XjiEbAS?= =?iso-8859-1?Q?dxT0h8CG32zSFf8VH7SVT/AimOHrGFXDtijDTJK8XhC9QMm5NN8cHaYpqP?= =?iso-8859-1?Q?n8e1UG/vHQLlxOfjrG+XgUgU63edFvaCJ28MCI6HmZ0P+c6OtKkEmz30t5?= =?iso-8859-1?Q?4AEGDQZ3yqKEUT2n7gXHgThE7x+0kokJb8xBRBNfva7TqsMv/SaliT9i4Y?= =?iso-8859-1?Q?DkOouO9wdHJR3AC/0Juose7PByIi9LUNIy/HoXgJXt4oF9H+vOxxPPtLBb?= =?iso-8859-1?Q?hysFtIX5STgbQFxT8eC/xqjABjuI3ZKIIIqr2BrhD946SNGoHXjtKgd/9r?= =?iso-8859-1?Q?uKfWUBR6PaIKh0+ABR72HZzuZJ8VSK5UTHM0TlKNRfpE944LnuFnEQawmI?= =?iso-8859-1?Q?vDlritCsZ/+SpBQ0tTHB9O1I/hPGXBu1qK7p97w6GvslKbeB6Be08iFBS0?= =?iso-8859-1?Q?xCi14Ijurf0qVU8Y4p6N0fTs1uncwXGPE8tGAx8kJh+4Hx1V9NUgDTOu1p?= =?iso-8859-1?Q?voJFi5moRIhrB9n4pYGmnFxyUoRV/XvruknHdtO+UKT/afVO9RSJDe134M?= =?iso-8859-1?Q?lQj2Jt/brG7/9Mn8i47XlRYjslixQnaCafVJaKrlQitf12vFnl3HKqEu1/?= =?iso-8859-1?Q?9MwfhB/ESjxJnoVtFeR9V+OUXH4QpaGqWf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c11cfc85-6c4e-4b41-7d3f-08dc3a00e9dc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 15:04:37.7266 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GagzfQ9MSAhz5VF59F2XvHKUosJ9NHObQG2QQ1h6cWudGnSvnjybvvKL/ho8InTjv9Kc4FAjnT7jmNQ5Eu+1Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7941 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: E7h1P5X8LJVlWBSDiZjPE3iox7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Qy/SQd5M"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Right, if it is only required by ARM, then it should under ARM section. Thank you Yao, Jiewen > -----Original Message----- > From: Leif Lindholm > Sent: Friday, March 1, 2024 7:45 PM > To: Yao, Jiewen ; Pierre Gondois > ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Liming Gao > ; Kinney, Michael D ; > Sami Mujawar ; Liu, Zhiguang > > Subject: Re: [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg >=20 > Thank you. >=20 > OK, that's logically consistent. > So we'd need an ArmLibNull in MdePkg until ArmLib itself migrates there > (ideally subsumed into BaseLib). >=20 > But the dependency in .inf should still be able to be declared under > [LibraryClasses.AArch64, LibraryClasses.ARM]? >=20 > Regards, >=20 > Leif >=20 > On 2024-03-01 01:00, Yao, Jiewen wrote: > > Sure. > > > > When we say "dependency", what we really mean is the dependency in INF = file, > not "dependency" in DSC file. > > > > From package release perspective, only INF is the interface to other p= ackage. > > The DSC is only the package internal stuff, you can create multiple DSC= s or > add/remove DSC freely. > > > > Having "dependency" in DSC does not matter. > > Having dependency in INF is something we should care about. > > > > Thank you > > Yao, Jiewen > > > > > >> -----Original Message----- > >> From: Leif Lindholm > >> Sent: Tuesday, February 13, 2024 1:38 AM > >> To: Pierre Gondois ; devel@edk2.groups.io; Yao= , > >> Jiewen > >> Cc: Ard Biesheuvel ; Liming Gao > >> ; Kinney, Michael D > ; > >> Sami Mujawar ; Liu, Zhiguang > >> > >> Subject: Re: [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg > >> > >> Jiewen, can you clarify what you said back in > >> https://edk2.groups.io/g/devel/message/111551 > >> ? > >> > >> On 2024-02-12 17:24, Pierre Gondois wrote: > >>>>> A ArmLibNull.inf library might also need to be created. If the > >>>>> OpensslLibFullAccel.inf module will depend on the ArmLib library, > >>>>> a Null implementation will be necessary for non-Arm architectures. > >>>> > >>>> Can ArmLib be declared under a [LibraryClasses.AArch64, > >>>> LibraryClasses.ARM]? Have I forgotten something that we discussed ba= ck > >>>> in ... November? > >>> > >>> From [1], it seems the MdePkg/CryptoPkg should build without a > dependency > >>> on the ArmPkg. This is currently not really the case. cf. [2]. > >>> > >>> However, having a ArmLibNull implementation in the MdePkg would allow= to > >>> avoid going in this direction when providing libraries to CryptoPkg.d= sc. > >>> > >>> (Just in case, I think this ArmLibNull is a minor point.) > >> > >> Well, sure, it is now. > >> Until we need a RiscV64LibNull, LoongarchLibNull, ... > >> > >>> [1] https://edk2.groups.io/g/devel/message/111545 > >>> [2] > >>> > >> > https://github.com/tianocore/edk2/blob/8801c75b4d77c2e6e06b3ddc8560e0db > >> 590f6342/CryptoPkg/CryptoPkg.dsc#L117 > >>> > >>>> > >>>>> Otherwise I could apply and run the CryptoPkg/Arm native instructio= ns > >>>>> patchset on top of this patch. > >>>>> > >>>>> --- > >>>>> > >>>>> As a side note, it also seems that: > >>>>> - ArmPkg/Include/Chipset/ArmCortexA5x.h > >>>>> =A0 =A0 isn't used anymore in edk2/edk2-platorms > >>>>> - ArmPkg/Include/Chipset/ArmCortexA9.h > >>>>> =A0 =A0 is barely used in edk2-platforms. > >>>>> Maybe the files should have been removed/simplified as part of > >>>>> - cffa7925a293 ("ArmPkg: remove ArmCpuLib header and > implementations") > >>>>> - a913ad02479d ("ArmPlatformPkg: remove ArmVExpressPkg") > >>>> > >>>> I think you're right. > >>>> Well, ArmCortexA9.h is still *used*, but I can't imagine the Arm bra= nch > >>>> of ArmVExpressLib has been build by anyone for some time. And surely= the > >>>> inclusion of ArmVExpressLibSec in ArmVExpress-FVP-AArch64.dsc is > >>>> superfluous (such that that .inf can be deleted)? > >>> > >>> The file could just be moved in the Library. I assume you/Sami/Ard > >>> will know more on the usage of the library itself, > >> > >> Sami? > >> > >> / > >> Leif > >> > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116261): https://edk2.groups.io/g/devel/message/116261 Mute This Topic: https://groups.io/mt/102731845/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-