From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 925D7AC090E for ; Mon, 30 Oct 2023 02:40:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AqPw/RSMtKiT5/7yRGPjI4Mo4qn7WFb6iJtyuMzI92I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698633654; v=1; b=LwCR3QRVf+eBe5ghCOgd7vTz12AmRf8f/aYgrTCTNzYdIVt6KH7xYYXjdbI+sWKjDHXvKPgk zNG20P2SQntutbWJcMPtUOxts/izsLQOWB2QJiz3c7zqSen7N0pbZfEccU3rnN+yJQfquPY9o0/ 1KL+nEXfqYysQ5HJqTFGloOQ= X-Received: by 127.0.0.2 with SMTP id kRtwYY7687511xsfQyhJSbU1; Sun, 29 Oct 2023 19:40:54 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.141220.1698633653524162605 for ; Sun, 29 Oct 2023 19:40:53 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="385205194" X-IronPort-AV: E=Sophos;i="6.03,262,1694761200"; d="scan'208";a="385205194" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2023 19:40:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="709969862" X-IronPort-AV: E=Sophos;i="6.03,262,1694761200"; d="scan'208";a="709969862" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Oct 2023 19:40:52 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 29 Oct 2023 19:40:51 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 29 Oct 2023 19:40:51 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 29 Oct 2023 19:40:51 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 29 Oct 2023 19:40:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ld8k8krpLGhSOdPM9iRLaFcFR92FjrD6kqh9G0KMhgp5XFRJsOfTuwcUJ8yFAQXFWISejwqOy+1LPpWgobdhlnUwDEEcaySRsfnsP6qt4BhU4zOx3fBpXpvt+c8wvgIIvhhZK4T9u+0jaZjYjHlJGnTIFgd/kE91ddLmSdwmQCUMBYyCTVVOxKQPOQLesF2SGMy7GMflub3NX+WVmUQtmR4RQrOZSAMdz6UqMuqUH0fwmIeAT8nGd6DXHurA/iqIdZhUlE4gWYqdRgQ5xzraVp+LboTxCesuVQrgpP5a02mz4dJsJJQJR/lKRDdZ0D991jPtGy+6kAYaqPj90YRgsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5ArfGL12o4paFetuGp5fNgrnvZqWOAHfWT3s89K6JM=; b=ETVEfrWcirdWCcv4JbUuTyEgvDYwVFD3Qc5UH1L41chUBNpQX0xQmSsxNY2th557DD/9Et5+JMIJ1xV2Ee7S2sUcD6IONHFO1W/0njzwfgQ6KCZzwN8szF5el26L2H321G6lavnVbKzSohquUY0acvdHJpSOClVx0/uzMKnjE2ZOKBZT2Y8FtPIK5mh5WBA2qI0p0e5qq1hYP3itXVSMVS6pNiiySzmK56IWPBwq7S26fr+rhD80ZQUF2elkryj4B0fXW+0wXyRrFA3JGhQE0njkb6BJT1m3sEuG1JgCrw8C8OjoyGI5iqr3ysf6eY07LzaoUwds2qKjcEpfCDkmOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH0PR11MB7636.namprd11.prod.outlook.com (2603:10b6:510:26f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.27; Mon, 30 Oct 2023 02:40:49 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6933.027; Mon, 30 Oct 2023 02:40:48 +0000 From: "Yao, Jiewen" To: "Kinney, Michael D" , "jejb@linux.ibm.com" , Laszlo Ersek , "devel@edk2.groups.io" , "pedro.falcato@gmail.com" CC: Andrew Fish , Leif Lindholm , "Warkentin, Andrei" , "West, Catharine" , "Bi, Dandan" , "Daniel Schaefer" , David Woodhouse , "De, Debkumar" , "Dong, Eric" , "Jiang, Guomin" , "Wu, Hao A" , "Wang, Jian J" , "Justen, Jordan L" , Julien Grall , Peter Grehan , "Zhang, Qi1" , "Ng, Ray Han Lim" , Stefan Berger , "Hou, Wenxing" , "Lu, Xiaoyu1" Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Topic: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Index: AQHaCeM1LrZM/wTLG0uaCBqhn9AFpLBgCBiAgABc0PCAAGR3gIAAHeTwgAAHVwCAAAJN4IAAFFQAgACaS1A= Date: Mon, 30 Oct 2023 02:40:48 +0000 Message-ID: References: <20231028192330.1031-1-michael.d.kinney@intel.com> <99615ab9-f669-5ac8-fafd-f154e8af5da8@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH0PR11MB7636:EE_ x-ms-office365-filtering-correlation-id: d85d1b42-7b4b-4a9f-e23e-08dbd8f1a021 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6PB03lfDm/IMXv+oaCYuvJqw1jl1+/ew9jQixTsd2DpPR59ZjQtKAC8yg/KahMFQfXP0qCbG73CbLAe/+mS8i+4NBrGg9KBhHsNV7h28oaU/yCHkXWirxNnS+hpZPuNHoPu8m12W/utRoCcJlnfm52gOPDHvg13Qf1Ke1jS0oAEA5BKFN8ewpYJ4qWmP0S8P6er5WRX6awMnCMufFkekFtItXIM1vKqGIPcosoEtZ9HuWCQraR0vEcjsbg5WOVWl1CWhgpMv+WJy6DpTFPTxbkWImjtJL9qjEF98bqXJ8WDuzacPygzOfzEKgPIvEJpAnDTqKbAUYZWYuCemFYjQ7hQfLFPeP6cDJVQf4SvrBQSdxHJmmwQDZHPMr08DZtBQn9/AL9WxvH+MTaSgentK2MLfMiRGhosWH0fseyPDPWGeDa6+tLwG02KxDSvHAvns8e+PCFvw7+NuHK0y0DyCkxj1lnK5jNL75pV3gx0CIRTzbv+fbDpD48HPmNLmwmREeomPCNXJWgtLjhZwhsU2tb1EQZj868M+PLgedh4lrds8Eh80tGn/N+mpL8sY4zDZYdz70y1kwL3MUBYV+jQ/HmbT+iEUzg4jTEqOeiOvy8U= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UOT6Adbt8qFGEyVYqyPqNsl34ZvBpCB2TzbKDbRivEmqt/VyrV/C7Nr3/GQz?= =?us-ascii?Q?eXJZGPwM/nbM6B9o7WlSK/iX/FChnTlzyUdBYJ2SC0gG9v/dBJqeL7r3g4z/?= =?us-ascii?Q?pvq9tGZ3uVlbVYsjShzIMRjMfJbEDXf2kjiyVYgWyWjfeqiccO9AiG7ozodi?= =?us-ascii?Q?AAJzpGrXK+FQnn/uf3uVwrpHwDjAtpU/TX+Gt8JfOGLoaDdnNEZw3B2r+y85?= =?us-ascii?Q?SrPVzflpC1PToA1klMCZeiSd9JWI5WD0kSnbWwDr1PgXeU0sPbsxG9HQtMcl?= =?us-ascii?Q?NzAzjFAizNOXzIVRAD7L820BVbN84AHfUe1MiOdMHfA8MIbxJkJySZCgg7kp?= =?us-ascii?Q?15IwWoxcXyCkxb62MBqVDynVFi8GijQ7WgraLqoUbjuBaDfuqaq+iyLxh+iM?= =?us-ascii?Q?8V5gFgRpQGz/8pr1JHonGgrDy9d8kOZu86VU5zaULNquiKiJz+gOAVKHJ/O+?= =?us-ascii?Q?/BVqO3bi+qlSWAmVRSgzNNGYvEWTWFhiZZ1LBeb7YO07j9XwcEPp+PiqI6Od?= =?us-ascii?Q?9suAJsrSnWov4/vE+RbhRcGpKiLqInGBgyLrM4TPEtuNdhFlljWZYh3Bs+qS?= =?us-ascii?Q?i1qAg6oFVuowmb6fEOrWTBgqWYom+SDlVJFD8yvIBQJeZI7iK7DpmPVyEK5t?= =?us-ascii?Q?HUH4aypPSD07mwQ4stun196i9jY3xpFiGSIxR/a/XD5Zc6G5g3DWVk6DvyE+?= =?us-ascii?Q?n3KgUz1/d6QaJx5kViCjocxNfzRhvhpMb4SldgPe97SW4GD5Xr1rTNdPJF5w?= =?us-ascii?Q?8lVuW2WFml8H4KkNrCbnVRDEC9FmlDG1iGs8EZrLY7iaJ/BmgaYgpa4wEI9C?= =?us-ascii?Q?OC0/kF98FJTz0CbMHM+QxLlvc08Y17UdToi4+1zoVQ7DeEw/j47OGJgwOqUi?= =?us-ascii?Q?M35i1N02RoYxpptsJ/SrLKFP9ZFNK98RmaNvMlxv/oL1IiaAV4UFHdvA5vQx?= =?us-ascii?Q?MVSNALkccUu6yGX0ruh8pxZUC4pIj/qW5avBJuvbOEKVLOtcNxYkS/KOvkGg?= =?us-ascii?Q?lYqFV6IP6BCkN7BX//ELRAvkHNwuR0Z1yKu/uzAgu10HLuWOPpfLz5qi9UAt?= =?us-ascii?Q?kcQdHvdPlaZ1i2Zu+0rZoceubolkzEBmSJDmRE8IgRmujCeGvwGIO+KKadCj?= =?us-ascii?Q?ex/Czx90EeSUwf0OpfE51tL+9QE/shXKJPSP8bE5NFqwqPd23LeEgQ9ZgJfT?= =?us-ascii?Q?CyQ4vpAGx6HAeUToYBuiQ7H82+ZpsR2I1ucTWqkLF3MNJ7qDY1ocXByJMnRj?= =?us-ascii?Q?uEAFyGFa3plFtgjW9WeoCykpPMw55cjDbYUV4tSpWlP0KCZZCZ1oPjPrG5Lq?= =?us-ascii?Q?I02QAMXJw7nh5QPy5W6wx64143MTJsL08zdbj/DtCUkiGXu4HfmGYzISwmsl?= =?us-ascii?Q?p117safRKjUKWqLSNTPkwKR88laymgk4f3Pp+r1rxWL7VYVgje15Z/8AIwHq?= =?us-ascii?Q?2oYU53mYu/uBTpFR9UrkAr0UYW/3xpZIlfM84nEx6MVA6IMjTnHvZwBuFJBt?= =?us-ascii?Q?BLK5vRwBtkq3Og9vfFOdxH6JEahsfRPinHBI99BrXTYKqMrxjzyhSYvIk9ef?= =?us-ascii?Q?p6RXHj4ExmjwqrkCQKSs0QllMtNe8DpI3MzKehhL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d85d1b42-7b4b-4a9f-e23e-08dbd8f1a021 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2023 02:40:48.7968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9ibjbIyggnpGgbXucKpip8ZBPyQCEUJGg1GD/c6rglGUeUhgSFs9j3kq/0u64DfZsSN/XfKvi9G/uSZS/RoWrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7636 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rbxTJgQ3kAHOadKejLukYy7Zx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LwCR3QRV; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Mike. I am reading the WIKI page. > and/or provides testing or regression testing for the Package (or some mo= dules thereof), in certain platforms and environments. [Jiewen] Are we expecting Reviewer to provide testing or regression testing= for the package? Is that what the reviewer *commits* to do? For example, Maintainer may ask the reviewer to do some testing, right? > Reviewer is responsible for timely responses on emails addressed to them = (preferably less than calendar week). [Jiewen] Is that what the reviewer *commits* to do? For example, Maintainer may ask the reviewer to provide feedback, right? Those are more than just CCed. Thank you Yao, Jiewen > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, October 30, 2023 1:23 AM > To: Yao, Jiewen ; jejb@linux.ibm.com; Laszlo Ersek > ; devel@edk2.groups.io; pedro.falcato@gmail.com > Cc: Andrew Fish ; Leif Lindholm ; > Warkentin, Andrei ; West, Catharine > ; Bi, Dandan ; Daniel > Schaefer ; David Woodhouse ; > De, Debkumar ; Dong, Eric ; > Jiang, Guomin ; Wu, Hao A ; > Wang, Jian J ; Justen, Jordan L > ; Julien Grall ; Peter Grehan > ; Zhang, Qi1 ; Ng, Ray Han Lim > ; Stefan Berger ; Hou, > Wenxing ; Lu, Xiaoyu1 ; > Kinney, Michael D > Subject: RE: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on ac= tive > community members >=20 > This is the Wiki page where TianoCore documents the TianoCore community > member roles. >=20 > https://github.com/tianocore/tianocore.github.io/wiki/TianoCore-Who-we-ar= e >=20 > We can update/edit as needed to accurately reflect what all the Maintaine= rs > and Reviewers agree are their roles and responsibilities as assigned in > Maintainers.txt. >=20 > Thanks, >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Sunday, October 29, 2023 9:26 AM > > To: jejb@linux.ibm.com; Laszlo Ersek ; > > devel@edk2.groups.io; pedro.falcato@gmail.com; Kinney, Michael D > > > > Cc: Andrew Fish ; Leif Lindholm > > ; Warkentin, Andrei > > ; West, Catharine > > ; Bi, Dandan ; Daniel > > Schaefer ; David Woodhouse > > ; De, Debkumar ; Dong, > > Eric ; Jiang, Guomin ; > > Wu, Hao A ; Wang, Jian J ; > > Justen, Jordan L ; Julien Grall > > ; Peter Grehan ; Zhang, Qi1 > > ; Ng, Ray Han Lim ; > > Stefan Berger ; Hou, Wenxing > > ; Lu, Xiaoyu1 > > Subject: RE: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on > > active community members > > > > OK. Maintainer should do code review. I have no doubt on that. > > > > My confusion is about "reviewer" role. What is criteria and what is > > responsibility? > > > > Are you saying that "reviewer" just means that someone raised the hand > > and said: "I want to be notified", and there is no expectation that > > he/she would review the patch? > > > > I would like to understand more on how that works and what that means. > > Would you please give a URL for the reviewer definition in Linux > > Kernel? > > > > Thank you > > Yao, Jiewen > > > > > > > > > -----Original Message----- > > > From: James Bottomley > > > Sent: Monday, October 30, 2023 12:02 AM > > > To: Yao, Jiewen ; Laszlo Ersek > > ; > > > devel@edk2.groups.io; pedro.falcato@gmail.com; Kinney, Michael D > > > > > > Cc: Andrew Fish ; Leif Lindholm > > ; > > > Warkentin, Andrei ; West, Catharine > > > ; Bi, Dandan ; Daniel > > > Schaefer ; David Woodhouse > > ; > > > De, Debkumar ; Dong, Eric > > ; > > > Jiang, Guomin ; Wu, Hao A > > ; > > > Wang, Jian J ; Justen, Jordan L > > > ; Julien Grall ; Peter > > Grehan > > > ; Zhang, Qi1 ; Ng, Ray Han > > Lim > > > ; Stefan Berger ; > > Hou, > > > Wenxing ; Lu, Xiaoyu1 > > > Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based > > on active > > > community members > > > > > > On Sun, 2023-10-29 at 15:42 +0000, Yao, Jiewen wrote: > > > > > I'd say that's pretty close. A reviewer role is a request for > > > > > keeping > > > > > the reviewer in the loop. > > > > > > > > [Jiewen] I am disappointed on that. > > > > To me, that is NOT a real reviewer. See below description on what > > is > > > > "code review". > > > > https://google.github.io/eng-practices/review/ > > > > https://about.gitlab.com/topics/version-control/what-is-code- > > review/ > > > > > > Well, that's what someone's view of what a patch review should > > consist > > > of, not what a reviewer's role in MAINTAINERS should be. > > > > > > In general, you really don't want to force people to review patches, > > > because you'd like a reviewer to be familiar with the area and > > > comfortable with the patch. So are you saying that anyone listed as > > a > > > reviewer in a particular area should be capable of reviewing any > > patch? > > > and further that they should be expected to review every patch? > > > Because that's definitely not what the R role in the Linux Kernel > > would > > > mean. > > > > > > I know that's not what happened to me in Confidential Computing, > > > because I had a very specific area around SEV and SEV-ES secret > > > injection and really had no familiarity at all with say the memory > > > acceptance patches. > > > > > > > Our definition seems more like *a notification receiver*, instead > > of > > > > a real code reviewer. I would say, it is a very misleading > > > > definition. > > > > > > Actually, I wouldn't, but then I'm more coming from a Linux Kernel > > > background. To us, the reviewer list is simply a list of people git > > > blame might not find who might have the expertise to review the > > patch > > > but on whom there would be no expectation that they would review the > > > patch. > > > > > > James -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110284): https://edk2.groups.io/g/devel/message/110284 Mute This Topic: https://groups.io/mt/102245264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-