From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.8971.1652258867882135372 for ; Wed, 11 May 2022 01:47:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eLbLj9T3; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652258867; x=1683794867; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LYJiuccZBwhfScu9pC0IuY1bj3nqdPTXM+6NneOf5BQ=; b=eLbLj9T3bCKbJ6UBXXWaECn1op5WDKn6//uznVMu5S98FSqpBCGpif5N aT0oi6bcIwjT5hLrBopeQvcvOwrY/QHF6a44W0042OuDgXH+/194Nv5Ll nqYCcMBX6vfLR5iOPphAbTkpIRiQsNv4GhIztAwvcjXDILaIQr95uhI27 mGi9HdF69w3214e2CCrz4SoTekzsAbsm6KRATCk9L0Q2QVDvR8o2QJdf2 E7RaFRTuGNb/3E8KmsVANsyK5zDRw+ZZvpPYnpzkvzfBflvTr1CNBOzzd udl7BfOR00uTXSdRD13ufkb2hHU9FQW3Eoq/e2ZqfInOw0W16BFGXzsTG w==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="330234599" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="330234599" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:47:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="602858080" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 11 May 2022 01:47:45 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:45 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 01:47:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmDcwUUw3dVBJZHYX/c/91sDm6xzzB/sCi0upxfGkqTu4xgAJRr2Fb3vcW0DpeUzlzcRcdpG4TUDMBWtPSjXgRU6tswMBWdNrRZN15WrEAXfbLD3KrlJNAmPcr/p56AFbiGghhlUehYzemXBxyW66QbDK5tPiMGvrzVhxsDQyhdRJUPdPAzBs0bhi8PfugitEiBSnQ4yBIBqnQQllQ6Unn49hBAAg+VC6cdGDz+B4boQMTE8861q1LKNxVb923ydc/gPy3QeG5z84eOK5OHbylC1ZHIarAh5mR4d2RHajjzOq0QPLSAGAcBxtSFfGlTlvivxZrPKEEZn5wHZv8Ongg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5/nd+N8CQ986tLuYHEcIeMdhn07WsBTBDCBwNJ+FIw8=; b=QzNsJ9aJsT2wvyrlYExFyPZBfgyIK7tdXvc2MfLhINE6c+3TjkD9lpSnvBI9v/LitTtmV0O6DiInxSuqe+XEgLHIKj0Mv7/a1r5Ht8+hMuzir6FAy48mCn8if7wmjTVPq6FeyGH2Tk5hJCq+mf+plXHSxByEPTPY7hV/zHxUAxGX2SfkNg/ul0nntP9/7pKX+LyOg3UB99aSRQoWUsssPHQpferiwKHysAyEQbyU7LcFHV9OI41h1l31AfYE9DZdMi9Vm47KmRchZPQSNUrtpM/H20SoZC2lKZI/t5CIERs9mw6BZgrlTCGXY3qqN1ubJfKLG3/juqbEfvWiumqa/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA1PR11MB6196.namprd11.prod.outlook.com (2603:10b6:208:3e8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 08:47:40 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 08:47:40 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Ni, Ray" , "Brijesh Singh" , "Aktas, Erdem" , "James Bottomley" , Tom Lendacky , "Gerd Hoffmann" Subject: Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Topic: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Index: AQHYYbLqBet/1uO4IkC0n+Qg20I9Sq0WgcgAgALiSsA= Date: Wed, 11 May 2022 08:47:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70495143-9972-455a-cff7-08da332ae831 x-ms-traffictypediagnostic: IA1PR11MB6196:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8psytTQS+POUPFdYLjipVCuROx0IXiHwUjJU7Pejz6fTyKbrzw6lInc648w40LytU7vXEqIENgCQlqm50alDNcp+xqfMfEmVlgcck2sjxJ7mtG8SWmgg2MYxDwliI5pg/OQIcldHJuBddFR98/PulusaNI7daUIxiCdXb/crSe4D1Kg6s1RS4j7SRtAA0NhJas2apdj2Z/ULR9+84rSn/v76NAZ/JeVQDdmz0BX+nm9BoC7ZcgJpMRhojryBMai8BMl2dRChI4KmIN9iCUOr1LDv9Gl/hGf2b6nfjsogeBlSyCT8kTvFKRxxqz8o4thnQkagO0pq64t3ELe6xem37B6t6cLcTlJl72xIoo5xckFYgWaZ/d1uVQP9f+xOEDgrL1TtaHW79db8yNHenZkRwgAyxzXFmlLQKy3YxScQUnTkJi+4RA79O4bZ5fJ1etKVOmKix1rKsjjTw0Iq+hmO0neqbmSDR7SJa+iLGg5slVyGlbomW1vemm62D29Z8xMOkUqiD/mmL3up2FrecFgLs2zDvBqalmbOHMXD/D+45hqT6kWjva6fJC60R1WB7SbeCTSRGjv6CsA2PTUUjlYvUrR9SVvAPF+rCvHxU57h12QBf5ZtAXy2ihTFMxW59lfo/6m5b2vElK1LYEXyAn0C9ujdj1key0JN4OFg1KOJGL2ZXsB6/X5E/sBgg59HtgFTNIPXsH5wwyaSAGxLVly/j9ctXlTaWOEH8UnRCFa7cR+D3R9ucwa8kILLyO4bMNISD7WuBG0D1zScKHxVafNRRrMRMNfjDR9JwlRUvkxNUXkr+QhxDPcwpT5DPOwTE7Iw+S/5GVwI6rHWFHg0J7YIAA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(83380400001)(508600001)(5660300002)(122000001)(54906003)(52536014)(38070700005)(966005)(38100700002)(4326008)(76116006)(8936002)(66946007)(71200400001)(19627235002)(66476007)(66446008)(66556008)(82960400001)(64756008)(8676002)(33656002)(2906002)(110136005)(55016003)(316002)(6506007)(53546011)(7696005)(26005)(9686003)(86362001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?72Y9cnhucOa52M9W4RXN9NTPLbwgukdPEfN+5wnjbs5JAFSggI7aYI21X9I0?= =?us-ascii?Q?haxdOhNIRcMuKgnMZFmqXCtwmPQ9oDKahzfAKbZr0sVubnVso6YrrYj7lTDj?= =?us-ascii?Q?2LT7OVFeB0WgIT7Te8QHC4EM2hSDSBV+AR5eK80eM79vv1Sy5tLjDQKNK5RH?= =?us-ascii?Q?Iu4QCfOvhHsMZkIfmFq9nmnKSOySae7yEvf2PK61d4mAsM4undjdS8aEmznb?= =?us-ascii?Q?vBex0gdDjK/ojcmvpD6hANsnt04rTUSrN9nCaIvYUUYSfOfsyoobWwTWG6j+?= =?us-ascii?Q?c6gmtahuMxEH3yKidY576SV2J0AftuufTqInYLCSJv4rdqEivv2ilew8YhEc?= =?us-ascii?Q?0RT1hiG3XuakfofnWfBDuiLHCUsf4KvXXV88k4EG6+u/Pt0zz1SvHKrhEZls?= =?us-ascii?Q?HDG/Rx+FQn4tkLJ3CSQze2hX0OEeh4OqwfG29Uzk0ox3Fufo6wzMuTZT/+Do?= =?us-ascii?Q?WZtUmrpU7b7HfLsHr7tjn0E4LlEzPFbdzE4QXNHCnscuSKoQus3i8ug9Jc91?= =?us-ascii?Q?c6k6OADCWh/kKvaRh2j2k/eOokkV/7Z1gsjEPi19cyk5GdbAzj+XicOpQska?= =?us-ascii?Q?6Cq5e9XNqb935J3TErg2qOH7ESFOu9+tYQuylZG9AYfBockSnOKQVlAqD7i5?= =?us-ascii?Q?SIAnAF90yuYuMaTL8sK+v4cbaWuZlpa1XBT3Z71KhPME9woL0vze2M8DEhM4?= =?us-ascii?Q?R1ko6lx9T9d8n9DwecevuhBIGsZRxNlH5oGCRlARPS7v4GQAYhydFsple2tJ?= =?us-ascii?Q?I2oK4Ux2u8mM3jhlvbQCyDH92EzpxGPphzeZlTJSELPYvW9egfd6cLezYrtH?= =?us-ascii?Q?9WDzl4cxp4tC0d9PMtyR5VwiGSZwrZvQEhfzRmK09PUyxZNLHOlBscNofyiL?= =?us-ascii?Q?1UhTWN+FYi7LG6MkynWNDBKwsHFcL94b+g/xu6No9L4Y4LJsEKI4NYh+zOYJ?= =?us-ascii?Q?0NMEf1d6DjcBm0KOGkjHf4EoQsl2o5I1NpZgKxRejgHDPbEQg5+3a0/khQ1d?= =?us-ascii?Q?StXFxpcjDrH9368pJIJForGM+gSlaZw2ySKPLNyjRhSljVMrSE4Ie/WGOEps?= =?us-ascii?Q?lGnfvBd7J68TAzWE2YGRlKcheUGaeBeKzsydPEog2V6+FWRKLKyCeGAcMAPB?= =?us-ascii?Q?aTEY0/7g3YbjWTynIoR8Gms+UJ/aLJ3Q2v4eKInRFWr0YCfOqmMeJCgfQMnR?= =?us-ascii?Q?Hibef92FwUXiWEcsTQFbcxpb04rRPsVTFhWZ9HlayR35SzLUwZcLvd0q3RUs?= =?us-ascii?Q?FDi7f0ViEHptNXYfGXCY/XQDVRCRs7jAKIDgaPuFAf+BfRS8sElqlaJvojDS?= =?us-ascii?Q?gqx9rcaEQFoml7EPC76NpyscKvwqRAkFOrXscNPGRV9GXwALFpNdPm7fbgbL?= =?us-ascii?Q?NQfAD54jVr5FKGW+WX0DfnhSF6IJ/zuxm/kmZdNhG0/nKZK231w5odjxvfsx?= =?us-ascii?Q?3HmaqFFmGPcZMNvx0r7fyDiEXJMzxD+Dt2VH2A05Ieb2Z/HSBm8GoCZ6avEG?= =?us-ascii?Q?xq4sWjLcJMMsiGvYeL5xREaBB05UL2e+5utG68kvbzGyJyp8MJ2Nt5pCBWDP?= =?us-ascii?Q?OhA5sEZOs6M2h77TwGUPZh9Nsx605LOEb27CAWlK4sRDzxKfZcAeZT6Zl+/9?= =?us-ascii?Q?/6XQZBkczvMplMRm1Wu0EG4SQ3GODlsieICq+iIkL1TQ8r6Jb7hOcKINWz1T?= =?us-ascii?Q?4SNEwXsMrd+VJtRnV3N3c3Ks9C+Q1MfMZsxjzwdGWxtQH5pX8I6XI4P2xpYH?= =?us-ascii?Q?SaOFdMEthA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70495143-9972-455a-cff7-08da332ae831 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 08:47:40.3255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R6caTuUC7O2/W4/ylEFMglNfTbav1rKv/3AgL6VjUX8aVjPDtFZ1D7v+3gsX2VQBf/Zopk6dBHd15aUZDkuZmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6196 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/2877 > -----Original Message----- > From: Xu, Min M > Sent: Monday, May 9, 2022 8:45 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Brijesh= Singh > ; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky ; Gerd Hoffmann > Subject: RE: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image >=20 > Gerd & Tom > What are your comments about this patch-set? >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Saturday, May 7, 2022 9:36 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Dong, Eric ; N= i, > > Ray ; Brijesh Singh ; Aktas, > > Erdem ; James Bottomley ; > > Yao, Jiewen ; Tom Lendacky > > ; Gerd Hoffmann > > Subject: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3918 > > > > Above BZ reports an issue that commit 88da06ca triggers ASSERT in some > > scenario. This patch-set is to fix this issue. > > > > As commit 88da06ca describes TDVF BSP and APs are simplied and it can > > simply use MpInitLibUp instead of MpInitLib. To achieve this goal, we > > include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and IntelTdxX64. This i= s > > done by setting different FILE_GUID to these drivers (of the same name)= . In > > the other hand, we import a set of MpInitLibDepLib. These libs simply > > depend on the PPI/Protocols. While these PPI/Protocols are installed > > according to the guest type. > > > > This patch-set is a replacement of > > https://edk2.groups.io/g/devel/message/89381. Please see the dicussion = in > > - https://edk2.groups.io/g/devel/message/89382 > > - https://edk2.groups.io/g/devel/message/89455 > > - https://edk2.groups.io/g/devel/message/89522 > > - https://edk2.groups.io/g/devel/message/89535 > > > > The code is at: https://github.com/mxu9/edk2/tree/Rework-MpInitLib.v2 > > > > v2 changes: > > - Remove the un-used FILE_GUID definitions. > > - Delete un-used EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST in > > DispatchTable. > > - Add more comments. > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Brijesh Singh > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > > > Min M Xu (4): > > UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib" > > OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c > > OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols > > OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers > > > > Min Xu (2): > > OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions > > OvmfPkg: Add MpInitLibDepLib > > > > OvmfPkg/Include/Ppi/MpInitLibDep.h | 28 +++++ > > .../Include/Protocol/MpInitLibDepProtocols.h | 28 +++++ > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 30 ++++- > > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 3 + > > .../MpInitLibDepLib/DxeMpInitLibMpDepLib.inf | 27 > > +++++ .../MpInitLibDepLib/DxeMpInitLibUpDepLib.inf | 27 > > +++++ .../Library/MpInitLibDepLib/MpInitLibDepLib.c | 23 > > ++++ .../MpInitLibDepLib/PeiMpInitLibMpDepLib.inf | 27 > > +++++ .../MpInitLibDepLib/PeiMpInitLibUpDepLib.inf | 27 +++++ > > OvmfPkg/OvmfPkg.dec | 5 + > > OvmfPkg/OvmfPkgX64.dsc | 55 ++++++++- > > OvmfPkg/OvmfPkgX64.fdf | 4 + > > OvmfPkg/Sec/SecMain.c | 34 +++++- > > OvmfPkg/Sec/SecMain.inf | 2 + > > OvmfPkg/TdxDxe/TdxDxe.c | 22 +++- > > OvmfPkg/TdxDxe/TdxDxe.inf | 2 + > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 - > > UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h | 69 ------------ > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 63 +---------- > > UefiCpuPkg/Library/MpInitLib/MpLibTdx.c | 106 ------------------ > > UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c | 69 ------------ > > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 3 - > > 22 files changed, 343 insertions(+), 314 deletions(-) create mode 100= 644 > > OvmfPkg/Include/Ppi/MpInitLibDep.h > > create mode 100644 OvmfPkg/Include/Protocol/MpInitLibDepProtocols.h > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibMpDepLib.inf > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibUpDepLib.inf > > create mode 100644 OvmfPkg/Library/MpInitLibDepLib/MpInitLibDepLib.c > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibMpDepLib.inf > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibUpDepLib.inf > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdx.c > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c > > > > -- > > 2.29.2.windows.2