From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv
Date: Tue, 6 Sep 2022 14:27:35 +0000 [thread overview]
Message-ID: <MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BY5PR11MB4401A104D489FA07499F49FCEA7E9@BY5PR11MB4401.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]
This seems a big incompatible change.
I feel this is weird to hardcode the configuration here.
How the OVMF binary knows it runs on a new CloudHv or old CloudHv?
Can we have a mechanism to detect the data at runtime? E.g. read some PCI register ?
From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Sent: Tuesday, September 6, 2022 10:08 PM
To: Yao, Jiewen <jiewen.yao@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com; devel@edk2.groups.io
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv
Hi Jiewen,
Do you think this could be merged?
Thanks,
Sebastien
________________________________
From: Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
Sent: Friday, August 19, 2022 11:59 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Justen, Jordan L <jordan.l.justen@intel.com<mailto:jordan.l.justen@intel.com>>; kraxel@redhat.com<mailto:kraxel@redhat.com> <kraxel@redhat.com<mailto:kraxel@redhat.com>>; Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv
From: Sebastien Boeuf <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
Both ACPI shutdown and ACPI PM timer devices has been moved to different
port addresses in the latest version of Cloud Hypervisor. These changes
need to be reflected on the OVMF firmware.
Acked-by: Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
---
OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/IndustryStandard/CloudHv.h
index d31ecc9eec..527c236f48 100644
--- a/OvmfPkg/Include/IndustryStandard/CloudHv.h
+++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h
@@ -16,12 +16,12 @@
//
// ACPI timer address
//
-#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0xb008
+#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0x0608
//
// ACPI shutdown device address
//
-#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x03c0
+#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x0600
//
// 32-bit MMIO memory hole base address
--
2.34.1
[-- Attachment #2: Type: text/html, Size: 6614 bytes --]
next prev parent reply other threads:[~2022-09-06 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 9:59 [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Boeuf, Sebastien
2022-09-06 14:07 ` Boeuf, Sebastien
2022-09-06 14:27 ` Yao, Jiewen [this message]
2022-09-06 15:40 ` Boeuf, Sebastien
2022-09-06 15:57 ` Yao, Jiewen
2022-09-06 16:06 ` Boeuf, Sebastien
2022-09-07 14:23 ` Boeuf, Sebastien
2022-09-07 15:21 ` Boeuf, Sebastien
2022-09-07 15:23 ` Yao, Jiewen
2022-09-07 15:25 ` Boeuf, Sebastien
2022-09-08 2:22 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox