From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.4660.1662474470624766070 for ; Tue, 06 Sep 2022 07:27:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iVANsnN0; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662474470; x=1694010470; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=dzJZgpAkSakrfesIV026iq664pDVqkRJjweohlkt6wg=; b=iVANsnN0T+fnBqFmowUtI28d1e4NT33CQZXWBq6OvNj0BbqKzTiaPwaJ LoLtKYfwc6AlykKCenTTm8InNH1Y6YgcWyRIi1ggWzCfCiXY+GFVw1b0v 0j5heWsNXrJycaZvxUb4Ef66fl/7xRLIxdDsMrDRptKwLRQJNRMRePzbm m3oCv/oj+AfqHH0E7gcHsCkv2LsyGxmBsiQh6WBrZyEoi4N3QOrwLxMm8 5srahDXLKCmHLo1XkfN/WiyNWd7neFHAUrTVmSF+wfTjVq63HE672t6vM VkA9LOy3s03z+483cej6pqBicC8rnfFzFFYS4us5kLcD9pjW8GjXS9uqg g==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="360554727" X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208,217";a="360554727" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 07:27:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208,217";a="703229288" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 06 Sep 2022 07:27:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 07:27:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 07:27:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 07:27:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbjS+yUPQbdeFfXEjzYra/9Sx4Rd7pedU9taxE5gO/hO+4Y8sScax3t61kKqgRI+hIi+11Irrp1ss23ZyzmPCG8vYZ+Ixtd3iRcGpvF95kt1ChIRBzyfGLO00pZxGHHd3PrjZM/jCYyOceld3s7EVGSVwluaX0KQE8CB3ngpCP3Ym1SvaUXf6x+IzXprJCbxpebW40yRDgG8MdcOdE1izQKZI3+N3cqu2GQONvPDwcnfVUkBrh07CHLk/VqJkjgUfyuo2eBKb0osYoYhp+oUB5zyaQSd/+FZ7T2DiASOA5TcRHX2rybvSIt1KY51jgqXnxdWwE7lkNvaMgKDlY2LJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7PmWOgfUKWZiI4If9F1Og5MDxLUA1NUYGeL69kjy9SE=; b=Aipylb9OHg1Q43zZeijcLaJZ+7gxjW8Wj+2sYfinOEnQ/XFfsPDrYF7n1cpW3ic0RDVl/tf96WeKFw6p3db8mNPiAMRJVfy+lv4sVJIw56/WlPzshgWv71NAGq6jHOOs/q2ES1gEPeHk4XQuLhLfunh3NqbEBOLlIHrQQVgmuizQz9OcDhA157Mq0IlPG68/1/fHuJTDFU7dhDFxZM/wVl7WmlcDh9TYhdfLNLUb0B2K99ZOI8OnyDzd/s+KzFnoaGne9j4Y6MoflkpRSITCy1zzBdCueZDJ5p+GXCGsnP6QI6xbhgrC8uZLgnmCwk3Je7H+jO9sDM9Od3BwgpknbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SN6PR11MB3295.namprd11.prod.outlook.com (2603:10b6:805:c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 14:27:35 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749%6]) with mapi id 15.20.5588.011; Tue, 6 Sep 2022 14:27:35 +0000 From: "Yao, Jiewen" To: "Boeuf, Sebastien" CC: "Justen, Jordan L" , "kraxel@redhat.com" , "devel@edk2.groups.io" Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Thread-Topic: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Thread-Index: AQHYs7JjJ07IYAhL7Ea6vqAgQtyOYK3SjLmAgAAD43A= Date: Tue, 6 Sep 2022 14:27:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50ba1fda-c4b1-4359-33c8-08da9013f189 x-ms-traffictypediagnostic: SN6PR11MB3295:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6or04n5kfPJyNjAZkS/Bge7LwRl8/JXXtJYeu2x77G5vHSLPsfTDrCnL4mzVJ5XuqogzNEkucJJDQyZKQ6JxkkT3OD1225FyBTlQO9HyRnfAtTzwfTZZ9B4mU6Lq12cWOACj4l5WpATzaxv79UpE4vpXmDQAqnaMJR9WfdEbm+S8BgIDfRZ9Mjlmdlg5qDAHfgaNr3QBrzORN/qr3M9pxnXtmzs0qUfhUhSsurH+hcVuOZaqyoaNSYDsoHOx0KzrhJyFl/Ob9kHD8WgowPikYTLGTLK4h1jyGHi3FM2uzwMn0bMnP5iSrDL0OJb4LBmxQFUCoAKYg8EViEEYxgIjU7SmC+PJl1VP0MsNYdry1QwkwR8UnU0HpdCSsXjFiVAPZ7QgJq1O6k1UO21vhjCJ7RyQqNxAl07JapP2whTZBlrh0p7HcpqoW38gwppULEgsDFFHjlX+jdJikeb/w8Trr2Pp48uZ6LFCSspwYDHOWA5ABnGJNbd+dO8eUVQMJfUqf3H4NcCf7sB7GTnKja+oAU6/1CMDoI+iT0xos5FXTUiINXP6uOdYw0k0HVUgc6f/NaUjL6NJbmk9/0lAOWB3uPhHZLbj9ZuVD4cf9t55ilvFUWg+W9LTw1IG78uQYE/ZEhMxgjAODVkkERYf+5XNmbXAD+auqhO7Whnu21MpMp5KIfvaBUvRRAkyDUxNnVI6xCRkyg2vyjwcixb2FzAnCQRPQT0Z0eHw89s31h/Qr0dvimF0hGs5nXkjskCOb+F/m8TngAEiYz0pTcwotCsgfA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(366004)(376002)(136003)(396003)(33656002)(83380400001)(9686003)(41300700001)(55016003)(478600001)(76116006)(7696005)(53546011)(71200400001)(6506007)(186003)(26005)(86362001)(6862004)(8936002)(52536014)(5660300002)(15650500001)(38070700005)(54906003)(66556008)(6636002)(38100700002)(2906002)(66946007)(122000001)(8676002)(66476007)(66446008)(4326008)(64756008)(82960400001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ikcvZXM64E6sy0xE+E+wBYekVHdu5ge3L7uH3qv36Gr8oImHdy1WtXcpHc2g?= =?us-ascii?Q?e3GVp33mSM/Us079eiV8f9a2nyvGfoKsisaNNxOwfw98nLgI1HwweszHZmV4?= =?us-ascii?Q?+PfLcq0ISyj1PbH5pkTFNyKgmWn3lwibANWBIS8NPKi3rtTJF6Ik8bUNoaVe?= =?us-ascii?Q?V3zicIi226k30xKuVOIsgHXOVOOwzqN2wfX+tt745KuiTeiVfZVPuHTLy1Ix?= =?us-ascii?Q?JcO2QIy5yX3kcjYX1/l8fumtLnbIXQY47dmMZaYiINGsb84NvFe71Dwzhrbd?= =?us-ascii?Q?Mr1kg+SXEEqLActyunO/yd1BrW01Ov9d+n5ODIFVe8isGo96S6UjVn+iU9hh?= =?us-ascii?Q?XU3/6fllZL9qekcDf5uchZFmMVNfHI/LCqop61J4eZM2l94XExyv6qtC11Q8?= =?us-ascii?Q?nEUg49otnxTPlBOgkrJZyLeF+vo2SC6YP3z20m9+Ed4BwL417CU/Lf9YWG2R?= =?us-ascii?Q?F+/kCPyi2/ZFV3TDUmx9zSK7zrop7FAk5cYOvCVraSG3izgc+jFw/Vle25lU?= =?us-ascii?Q?MR10pe87Zjc6gXfettDTkTobxvrLSyecB0kTHb6Cd1LVa5cAS5Xw4UtAdBRO?= =?us-ascii?Q?OCIJEuNyKneOFoHCh+DlatdbEScL7eCIPAzbcmUTL3uG5QChVkqqudO/81BZ?= =?us-ascii?Q?np14778kT8QhEGvUDDmMoZXu6gcvbIEe1CNJKBWIGg40Yol+skFjIe6vGpW+?= =?us-ascii?Q?Mpu8UQ8wU8ZyE/yneUE76rf86d+gba+QpjF3uHwNBsNSuFFrYmnBm3jdPmD4?= =?us-ascii?Q?1ymF00XhUTgADyvTobQEhg8ps93YqSsDH7lC8Ukhc9fUSFEJb7TC/ylcpUZk?= =?us-ascii?Q?S9BxyBh7/RC+Brhym5Ve6sQuBzEjDHOi4hvPp5VLstoleVSsa+l6veFIWAEq?= =?us-ascii?Q?eZ6jT+d8dPaXv4H701XCsZB7UfG2cfsqvL++iuuA8I5zE1vzBabquycA5Ycf?= =?us-ascii?Q?/xI6UkeUO4NAGRw/QTuFXZKlPfJb8C0s7s6GWuKgZVPIL5isTxRrXes5+B4S?= =?us-ascii?Q?YS6Yko/yWWkM/ckw8XUc2tB/b7UF36hmaKNU5jQ5w67R3Y322HXdzh2GvwC7?= =?us-ascii?Q?rOgKVHxLVc01NdQviUXC93HcpZ83eZi/lxVowZxm8mYi7SEdB/VAQv5qLOXo?= =?us-ascii?Q?gQwFYQ6GUcbuqh4Y6JHfDl17myli9yHj++yQowZ/HbAf8QG80ZA/CYFGhjYZ?= =?us-ascii?Q?yKVrBS0lhpb0ZckFP9GyUHDlhwg9N2qoOf5+2Lj1WkXRbAhb7atn+6CkG1ZD?= =?us-ascii?Q?bSa7hr588ms2nvk7sFIodPUa7Zqp8721kDtlnCYxkUIK3XKJS/Sd1Sj4Um31?= =?us-ascii?Q?jbEqxg28niUysQiPxKs8xsz9Wt5Obf4pFHAPzVU89czHrUzYTUveXz1Q1WFM?= =?us-ascii?Q?ALjYng5uC14FvTVWLwKzrnqFXzHN7WX4HyxNXTD+cq44ZDPyDzjwQQnWtnGc?= =?us-ascii?Q?Hvcx+4Lp9aNAc6s3VOvOCVZ7/33rgkV1EG3T5Kp/2QVE+IRJTbEOr7eV7tHf?= =?us-ascii?Q?p9Kf/Lw5dzSt1EXwaRodR6WA1LA055lOw7SCByv911AibxJAcavmg/36bxwM?= =?us-ascii?Q?n8H0XVD9sPQltw5yfylvRVjeIsZaArb7DwUw9W/T?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50ba1fda-c4b1-4359-33c8-08da9013f189 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 14:27:35.6800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AxQaOw4/RqGYPxR0QAZ7K/DsBoB6alO+QLjRl3YIQ1Mt8JhxtjHYLtlZr1TU0sz32K3ynoGzSxXOVVYbp5XGZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3295 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9MW4PR11MB5872namp_" --_000_MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9MW4PR11MB5872namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This seems a big incompatible change. I feel this is weird to hardcode the configuration here. How the OVMF binary knows it runs on a new CloudHv or old CloudHv? Can we have a mechanism to detect the data at runtime? E.g. read some PCI r= egister ? From: Boeuf, Sebastien Sent: Tuesday, September 6, 2022 10:08 PM To: Yao, Jiewen Cc: Justen, Jordan L ; kraxel@redhat.com; devel@= edk2.groups.io Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices fo= r CloudHv Hi Jiewen, Do you think this could be merged? Thanks, Sebastien ________________________________ From: Boeuf, Sebastien > Sent: Friday, August 19, 2022 11:59 AM To: devel@edk2.groups.io > Cc: Yao, Jiewen >; Justen= , Jordan L >; k= raxel@redhat.com >; Boeuf, Sebastien > Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for Cl= oudHv From: Sebastien Boeuf > Both ACPI shutdown and ACPI PM timer devices has been moved to different port addresses in the latest version of Cloud Hypervisor. These changes need to be reflected on the OVMF firmware. Acked-by: Gerd Hoffmann > Signed-off-by: Sebastien Boeuf > --- OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/I= ndustryStandard/CloudHv.h index d31ecc9eec..527c236f48 100644 --- a/OvmfPkg/Include/IndustryStandard/CloudHv.h +++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h @@ -16,12 +16,12 @@ // // ACPI timer address // -#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0xb008 +#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0x0608 // // ACPI shutdown device address // -#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x03c0 +#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x0600 // // 32-bit MMIO memory hole base address -- 2.34.1 --_000_MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9MW4PR11MB5872namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This seems a big incompatible change.

 

I feel this is weird to hardcode the configuration h= ere.

 

How the OVMF binary knows it runs on a new CloudHv o= r old CloudHv?

 

Can we have a mechanism to detect the data at runtim= e? E.g. read some PCI register ?

 

 

 

 

From: Boeuf, Sebastien <sebastien.boeuf@in= tel.com>
Sent: Tuesday, September 6, 2022 10:08 PM
To: Yao, Jiewen <jiewen.yao@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redha= t.com; devel@edk2.groups.io
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI dev= ices for CloudHv

 

Hi Jiew= en,

&n= bsp;

Do you = think this could be merged?

&n= bsp;

Thanks,=

Sebasti= en

From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Sent: Friday, August 19, 2022 11:59 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com <kraxel@redhat.com>; Boeuf, Sebastien <sebastien.boeuf@intel.com>= ;
Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices= for CloudHv

 

From: Sebastien Boeuf= <sebastien.boeuf@intel.com= >

Both ACPI shutdown and ACPI PM timer devices has been moved to different port addresses in the latest version of Cloud Hypervisor. These changes
need to be reflected on the OVMF firmware.

Acked-by: Gerd Hoffmann <kraxel@red= hat.com>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
---
 OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/I= ndustryStandard/CloudHv.h
index d31ecc9eec..527c236f48 100644
--- a/OvmfPkg/Include/IndustryStandard/CloudHv.h
+++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h
@@ -16,12 +16,12 @@
 //

 // ACPI timer address

 //

-#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0xb008

+#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0x0608

 

 //

 // ACPI shutdown device address

 //

-#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x03c0

+#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x0600

 

 //

 // 32-bit MMIO memory hole base address

--
2.34.1

--_000_MW4PR11MB5872BC8CD953ABEBDD2B782A8C7E9MW4PR11MB5872namp_--