From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.13715.1663689204811629872 for ; Tue, 20 Sep 2022 08:53:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=l4B1X219; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663689204; x=1695225204; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2NeLRCukKVKsmi4lLR5yxy/j32WkVOxClmbxYtAcK8Q=; b=l4B1X219M3f/Btp05HFYq1N09qv9Wy7MILwZVuiHoY5fHEQ3czzSWWX1 D5S2eG3YKc/kUQ/IW5RtzTE5zRH1iDo/r5l+D8OubH0j/3wnMxnBElP9/ uujW07aEE3Q3OMkPUmMzNTWNlHdPabgmaoJlYiDDXyyJhgJ/5is1qSh4t dFbboovzSDPfQGrp9/MYBDtCLUZVuCxC70L+zo9mxPWiJM8nRnSU961gj o4xNxTup04aEEDLsB8l4ornbPKAlF7WUE9qoelb1KRJ53c/r9VRzjCAur xlyb5UqAuLZvveuuNDQP+mgsEEwQm2ssWVedjzZjVP885RzCU3GjiHi+4 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="299722978" X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="299722978" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 08:53:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="596567486" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 20 Sep 2022 08:53:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 08:53:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 20 Sep 2022 08:53:21 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 20 Sep 2022 08:53:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmpsC+iSUZaEKhYY9rLpbqld81W3q1gdTTrY9RCE2Iup3n/CS24mxqFuMWqQo8cNnWwLVZbRvnbkvOPmv0S4jHrEC+nkEXqSZiu4Tgwg2tFt2E7aITCuEOkVddYLaj6NxYcumotDGnOipYXaiGMTmOU7BkXItFqvBO5qEQSj4GH2gscgXeX0rf/7kpxKHL4fy5/sNAYzl/WmMc/D2pzs6lZc9Yctp+Whd20EOt5yb5irwr3CRpa9zGr2UeqAzp7GoiTbZVBVaob4Fg4nkmxwoFBZY3D9D3BCoTQmK2z0SWJv2FrMetTGu4TSkGdHKwmtHKLoVNZuclOq+kmXbJyfBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SnTfG27grDn7DAY71lplOYkVIb8K5P7/bIkEAno8t+Q=; b=D1iNaLOMwHLdpPAJYSLZPCNkmER5VaTpSUHr6LsVDoXyEnEoyxrsQJGJtPMoieyeSoX1TkG1HYbDF0QnQTx0zVDZ7x8DrgY3nQZJjp7tFqQ4tgviHZ6xUkJarG6bV0rArP6MWf/Hl1bMcEGtkdab5hMxKKMOKorx8K7MQ7iw8ikya49LWGXoUI5e7oUYr3jaUcC9h4vX6Z6UaXZb4ZNbhfo0+tNrwTNeQi85JJps3R7WVQOu1PWzEiLYXdXCoiAq2yn0jiR63/OaOUkeUrymg0IruFXyLUvyyNT+j9dt4UTRZ0I3/E+Wlazu5Zv37Bu7seb0A8vU+S7LZHK4Jx+XjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH8PR11MB7071.namprd11.prod.outlook.com (2603:10b6:510:215::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 15:53:14 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Tue, 20 Sep 2022 15:53:14 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support. Thread-Topic: [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support. Thread-Index: AQHYtr7pJPep/jTzUEyVWrEtNaQOB63opE7Q Date: Tue, 20 Sep 2022 15:53:14 +0000 Message-ID: References: <20220823070623.7002-1-qi1.zhang@intel.com> In-Reply-To: <20220823070623.7002-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH8PR11MB7071:EE_ x-ms-office365-filtering-correlation-id: 532dbc05-67a1-452f-e019-08da9b203a1a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BLuJCxbwSx8CgD4+iHIcHJIb/LQBJHH+EYwCUK3PBnQ8Tq12AfNpfY8eoUsdsj20vdLEXkIU1t6zjDHhPKw9Qt1iNzJdZXk7G5KK7hzvkHYZnyn1U6Cxl88ZPmM9RQ0Pphzik1h2z+k7uI7+zXEFSkZaDtdkr5aIrIUMPVjdwgYl+vrEhKuMaa/+b50/1o2F7VB/fDxknPYSVSLIhY9A6AIkU0o1t9HNbG4VI8pmknAM0KccLfDslvl/kOSJbbuClMM3+bpaFLaQOMUl//Y1pcOBC33Y6GLKirFx6O6Ddi3sXe9tiQYb6ghyRuk2IZy1qbxmA3jUxUYGLhavNpG3bcUmP9hAPx4DM8ScmjCc5gdpwkIyyFW7iLY82hF/REfSdiJdrBsdPd1/TIGeRfzrOqQ4/Q/NEDWCdWsH+7UHAObp1Cl4RPudbegrBGfmRMfED6wSTqr7KZVqimU4QgjxC9+/1Mel7FS+KITSLYvfBtOhG9cQh7YxlmBTWdg1gj+q6xaZKdKbcNGZWnia9gnBdv37X305yKGHT3t4/D095vg48qN+X51A27HxdXnaafNXfNmkkx6juUcGPfnbv4bfX1mlk/BbWUPYrVip0/j+fVEZKQPF8OVRiew5N26rmov7dalr1I1vYqgkejdrl0a5tXWt6iJAPjpLl4UFcAIwWq5aOrfhCt9vwf3haz2snyXhPGnBH/x3tCgJ47A0t9gZxJjLxGpD4hubEfaa2vlG06dr46FQbzQd6s3ztHZ7hQiDsE+eujH8qmuX2rBzfuzkLPxqnYSc2FbDQN+LWSUxpf7S+/OIYx0mByzniKXla4yzqoN33sddMkmGUGExfBrzGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(136003)(346002)(396003)(451199015)(966005)(55016003)(122000001)(86362001)(33656002)(38100700002)(66946007)(66556008)(64756008)(4326008)(82960400001)(66476007)(76116006)(54906003)(110136005)(41300700001)(19627235002)(66446008)(52536014)(2906002)(316002)(8936002)(5660300002)(186003)(83380400001)(8676002)(478600001)(26005)(9686003)(53546011)(107886003)(71200400001)(6506007)(7696005)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/XboKGZ4YTdE9CfcMcNT15j+3nIVn8jm8bltce4hvToXGn0A3j4esgqg/4it?= =?us-ascii?Q?t3IdT2lnVIvQoNyOoW7dMM86jTMf3XNE4KqrzATCW+N/+WRebHVK8C91IXKv?= =?us-ascii?Q?Ee5723HVhjuJr3Sv5dcepIkUigi+HLYOVK+yKlTXVXVCztPF1DpWuvOb00VS?= =?us-ascii?Q?WrmTwbfuovdMSyh4ViO4bI9E8qAo2iWa808M7HjmbFSyT7ztUYRSP7J+w98n?= =?us-ascii?Q?uLU4pT6qNCzxfq+pu4BkgWLzqG6xo+n89Hi+Ls79mwdvAcPG/GF9exiaoZ6X?= =?us-ascii?Q?7KzWXVKlftubYk+mvwd5zYYDb52hJlmZtto3pKdI3HUTe8iHXbpWjhtJweDz?= =?us-ascii?Q?uWjuUa9T2DncuaDeZjNdqrTyifnAu1+j7QMuUZsHA70RaDFP+lCoKYIY/QK7?= =?us-ascii?Q?AZNLMlUVaUar3n4xeEA7h68tNHX+yL0+AFOdd4dCKpQau/7SVXo6C1BjbviE?= =?us-ascii?Q?d+ks4ny9Qy+IyCo2YSk0lGulwKs0rJjfIjBdtPKpHItd7H9YYLhl99nNI1fG?= =?us-ascii?Q?Qt218k0EW2FXViNBhw1r83VAkQ2B/kIMzczOS8NLeipt88e17TfuLoz8mFfs?= =?us-ascii?Q?SRLmZEZqzogBdwmaXs4TBJPBpmmdsTVavTFzSlYALU292n6by8xzZQPV5qu2?= =?us-ascii?Q?T7FuK33o5aM1mfJPd+UQnhDlin9C8VMdwI6vlgvBqqClC8FR085HWjjqdhIT?= =?us-ascii?Q?cCSmDEpX/IahTxB44A2G/EMxaaR8tZIQuPbVJRZvdRGEHpta7SygDbGamntH?= =?us-ascii?Q?en4aumETVXb1RljcDPMX7VSkgNA7uSM6p9rs825T1QM7qKonIMrWG3HqhsrT?= =?us-ascii?Q?4Fs9CCJOqTewM5n024BNYDgeHy7M4Wuty/yJmwrjHRLmr60fStIOHZI5B0Mq?= =?us-ascii?Q?VsNmGuaL7LHd+aDwPJ+qz+v/0X4AW0D/hytTdlG1ZnLmFofl9XgDc+X1msqF?= =?us-ascii?Q?uzIFI49cMl43TrOxgSCKMX1NY2m0p/MofDDx2ktUjdgaa2oE9Yi5dbAGruAM?= =?us-ascii?Q?hsCQ+LuJCzajgVIZbE8KnjursEkni7MPYShNH/7MTYuQN9FrSnqAYkwYapm9?= =?us-ascii?Q?dur+dGV0oirVtggKa4PuCU0r+eKOc6aSgtVC8bjH30fAi5krap615oMMuoTF?= =?us-ascii?Q?aOr7xe7wUUwhZJOcn+jsr1kU42Sf27EF4Sdqe9n8dMUuQH3aJpqPowyEYNhP?= =?us-ascii?Q?EbZlAb57zOdVZ8D5MtUzDOGKv/KPjQ9eOpTCA97dgI0wynfD/nL3FIZXX2dr?= =?us-ascii?Q?tMm21wDOZ1v1sno73iTLPyde+AM+a2ENCBcVQPq/8G+CEDiokKo6G8d4RwLl?= =?us-ascii?Q?fKLPXmrzkJShbUPZDz8C6fcWdM37uhG9Ygvx5yhkC4PsQ6gCzkPM9SqMU7+7?= =?us-ascii?Q?GFvJTOt0jh0EOBdQr6GYjvz2upHz3LYiynTGRlx6CHxNMk81RZm5bnE0mtXS?= =?us-ascii?Q?+vfQahwBQl54jk9S+RkQdL2YoW4XfwwCyquaYBwBIqid+GzSeWm6ocFsuL8e?= =?us-ascii?Q?6MQJgHXlEabRaHZyxUhRg9L2kevy5wCtIN3JtyzMAVkEMgUAdbRBI5Fp82Hf?= =?us-ascii?Q?A6c/b9L1Y3VNCr+PeFhfW2ehPs138ITn8+dh+ZBD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 532dbc05-67a1-452f-e019-08da9b203a1a X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 15:53:14.2288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7/MmSZNDaE9tKTiaFS1E87Rvy7fFZ5ef1XdC9SdDwjfQUCwMAesiQ2dXsfz55sVWVw9MZ8j5zNR7qauwK4Jtlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7071 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version 2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't= insert in the middle) With that change, reviewed-by: Jiewen Yao > -----Original Message----- > From: Zhang, Qi1 > Sent: Tuesday, August 23, 2022 3:06 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen > ; Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support. >=20 > HmacSha256 is already supported on Edk2. This patchset is to add > HmacSha384 support. >=20 > With this change, the size increase of BaseCyrptLib is about 7K bytes. > HmacSha384 function is verifed by the Host UnitTest. > And also it has been integratd in > https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been > verified. >=20 > All the code change is on the PR > https://github.com/tianocore/edk2/pull/3224. >=20 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4025 >=20 > Signed-off-by: Qi Zhang > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang >=20 > Qi Zhang (5): > CryptoPkg: Add new hmac definition to cryptlib > CryptoPkg: Add HMAC-SHA384 cipher support. > CryptoPkg: Update CryptLib inf as the file name changed. > CryptoPkg: Add new hmac SHA api to Crypto Service. > CryptoPkg: add Hmac Sha384 to host UnitTest. >=20 > CryptoPkg/CryptoPkg.dsc | 3 + > CryptoPkg/Driver/Crypto.c | 221 ++++++ > CryptoPkg/Include/Library/BaseCryptLib.h | 188 ++++++ > .../Pcd/PcdCryptoServiceFamilyEnable.h | 13 + > .../Library/BaseCryptLib/BaseCryptLib.inf | 2 +- > .../Library/BaseCryptLib/Hmac/CryptHmac.c | 629 > ++++++++++++++++++ > .../Library/BaseCryptLib/Hmac/CryptHmacNull.c | 359 ++++++++++ > .../BaseCryptLib/Hmac/CryptHmacSha256.c | 217 ------ > .../BaseCryptLib/Hmac/CryptHmacSha256Null.c | 139 ---- > .../Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 2 +- > .../Library/BaseCryptLib/SecCryptLib.inf | 2 +- > .../Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +- > .../BaseCryptLibNull/BaseCryptLibNull.inf | 2 +- > .../BaseCryptLibNull/Hmac/CryptHmacNull.c | 359 ++++++++++ > .../Hmac/CryptHmacSha256Null.c | 139 ---- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 212 ++++++ > CryptoPkg/Private/Protocol/Crypto.h | 197 ++++++ > .../UnitTest/Library/BaseCryptLib/HmacTests.c | 19 + > 20 files changed, 2207 insertions(+), 502 deletions(-) > create mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmac.c > create mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacNull.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > create mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacNull.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha256Null.c >=20 > -- > 2.26.2.windows.1