From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF6667803D9 for ; Mon, 11 Sep 2023 12:04:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8XT4a/aP2Dx/x7f0gb6Qcslwcxo3B8Od3T4G0v/cSyw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694433891; v=1; b=T7lm1SCnEG0cu0CIs1iRhTAXeXdaXMgnT79btvHS5jScT8/hv/Kuq7D2JVeDyZUbTQrVfQQF QCPnEcyTtStU3/UR85SX/cPbAD1lUJRQerzh68YOJqcaE8bOYwsRcZK5gCqFqJ95qFUWhAvpHmx /bErHu+gFUgYYug0iZEXm2OM= X-Received: by 127.0.0.2 with SMTP id C1SGYY7687511xEj3DyJ1RYM; Mon, 11 Sep 2023 05:04:51 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.56712.1694433890446711654 for ; Mon, 11 Sep 2023 05:04:50 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="380762278" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="380762278" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 05:04:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="990078739" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="990078739" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Sep 2023 05:04:49 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 11 Sep 2023 05:04:48 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 11 Sep 2023 05:04:48 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 11 Sep 2023 05:04:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMqj6daI1D+z+VQWE2OixgMuKoudd5hDdypBBlAD0UeoR+2JYAwhvH3j4ANCeDnweHNZxjfJltr6GSueciNpxT1OrsswW2MDQwtzQfIZyajjGV8km+OiURkqrSITcrHy0PTxwTc+RkuEVEKtL1DUyqej54vUCVeLc1V2XhxixBWC6BaIHJDAF0bAFmnmj59YVZQxmslEcurJMIII8ePWl+xEs0UNGfIIs6ioMwXW5JTXEQYL08psEVJSAMAl6+rMmn6z/ZPp+8Q49rtQF0QqwwWjDv06CJHbrO1fq75VXLFjNiBxzxRskD2d4qOCecU6ErT+m6bi2R/I71+jNH7s/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kLH5dTCwiC8ddvBAOal7e2mnA/HY3RP+BmMgqgAoL+U=; b=UI4ceq77Dfb9Jy0Z1BEDIo4m9ew43gCwQnAdiFYVYARlPfPlIVoTzT+t8ydzv+X6Q3oXVqtXY6JydOoxD1FxDZipQaxTfyog3Bg/f3v6LJbhrkHPxpQrF8ud48CHtujGxxI0BVg2iLLw2gqt7IHw6eMfL9DnKYxi8wjJuqorWuQ80tKTOfXmy/N5BQXqHGPjbQzdicKc/CAyMQXPzrHTc18qnCPH4lsHfsCGUzhbJOSBj2ekd55v0hiF5uZ3swtFCOTyJkQqVFf+yiyf+hLB7oFhOauQDbTDAzK8iEtEECom7JoLtjFXuEqvoq/fyYg/sxxU1HZQJDKCSB3JWkB/Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SA0PR11MB4574.namprd11.prod.outlook.com (2603:10b6:806:71::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.34; Mon, 11 Sep 2023 12:04:43 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6768.029; Mon, 11 Sep 2023 12:04:43 +0000 From: "Yao, Jiewen" To: "Liu, Linus" , "devel@edk2.groups.io" CC: "Zhang, Qi1" , "Kumar, Rahul R" , "Chen, Tina" , "Chen, Xiao X" Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. Thread-Topic: [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. Thread-Index: AQHZ4WoLl90sQm68B0yu+xeiioteDbAVjWgg Date: Mon, 11 Sep 2023 12:04:43 +0000 Message-ID: References: <20230907090212.485-1-linus.liu@intel.com> In-Reply-To: <20230907090212.485-1-linus.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SA0PR11MB4574:EE_ x-ms-office365-filtering-correlation-id: bd0d6d97-6de6-47bf-48d3-08dbb2bf48ba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7W8eo9Ec6l6+G9YpRr2294e5818UZNFPXh1IP6GRaPXiyjNQvggFlMuJaeA9oG5mGkM6jAJ0g1supA53pJ+ZCrsFKEg0lzjwXQC0n80/FHZ5Zd21QrO1mropFCrDWWKhGDalmU5SmVHxvjYsRBx9d5P719CqNUzCv3Zf07ckV1vzoH5uTbVJ7qEb8B8DeNmNK+CFGz1svnSGJfV78YmrEFHsNAMYRM+JE+dbWKcXt480uk92Ako/7U4jBrsxjs0/iWSvCQ/bOH9lMWG71j2UQSRC2EVpENk5PrHKNm8aiGB6S3YFT5Xgq5PpMzdtwp9uOti5UQ95n3VtbzblmOfFNQ1qZpe3wJoASyWOKpSdIIO3hjZ1kmx0W3vY/095z1lC6t01cCHN32AGP+9AL9Jf33Y5r0snZcrKkCMcYaH0neRVH1TmKFixMUFrRcyqDxSCgd0IGJOcuChkUy7mdjAfjDfscilPjtCZhquxkqg290xSJJD4Bpzn0IW5Mr8DVu7FGz3Ih2CYZE/qkiURbpJkpLKCPi2edO0nEmq7lMAtaXVIChjHaNHw4bcQnEbVjAmsJSxuNA+A/ZoBXugOTlvZRWa6Fc+nL5L0B6HEWs1bRg0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1nsS3Znx6hdl5nCRktU0DdHKNDPb+jwSzmXZxKGiEonhcA7RwI8RZNDmj9Us?= =?us-ascii?Q?MSSpDqHg0AOckmuJW784xCLuOWtRo2/zIWZC1i1R+1wYcmT0sNh46RFnNe1a?= =?us-ascii?Q?32raqqBWrgicM+d6MjIu3hRUxl52vt/VoOeRyWuNJrP63KWgLsRsq1PBdYXF?= =?us-ascii?Q?AaISZPzujgyXF6kw1dG16TCAaMJ8ASHYFoV0n9wnuFH96G/5cHKARDLyTu24?= =?us-ascii?Q?eboZ7B4rEvbXbwmc+eIWBokH0szPNqrSGPEQgHE+9Tx4EQZBizc2ZFwXKjuE?= =?us-ascii?Q?UF2GM0m70lFgMK+OpROjfMxwJUu3fPTxPVFnXinsl2DVNcrHF4t++c8PKbIG?= =?us-ascii?Q?GSS4O14Nql7jehygIpd3EKGkkeWpQJ8ikIwq6WkBmv6JIxhSAsfgEfJsdbFF?= =?us-ascii?Q?tc5agRBfm/DJJpQQRS1dpM2Qtp2yFz3dHQ7RFfgCE3qc+aIzEN1CksE2Ccrg?= =?us-ascii?Q?kmRKkBf/lUAwD5C/pwtHFVamK5iU7UxvNlAp24WDZEdZP4ScfMg8SiHKVrck?= =?us-ascii?Q?FO04P/pSdwaEDq/VNAX56dj0j73KqzdqTdTOjy/A8jW4h5tiOsTokwti98Wd?= =?us-ascii?Q?Z62mb2QzycDfSJ8ZqOTeJvBX6qAYgHUf7MyCJFGrOzL09X4nwctPbbz4NPvC?= =?us-ascii?Q?ihY4FhEbdGZYRxTP/t551TLzG0blCMM4OwSTKG9yz0FDoD38tHlrpovWo2AD?= =?us-ascii?Q?BgrHo5w4Mj3o7dAjGbkiYZbKXvDoXGx5VGJpSlJLXTAhUOtoGWo0simrLQO2?= =?us-ascii?Q?iHALQdrELmlrZeH3F7phfjt5Xt/2bkruHzl1W7b3TH/Pc4iUsmXba3/tDZkI?= =?us-ascii?Q?WTQ5qKnq6uYOgYN9LpqpyFgNPVYkPgNaKJrqC3PEW91UN6wXevuBX13SFSlX?= =?us-ascii?Q?MYZ1snXCrp8tbE1jevyaJAjLaI/GEagxCi2rA2u0IBMcU7VZT1YmXuaXcsoU?= =?us-ascii?Q?9gmT7QAWfI5YnHhElRcCTP/vQkF0q5Obvf52hjTsfN9Me0VS1mbPvIpWA5a9?= =?us-ascii?Q?rVA76qkaSMkUutHt8HAHXO58pfiHQmuOlbJH0UwH78Odz97TJ1O4giSouhcj?= =?us-ascii?Q?VwZcUfafwnhQnG8eATVAocLBhGQpmlD/K5gKgaGdvrQrQblMbQ/EbBCb1293?= =?us-ascii?Q?SW9SE05dCBX+kDRdQtJbmRmJ2JzIq6G8lzNKOdnr19nEpnj1VWC5wnTOqdHY?= =?us-ascii?Q?npT00NEJJBngJEQQjaWpkLe4MDTM7Rwd64wnE2GjH8MX2lPQzqJcFkbtxFEG?= =?us-ascii?Q?OHljvaml8Pv2NP608Zg+yzhksSKenMllgB67WvsSuxNWpmJBl9u2M2lFHbwH?= =?us-ascii?Q?k2ae5HJ847Yy3sQ1n8hUvLqjjs5BzDlosW7ATeCfH2iXrYywDrTJOlSdd9wE?= =?us-ascii?Q?zoqi95DIUMi4ZW0JUnF3EYwMT9Hr/Dmvx306ZreoW+dTXHXdPSKtajm8s+6B?= =?us-ascii?Q?DkcKvjVmedN3NOgTxAkXP0BmA6EwFayBvceIgYMkRWXAfq0LnZCFyguWlGnQ?= =?us-ascii?Q?tpYtbXFJhxw3k/g9yMEAwt7XJY5ifR7/JGlKkLRUPIawakof6S3lmsg3trWC?= =?us-ascii?Q?cOR97ZUHGOmJInVkkzQ3Yq/tYsMZsmBU41+ZrnXb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd0d6d97-6de6-47bf-48d3-08dbb2bf48ba X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2023 12:04:43.1358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b8uWYaxQCYTVo7lS55qN3Eb6WR+Wh5xgugpQhpPMQ4I2ZdxsASYlmOXwDFVz5Ongc9pOOObpFYICgqFLfhFFgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4574 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wkC80VTtdtZ5XLV3IjKUMfR9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=T7lm1SCn; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Jiewen Yao > -----Original Message----- > From: Liu, Linus > Sent: Thursday, September 7, 2023 5:02 PM > To: devel@edk2.groups.io > Cc: Liu, Linus ; Zhang, Qi1 ; K= umar, > Rahul R ; Yao, Jiewen ; Ch= en, > Tina ; Chen, Xiao X > Subject: [PATCH v2] Pyrite support - Secure erase is only available if en= cryption is > supported. >=20 > From: Linus Liu >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3004 >=20 > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > Cc: Tina Chen > Cc: Xiao X Chen > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key >=20 > // this is only available if encryption is supported >=20 > // >=20 > - AvalDiskActions->SecureErase =3D 1; >=20 > + if (SupportedAttributes->MediaEncryption) { >=20 > + AvalDiskActions->SecureErase =3D 1; >=20 > + } else { >=20 > + AvalDiskActions->SecureErase =3D 0; >=20 > + } >=20 > } else { >=20 > AvalDiskActions->PsidRevert =3D 0; >=20 > AvalDiskActions->SecureErase =3D 0; >=20 > -- > 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108485): https://edk2.groups.io/g/devel/message/108485 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-