* [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. @ 2023-09-07 9:02 Linus Liu 2023-09-11 12:04 ` Yao, Jiewen 2023-09-11 13:14 ` Ard Biesheuvel 0 siblings, 2 replies; 4+ messages in thread From: Linus Liu @ 2023-09-07 9:02 UTC (permalink / raw) To: devel; +Cc: Linus Liu, Qi Zhang, Rahul Kumar, Jiewen Yao, Tina Chen, Xiao X Chen From: Linus Liu <linus.liu@intel.com> https://bugzilla.tianocore.org/show_bug.cgi?id=3004 Cc: Qi Zhang <qi1.zhang@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Tina Chen <tina.chen@intel.com> Cc: Xiao X Chen <xiao.x.chen@intel.com> --- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c index e2e77cbc24..ba9fa66c60 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( // Secure erase is performed by generating a new encryption key // this is only available if encryption is supported // - AvalDiskActions->SecureErase = 1; + if (SupportedAttributes->MediaEncryption) { + AvalDiskActions->SecureErase = 1; + } else { + AvalDiskActions->SecureErase = 0; + } } else { AvalDiskActions->PsidRevert = 0; AvalDiskActions->SecureErase = 0; -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. 2023-09-07 9:02 [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported Linus Liu @ 2023-09-11 12:04 ` Yao, Jiewen 2023-09-11 13:14 ` Ard Biesheuvel 1 sibling, 0 replies; 4+ messages in thread From: Yao, Jiewen @ 2023-09-11 12:04 UTC (permalink / raw) To: Liu, Linus, devel@edk2.groups.io Cc: Zhang, Qi1, Kumar, Rahul R, Chen, Tina, Chen, Xiao X Reviewed-by: Jiewen Yao <Jiewen.yaso@intel.com> > -----Original Message----- > From: Liu, Linus <linus.liu@intel.com> > Sent: Thursday, September 7, 2023 5:02 PM > To: devel@edk2.groups.io > Cc: Liu, Linus <linus.liu@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, > Rahul R <rahul.r.kumar@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chen, > Tina <tina.chen@intel.com>; Chen, Xiao X <xiao.x.chen@intel.com> > Subject: [PATCH v2] Pyrite support - Secure erase is only available if encryption is > supported. > > From: Linus Liu <linus.liu@intel.com> > > https://bugzilla.tianocore.org/show_bug.cgi?id=3004 > > Cc: Qi Zhang <qi1.zhang@intel.com> > Cc: Rahul Kumar <rahul1.kumar@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Tina Chen <tina.chen@intel.com> > Cc: Xiao X Chen <xiao.x.chen@intel.com> > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key > > // this is only available if encryption is supported > > // > > - AvalDiskActions->SecureErase = 1; > > + if (SupportedAttributes->MediaEncryption) { > > + AvalDiskActions->SecureErase = 1; > > + } else { > > + AvalDiskActions->SecureErase = 0; > > + } > > } else { > > AvalDiskActions->PsidRevert = 0; > > AvalDiskActions->SecureErase = 0; > > -- > 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108485): https://edk2.groups.io/g/devel/message/108485 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. 2023-09-07 9:02 [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported Linus Liu 2023-09-11 12:04 ` Yao, Jiewen @ 2023-09-11 13:14 ` Ard Biesheuvel 2023-09-12 2:03 ` Linus Liu 1 sibling, 1 reply; 4+ messages in thread From: Ard Biesheuvel @ 2023-09-11 13:14 UTC (permalink / raw) To: devel, linus.liu Cc: Qi Zhang, Rahul Kumar, Jiewen Yao, Tina Chen, Xiao X Chen On Thu, 7 Sept 2023 at 11:02, Linus Liu <linus.liu@intel.com> wrote: > > From: Linus Liu <linus.liu@intel.com> > > https://bugzilla.tianocore.org/show_bug.cgi?id=3004 > > Cc: Qi Zhang <qi1.zhang@intel.com> > Cc: Rahul Kumar <rahul1.kumar@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Tina Chen <tina.chen@intel.com> > Cc: Xiao X Chen <xiao.x.chen@intel.com> This patch is missing a signed-off-by line > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key > // this is only available if encryption is supported > // > - AvalDiskActions->SecureErase = 1; > + if (SupportedAttributes->MediaEncryption) { > + AvalDiskActions->SecureErase = 1; > + } else { > + AvalDiskActions->SecureErase = 0; > + } > } else { > AvalDiskActions->PsidRevert = 0; > AvalDiskActions->SecureErase = 0; > -- > 2.39.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368 > Mute This Topic: https://groups.io/mt/101210886/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108486): https://edk2.groups.io/g/devel/message/108486 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. 2023-09-11 13:14 ` Ard Biesheuvel @ 2023-09-12 2:03 ` Linus Liu 0 siblings, 0 replies; 4+ messages in thread From: Linus Liu @ 2023-09-12 2:03 UTC (permalink / raw) To: Ard Biesheuvel, devel@edk2.groups.io Cc: Zhang, Qi1, Kumar, Rahul R, Yao, Jiewen, Chen, Tina, Chen, Xiao X [-- Attachment #1: Type: text/plain, Size: 2617 bytes --] Hi Ard V3 patch has updated. Please help to check it. Thanks. -----Original Message----- From: Ard Biesheuvel <ardb@kernel.org> Sent: Monday, September 11, 2023 9:14 PM To: devel@edk2.groups.io; Liu, Linus <linus.liu@intel.com> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chen, Tina <tina.chen@intel.com>; Chen, Xiao X <xiao.x.chen@intel.com> Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported. On Thu, 7 Sept 2023 at 11:02, Linus Liu <linus.liu@intel.com> wrote: > > From: Linus Liu <linus.liu@intel.com> > > https://bugzilla.tianocore.org/show_bug.cgi?id=3004 > > Cc: Qi Zhang <qi1.zhang@intel.com> > Cc: Rahul Kumar <rahul1.kumar@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Tina Chen <tina.chen@intel.com> > Cc: Xiao X Chen <xiao.x.chen@intel.com> This patch is missing a signed-off-by line > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key > // this is only available if encryption is supported > // > - AvalDiskActions->SecureErase = 1; > + if (SupportedAttributes->MediaEncryption) { > + AvalDiskActions->SecureErase = 1; > + } else { > + AvalDiskActions->SecureErase = 0; > + } > } else { > AvalDiskActions->PsidRevert = 0; > AvalDiskActions->SecureErase = 0; > -- > 2.39.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368 > Mute This Topic: https://groups.io/mt/101210886/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108513): https://edk2.groups.io/g/devel/message/108513 Mute This Topic: https://groups.io/mt/101210886/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: message/rfc822, Size: 8088 bytes --] From: "Liu, Linus" <linus.liu@intel.com> To: "devel@edk2.groups.io" <devel@edk2.groups.io> Cc: "Liu, Linus" <linus.liu@intel.com>, "Zhang, Qi1" <qi1.zhang@intel.com>, "Kumar, Rahul R" <rahul.r.kumar@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>, "Chen, Tina" <tina.chen@intel.com>, "Chen, Xiao X" <xiao.x.chen@intel.com> Subject: [edk2-devel] [PATCH v3] Pyrite support - Secure erase is only available if encryption is supported. Date: Tue, 12 Sep 2023 01:41:59 +0000 Message-ID: <1784033FB294A935.29005@groups.io> From: Linus Liu <linus.liu@intel.com> https://bugzilla.tianocore.org/show_bug.cgi?id=3004 Cc: Qi Zhang <qi1.zhang@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Tina Chen <tina.chen@intel.com> Cc: Xiao X Chen <xiao.x.chen@intel.com> Signed-off-by: Linus Liu <linus.liu@intel.com> --- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c index e2e77cbc24..ba9fa66c60 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( // Secure erase is performed by generating a new encryption key // this is only available if encryption is supported // - AvalDiskActions->SecureErase = 1; + if (SupportedAttributes->MediaEncryption) { + AvalDiskActions->SecureErase = 1; + } else { + AvalDiskActions->SecureErase = 0; + } } else { AvalDiskActions->PsidRevert = 0; AvalDiskActions->SecureErase = 0; -- 2.39.2.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108511): https://edk2.groups.io/g/devel/message/108511 Mute This Topic: https://groups.io/mt/101307436/7575003 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [linus.liu@intel.com] -=-=-=-=-=-= ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-12 2:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-07 9:02 [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported Linus Liu 2023-09-11 12:04 ` Yao, Jiewen 2023-09-11 13:14 ` Ard Biesheuvel 2023-09-12 2:03 ` Linus Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox