Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>


> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Thursday, September 15, 2022 5:26 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant
> init
> 
> CertCtx is used to be defined as a struct and ZeroMem is called to
> init this struct. But now CertCtx is defined as a point, so use
> ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> index 3336d2f60a6a..f8028181e47f 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c
> @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList (
>    OldBuf       = NULL;
>    Signers      = NULL;
> 
> -  ZeroMem (&CertCtx, sizeof (CertCtx));
> -
>    //
>    // Parameter Checking
>    //
> --
> 2.20.1.windows.1