From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.124.1663715002523859311 for ; Tue, 20 Sep 2022 16:03:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=fkNvEcfv; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663715002; x=1695251002; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=viXn/Tlvo3C+WNLDPOnKuOXdOkXpV0VJQMJ2Qg/pS14=; b=fkNvEcfvYRDAmT5hftAjZmjQAHNOKv7VhoML+be+d1iwJZlD6rmWMPx8 3hsLf1lgnKJvIGK7gksOZZ4gHJhAqcLBvsqb7eRz+RkZqjQfj+pVVWMI7 GZmtnDYmus0xKTO08Vm6/lqvMpR1EyG3nCLp+I652Q01ff4q9DuNfNJ0c 5lCz7UYo1c7KymKuyZCFYlaKhQBTggiV5VlQKstlc2+jP5viKThMCE2lI VA9bupDc0xl/oZUW2ZGj2BRIQqbvMFE4PZpo8T/oPKgYGX+fvZcw7DbBZ HJA+GuVOtNzzhoykr8xCeNP1+wHm6s+ARmxq43rjXkqmtMXa2og6HjSox w==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="386127756" X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="386127756" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 16:03:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="687616780" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 20 Sep 2022 16:03:17 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 16:03:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 20 Sep 2022 16:03:17 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 20 Sep 2022 16:03:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/pfQbfNYpWhFSMa/ODOYNVjDLwVAUJVXDNUZoKqVfdCKPAHMAXExO7uoxnuUYt5DBSo+0FQB1bnggkeRqnovbG2gxf/vU8XbZ+f1Wbqss28QuTANwOgqRrEd6EYsQ0SyV88JeV1P9HCh/i2iM5Je9TIPsWv8GQSjnStPrrJ4PyDUjqTQU62FuMIXwk6nFFc5vZHVPVFR3G5NJH/7sdecR8yWtIQ52YzVex3p014nCdasa75fVw05IYTo+1OgacLQwmpW3rFlxTxvqt13GxzL7q42oizWDd/OWijoIj6baaT1NnoiDWi2mQDTz5Dw4eVxp4kTBJer1mxjyUFzTKw9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vw8ZG/emOn9Bz+x+P4MF6ObFbJU9i1RxC5m9LhxaALQ=; b=YMVVoCHKilXxnfSWZwT/XfKd0woxGGgzpwYQ4W0dMrm3JDz+MglMbnd8tb1OmoQVSgkiVnh7/57mJFzCZSyrv5Hgg2tGbcq9WcS1icPrW9pucQkVn3piZLqRaikCqATOkKMr06BgFrm4YDp3phbtmDhbcGwWHBSRhRUy5jQT4BEZxLEfg4JkDsMXD7n8kLMN7Yo91U3IL6r/wN6zhng+WWfdw1ft7slLjvidIUruXILxXcfTh5dh1sDy535HKdkH1g4c10iqJV4Pviozc21qxeBzf7GmHVsTYqNnsNTkI42FuXu8ppYanaWzEbB2wgE7jpqLDC+3IDZOum82SpnyfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY8PR11MB6842.namprd11.prod.outlook.com (2603:10b6:930:61::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Tue, 20 Sep 2022 23:03:09 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Tue, 20 Sep 2022 23:03:09 +0000 From: "Yao, Jiewen" To: Wenyi Xie , "devel@edk2.groups.io" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Topic: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Index: AQHYyOVFji8FHlhyaE2Gx1IXSmeG3a3o+HDg Date: Tue, 20 Sep 2022 23:03:09 +0000 Message-ID: References: <20220915092620.3341564-1-xiewenyi2@huawei.com> <20220915092620.3341564-2-xiewenyi2@huawei.com> In-Reply-To: <20220915092620.3341564-2-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CY8PR11MB6842:EE_ x-ms-office365-filtering-correlation-id: 97f4bb49-0b17-409e-1dd7-08da9b5c4904 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sJyiaossIwAMG6BIDunjL7OqAnY/sSCXI+KmoyEEGBWlysReO9SqQsvRHGKh4S4zVv2IGVgu8hAl6jHgvkL0xpclV1SVBqgO9DWu4+wjtvu2vU+OzDyxz7JMTP8V1RFKeM4pbqhWvQ81sH0rtM4poLep8mUsS2NVWuulqq4LrCz9HtV/MV1vJJJVEbUWEXFCHw52KuyJMGG9ar8dU+DtDxmhFOCEAETvoDu6fNj2XFq0EAGuRSGwkHtHy/5CVXXOwlaKoPDd2P7xg+edLKgI14XvYpp4nIRZ629B97Eyquo0zJYq1loY7EDyPfhHa2CC8USTReOZ9UZlXu7ilw4zPZyfjnFA2oKdNurhiyqOGjhexR0xFRxSxHrS3kQLrqB+NS8hEGYPjbovQU8nCeM+dRbG10VQC6RR00zDLSE77AMhOd0NhLZ/rCE7I4sMVbU2PPESRYOszwmnV5vfre44f/6p+4bFClGNeD3RLQ2VNri8aYUtKILqfY9rbi7wHqSHMVn9OO1QeupnecO1X4XNwIj7G39zhkCUZJMrgprl8kS/gTJ/IaeYHD1iNKTC2CflyLPI6E3K8uNPw9p2ZWCemz3tLFQNMK9BtkJRUdzIb6eyK5WhqwCGUvY958PKjNk7a2wcXe9mzj7T7PeFKre7P4UEgg4NmW7YSpgUeXDMSoEQIpPR67/nSN3Q4I3gNvTGHCSS4+FdVBI//Xhdn4HmnzELw/rvcFDfq+UB9OpYupg1hgy2GUmgqlV1nBJwTELei2Bii0JSGkim2G/WztK3OQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199015)(9686003)(66556008)(86362001)(66946007)(5660300002)(19627235002)(38100700002)(66446008)(66476007)(4326008)(122000001)(110136005)(76116006)(8676002)(2906002)(6636002)(316002)(8936002)(64756008)(38070700005)(52536014)(6506007)(478600001)(7696005)(71200400001)(82960400001)(33656002)(83380400001)(55016003)(26005)(41300700001)(186003)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wzTR8wYMXfM+4fdVeB6MB6YRDHt43TWN4iHkceBy/G8/JDhWd4LkGile+T0M?= =?us-ascii?Q?w2SkG35C4uODpjjN1gnlcsEfpK/exWQwFrVqikjNpyxtzu21XLCZpDsHQ1E2?= =?us-ascii?Q?raJ8OcTy39Rdhg6E4nPSX77cEZYbxWFQLurSzqLsFUG5ywoKJ4Voq+ICflmK?= =?us-ascii?Q?KM/zTvYc/73zWtI7fycrmqaX6iNBCS4HK01GzI5qJeDoUgIYRzljEkGTG5DT?= =?us-ascii?Q?P5SvrG67f1d/aTGdwY5Yrrsu4SagGNsVoW9SvmkKp6XXucNt+UalGcAt+lTj?= =?us-ascii?Q?lfRolgrq/Iz2fv2Q9F+lgzM61I4EbhmUxY0JAHjy+80l+x/ZSoVFDvFwj56J?= =?us-ascii?Q?b24YEr7Tk+npK0JJDvmK71W3kzg0NaRK4NmJA51ZXfi1SSMbus+fNBEl7axj?= =?us-ascii?Q?qwxcMHSyI0RJvs/+a/7p03LIIxW4kdKMq20dJKIdOksXr6ce8bgHZqb1qSEg?= =?us-ascii?Q?+/sWzEfAxycgz3TPEWWHvbu1+oU9Ik9OtZ97jhXfAHn2haJKjAB0c5Ly/OdE?= =?us-ascii?Q?H4kt/nCRrBPBTrD5s/ZWW1zChYRbvQFt1rDcjbBt0HntW5NzXJHhAo20MmbB?= =?us-ascii?Q?P9M6bIzlXUxzoc8NKWm6gwC1uYYsRA2aEtv8zU4F0Yqf0TsBkzacTj0sQVqu?= =?us-ascii?Q?Pw7gBZSFGdQjAUSY3fFf+FJhMtOcgTO/LcAE9ttACNsaI+2WzCUuLSee6Zal?= =?us-ascii?Q?jF7SHxTf9VbnznEoj2cJOH5vWA+brJ60BFtdf9OTV5X6vXdBtgFvQr5vFVVN?= =?us-ascii?Q?3vKiZtoc1GasPCpFftxWKHqoV+J8i/UFRUvkN7MrpVFN1Ir9V/gqDdVopXiC?= =?us-ascii?Q?DqCQwmfyr49bqLKRTK05ZhLgIxeKgkfcC6ldazv9ORDiny9GrhHVGqzS+E3x?= =?us-ascii?Q?qhbJ9Smhj/LUXNnjSn7A8xVwW8SGxJiGnHqqxtTyYeuWlaMyH1oAOham2gTn?= =?us-ascii?Q?dwt5hOSK8jmKS+Ydn0h1TFJYQHic4RW3xovHHCCiugbC8X2Gtqi+qVFy+R89?= =?us-ascii?Q?KFI0MzIakeuVlO6tyDG6FNAewJ5LRTfsPnzZTlabC8VGZz84AXGS0lc7kQcx?= =?us-ascii?Q?3O2u8zEk3+/qmavNMS/6/mCn9WRfrl/SeeJ9L6mSDAOD5dTqX3Iwf6g16A6q?= =?us-ascii?Q?78WVo4Tny7EsdliG0wpz9niOC4TDORnZOtzVsyAjbgCSVTeudvI5+vaE8H90?= =?us-ascii?Q?u3eI8u9AO+PnozP+zSn1icLrmaxWQhlJG9WRbbDy7mPeaNWA0afHOIn5QEIN?= =?us-ascii?Q?wVIH5NBmmIBFwNBtDFEghJ3axWq2lvsVcGw8NjFod5Mkcqz8otHyY945ntTl?= =?us-ascii?Q?i9draMK7yinH1texj1J5idNSkpJrX/z7coJjxeSakD7Um5iz2+2J0kRw1B7E?= =?us-ascii?Q?FFfNy3Lcf9+qQzr5i/uTKH/nCctb1yjverOwhUH4ccZyfman0DBvPduY/PL3?= =?us-ascii?Q?eDBOf+ZwMO2RZrsGDgv8Q2mw2I0zCHIv7RvTAjXk3sVhgx4nfhWTpaTHw6Ka?= =?us-ascii?Q?hnLDfyUDHNAmTmRHVA8v+i7vKvUaGbCmN+aru3XWDPxib5z/0shCBVykqeUw?= =?us-ascii?Q?XaHqaDtptpCJWzdfgHJOiBZdYgrDhV2FvFC7Vvea?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97f4bb49-0b17-409e-1dd7-08da9b5c4904 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 23:03:09.0493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XOBnuYvvUxrha4UppSdHPs9EV/G8h4DoXPm5Aq5v9LMJ4YzpW/MKfc6dL4JZjhU+V3UseVTefMI94C0vz+rkKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6842 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Wenyi Xie > Sent: Thursday, September 15, 2022 5:26 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant > init >=20 > CertCtx is used to be defined as a struct and ZeroMem is called to > init this struct. But now CertCtx is defined as a point, so use > ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Wenyi Xie > --- > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > index 3336d2f60a6a..f8028181e47f 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList ( > OldBuf =3D NULL; > Signers =3D NULL; >=20 > - ZeroMem (&CertCtx, sizeof (CertCtx)); > - > // > // Parameter Checking > // > -- > 2.20.1.windows.1