From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.2545.1659483815694503102 for ; Tue, 02 Aug 2022 16:43:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PS364Jo+; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659483815; x=1691019815; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R2T4pCZm6QlvmBeiS0kX6hXXSH5sDIYljWgPG1BkBJY=; b=PS364Jo+OqNoa+JXUTsPLy1i3BV/9Zegk949FBwGlpo3dXxFA8GeaULt f97xjz9RyGeOpS/djcI0Ceicyq46bA6E3FnfqteveiuQU8z1rD4mxcPi/ lXx85AV2r/rin4ZzGjRFClaM/hUq01sYkJ3EMmezZlcTjj7pAfJ6wNgA9 CmJpEujHW79NL9H7s76+H+ut0Q1Dyn+7U1u7gyrPG1SV5tnNqAxxRyLtS 83FWgVl6VMYQj0mxa7ZoH6FKKVbpMKsUdOuOF/MfTdnCRuqEjbHW3NBad V5BrNznHmRKjViCFbVpxR7g3REQn4ZW9Om6GpthVVgl5sRTkMMUzQlD1h w==; X-IronPort-AV: E=McAfee;i="6400,9594,10427"; a="289554905" X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="289554905" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 16:43:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="630918014" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 02 Aug 2022 16:43:34 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 2 Aug 2022 16:43:34 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 2 Aug 2022 16:43:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 2 Aug 2022 16:43:33 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 2 Aug 2022 16:43:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DOBS7FBMtybhVQH0GGKwaw2jXbHBjo/y/UWMIx4xXA63NJBHMx+Jirs4kQgLHBtNLaPXwvS58Bgw6JbnRyhk34G4r5lkzcFYHhIBeUouWp83jCbZUJ6ffbww2p7gsXtqRfhMU1hZFfC8Haobfnn3oF00S/FILq7kMF8hLJx9jzjDjh5C36SxwIj56LrnhwjLthxnCn3leTCLQ6yV7xyHqF/BCFr6UdGf7EdmiG/UWLmkkWEX5YOgk8CyagvUOjt/a3htTEkU92PhwZ+pbRuYq33rF7zgTA9swQqLyMuVF00h40vJ9ehdtlmR5rWtmwTePDfxTqvEgcXTIU5sCIgkZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hcTTNuondpnjL3Wat5L2WDdHqeE6UqHytLEzszvZhJs=; b=FaDHyLzF//uely1rRRLI5I59R6FgIMtmgFZWrtROeHA1CB/nca72yRUAWuZahVXMYYMwcXYztrN25bJCkUWyaT71cnszhkQ/3PjxiNYG+uFeIF9t+GeIReqbIMw3lSbb4MVC1Ngk+B4aW+UjM0C8iYho/MVa+4WMOGr88dXVWH+Nq4/A04weqIvZYeoZRiSZaKPo8EpQH7Z2FXjRztd9aB8Gv4SA0OElDBbW6hNfTjSuNhEtWLwO9eBHUG5k6Ds3BcJlg++fN/FvFvaB5TstT5eKKJy/wcal4tdcHKszD6uSlzuwDp8O7RkHbHAysVYGu8uI6iQld7TynY1fUEB1Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY4PR1101MB2326.namprd11.prod.outlook.com (2603:10b6:903:b3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.15; Tue, 2 Aug 2022 23:43:31 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fd61:b244:d8fb:ab1d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fd61:b244:d8fb:ab1d%6]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 23:43:31 +0000 From: "Yao, Jiewen" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul R" Subject: Re: [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Thread-Topic: [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Thread-Index: AQHYpppqmTciVUyask6Pkj4qpSWwma2cRhMw Date: Tue, 2 Aug 2022 23:43:31 +0000 Message-ID: References: <20220802180418.880-1-mikuback@linux.microsoft.com> <20220802180418.880-6-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-6-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 105ac58a-67ff-4ddb-c3fa-08da74e0ce90 x-ms-traffictypediagnostic: CY4PR1101MB2326:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u1CCAqEeMxuiWszlV7q5RAQmncxC3c4jDFKj5s57jP39DDJa39bhdFQFNO8cQVWhTvs2oznI7hcX3AIgS7vmAlMwhe7aJTxT6WG/fCRJ73H0L29i0xSm7PsBOSf8lhEQjcbNAB4taAK5PzpYkI4BI2jZNBb43PIcgan1ceGtN7BLNvgZCHFw0nQL45MF9hXyCzrBmYuN0MzKGlq7bWlI/iStOTzhwH1fACJIiDIixMkkoLRz1ve29vt9C+v//YNKQXpJ5OjYUtgOZRUZRT5sSWPBAvs6+VQbjl5tlNXu1yj6WOoVkjClNlVj5tvyyNH2qMJIZuZjEVFlA3kT4HERu57V6fXNc+kGhCfhRE6aVsI97dImcrVzk5/vofEPrqzLcQj1mqwudJp7GIDDmj1H6h2L/2Lm3COsjGnkPvr0u2nvzteXF/EW7C3no99t8aU7uklZbbAaz7RwYi/gbmyXwUAPQ/lIWmCnavl+gj6ffUpiQizn7yYn2vCaL96r9g9h89dygF8BBqTlZPxzqR2Q67mZ3xHXDbTFj90/wlP8fZD1RraPhmkbTKQGh/YTQRfaGb4FEscAwYOYsqIAyPvNWfw9IbuKd3ij9my8gcfT/tV5W9LntsjbOr/5KFLZuzvpUlT5XzFxEGwN39euwbLaEHQG68hHC5LIzwx3k7N2Exs0QlfozhQtLxopXQ19loV/3y9bMzvUp9P7qPv97cmFJqdQxmWw0Hj9QJSnOU35SElCskxQ1yV/hCX5vyDRzij9+jQMh18ZpFWKsxZvBXDICqhwVFzwyvwdHn/VRNkP+q9A4j2mGBkvLQm/QICwirFB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(376002)(39860400002)(366004)(41300700001)(2906002)(5660300002)(82960400001)(83380400001)(71200400001)(478600001)(122000001)(53546011)(110136005)(54906003)(6506007)(107886003)(33656002)(8936002)(7696005)(38100700002)(64756008)(186003)(316002)(52536014)(4326008)(8676002)(66946007)(38070700005)(66476007)(66556008)(76116006)(66446008)(26005)(9686003)(15650500001)(55016003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ibjmj+3nShacQEuPBKqfXtuVasXvOUxP1+3jTCKSbtmiHtF6TnF9LeoK3/Dq?= =?us-ascii?Q?e0lOR77z6YHbptBvzGzXlIaZafWTC32KwYWZQzxjcjI0EciqPt6sXNkPZWs2?= =?us-ascii?Q?KR8JSdvehvgq3laOJGox4+U1JyzKXuYiuU8ljZ0eMNn6EDuR+0ddrzM8G3qw?= =?us-ascii?Q?q5S/oPObLHFUrBAwNZ5YIoW+/w1O3xtY7CwnI2J06I1gzz6brpCcKfjplCOh?= =?us-ascii?Q?QMATfNdVziCpb4dyDqwmBDB9uxBR4uKSKdPV/hg2RJuyDpy+KNKcGpNjAVUq?= =?us-ascii?Q?JwerkmCanQNeeoICcgWZfTWhgwAzEDOw5zEx0XH5A3l4wMaG+vkByXbcgN1L?= =?us-ascii?Q?kx47cd/bEIOADOWt5dtxgGWvjDRmswspSMqGXfSlpqOh8jxeqNxo7F9nQXPd?= =?us-ascii?Q?rPcvKdvRiHk7NbZIqmnMNoP/2p8Bqhyqh54RCPGJGBuqaZSyQO4HJW3bCO/6?= =?us-ascii?Q?E4N/jrR8Pn3Q1FMKWAbprpSGRzP3F45LROTck70tAROvz66UMDj2a2yU9p9N?= =?us-ascii?Q?sfNckG8EHcGdk/znXyDrnkZFvQ+w2WSv1GhYmLBzHrcZx8al2urCDFKxyeJ+?= =?us-ascii?Q?lgruuqPZ0F23jhx4HAvevvsJEjG94NWKhcmFscH2lG16yAeNU4BUxtfECQBB?= =?us-ascii?Q?vAZq1UHoFY3QMp0WAv0sXt45B3vnu45lb9LsRQzIa3+ZiL+yPBsxJ4BuK6qO?= =?us-ascii?Q?8g35xLhF7INKn6p/UH5w31OpMdtkcJ4wtFYIORw71AugY9B5GsO+D/inWk52?= =?us-ascii?Q?Qr4hDOdBX5hsH2IdSx3XTeEOP7WuxYmT5h5ou8hLhtPGN9KKPGYMW/vugbDt?= =?us-ascii?Q?IvrHtHqUM4S+tOafBnLnH9CLtOGO/0kyqROlxjMm77izmJ7gy2n0T94kjxrT?= =?us-ascii?Q?5IQ5CsLCyX1Hh3dbMy2iuiw6uiTgmBB2jJFkinibBe+YICq4jXBv7Bp/3CwY?= =?us-ascii?Q?4HRK2U+ZlTqVTCR5N7D/1sjIbRDQphzRfl6DUZUcj1R1X24JLIIC333/qdPd?= =?us-ascii?Q?sIHN8hJQf7p2+CgX9thKzcUbGD3XcZm0j0yYk+8SLvtVMbuadgkWnJ+KdCYM?= =?us-ascii?Q?lF8RVQg30E8o7t8noSMYpg+lsFKs3J1gu4i6c+XPyFgFKbIP9lkX1vwlDKTq?= =?us-ascii?Q?lRqd+zQOquUEKccO5H3qP9txgeCqFVck5gnwKAAV6QCKldgE4RFPebYa0cja?= =?us-ascii?Q?ffbylb6hS0gbzH/EIMk/5TY0wuEBtQEDhGdAAUg9JUh+GEemuTuR75wazu0f?= =?us-ascii?Q?WUPnyh2G9WKCLyzOyOMx0K5haN+ZYni1vho8fXOdSP3RWemE/d33K6kcoeDM?= =?us-ascii?Q?m9qJpihpn8QKgmI6LTDv0spBKzHsE9eKPfLQk4xlKfzKZ2k3ylgKHGxI46FV?= =?us-ascii?Q?eOPNruY/jGLWuYCPpy0lPXPvXDjVFgYiZT1KsdDxji2sHWAm8PQKvVTWirP1?= =?us-ascii?Q?BkAhwc+Q8jZEIDImwvoZ5Lp6WF5nR3c2J8uzikFSDHAOAggGxrOCUDptlcao?= =?us-ascii?Q?s81BsyC9HREo+dylUyksCGW/a8fB37z349YERy4FRYEe60ge2VaV8X+j66nv?= =?us-ascii?Q?V7hcdZkwAc8qj+ltAIVr4Emo/N/L+uzcKOd+aS5m?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 105ac58a-67ff-4ddb-c3fa-08da74e0ce90 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 23:43:31.2811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NUC5HNLXY7Qx/nF20NaemvEBFnM23NPtA+6/AtOeG56tvC4N4DljtBGsuTeRr9qgeqr1/fDe9DKVornDP1BV+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2326 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, August 3, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul R > Subject: [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missi= ng > debug print specifier >=20 > From: Michael Kubacki >=20 > The debug macro modified in this change was missing a print specifier > for a debug message argument given. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Signed-off-by: Michael Kubacki > --- >=20 > SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLib > Common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > index 1fbfc00547cd..f2ab4f125007 100644 > --- > a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > +++ > b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLi > bCommon.c > @@ -176,7 +176,7 @@ > Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( > // Sync PPRQ/PPRM from PP Variable if PP submission fails > // > if (ReturnCode !=3D TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { > - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable.\n", Status)); > + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync > PPRQ/PPRM with PP variable. Status =3D %r\n", Status)); > DataSize =3D sizeof (EFI_TCG2_PHYSICAL_PRESENCE); > ZeroMem (&PpData, DataSize); > Status =3D mTcg2PpSmmVariable->SmmGetVariable ( > -- > 2.28.0.windows.1