From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.8968.1652258844667743098 for ; Wed, 11 May 2022 01:47:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=L49qAS7H; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652258844; x=1683794844; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DD2FKvIZAvSyxu50ILM0EtOAg4LEmoar26/nz0XvN2o=; b=L49qAS7H4MVzWl7Yfzj+CQXRG1Q6Qlyyea4SI7MfswBAuh4tNqPBbkFp J+5ysEUYgMNm6p3FzWa/oOd1nz0eRT1YGGr36s4fE+cMqtvTBcNiEUj2Q JTV+4Rvdp41GTt/mF9UXgF9LtaNShPjgh2XPGMC9w8gd/7M7zQ9cEWV5p PAVUbWDUJqWJbW//paaE3EFFUjc3MhvBr4uARMdq3qYxzljpKO/0RTy/r xthHiOKnyd+kuJbQovB2EjNwQE0pBAoMtwKhRXU3paS1sIIxg9znrIVDL VujcsUDnzgWXz0zMCSV0rC3bgZNn7zkxiauvFWEpF0SS1yNF9jBc8qQpD A==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="269572603" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="269572603" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:47:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="602857914" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 11 May 2022 01:47:23 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 01:47:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pr5XjDC6otzq3RDT9WcOwJRFwQvkpzM3SuNmr7wlvIC9E3zsJXqlin+efi+UjmUsVblw8cAzTGv0oFvI2wwPkhEHd4b3knkaQAs4227KZgbxzvk9NjxMA1CEWN63kWJyG0GPrnFEa1R+dJ36ecP9OSxIu75v5ZY4fgAKkw0N9WEBC7x6jr8amfhGAy20gD4gKX8ldSStXqLw9rMbQnYlER89jYcCihSJ0id76HkRBXZkznNTPUaueP1sgCy3JGsdDw2XR3Kf98SfdnLBo/qkFy9jx5WBEOeFDRiIw/Q27isOMz9ICSUE7A57oHLrLkGoxCIiKvoJNifmke/sPNMHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g0hZSVFcTM/RJrUS90l3LFyf0idzLIp0PWiUZyy+PY0=; b=lmQtQw+ckTB8HAEIkS6HKbJGuVsgmEJe5azYQ8nkM1X8Pkt5NCfOD8ksphoy3d05K2BbQqRFbDUyUHOe2eJ/BLiJmez2dYm8Y3CgTQqnf6mznC/r3U0z6PZrSMY+o5CIrSnpHfFOyyQc+DTAqy8xavJ/uuOd2vX7iV+IVZ6Hwb7eqh9Uq1HZ9aJE4xzUviPAgjuCUTitqmLELkbR2F0dUBwkegIJPFY5h4jUibrF/JWmUanH5g0uE+v3qJ68syQ2qsDW1mrqRlRz+k1xPxYMbnTuiQysw36ccikc15ELduZ3IM48OU5OUGW4OOsEuwpmARbEdQmb7LqWOGkEe9vVdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA1PR11MB6196.namprd11.prod.outlook.com (2603:10b6:208:3e8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 08:47:20 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 08:47:20 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Ni, Ray" , "Brijesh Singh" , "Aktas, Erdem" , James Bottomley , Tom Lendacky , Gerd Hoffmann Subject: Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Topic: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image Thread-Index: AQHYYbLqBet/1uO4IkC0n+Qg20I9Sq0WgcgAgALiLzA= Date: Wed, 11 May 2022 08:47:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 121e5b5e-c1df-449b-244d-08da332adc13 x-ms-traffictypediagnostic: IA1PR11MB6196:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7YHTAoiIYtjwNeuO3Du/wJSBN0f2mC03g07q7VWE23NdUNNdlRut2wmkT/CxxhFp/pnkC7fFTLjT2OFkOGi+MC45ge6KrhkfKcDu4osoQiD6+7pgwNMVohLPOFcjLg8KJIFvo9SYGoKHyiEvjzrM1XXCa08yrKiDF/4LakExvrSPl2ng6M+i0XB3tutPxtuN0skJ269nlNSN0SuqEPdQ4cv2t69++OtCW89/5ouSJUnVidaYe0HNk1RXRcso3F6igo3FNi8iZLA0xD4ENLUzNRXnTzTRV4+Cg9zw5wqGNPuj1+oAsmPkvEmOQ8MrdLFfScC2C6mSlHpPDzlbj5Pi/GYGCtKrfyWSbPWg+lq+I3ztfd/v2lbpZcgHi4537frg8dEcFWs88JC9SMzNpvgJzpyiziXvRUVvrnktv9hjwsBELjKZ8gAGEVe+aqiAhR5KaQnIMvLIjbYE5bPhXD5N5amRVta25b3h1Td0jYTZ4Ih+2JWPt6ryeY0Eh/by6aucYRAqbsZkpGMMRvHHOr8uJhUXkZb5q+kpJhtpkgOEPYZi0sv0sRfCF0eIy06VPyo5PsYlW3TZPPlzDjW0Miit8Uoz8TX2hfyPdVyiV/zCCLTre+BxT1G4uVaf3RiU8r3US3v8bFK8IbB+602z0WLZnxX45aMgN2O8MtQvNpazLD6jic9UgQmFWGTOVpBV4Mxp/sUT4i1tOBK11LddGXuEUQ9u/RBlBQY8ccHSag4xNdBNqD8EIIira3gWK7hta7rWBKdyxmyTKbiXQUYTRgvXHDm1PHDx7xw/mSrmxTrxof19voY9TODI7PnGIfhXr/6PaD+vzulkR+8QlV7l8zvvYQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(83380400001)(508600001)(5660300002)(122000001)(54906003)(52536014)(38070700005)(966005)(38100700002)(4326008)(76116006)(8936002)(66946007)(71200400001)(19627235002)(66476007)(66446008)(66556008)(82960400001)(64756008)(8676002)(33656002)(2906002)(110136005)(55016003)(316002)(6506007)(53546011)(7696005)(26005)(9686003)(86362001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MyCcUr90DG0uSkBIsO/fmR8Pmye+zq8DyNJMBRBvarEQ6lJpIZA4EMC9Qhgg?= =?us-ascii?Q?Acpd7NpZRSrwiWKOYf/+3YCSGgnvVW4XW3BUFv0x7wZ/XEm++ktH6QxkZefT?= =?us-ascii?Q?dQQS1yMA9x3kwuNXj3d+GtWarVrNLBahRfwH0OT0hdzCxxTAab1Q3UdzS2q8?= =?us-ascii?Q?D4bEZFPEpP+yKV00KTo60GoIXIdcFRZcp+XClW0KQshwNr6SMlV8fRsCKvUA?= =?us-ascii?Q?6aULaKvrkP7PuVFu/kXjxZ+X5ZIMq1OaczkI2bJNxh2YLFTNJ5T/bqdoYmZt?= =?us-ascii?Q?vvg3tNSKsGnZyGIRC/jm0LLib2+Xut1fnD5WNUGPP2d29GwWKREf4i2n+xod?= =?us-ascii?Q?qG11U98kO57ycUlj/4x+zRenjB0S514NbiP8JhMXuhz9iXMlwnz/2ZbquNdF?= =?us-ascii?Q?8K1qnwaOFu+SH2GXclim+/Jv888Y8VKtnpbaSPDu2sF6WK2LULq5emDWswjz?= =?us-ascii?Q?mQdxgGeX3eJs2y6J5htHxQ0cWZZNiVtE3N6+R7ZYA3s7CvqAU/8iq7p1Lnsm?= =?us-ascii?Q?PtplDLNCKgJK4EM8ACAoYP10m8BRYVaNvjRFK1H5ZyZyfKV6ZsMtRyeFKIrg?= =?us-ascii?Q?2ChjQqo+0ik4OhZBvAFf5Byd/m4ToLSVaDsm4pMbQkwDM0+PM4/prXcbO+HE?= =?us-ascii?Q?ULRHD8qI+GK92nGWFvYWmsH8cTu2AL6/m6UPXsSIo1ZPwNvL2nkXzxVFquNS?= =?us-ascii?Q?+tcQ/fhxwBxJJ81627NEz73eJ/zZCz6W1orUskZTmla1MWhrN6irs5eNjFhi?= =?us-ascii?Q?hQbzG28BqL9u0fkNOwZCeIwkZlRbApG4m/MklfL75J1HKSt+KgjzcuwQOSeZ?= =?us-ascii?Q?6R0jJVsJviuu8Pq61k6tA0IMc/ujpJTkE1AyV5XfDtBmm4iFBRiCVw05Uck1?= =?us-ascii?Q?tA18HOXRkauwHYY0A7ba1K6hXJ5xGZqtj7IrDDL3rHfZzMuNHwF7arMvNAV3?= =?us-ascii?Q?RpNuPYXRfCvTYE/ZL16Oq71Vh5VCjC8BgA4E1y/RyuPqL1+ECl5X5Gg52LLK?= =?us-ascii?Q?5gYTVdwJoQW8lejSdKyLChu9bg8mY2eCxYzMKNc5aKpvoyr35CddCG1NjZFC?= =?us-ascii?Q?kBfyd5WmTjYY0LMLtxiozUZqxA1xc8fW+fehUUNVORXkA5EWdvMQ2gBhk7aC?= =?us-ascii?Q?aASXpVtB63TZ1YbY06C3oO8xPk3v6QC3aW9eRno/j31WO5/ojhrDhz9UjXr+?= =?us-ascii?Q?5/ZvNXfN0hOOU9oRZ63ENEYTr/uKqFk0NxDWYwXBaVHyBWFwvLLRqz9NQ0Xb?= =?us-ascii?Q?wI5/2yHJ5VKbBRyr8Ovvw+NPLSZKaoBNOu9y9zlaSjOaFpd9W+3KI9H4MspC?= =?us-ascii?Q?qgeBYg7MyDV2KaiAqfislQA50yX18dskRW59VYHW2DLu+EM97Vm1HbDxBA20?= =?us-ascii?Q?iTCrP5uYQBGf3kJHw48jk+XnB3bjjlJe712lQ+V0xk9i4Jbfv+VUp1Xkvavf?= =?us-ascii?Q?6OgrHcJjM7e4a+NvczDFyOh0EwxDK9PQVZJ0dwQbQsRElgHk1wXHpuMOVhYZ?= =?us-ascii?Q?OfzoR2GQPHRIAOl7Kkhpd8wUXP80+jyy5QhEjY62NNOZiow5Je7DxchO6kE0?= =?us-ascii?Q?/nUWNocEbBGnEPw94+QbfAtfcTzUtZTd/zh4OaSxQRCIGAquwPrwD9Fcgqcf?= =?us-ascii?Q?8Pz2Efm16WdB3CU4HlR8+B2NjMI3e1sxNcVor9KmWbY1+PZ1h437Nbgt6x4g?= =?us-ascii?Q?0gYzdTMWhuW8M7wnBqts0UqiYbIRhfAhCxJGaxQqZ5bU/ufdHZ6kVW+mhbgQ?= =?us-ascii?Q?o2t4nYsxjw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 121e5b5e-c1df-449b-244d-08da332adc13 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 08:47:19.9595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KXgyZSSOGEQ5LkKhhawsgIb8CJJiaYEOVBgaeX9ThWtvX/pHmvNWVH8ECMSt9KbSdkQt0liA80WjCt6ZMnEflQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6196 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Monday, May 9, 2022 8:45 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Brijesh= Singh > ; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky ; Gerd Hoffmann > Subject: RE: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image >=20 > Gerd & Tom > What are your comments about this patch-set? >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Saturday, May 7, 2022 9:36 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Dong, Eric ; N= i, > > Ray ; Brijesh Singh ; Aktas, > > Erdem ; James Bottomley ; > > Yao, Jiewen ; Tom Lendacky > > ; Gerd Hoffmann > > Subject: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3918 > > > > Above BZ reports an issue that commit 88da06ca triggers ASSERT in some > > scenario. This patch-set is to fix this issue. > > > > As commit 88da06ca describes TDVF BSP and APs are simplied and it can > > simply use MpInitLibUp instead of MpInitLib. To achieve this goal, we > > include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and IntelTdxX64. This i= s > > done by setting different FILE_GUID to these drivers (of the same name)= . In > > the other hand, we import a set of MpInitLibDepLib. These libs simply > > depend on the PPI/Protocols. While these PPI/Protocols are installed > > according to the guest type. > > > > This patch-set is a replacement of > > https://edk2.groups.io/g/devel/message/89381. Please see the dicussion = in > > - https://edk2.groups.io/g/devel/message/89382 > > - https://edk2.groups.io/g/devel/message/89455 > > - https://edk2.groups.io/g/devel/message/89522 > > - https://edk2.groups.io/g/devel/message/89535 > > > > The code is at: https://github.com/mxu9/edk2/tree/Rework-MpInitLib.v2 > > > > v2 changes: > > - Remove the un-used FILE_GUID definitions. > > - Delete un-used EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST in > > DispatchTable. > > - Add more comments. > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Brijesh Singh > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > > > Min M Xu (4): > > UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib" > > OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c > > OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols > > OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers > > > > Min Xu (2): > > OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions > > OvmfPkg: Add MpInitLibDepLib > > > > OvmfPkg/Include/Ppi/MpInitLibDep.h | 28 +++++ > > .../Include/Protocol/MpInitLibDepProtocols.h | 28 +++++ > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 30 ++++- > > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 3 + > > .../MpInitLibDepLib/DxeMpInitLibMpDepLib.inf | 27 > > +++++ .../MpInitLibDepLib/DxeMpInitLibUpDepLib.inf | 27 > > +++++ .../Library/MpInitLibDepLib/MpInitLibDepLib.c | 23 > > ++++ .../MpInitLibDepLib/PeiMpInitLibMpDepLib.inf | 27 > > +++++ .../MpInitLibDepLib/PeiMpInitLibUpDepLib.inf | 27 +++++ > > OvmfPkg/OvmfPkg.dec | 5 + > > OvmfPkg/OvmfPkgX64.dsc | 55 ++++++++- > > OvmfPkg/OvmfPkgX64.fdf | 4 + > > OvmfPkg/Sec/SecMain.c | 34 +++++- > > OvmfPkg/Sec/SecMain.inf | 2 + > > OvmfPkg/TdxDxe/TdxDxe.c | 22 +++- > > OvmfPkg/TdxDxe/TdxDxe.inf | 2 + > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 - > > UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h | 69 ------------ > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 63 +---------- > > UefiCpuPkg/Library/MpInitLib/MpLibTdx.c | 106 ------------------ > > UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c | 69 ------------ > > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 3 - > > 22 files changed, 343 insertions(+), 314 deletions(-) create mode 100= 644 > > OvmfPkg/Include/Ppi/MpInitLibDep.h > > create mode 100644 OvmfPkg/Include/Protocol/MpInitLibDepProtocols.h > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibMpDepLib.inf > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibUpDepLib.inf > > create mode 100644 OvmfPkg/Library/MpInitLibDepLib/MpInitLibDepLib.c > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibMpDepLib.inf > > create mode 100644 > > OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibUpDepLib.inf > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdx.c > > delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c > > > > -- > > 2.29.2.windows.2