From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.4896.1663757203735853035 for ; Wed, 21 Sep 2022 03:46:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=VEZXyVjv; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663757203; x=1695293203; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OqxThSqp68sPEobsITKRcQAEGMqR4F6ANQOAGa7rMag=; b=VEZXyVjv0w0X+rwfflHH0rhO5Q667zMY1X88ZnP9QzYMPO+S6aWAdUrB N/T5vE09Y6v/xQCXVT8m6mTIZpZv01VE5zD9niafCGZBEobBMOtK6F/oL V+X81xRiWlwpp0OayLTJLVd8J4Y/JpyjWbcryjVzpRoW5esLRpp7WWqM9 zLmpdBv+XUvJfIuGV7hpGjRxuCX1DHqIzg8dk7jrTyDhul00sFLX9zfHj du2NY25ChHKM3BkN5XJKgjpHOZrsEXXshyyxM/B0Nvygc/bmMJ5iiNTza i01Rn2vfXd4I+PDEOvlq2jv8b8GhmgBxqLJbvGC6gqo6z5x6BI2EapfW3 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="301365936" X-IronPort-AV: E=Sophos;i="5.93,333,1654585200"; d="scan'208";a="301365936" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2022 03:46:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,333,1654585200"; d="scan'208";a="744907812" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 21 Sep 2022 03:46:43 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 03:46:42 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 03:46:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 21 Sep 2022 03:46:40 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 21 Sep 2022 03:46:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVwYdLuTsBkTagxjUpUiPZc3woMVTqqzZ8soHL//4R6RF3TWhsdGm5RLoKFjv2ALcd2qf8Vls1jROr8c6ikrablpjPozhp2IjukTNcJSUAVQimoa6Ski6YXPKkYrbnrc5BTmbbqaJ2h0UEOzp5AzKghsC78gnEUS+MEaAy/Me57yjioADLIRw1O82wcKy2XasMiBtva7iSS0MrpTb3zvIPtGWkVWqbywblQphavpEtMxc+BGOTI59pSewQTt2oQ6C7XaqHgVTt7/GNONt6X4e4DtYpWWXBWz/2Kwu99rwXW4VRiQ8l+ri51m9w7AqOHO/gYJ+49xnx8TxYn/ite+LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zrp0EVu3p+SOnKnTD1AbyntgpowaRYJLcQXfu6oesaE=; b=oSdm6Snm1GxgQC0MEutx7csVJhGPYv/7WVc54xV7wlLhB5iXnhakRVwloFJoGZDd1xhtkvCiF3X6mGo+yPGJE8G+daNTA5n7HjQgJyWuAh6Je/J+ySxOHxt2ekm91Oz5im0h9uwzJl3vhgsn0xhs+T52gX843IxR8krMkZgXk1P1cHFR3JjAdboMQshrsMNk8i3D5Pnu92xEsH/iYQYAxhzwvdgUHBzTiDyChFIv89076oMFDwYHIN8NqEAPZm9V0jbwsjSQl0HYZroJ6a/PsARur7R8bDpT1ULR1zyLReNHhOVvtngdaE0NVRC8u+UmRUW4y6GnMOix9YvqS2RoZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ0PR11MB6742.namprd11.prod.outlook.com (2603:10b6:a03:47b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Wed, 21 Sep 2022 10:46:38 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Wed, 21 Sep 2022 10:46:39 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib Thread-Topic: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib Thread-Index: AQHYwpP9HrnMkybXh0S9Crp+4Ik2GK3ojdqQgADZ6YCAAGHZAA== Date: Wed, 21 Sep 2022 10:46:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SJ0PR11MB6742:EE_ x-ms-office365-filtering-correlation-id: fd6e7f38-1ee8-4e23-5ab2-08da9bbe901e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: amCOEhC4CV/0tJ0GQJlQygFqlwAWppIa+HDzV5cMptrw1xvlPNzg+l46N5ege7Nusd+s4hiYkNH+GgH5wLtSrWL3X9ggr48KyfG4Jien6RrdoPChe6X1MTra6go2/PZwsjZxRaz4HZdApkJz0zSsLAWO5jh1X0WCo1HUq+fG10z+ldu0OZ4y0sNgJpLr4ZGNRwo8znMxfMPj2/iqUXZFgRyKKqK02r98/uhK3liasFphCkjE6FZztIw9u0bPqFhnmP2AFxfbmMv+tb50cqdBK4C40IzDqpa1sB4xW1t2y/oVbGwiTIJvxyurvFGNsgV7l1ZWsKDI5FjmMCoYK0IpJKjxKiK70JUWc+wpucwPknpVg/3tTmNknW566uYRNKLXmZ79psSx8hDL/bZF5mBImLKZXD094m1L6OT8RsIrIqS1XzJMS5P4IPmpw6uorjB0AvP49nm+h3UKPIvCddZR8ItMkYmrN4AzVO+llbFOmVYC3wQoku8Z8mbrqrVNinDcqo3pfw7vhQHwz/5toVO+QiyV9qZRWitrmO5+wT3UwWzt2W/1HAFgcz1ERU/yWzhykFeZH2iyLtAkK1kWzP4yhgv+z3aeNvWSTaRVGQVhQg9iOaFi40EJpuYyAklZrgjCB7ebww6x7N5F9ZTGscOiPWv44bkAW7oor6xs2BISbHHMm390rK3Ozxt6X11MRsg48ekAOK9tvrE51ieTVeJphpI31U+Ud9HIgFZsawusUesVMlcsMRY3L9VKiLNHXtGJi4Ufqwl1IXQI4Fw/V+bJIjDW/E/8sCtiOOAQympQGjZ/XKf+z/twbjPbLSmSj99apRxJLP+iMf+BUE6b4mV5Ew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(136003)(346002)(396003)(376002)(451199015)(966005)(76116006)(66556008)(64756008)(66446008)(122000001)(66946007)(8676002)(4326008)(110136005)(83380400001)(54906003)(52536014)(2906002)(66476007)(8936002)(316002)(33656002)(5660300002)(7696005)(71200400001)(478600001)(9686003)(26005)(53546011)(6506007)(38100700002)(38070700005)(82960400001)(55016003)(86362001)(186003)(41300700001)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zwhx4x0OjZgxR4+Cb11xyedlwaKo5T3WCKYodzVyzvnfQmsEXXPucNaJJc/Y?= =?us-ascii?Q?auuDPyH1oikmq6HOyt+nKRJgehAQfz3iWVb0T/1m3Tcb4i9zwXBtFBXdI/Lg?= =?us-ascii?Q?XyKMvl0FvL5G3AIyW8BJLhDYyuqRHgyZL6bAnOv7V1cjwGCT4G+8ku5qZUQ2?= =?us-ascii?Q?m28x5Bl8pxobbLG0Ru65TCmIUsNHGu58Lq+bE9S7NlizzQrObTKrTIfsR1tG?= =?us-ascii?Q?QILc7iIhcCQHmFe5C5nq3xjy8FcuhWBO6IyDr/bCtw+9GznaFfvP6bry4u62?= =?us-ascii?Q?jXarPAtu8gxrUI/8rzb7SImkaka/rLQ8Ccxn7AMjGQgNeDuh2cpfhMgk8kp3?= =?us-ascii?Q?HyZ1aTTyfENF/RH6lsPyTPw8ELX6IOrc09uwpZ2xVc3RDKBdnVAREfVBluBm?= =?us-ascii?Q?tCGV0x3oyQaDXb8JioAMC3ciQtpi3MijOZ+j0BGAmj6nJtV4mRgqW+KolssS?= =?us-ascii?Q?lLjNWAEkOq251kV9xG6EmpqjT5pQRjJpCMy+k2jUmlqXWrE3ikNJnvloeg9+?= =?us-ascii?Q?FEBshJ4Mf4fMSct/mG1HsmICn+8zSyXEbdfd8HdUcnkOUOVIfgX84w+hUf+w?= =?us-ascii?Q?Bpj2jEYYiqboTsUO7QlT+aeSo3xdgvqRtPwBHj8mNtWoW2v/viX2rq+Cmmg2?= =?us-ascii?Q?8lyQ5b3EywCwac3E75aT63y1wZvNbdSPtimKQVJBP6v4F86wc2h29ZEWYuJ1?= =?us-ascii?Q?dMLLmrD/5s/Fjk5qB0v1XY2Yb28ydXQYF3fRjPV+DBwGLPCYupCEa1Q/iVKy?= =?us-ascii?Q?UPG//6u/HapdUGg3+z95OIboBHuau/yQjXiISONWntDYg5D1bodzo7k0WcMV?= =?us-ascii?Q?mMGHVLLNbDhMutpx3cTcRhWSi4zMTpCEA36xC+YZBMCSdao+qAjbVvcJ9uve?= =?us-ascii?Q?ZzvehqC53cAXWIpVDTdmN/nFgbkj8OeI8UllezkkB83o439cLtVtMaXehoKf?= =?us-ascii?Q?dPMEoYmTnQnDyt8oFU+YD6+6rm8OX/E41EjtmbKNi+8+4i+6z5PgCw0E3RpC?= =?us-ascii?Q?w4bKNfROG6lS4Jn4xU516K7+eY+FtV95AHmpk2SHxPwIlA/W1GuGNRAACZXq?= =?us-ascii?Q?JCT4wfn8AFYcLZjYi8Kh14APaRSId0/l86WgDnIjUWAAm3gaiWeHu4vVJPZE?= =?us-ascii?Q?kTOvRarmmOytRjqKfiekBAXSFxymz5xNQoOqdwaf1G7stRrahkR4+jJZITCY?= =?us-ascii?Q?7EcLJ2qCHCAfYh3vNWLggBIlydavPCC5ghTu426UO85kwHN4GXBVpituQI6h?= =?us-ascii?Q?WMj/9nopOBftT5RRqYP23UCOiQIXSKS6BA+1C+gIM3zTPT1JTzz3tvsIcWTa?= =?us-ascii?Q?OTTZGiGP4eIHlj4bfIoo7EbCwIuR8kalt7PS1Sq4BznxwPYaMLBkS/ogh3RP?= =?us-ascii?Q?7b52voG9rRNxAxj8MyYb71JEihbtenBZjyU3S9DjkD3E+eDQ5BXuRHvB/KrZ?= =?us-ascii?Q?bRvhxfxQ4PzQh2uSleZggwR2vPQi8vJzsv8MUIFRyvAevoEiZooChHwpxOT4?= =?us-ascii?Q?ezdgMpAi1R+h4v+PDJyhhWRJDs94qItIUtILwPnbQuVM2mgIZdVEHgKVoYMU?= =?us-ascii?Q?aDc5OUswfI6lilsN/h5mddGeX1nplCxShz57bHUE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd6e7f38-1ee8-4e23-5ab2-08da9bbe901e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 10:46:39.0190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q+9UN+cViTr6Em74XIxI1QAlxmdxLcQbch0DaHRJ1yXzqDMv8ksme9O9QAthTM0juaU0c7Tg89kEwV+xhbPbbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6742 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you! I will take care of it. > -----Original Message----- > From: Li, Yi1 > Sent: Wednesday, September 21, 2022 12:56 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: RE: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to > BaseCryptLib >=20 > Hi Jiewen, > Thanks for review, changes done. > Since both BN and EC extend many structures, splitting them will cause gi= t > conflicts, > I've adjusted the order of patches: Ec commits are based on Bn commits. > Just convenient for merge. >=20 > Thanks, > Yi > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, September 21, 2022 12:02 AM > To: Li, Yi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Xiaoyu Lu > ; Jiang, Guomin > Subject: RE: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to > BaseCryptLib >=20 > Thanks for the patch. Please: > 1) Separate BN and EC. Please submit 2 different patch sets. One for EC, = the > other for BN. > 2) Please squash uncrustify tool update into previous patch. No need to > submit a standalone one. > 3) Please increase EDKII_CRYPTO_VERSION. >=20 > With that change, reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Li, Yi1 > > Sent: Wednesday, September 7, 2022 4:29 PM > > To: devel@edk2.groups.io > > Cc: Li, Yi1 ; Yao, Jiewen ; > > Wang, Jian J ; Xiaoyu Lu > > ; Jiang, Guomin > > Subject: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to > > BaseCryptLib > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3828 > > > > Review PR: https://github.com/tianocore/edk2/pull/3309 > > This patch sequence is used to add CryptBn and CryptEc library, which > > are wrapped over OpenSSL. The implementation provides library > > functions for EFI BaseCrypt protocol and EFI BaseCrypt Configuration > Protocol. > > > > All APIs passed unit test and fuzzing test, detail as: > > 1. Unit test: > > The purpose of unit testing is to ensure that the function obtains the > > expected result under specific input, that is, to ensure the > > correctness of APIs. > > All test case show in patch 5 and patch 6: > > CryptoPkg/Test: Add unit test for CryptoBn > > CryptoPkg/Test: Add unit test for CryptoEc 2. Fuzzing test: > > Various Fuzz Testing are employed across the all introduced APIs, and > > the test is used AFL (2.52b) and Libfuzzer (clang+llvm-11.0.0) as the > > fuzzer, based on HBFA. > > Fuzzing Pass Rate is 100%; > > The Code Coverage of CryptBn is 100%; > > The Code Coverage of CryptEc is 90.3%. > > All test case show in: > > https://github.com/liyi77/edk2- > > staging/tree/HBFA/HBFA/UefiHostFuzzTestCasePkg/TestCase/CryptoPkg > > > > Tested-by: Yi Li > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Guomin Jiang > > > > Signed-off-by: Yi Li > > > > Yi Li (7): > > CryptoPkg: Add BigNum support > > CryptoPkg: Add BigNum API to DXE and protocol > > CryptoPkg: Add EC support > > CryptoPkg: Add EC APIs to DXE and protocol > > CryptoPkg/Test: Add unit test for CryptoBn > > CryptoPkg/Test: Add unit test for CryptoEc > > CryptoPkg: Run uncrustify tools on EC and BN change > > > > CryptoPkg/CryptoPkg.dsc | 2 + > > CryptoPkg/Driver/Crypto.c | 1016 +++++++++++++- > > CryptoPkg/Include/Library/BaseCryptLib.h | 842 ++++++++++++ > > .../Pcd/PcdCryptoServiceFamilyEnable.h | 55 + > > .../Library/BaseCryptLib/BaseCryptLib.inf | 3 + > > CryptoPkg/Library/BaseCryptLib/Bn/CryptBn.c | 581 ++++++++ > > .../Library/BaseCryptLib/Bn/CryptBnNull.c | 520 ++++++++ > > .../Library/BaseCryptLib/PeiCryptLib.inf | 2 + > > CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c | 765 +++++++++++ > > .../Library/BaseCryptLib/Pk/CryptEcNull.c | 496 +++++++ > > .../Library/BaseCryptLib/SmmCryptLib.inf | 2 + > > .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 + > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 2 + > > .../Library/BaseCryptLibNull/Bn/CryptBnNull.c | 520 ++++++++ > > .../Library/BaseCryptLibNull/Pk/CryptEcNull.c | 496 +++++++ > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 961 ++++++++++++++ > > CryptoPkg/Private/Protocol/Crypto.h | 1176 ++++++++++++++--- > > CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 + > > .../BaseCryptLib/BaseCryptLibUnitTests.c | 2 + > > .../UnitTest/Library/BaseCryptLib/BnTests.c | 266 ++++ > > .../UnitTest/Library/BaseCryptLib/EcTests.c | 290 ++++ > > .../Library/BaseCryptLib/TestBaseCryptLib.h | 5 + > > .../BaseCryptLib/TestBaseCryptLibHost.inf | 2 + > > .../BaseCryptLib/TestBaseCryptLibShell.inf | 2 + > > 24 files changed, 7852 insertions(+), 160 deletions(-) create mode > > 100644 CryptoPkg/Library/BaseCryptLib/Bn/CryptBn.c > > create mode 100644 CryptoPkg/Library/BaseCryptLib/Bn/CryptBnNull.c > > create mode 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c > > create mode 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptEcNull.c > > create mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Bn/CryptBnNull.c > > create mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Pk/CryptEcNull.c > > create mode 100644 > > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/BnTests.c > > create mode 100644 > > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/EcTests.c > > > > -- > > 2.31.1.windows.1