From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 750FDAC097D for ; Sun, 21 Apr 2024 02:46:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QEnfWynjaYTZrw2nJl/ISV7roJ4SHjo/tSvKCCltrik=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713667595; v=1; b=AKjgzNlAUO5JivCARFeyuSq6YGXb/ckE9Hm3z7Q6HaejO14S1QZnY13QAamEF1JFUgRawWMf jxHQgX7zhNfQRjVdLQfedOT4ZcnC0WxQtgsYcZSAAo/POoL1hjc0kRlPGRmzZeJe6qh6oHNVnSK clH39MCHD09Y6vpBcnQ+gXqeieUnLU86lFxE/drJ18WvNy7aN1x/LA4eATAyYgI7heRtdLx7IWw FCsMcZ9431K3N5Ht5iRz15XvLysXTuVnHNW/8UQ+8P4yhiik7lFpSTeXfQ6bLY6Dczz2QinEC2V e9rMh8S0zllvxTzgAP7D6yHRHEo+rrgEI2T/e73WFWssw== X-Received: by 127.0.0.2 with SMTP id jQbeYY7687511xPUzkoECCva; Sat, 20 Apr 2024 19:46:35 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mx.groups.io with SMTP id smtpd.web10.25517.1713667594862076779 for ; Sat, 20 Apr 2024 19:46:35 -0700 X-CSE-ConnectionGUID: GfmdESm7T5KxUSPfkodG7A== X-CSE-MsgGUID: QvynQ6qtTvSTSE4l/gBPyA== X-IronPort-AV: E=McAfee;i="6600,9927,11050"; a="9455704" X-IronPort-AV: E=Sophos;i="6.07,217,1708416000"; d="scan'208";a="9455704" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2024 19:46:35 -0700 X-CSE-ConnectionGUID: 5t+fpoQUTBei4+yHjv1uzQ== X-CSE-MsgGUID: qzOAfbcKS72WjoMNKYIL6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,217,1708416000"; d="scan'208";a="23728397" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Apr 2024 19:46:34 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 20 Apr 2024 19:46:33 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 20 Apr 2024 19:46:33 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sat, 20 Apr 2024 19:46:33 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 20 Apr 2024 19:46:33 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SA1PR11MB6616.namprd11.prod.outlook.com (2603:10b6:806:257::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.12; Sun, 21 Apr 2024 02:46:31 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7519.014; Sun, 21 Apr 2024 02:46:31 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Oliver Steffen , Konstantin Kostiuk , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add VirtHstiDxe driver Thread-Topic: [PATCH v2 0/5] OvmfPkg: Add VirtHstiDxe driver Thread-Index: AQHaklWPcVV7n7ane02stzHD3NPhNrFyBhtw Date: Sun, 21 Apr 2024 02:46:31 +0000 Message-ID: References: <20240419123133.789238-1-kraxel@redhat.com> In-Reply-To: <20240419123133.789238-1-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SA1PR11MB6616:EE_ x-ms-office365-filtering-correlation-id: 5e7f651b-73b4-4c8c-3d97-08dc61ad4044 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?o+HG1ZNSQbN43argUtPA5QNPpL5OG+W0mbIyQZBw+nTeCFpeS31AsfuWiz5E?= =?us-ascii?Q?pC/mC8Pji/enqgYQ4+/FXoyullIQHlDAi6bpwDK9ul/tWltWfvezdlC7dllr?= =?us-ascii?Q?K/AG4+Eho0uRya8lphUMYWk30ISBR3BQUBYyg0lngHl/y6tF13ov5IrRMmoi?= =?us-ascii?Q?Mc91ouohZd9/+rh6bfjx2w0WV8P9ousWOhIPJPsode5Bq/Gqph70FqlsOmAv?= =?us-ascii?Q?4b8e/mD0X7ESWa4LX0rhac/0BxLOaXO1jV+g9w1O5SK0QCC7myMyBl6IaebE?= =?us-ascii?Q?v0yiT8r4jIauImcFrWynaQIWiltTjdnOYu2eqq/gXLZ90VvXgMViE4DbVqp/?= =?us-ascii?Q?eNImUPEd0+DyzfzE/6O8OQQQflzdhJAw9rb1UPTR8shSRBIpSgsq7gTPnawP?= =?us-ascii?Q?e+IYyogUO2LR0tYs3OCn/5iXbzDdfHMHIxkIHht/k8kBxZWieikxm+hX5qcJ?= =?us-ascii?Q?ilYNe+S8hgitHYYqYEsvh5/CN5PISfWV12KAZGAgRhg63aUV7e5+PVM8y/lc?= =?us-ascii?Q?c4n+5j/IQMicoX5/gQ/Ca18SwHK0n/XgywJlMbSa2oQXkXG59+06tPCF6uPs?= =?us-ascii?Q?8SJG7wERB+oQ6YOr8NuWf0vpFf7Mks+cThbYHURIR/XC+FqlRTaRr52cTcUX?= =?us-ascii?Q?l9ta5G1Z+qT63SY2XV/Lfwjagy8MyRPbXwKNABLHtSQ05TWpmwwlFP5muqpr?= =?us-ascii?Q?C+5Sg3Ffb+l6SarCGMo3PnSY477EIYgFNzfSnl4uIPw9yOGt7TjfngGkVoTk?= =?us-ascii?Q?rtblQjX9Q6UlHhh4iZAAOqgpzE036ReNaWoh8CTGtyQ5NTRGTOSu8qIq1ULV?= =?us-ascii?Q?elWCD4dfEJU2lJkPhAlvkx13KWoVGRyE2r4SWU1WKH9cdHFkOO50NTuK55Na?= =?us-ascii?Q?oALEfmc1EVu+OtwkJV//dTW+qpS5rPTVZZG3RC3Y18Oi8EOsbGS3KhJ8R2Aj?= =?us-ascii?Q?0B6XgcNr1yjKhLUMiRSP63TepuIK7eZAnsvqO2DVPAXSTChuBJtCNkf1lFc9?= =?us-ascii?Q?R5kW/458UqhPkaJuOViBU/wdmYHxcuKlk7sS86Xx4w9O8eUhhTSMrXXhgrsC?= =?us-ascii?Q?LWd2wrpxBHWHTufBTb0FCwipjTvrs0G5t3Ylh6Pfd/Brqml1AjMpnhf3yC2Q?= =?us-ascii?Q?wEy0fDiTVaXbs8PKrokSlsKzoI5kk+fUuVsE+bSNAJays0FqC4WCnjkZRxH9?= =?us-ascii?Q?MlysuBuFnCnHNNolpcrZ0fKeOh+b8fVGFErRwNvT6YRdLNkHiVdtPL8Mv3+b?= =?us-ascii?Q?llDKUvg5nh40mw+gHoadVHZtxDW3/7xv8e4mfe/KzNj4+9P20IJgMzivhebb?= =?us-ascii?Q?AHE5b0mueaPb3yw4kXtbiDCeoaNytaMhpQyYWKTwslZETg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Eut0gQzIBBZeSZuuAJneGDrBIz8P3NkmEwKSvIW5huKlNoPnyDz/kYTvBm16?= =?us-ascii?Q?hNcSDt/Ht7xkpG1htcU3uVkxPoUDMoqWzYZ03Stk6S8qTHPn8azGAp4FDWEP?= =?us-ascii?Q?rHWGhkp/QyDKuQB9UG3U4AqXkYZXoc5zYCCtTRg4VsrxeBp8dH60HXQOWvae?= =?us-ascii?Q?MXC/HSd0bAdK5vng5c6TlXL7w6Ocq3BuPR66cm3GdagvZBTVFRnRHQkBWo74?= =?us-ascii?Q?HKPDj2ylSyjwPRWNDoNXChumIvdKzADKCFlAzFGEvTBUb6EHjtHpWHjIOUeV?= =?us-ascii?Q?PxJ4bSO9r1754f7k9TOXYzq8MOrCRbe3OgegJGomgilLlyChsHQ8Ip0zY3Qm?= =?us-ascii?Q?i+1zA8j0JyH5V+cPdG+ehSHy8EZOdpOFvUxkyX9n9sQ3Lq00R+ot4lOEjpGK?= =?us-ascii?Q?kyn/9Sc5iN7uxMvN9RzAeboOGcXXAGEcjFq3fDtruKZmOp0+kcOcYI/xKnGD?= =?us-ascii?Q?38/DVilBDlFo1TFR5MtShiQCP7DFvJ7sOSmTtCtJInGrfFOBl8i4neyzGdkc?= =?us-ascii?Q?vrd87Y8ltVy95nWFnFkRm1kzA9KU4l2B0usHZ5BP9er4HjvcBosSXVr8I/pt?= =?us-ascii?Q?S3S8rW38Ws8qNYWGHefcDoeKuWaJ7nO77qJejpKhmjyQU21ZqhzsglKgGH69?= =?us-ascii?Q?oGYdzGZooFPaErZ4nc2P650abnsZmENDfUqHvwVq9C0g0ijcMq7+6GQBK8jt?= =?us-ascii?Q?ZfEPv2psH1W+Aazu/L0MRUxxwnDqu2NLHz9MFqqXtw/jmrqY6/XY3vZ6m3RS?= =?us-ascii?Q?50ilTTboJHcsc3o4Ok6A1hW9NzNO7s8+Bx11W4TqrnoDF6UcZC3JFuwcsZ2v?= =?us-ascii?Q?tlUblm/O3lMTSBdu7Wh7nMOWUPfHXUMFUO7iJTsPiF6AX4W4jV+55sfx2jaT?= =?us-ascii?Q?SRG1FUwUP4LDUSvytavUpopntEC0oQIECMV9/mDUgKP3X4vRo0duIt6OG6mD?= =?us-ascii?Q?t/bkQGX/a7F+buG4tRBxL/CEcrJ54V0XTcl+fC0SEgro4GC2vK9qjj4Ta4Vw?= =?us-ascii?Q?tzmHdWYEMvYi7cZSHe966vE3nijnLDSQtn9GCSmdZQxuRrXNGGcGgt1xR9kj?= =?us-ascii?Q?DkTtTrRGnFh2MOHYfrq+UDBvoZpf4JiadIf9lm62WxQ8JF9wLufY+T52KGTo?= =?us-ascii?Q?Xkwd3JgBHMeP7EhjxENJT/qtYKfTEQkI8wConLPfFc640Z22iXL15pOpf+Wm?= =?us-ascii?Q?1FIQl8SWyccIvUg11ThWNr044stWD9WmrdkrSjC7Xqfhhp1w7b9+z4FJBeL4?= =?us-ascii?Q?F/+G1HiuB7c89voa4szSlDWHhRIcyQTYiiyA/MfqU9+psVl6nn8O6zdnV2tH?= =?us-ascii?Q?UjSD3RYUujpD0tR3w0W29JsNaUxFmpZGcumncxoqFgknt8WAZ+pLNncNNkca?= =?us-ascii?Q?TtI5qqiwLdNmjUZ9pAjPmgBHDgSyaWVZwapwr4mFoEvcj66k5tbpZliVrUkg?= =?us-ascii?Q?rFzxC3rK1nX3MWAx7lHX7JkW4TSuHoxxw+DAZmyex4eNcLZhfeO/cIHoC6D+?= =?us-ascii?Q?pGGhd9MQlFXbfuVQnqiQPY+0JGjUuN5lBYSkYLw88mMNKh8cvHYbsxBDqYlV?= =?us-ascii?Q?7PFB/a43m3ks1uXC7AIctHEGWyV15k1DrH+6HEFv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7f651b-73b4-4c8c-3d97-08dc61ad4044 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2024 02:46:31.5146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sygpWZJYlDY+rBT2dHG9r0v63PymyFiuV+T/Q2z4B1PRQiozUdVj/zOsjTl5SRDO2nf4ppa8b3oyhL3mYzDxyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6616 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sat, 20 Apr 2024 19:46:35 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: v732sFxNRQYjpmAxnHFzs5POx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AKjgzNlA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks. I notice one more thing: CodeFlash check is using PcdBfvBase, while Variabl= eFlash check is using PcdOvmfFdBaseAddress. I feel the VariableFlash check may bring confusing and potential risk, beca= use PcdOvmfFdBaseAddress means the address of the full binary. There is no = guarantee that it must be variable region. (Although the current implementa= tion is.) After check the FDF file, I highly recommend we use PcdOvmfFlashNvStorageVa= riableBase or PcdCfvBase which should guarantee it is variable region. With this naming change in "VirtHstiQemuFirmwareFlashCheck (PcdGet32 (PcdOv= mfFdBaseAddress))", reviewed-by: Jiewen Yao Thank you Yao, Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, April 19, 2024 8:31 PM > To: devel@edk2.groups.io > Cc: Oliver Steffen ; Konstantin Kostiuk > ; Ard Biesheuvel ; Yao, > Jiewen ; Gerd Hoffmann > Subject: [PATCH v2 0/5] OvmfPkg: Add VirtHstiDxe driver >=20 > v2: > - remove 'Q35' from test bits > - add patch with a README.md >=20 > Gerd Hoffmann (3): > OvmfPkg/VirtHstiDxe: add varstore flash check > OvmfPkg/VirtHstiDxe: add code flash check > OvmfPkg/VirtHstiDxe: add README.md >=20 > Konstantin Kostiuk (2): > OvmfPkg: Add VirtHstiDxe driver > OvmfPkg: Add VirtHstiDxe to OVMF firmware build >=20 > OvmfPkg/OvmfPkgIa32.dsc | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 2 + > OvmfPkg/OvmfPkgX64.dsc | 2 + > OvmfPkg/OvmfPkgIa32.fdf | 1 + > OvmfPkg/OvmfPkgIa32X64.fdf | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 56 +++++++++ > OvmfPkg/VirtHstiDxe/VirtHstiDxe.h | 94 +++++++++++++++ > OvmfPkg/VirtHstiDxe/Flash.c | 90 +++++++++++++++ > OvmfPkg/VirtHstiDxe/QemuCommon.c | 36 ++++++ > OvmfPkg/VirtHstiDxe/QemuPC.c | 38 ++++++ > OvmfPkg/VirtHstiDxe/QemuQ35.c | 71 ++++++++++++ > OvmfPkg/VirtHstiDxe/VirtHstiDxe.c | 173 ++++++++++++++++++++++++++++ > OvmfPkg/VirtHstiDxe/README.md | 48 ++++++++ > 14 files changed, 615 insertions(+) > create mode 100644 OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf > create mode 100644 OvmfPkg/VirtHstiDxe/VirtHstiDxe.h > create mode 100644 OvmfPkg/VirtHstiDxe/Flash.c > create mode 100644 OvmfPkg/VirtHstiDxe/QemuCommon.c > create mode 100644 OvmfPkg/VirtHstiDxe/QemuPC.c > create mode 100644 OvmfPkg/VirtHstiDxe/QemuQ35.c > create mode 100644 OvmfPkg/VirtHstiDxe/VirtHstiDxe.c > create mode 100644 OvmfPkg/VirtHstiDxe/README.md >=20 > -- > 2.44.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118051): https://edk2.groups.io/g/devel/message/118051 Mute This Topic: https://groups.io/mt/105616658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-