From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.13781.1663689222773160358 for ; Tue, 20 Sep 2022 08:53:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hlC3mYmB; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663689222; x=1695225222; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WffrKhj+L5WF5FMYlh3cg0wmtxXeZ47E+TQtBCHMCXk=; b=hlC3mYmBRTOxeqNpkS+l1aVZrf/nEGVg+Xu4TY5NwK6nCU3/ZvJE+7Ko KbZm27ORk7g8NYxoBM7ElDC5UJmsZrSE9GjFnwSC7hqYopmJAbbl2QEaJ vzxHs6nV/cAcuv51XNa3wQ7aaxodYBT2n7Gby6266GGQFhdAcOkAY3fnV vlerTmjzVfY1b8NvEEmp4/NvjGNxQ99qHKhKxesXr0OpEBRd/DGhTksE4 B8XDtB+9OKcCSKVCsoy7EBIzb4XmMwuWIo/0T/yk7XwLCw7Wy+AxppGlf 9QTQtG+yf2jqXNFlXpyUg5eTo0xyZ9wyB6MTeJ1bY9egfZLPdFZdXI/nb g==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="301114277" X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="301114277" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 08:53:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,331,1654585200"; d="scan'208";a="761356634" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2022 08:53:41 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 08:53:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 08:53:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 20 Sep 2022 08:53:25 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 20 Sep 2022 08:53:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfKeGHgJr/ZEA6Lbx9bAFGxBZCglIYxoxRDmqHXDakeH9y9t6hoM1WFMAaQSr+ioSjOJIoSPU4mdbI/K7vvlvMBmxr/MaNgNDm2bZhqOj66wRSrrQlpoOw7Ky1N0diimhkFOo7VhxUFM30oPkeC2csDb0WH7Xn6SfZAD7sEBgSeuF5QeAyeZYV7bCohvu8TV13rVVLIFPqnqzZlAtiRF+fFU+WGuZ334KHCF8254CDxf+bihbzU9iISUeh78hxXJQzAlZFS4oYTeHAD/7zcSXWgB0yBVRahl5o4XCQmUFKENceLag7c7p7aP2zkGtoSRtmSo/XZRxKPsA6JJoACgxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QTIzqmRKtRv80nQ/znCOdDQ4yxB7SD8W7gj1AwnYkQw=; b=SaG4YKwfgI5OANumqzOs+6OIEqIu+MnIEkARewahxj3ZXSspVgIgcOo1DPH4mg5kgMDMUNC2hYEVv1P7JB0TjvYX9Vw9EiCU2CNygbR3CohRMLP6tFsj7TOTqgWT+bpIHYuSr5aMQxHDfHIMlWldYhIMwP3GpKJBxwCpUzCpOQZTgwoGTVl3d5lV4ILoZ2Qg5HvsC2TsPvcO0cClA1RqKz5YrKr5v3y/7ZfEDj6ZelabG0eneSJMMSp4JagIUsZkx7czGunTeOHfu5bvJ+zLuudQy97HuZUkoVxi9T+12IfFgiWZVmJw58NUVqEjx+OuAcBcom9LyMh2VLtrOcU7BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH8PR11MB7071.namprd11.prod.outlook.com (2603:10b6:510:215::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 15:53:23 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Tue, 20 Sep 2022 15:53:23 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH 0/4] CryptoPkg: Add Hkdf SHA384 support Thread-Topic: [PATCH 0/4] CryptoPkg: Add Hkdf SHA384 support Thread-Index: AQHYuRWt/BJQGD0R8EOpR1I2oaAl5a3ooAZw Date: Tue, 20 Sep 2022 15:53:23 +0000 Message-ID: References: <20220826063243.7855-1-qi1.zhang@intel.com> In-Reply-To: <20220826063243.7855-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH8PR11MB7071:EE_ x-ms-office365-filtering-correlation-id: 7df29b75-bec5-45d5-a52f-08da9b203fbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eRllpbwQkfpf8zzVvSxbdVR/ODA8HCi4Okl0NNnqpB2yzKMPOaHrsAel+hlJxHiUROefwyWEHv6bdiqBMrPDSNKifLUXm01uwXhVc17TdDKtzL38PPkrEldzAl1LG85A7HzH//gofzf1RJ4Jk/5La0b0uHBe3iitN6514ND7K3agYhiGzko2zGH+iZbSz8sV17aej+c3YekYNdyFaXLCYOTSOOC1Zwvoo7x2ReFKmV1iPFZFnyKu6wjGKKrJ0P3+um4XWHrPmd8hRMAtilXvSuq4MxRYOkHcWeneLSAwmNPceCVznHQiAcAYb7DuUcvzyO0ok3SB5QNBCevs6WaoANGoPei8jwXLxXDTJrPxFTHyuY9/KADQStHqsvnNB8tHrR2B4l0YER3I8yXojSeJcTaizykOHx74mhc9BzXAH4A5uqHoQ8OuyF/S+4yx5Z40l599v0HSIjO/N1aIXK821chJnqdSs/9rVeNm+gzZYz9P3iZqy7Ei9/GSJiIYVRhMsR+XoHzuWiTGTsEwvM5Z4sE0fXZyg3ay9tN1vAPrjs3pALoqezYeURHmVmOaXLzpBzXgCPN52xya+nCA0T4WhdHsU7UHMfrO0zDKuj1UiRTgmPpN+h/dDDAjnisDkdC4cA3kwCvR8gTXMLOo4Bwj1xhoWcOIPar13+OcnlsxrpR02B2CO9CNvAM0Heppf6jBhn33h01d2cPmBPvAILbnyEHnkWbBpiOpiPSvK8Zi1uDRh1QwvncbmMhQ9Ksx7aP7cFfvu99do3Sy3Zb55aZxn1AtAdDZeLgOi8dWI8yuXAB0IEfR+vRJImVHKBUp2f3oYZApdg9w49nvVcUJEHpSMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(136003)(346002)(396003)(451199015)(966005)(55016003)(122000001)(86362001)(33656002)(38100700002)(66946007)(66556008)(64756008)(4326008)(82960400001)(66476007)(76116006)(54906003)(110136005)(41300700001)(66446008)(52536014)(2906002)(316002)(8936002)(5660300002)(186003)(83380400001)(8676002)(478600001)(26005)(9686003)(53546011)(107886003)(71200400001)(6506007)(7696005)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dKqun7TcQKHyPKR7VIocwK01NUaPke0nBwGHeaBNSW9qdrQgIYjeZHGS4B3f?= =?us-ascii?Q?tY1tapp+8ZeE34stbFuxr6ngY0ZK/LwRtA+uAYwRBmhBNA+db7qHbnPiOOHl?= =?us-ascii?Q?mQqXnNPoUfNpmxb3DnZ22LYOJKdC5HzxdvAi7ShnQyaT0HkXJpKfrm7FIDyG?= =?us-ascii?Q?tGl3D2juGFOTLNAFvPNLOQa43gbXj5qukSQC4x92Cbo2LSZzQnnyfMpk24ML?= =?us-ascii?Q?HL5NkuwgN5+L29vHw4uvlG1kd1K2vfptZFU/bYA3zvFuxmhK+RCAH64K7lCo?= =?us-ascii?Q?V2sff96OhVA3+M/F/dbN6KW911mT786WC/xyA79N+nWZF+YjwuxyYLG8ql1X?= =?us-ascii?Q?61GkpHCqISlEXeTg7s5nXIe7Y2aXXxEw1ubXZFugx8TuKF0sGnpaWZP4XYV7?= =?us-ascii?Q?VNQXG2tyHB46r7mLP8QG80O5oMH7s+mNHionkk2trwr3Azw8DOzS3i2W9Yxe?= =?us-ascii?Q?RcN0L89tobFfhuYifM3FxEep3N217BqtSSEFuKoOM9vZigLt1snwmaXdyRRV?= =?us-ascii?Q?V4oI+euOtHozTavZKUUk/R0x5ZVTwHHon1Dk+qKoWD0qv7A8WbKvHdglMG9P?= =?us-ascii?Q?rFVREUPhFxv9WwATEjss2SejCKaT7eWb5qPCBaiqRmY8Id0XxeJN1jLtSgAr?= =?us-ascii?Q?ns9V6EQrpovXpYayQqt8S2j7OKgZslJlpfSoMupYUuEBjywMTukQ1dTdzlxw?= =?us-ascii?Q?biWuzAbwy64pg8OnOidvwIB1P23Rw0w/mBo09TiPqRlaGcZfCRrLayT1HDTj?= =?us-ascii?Q?3hlbcGcuxGe/HrzK7kKwgaRpD44qqXGi/5iWBPTz8Y5WO4UYyXaxnCGyMhFc?= =?us-ascii?Q?zEu8aSfoy9yyxwS015A9GLiVCDOi/ER8x68BZtxxM1Ir70L1lSeXRAysWwjH?= =?us-ascii?Q?z0hK2HrVAmkcSghieIbAUK+53Jiq4qDnF1ZOq8DaKxUkFwdGi1rQYF2i9FJE?= =?us-ascii?Q?3YY2qWswju7KTGTrATWUA4JmaRcViT/IdOZQiAB0NF8apmghg9B/+/K6ThrU?= =?us-ascii?Q?cMIQ01W2O39YkYE9A5YJ9eDENLFtgmpZrbPQsfJcWx/XAGU5Nn4HwFynsoPG?= =?us-ascii?Q?E65NbxSTKGqIMBqotIyRxpNL+9x+U8EJJ1qbsA9TuejFe2Ec8no0LDCTcJJg?= =?us-ascii?Q?JajWHGoPmQ3tflusQtROjj1L9nGj8Di8N1KwQbNIEd/EIq+Ppe1qxzjtscYy?= =?us-ascii?Q?qREb5Jj5KILmyfJDNqALwaTpXxj+dmxaLY7maRVy2QilruUWsIERThS/av5w?= =?us-ascii?Q?fscFKXjqDrGOk6bqKUxRGCW0K428xDHdGCNU6AFOUdebhCcN12dpJFj0yOpd?= =?us-ascii?Q?GfsuV+lM53Pc1CO+fQMcSWhG6seHxAUVOUjRfZzGB0hPWPZmcyYrV0JugtG+?= =?us-ascii?Q?TPxMkHGnwrd4GAWzPus4C0WVTr6h44yZw8T1CGpyrXt+pNNs5rtZLeo4htSH?= =?us-ascii?Q?Q6oH/shzkp7lUXqoKpQMzCacMZg+GWh2JixeU6LAtJ51ZFjK4CjDvQC2fkjC?= =?us-ascii?Q?QWWkEjS1HiBBL06fLRZwtMPIoOwjO7uQtkiUltP7mBjPAmpdTgCl5OE2H+4D?= =?us-ascii?Q?WRfI/hUAE2e3hlDsNtruICBe3aNyKYElZB/V6dGd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7df29b75-bec5-45d5-a52f-08da9b203fbb X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 15:53:23.6242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eGPQ5QYZ0523Ieem8brjkc3CbP2yDYtqA4POZIcniqT1qkZJihGw/3V2cPNTycy3s0hEyYB94qb37kZ6m1RG3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7071 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version 2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't= insert in the middle) With that change, reviewed-by: Jiewen Yao > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, August 26, 2022 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen > ; Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: [PATCH 0/4] CryptoPkg: Add Hkdf SHA384 support >=20 > Add Hkdf-SHA384 support and Hkdf-SHA256 extract and expand separately. > With this change, the size increase of BaseCyrptLib is about 6K bytes. > The new functions are verifed by the Host UnitTest. > And also it has been integratd in > https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been > verified. >=20 > All the code change is on the PR > https://github.com/tianocore/edk2/pull/3242. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4033 >=20 > Signed-off-by: Qi Zhang > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang >=20 > Qi Zhang (4): > CryptoPkg: add new Hkdf api definition in Crypt Lib. > CryptoPkg: add new Hkdf api in Crypt Lib. > CryptoPkg: add new Hkdf api to Crypto Service. > CryptoPkg: add Hkdf UnitTest. >=20 > CryptoPkg/Driver/Crypto.c | 149 +++++++ > CryptoPkg/Include/Library/BaseCryptLib.h | 129 +++++++ > .../Pcd/PcdCryptoServiceFamilyEnable.h | 7 +- > .../Library/BaseCryptLib/Kdf/CryptHkdf.c | 362 +++++++++++++++++- > .../Library/BaseCryptLib/Kdf/CryptHkdfNull.c | 151 +++++++- > .../BaseCryptLibNull/Kdf/CryptHkdfNull.c | 151 +++++++- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 144 +++++++ > CryptoPkg/Private/Protocol/Crypto.h | 136 +++++++ > .../BaseCryptLib/BaseCryptLibUnitTests.c | 29 +- > .../UnitTest/Library/BaseCryptLib/HkdfTests.c | 202 ++++++++++ > .../Library/BaseCryptLib/TestBaseCryptLib.h | 3 + > .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 + > .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 + > 13 files changed, 1436 insertions(+), 29 deletions(-) > create mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HkdfTests.c >=20 > -- > 2.26.2.windows.1