From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.3621.1674000942506712064 for ; Tue, 17 Jan 2023 16:15:42 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=A1qiU978; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674000942; x=1705536942; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VIgHrWzztVFnWO/crka6DpOlgo0OVGtmfhPwnfik5Os=; b=A1qiU978l3SlRvQrHW6Lrk7nne/lS+nQJxDdfwOGzTghp8ituxfqPudZ WhrrMjNj4svnWSyh4MlmpTNT+u/OG+5L6Reyj87FwRJbFUCDV4OuY9Dlk bKq6+cCFgJYMjoC0Y/fwEeccolX+n3zdMemYDzf0u2p9UpVsirplMD2bK WJHxo+vI1p35DASGV/SFy+8lRDR0sFn1BXWNPSxzD4WRx10azoMTnpig6 eF1mYdyIQFppuuNnVyl1xRN/TyXyRQxdT0d3FOGsy86/436GzrX6v4bD1 aO7NaWshWs4ueA9lzUU2lCpgSddXLl4rOowfBFIq6Y5aL90sr+aGa91xi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="389359179" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="389359179" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 16:15:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="659565795" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="659565795" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 17 Jan 2023 16:15:41 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 16:15:40 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 16:15:40 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 16:15:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ui6KRF+OSzjDWZQNZ/8D8b5v/jG/TYZs7FN0imAZeOhvt54Xi+am6GLsOSQ0XXr3P6nzE7m50vH70+HMKNya4eZ8dyi7RPFmScH8BrAb2mTIvLE4iJBRzZh/Z0nS83OLuvrbDyBXki87l7LSXQulIJ1Jkmf/kUiayqqlsqZB4jH+dzp4CmR8/8zeie8V0qhSJVBfgkvqqH4rdT+4554xWbe0rOMdqRF1s2AE2UsgSsyaEyEudb8McxdzFpXzi80965l+zNlmkcDSoQlfNxOvtyGwU2k6eT7fF/sFs+bDMRxUhZWtzBBji+P4x/0NtAZjL7/FxZSE/Dv7WbdpAFUjTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bPzb+bRdZS0J5esDc33ou9WXKj0Hy3Ty9pENLaUZ2IA=; b=OG+ezY7LG5cav+wgz2uw/InpENzabdmlQnY4iBw21KZKazApNURD3yRFpFGrlivuBjH9hERaHJ19tC9hqPagPZhqlnrL+n4zQPjTFpOk+j5rDv+0RgQDVi0PCUIYO6YrAr3uOwlgLLar6XrgYb0wGKQ/I4vi2jaG9CXD6ooiKSuTLK8sHnUIqjWxsLytMX+gzWncP43qJDCTH8yMACY5Sc03xgzo8mQusbRo1VVn7ktAwFQ9uz/G3Rjzxcy7hEAY5WaIp3QMMYyJUP6jCYKMx56OE0mckOMyYXnydx8CNHGyn5cB4L2Ko2Pwgl92US/RLOnG5XdiOdEmUu1cGIZVZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL3PR11MB6313.namprd11.prod.outlook.com (2603:10b6:208:3b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 00:15:36 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Wed, 18 Jan 2023 00:15:36 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Aktas, Erdem" , James Bottomley , Gerd Hoffmann , Tom Lendacky , Michael Roth Subject: Re: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit Thread-Topic: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit Thread-Index: AQHZKs7h66Igx7WoyUCRcIWbG4HOQ66jTlKA Date: Wed, 18 Jan 2023 00:15:36 +0000 Message-ID: References: <20230117235301.1927-1-min.m.xu@intel.com> In-Reply-To: <20230117235301.1927-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BL3PR11MB6313:EE_ x-ms-office365-filtering-correlation-id: a8da937d-1d1a-41da-7548-08daf8e91f5c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1X2nkxY6J4XMOKzgwFpF0HjRzSaOcM5+UCPDbAmL0Kwf2RLE7Z1lbDZ1F1MZBooQwpKlijUgv4N3++tkbJoSE+szD+UG+xTX9imYDf+pHdWjxogvC4HkOwVdPymGUUN0PTmBjGnyIqiqLBG/SdNJr2BS8iFCaQgTdxMFjBZvj81ErVa6hetkz2BsDyU39wMxnV7wtvMg/WSbi11FV3NHAD4OuV2IuuNXgksTVdcMxg7d0nZRAuuTFtTj24pRQ7vlzEO1YT6y5/QZ05PWxjOgpgxmvuscOwG4kTWC2LMd2XBd1G6Q5DAtW2E4aQEGv+EY1Cx5W/J3Pruxo+ITswHAM1bTRGk1F3gZsnszpYr70/yNEZJ/0odptcNJaX1V0K8mcjJnLfasqiQes3Dxpr7MKNXUz+NNTpYAFipm/sA6yQo7MgXXWEaeaPVM8B26KiYc2W2n4VY1I2azz4J7P2JGUR5PDrVyM8siGv3Ib2Qn3EZgPXnjL6WA9WJg8CKKYnM9G9oXM+u3YLAb1XLs/vdwhJN37w5hJPio3taBLxsoNEjIitlk24CGAMBY2WUvUFKBuGbXwG9bWewYQhrfZay06iL3ddSPQAt6iHhihLRrUuU5x9dOwwJE6ulFF9BVld3yXe1Bos1+5woctm1cBlT59mBrLe0Szoj+mygLthnkkigyP38hQ9Sghv7mkDZA3n1uiXFKOd+auQjwZ2dGYxLOdA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(346002)(366004)(39860400002)(376002)(396003)(136003)(451199015)(26005)(186003)(6506007)(478600001)(9686003)(7696005)(71200400001)(33656002)(66946007)(76116006)(66476007)(122000001)(316002)(54906003)(64756008)(8676002)(4326008)(66446008)(110136005)(41300700001)(83380400001)(8936002)(52536014)(55016003)(2906002)(66556008)(38100700002)(38070700005)(5660300002)(53546011)(86362001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tMuJnQ5xtEJG38GO5ziefq6IhW1oaQU1aCsnjvptMAbYrbG9mfdwd4+MbGsx?= =?us-ascii?Q?uZNgY7hk/lBcboe8ksPAiTze5bcmwaAZ1wliJQBsQjY47snSgBknmhLVjhqO?= =?us-ascii?Q?QWlHMdNYteMZcHGQeHZfRLjF1ls4bihUaVChc9a1iMg2qwgSyHDb5zYmtVx2?= =?us-ascii?Q?WUbTVo528MNJ8ouaadoXwwqfXBmdnkIow2YkjWSmo8gG8NxUWL0Qlkj2cPht?= =?us-ascii?Q?3rmCVeNX6MDOWlpyIwazBx/fUfLPPNUdbu9ToWDGqYpQ8pGw77eqn3jA/J95?= =?us-ascii?Q?4ljDPGRsD4QAg2ceo+vAImqVb9tFySAvOHQrlmc+H1xk7T8cm2lFfp9PhFiz?= =?us-ascii?Q?2ya699OMZ+UuWNE7mg1joQ5JkUS5ORWg9HpLxZfpSCUti5CJVBs5Jw/kbnJY?= =?us-ascii?Q?0uGsO73euGrqKH26XG2+Oy38Xs9YNaVgUQL2oySgm3USFaXb5iM/3kNkm+xA?= =?us-ascii?Q?VORh9ljNzk3cL7DSMCaoriv2QDxlsAeQ6pFrWN9J3mZDjN3qTxHpnYExpOXG?= =?us-ascii?Q?Rl1oJGEtnysQbVTd7YY46P77a2h4SFBNu/xAnpFHM4Dh/jZHOMstlB99tEjP?= =?us-ascii?Q?CRtEj4rYpPiGDk5Nw3qR+rP5dJbVjinoqa+Cg76LJ7tOvgLETbWXox9NMm3h?= =?us-ascii?Q?WRAmald5/gYZbcgCkKaCXNg2SzlmV/wOflzQzT9KXqXMAzDrhP+Yr7BRnfWn?= =?us-ascii?Q?Fwr25eFYl3yaVvlQUKH3oRdmnDznnOk+5hA/c0uji8m0TstIZc4LKprCJNVh?= =?us-ascii?Q?+FJhIJHbAnj/quoXcR/QGtVGYjzoel0PgRRrHduSCFjkr7ryfFdFonxG0pBZ?= =?us-ascii?Q?WAf7hD/ES75OozZbx5p5wccwgxmwE293mh3yO6nPG6Ta6uEErhKLsAWuw1Jp?= =?us-ascii?Q?22bPyPuIHY1TYVjm8hLGB3jjGOVKv6U5cJiYW4E1+l86v53mlvXE3DnP9Eol?= =?us-ascii?Q?/PNK+J4T62kNzorJDr5x3PEMoYQUsVavVUtcD48YJDoEUh7FNAPslc6QJSCx?= =?us-ascii?Q?lD+MSo6Gr1tRj0HCA3pqKsP1ftuDywo4GjTpFkydzvMOuuuoE3hiP46/e41K?= =?us-ascii?Q?9Aqoamkod7v9oaekm2DvRErbJIJ0NEtLXPPg+rDTw9OLVF6+5Z8QfibuKMKQ?= =?us-ascii?Q?jyVgLBTQkTb4m5i5/Srj1k9358QKWX8CwAkEw8tK9g5TKFh2J2F1/rjUFhrd?= =?us-ascii?Q?c5Jdb6fKPiASztGizGAPZQrP6P5aOR+aIoyNYvNXzBiI5cURN3NCm8B3w0Rc?= =?us-ascii?Q?qg5pjpO7cUAwlhIbjwTbTTDu0y0IRYXhGxdAKH4vtqsnXEgngT+p6db3qLl5?= =?us-ascii?Q?PpTqIeGIQ84yMlFBLJvqs4iDi10DByDQHLqgAKKB/8ugeZ58o7zpcclf8D+m?= =?us-ascii?Q?Q4KKlxwll6mlZX3QI1O7NVlhXZQt2YjQ7g8Oc0OEuQVQ+SrMCBuCS2Ov0iLh?= =?us-ascii?Q?5BmgRS0ia9yc3qDY8LDmNqeLfGVPSaQdnHN94bHEmLky1k2cSLgVHKizQ4tk?= =?us-ascii?Q?DjszhbGJ2nMR7butBUOdywe4nt9bSvViu4wTh2Hzg/gYYF+Y5bvYgmr+zfvn?= =?us-ascii?Q?/dT+EP4pVbbuDkoRVCvZxtRfOCmpKCH8dWiZU432?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8da937d-1d1a-41da-7548-08daf8e91f5c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 00:15:36.3411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0TTlyp7t55v7uN1kNivnxIK1SaAGkL+Ge9/66C53pGe2o7lGNUIY+RFkfk8V/P+Y4nOiET69AJwv4XkIg3jjGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6313 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Wednesday, January 18, 2023 7:53 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Gerd Hoffmann ; > Tom Lendacky ; Michael Roth > > Subject: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit >=20 > From: Min M Xu >=20 > Status should be initialized otherwise it may return unexpected value. >=20 > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Michael Roth > Reviewed-by: Jiewen Yao > Signed-off-by: Min Xu > --- > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c > b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c > index 30d547d5fe55..872f772a5ac8 100644 > --- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c > +++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c > @@ -105,10 +105,11 @@ IoExit ( > UINT64 RepCnt; > UINT64 Status; >=20 > - Val =3D 0; > - Write =3D Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE; > - Size =3D Veinfo->ExitQualification.Io.Size + 1; > - Port =3D Veinfo->ExitQualification.Io.Port; > + Val =3D 0; > + Status =3D 0; > + Write =3D Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE; > + Size =3D Veinfo->ExitQualification.Io.Size + 1; > + Port =3D Veinfo->ExitQualification.Io.Port; >=20 > if (Veinfo->ExitQualification.Io.String) { > // > -- > 2.29.2.windows.2