From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Michael Roth <michael.roth@amd.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ni, Ray" <ray.ni@intel.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Xu, Min M" <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot
Date: Mon, 21 Aug 2023 14:53:02 +0000 [thread overview]
Message-ID: <MW4PR11MB5872D9E00DD90DDFF0C23CA18C1EA@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <giodnj76ql5rpyh4jlx4peaaotgixoezihicfdkeox7mxd6d2r@25gbw3qcpdw3>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Monday, August 21, 2023 11:29 PM
> To: Michael Roth <michael.roth@amd.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Xu, Min M <min.m.xu@intel.com>; Tom
> Lendacky <thomas.lendacky@amd.com>
> Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure
> during boot
>
> On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote:
> > Booting an SEV guest with AmdSev OVMF package currently triggers the
> > following assertion with QEMU:
> >
> > InstallQemuFwCfgTables: installed 7 tables
> > PcRtc: Write 0x20 to CMOS location 0x32
> > [Variable]END_OF_DXE is signaled
> > Initialize variable error flag (FF)
> >
> > ASSERT_EFI_ERROR (Status = Not Found)
> > ASSERT [BdsDxe]
> /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.
> c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >
> > This seems to be due to commit 81dc0d8b4c, which switched to using
> > PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That
> > pulls in a dependency on gEfiS3SaveStateProtocolGuid provider being
> > available (which is asserted for in
> > BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()),
> > but the libraries that provide it aren't currently included in the
> > build. Add them similarly to what's done for OvmfPkg.
> >
> > Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using
> PlatformBootManagerLibGrub")
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Signed-off-by: Michael Roth <michael.roth@amd.com>
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
> should be added to the stable tag.
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107923): https://edk2.groups.io/g/devel/message/107923
Mute This Topic: https://groups.io/mt/100787519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-08-21 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 20:11 [edk2-devel] [0/2] Fixes for AmdSev OVMF package regressions Roth, Michael via groups.io
2023-08-16 20:11 ` [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot Roth, Michael via groups.io
2023-08-21 14:29 ` Gerd Hoffmann
2023-08-21 14:53 ` Yao, Jiewen [this message]
2023-08-16 20:11 ` [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti Roth, Michael via groups.io
2023-08-16 20:22 ` Ard Biesheuvel
2023-09-05 13:33 ` Gerd Hoffmann
2023-08-21 14:34 ` Gerd Hoffmann
2023-08-22 6:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5872D9E00DD90DDFF0C23CA18C1EA@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox