From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 02E4AAC16AD for ; Mon, 21 Aug 2023 14:53:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4DzlNXnWZS52qXBR2fnRppUda6QXWJzHedbnjM1eBO8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692629588; v=1; b=APHRn82GvtwADHK3X59RQk06k8FFpsJZyBA32XFHGx5GY/wBitmmyBWtXKuHSGFBI4dRGHe/ 0XuG3H3Ip5pH4PNYPTp0FJpX70nd0Dh0iQgGmno5Zhlz1xdQA8Uoa5iF1qtbUG33TqmlUaj/WmM raxFqWTLsjqIdl/vNJbLCrr0= X-Received: by 127.0.0.2 with SMTP id YLPTYY7687511x5RHkJyIQSW; Mon, 21 Aug 2023 07:53:08 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.1435.1692629587717619344 for ; Mon, 21 Aug 2023 07:53:08 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="371040010" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="371040010" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 07:53:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="685680858" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="685680858" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 21 Aug 2023 07:53:06 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 07:53:06 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 07:53:05 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 21 Aug 2023 07:53:05 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 21 Aug 2023 07:53:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gGW/fCFzeCe6h7PuxU2dbcZGVIpz/r5HUpwLY4SUGftRS1Ds4DM8PI6YaamA8foFXjKs9iZ5WLo3x+rs8hGgUyddOUA0xnUqDt9PGc7DBbAo1VLd/v7LpBwcVv9kTwCmyl+f00cR8vUDx4mYG2TNJ2Gk/Cv5tCHSYUa05n2m+NnAAti/7/e8fLGA0BgQlg+w+90HtZAiK8c0ryv+uXna6ty2BBSvJ/HjlQIzz1tFZlaJY6jfr1foZEpqa1/EFq5YshcW/YwA0HUKcT5AQPds+l4YHKZ/KTjmGCMACX15ARGHdxxil6s1UhRH7rJRDqRlWg67pkOuUmximcM7Dt9svA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TENMrEtBiKWGAtfIJ/HleTrLHuF0PK/xvZk7yN2aSHU=; b=VvTEs4fh2YJrctNDk9SQpyvups8gtTGnaj56xVG8Cs4tpAYYr5aIILNfGE0IeyZWgXNGi1dqjSIAmNyYcuO6zpWK4HYvtrsdq+YyXNjrX/X0s26+Ep8kWYkz6Lp8lNFLlWcFeR8h9GiwwX4MipbfWWzY7KSMXYurUw7ISXF1S84o+dtKgIkhw/QuL8YUhn3JJmrcZrZ/fajGj3Iuoz5nNhhehBnVXaFz9LywQql4QMpdtX8DBI/Fa5dL7MxPblhtmcBUAJl2STiD+cnrXRZ0+ezA2q91HW3EnIqZhnXglLFotFjRJn7/bfQjSUqwTes0rzA6644mdmYZSdM6PhhGSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SA3PR11MB7525.namprd11.prod.outlook.com (2603:10b6:806:31a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 14:53:02 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 14:53:02 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , Michael Roth CC: "devel@edk2.groups.io" , "Ni, Ray" , "Aktas, Erdem" , James Bottomley , "Xu, Min M" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot Thread-Topic: [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot Thread-Index: AQHZ0H44UBweZB3tOUyR/EPwB/73yK/01qoAgAAGoRA= Date: Mon, 21 Aug 2023 14:53:02 +0000 Message-ID: References: <20230816201146.1634348-1-michael.roth@amd.com> <20230816201146.1634348-2-michael.roth@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SA3PR11MB7525:EE_ x-ms-office365-filtering-correlation-id: e5b8801d-1824-4e49-2df7-08dba25651b3 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kowR4OtCuSXFGVhxOJWpxVOSLSATU62HQcOavPlwBt+tZ3J/lkxdF15b7HMfDH3NrkT2zCy5oaFQQ3XwnZVCdDwnXXID3EYYDVqi+4vmpv6e1Gh14VDdjRPWV48gymQVAsJO8VNepaHhabeiy5VR1hd2vrOQTljJf8FqTz9E1qxPN2DMj663swJg+BCHAx0TPOlOJoJdbX+Y6RBClVh2ErnZUWc1UIVvgan35PujKHvxC+US3iKT2W0ce5WgdTupnqh0E/QzsZ+4XZypwnQ1I7mng5ASgdfJvAFH5ygx0AQz1Gp8UumOi25kXuam8OY9pDeA9zSGa0TB8XBXyZUhOciCizq6JN/UlVP6g4/gXB1zem0J4fTOd9SneglvSHfF4RNTT3kRoCzvX6q/8oSCuFLwbsmdg7LpQ7SjDkYsceR2sZmE+sKfpExNj8hdOzMpVlH4VWYjcR+sevwPjRwOx4oLAagBdhCxa1HQPw8KNrpQCrt1oPj9/Y+Vl3NMrQvCbFWJTozq6PeKgjuqFuS7y1PDHbBYA6b2dGoOsAgfOiw9tsYAgeY1CrLY3Aeccpmt3Do/26CMvX8eHcJVElytHe7nMpIGQ5i70hbWWmp5vJBFW9c6zzqhBoFpNhS5rZ7S x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G09+5P72ZxY198vwCMdCcidild8egLtgQpjdh0Mqop2hWQ7uJt4pu7/qFNwW?= =?us-ascii?Q?uW7/8Ybr07pQbgVFHm4Lve8mjR5IbtWxuFAdirTKlnSuCS3cqxAyU/VvrgJ6?= =?us-ascii?Q?BQMHTLeHe07cs3FF3P3lcBW4CptsAy8zn23F3Q6uvXi7FNoilIUF8ZqMXaMJ?= =?us-ascii?Q?8JpMVBhBNrvNMK5xuZW6++NfN44JfOFEredz3gdS5aQOQSDJi5jCgml689BP?= =?us-ascii?Q?/4Oo07dVVx/bDKOGFju06mXEjv+9S1vMj/SaE0PJVp8CzgAdUV7vYN26SshB?= =?us-ascii?Q?3UpAJYRHC4p4mKDqlchmr+f3JPskKJEtdXqgVdE+7Yx1yyexnT6af+H4Yn6W?= =?us-ascii?Q?wohklxFE/eDpZGJwialWZBBasKAxCGvYRfmpeyf+NxgPkQq/2v1cDqUekawh?= =?us-ascii?Q?LQkDfeRVL+TGJGyXLzJTw3+N6qFX9mAcQvDl+6EHweIMHpDFPcXJQ+0lnhMs?= =?us-ascii?Q?caQ1PhvHRGT0BOPWY29YQBnvJBpqN6WS55CStaXEId5+HvtVlp//bBhTVepR?= =?us-ascii?Q?Cs3UBoCNVw7VLcIy3EBFEkIMjKktgWicO8Ksl/S+1aOgLqgcXRi9WCFJi5Ob?= =?us-ascii?Q?TKlxzh1yGc3TvxbY29DXGTFki2iez+XcbH20aqxy91TucK6pCJ5p/YgSahNa?= =?us-ascii?Q?gRe66MVQXqHqU4PsoYFkRXgZW5LckmN0Nr1IWpnneJXWuJyfWeedeJpA+ZpK?= =?us-ascii?Q?oot5CNiMemg1Jr7EsBC4IhZqL96tNGfIyzGhURovLLUOJQicFRykBgm70Mqj?= =?us-ascii?Q?lWa7btBridOe19J2Y60OqY4HY8OJD2V0BVfrexRnkMDx9AFc+uYtvo9PHdNc?= =?us-ascii?Q?4qXrL8pZ6RwzGpFLwNfYPbWYYi/nKRIF+QxNNNT3wHWGXsGkhz/axr/oP5BG?= =?us-ascii?Q?9PvutCfdpmhEvBGVfn6RA+WqgLlKXz/UkRRREcH0E8MxMjUEGxtcRQ8gbUDl?= =?us-ascii?Q?snhEBqz4PMm1b09sSsg9RSSO1jNoD3IwNe1tqBMYbuWGMLzDimLfNPuLieX8?= =?us-ascii?Q?S4rHCxjn+mOXlaq8U2p0sEUVEHcD+gAFw3oonoeM/aM7b753YfVTcs3yifsI?= =?us-ascii?Q?Eq0u6TJoqF5p5GpqwI5H6Lo3SOmfkAY0sMHqyda8lFpN5DQDRQjXA8jYJaj3?= =?us-ascii?Q?MFJXsw0TJGKjs49fWyroNG5j7rNnYr2Lx++o/b+sgq84o1fFtlFr4gadroB1?= =?us-ascii?Q?J1L7fNCNNZS/6ULsQ0vpyg3eMh/cUvVgWLusuVBiumHC5UgH6JO/xcm9UAkp?= =?us-ascii?Q?UrJYV3j7i7v2pl9ClwEoUJFu3mSwENt43TRu2abAY/6ZMxGlz1IFEdRyTvX4?= =?us-ascii?Q?PdVtNvL8NSZGHuLoPZfx0KYbcKGvcl1ZnB9eN3EuLiO0AS4/tnNJlGJKKpnQ?= =?us-ascii?Q?vsmrKnUT3MwD1zXtLL++s2xAfMwCOfkp+AQOYvmbDw+GxEwga7TqUZTNUDu5?= =?us-ascii?Q?bdwN0rEvXzMgKTMFTlhISCFPDwSaHDDi9jZw8yAj2yt8gqCOF/JNnRoZGiob?= =?us-ascii?Q?7gBM8kLuoiK/vXGBRcKa0qyU5vSoO1PoiXCTk3LYh/E6FJqiQ4z8p+fJKqFP?= =?us-ascii?Q?8G2TqR4kSpITw5Dt2Gjo0AGqkaw9/Sx1zo937C0c?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5b8801d-1824-4e49-2df7-08dba25651b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2023 14:53:02.4585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o/naemt629jcxtR7fEdjj/i1psH2f6QdOg+kOBKXNPNCnCq8WJ/oGFqDNg8rfTlVZ7/pQB5q0yr0r4Ci4xdlAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7525 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: osY0lCuHegXdgJIKEbnYN5kNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=APHRn82G; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Acked-by: Jiewen Yao > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, August 21, 2023 11:29 PM > To: Michael Roth > Cc: devel@edk2.groups.io; Ni, Ray ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Xu, Min M ; Tom > Lendacky > Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion fail= ure > during boot >=20 > On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote: > > Booting an SEV guest with AmdSev OVMF package currently triggers the > > following assertion with QEMU: > > > > InstallQemuFwCfgTables: installed 7 tables > > PcRtc: Write 0x20 to CMOS location 0x32 > > [Variable]END_OF_DXE is signaled > > Initialize variable error flag (FF) > > > > ASSERT_EFI_ERROR (Status =3D Not Found) > > ASSERT [BdsDxe] > /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform. > c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0) > > > > This seems to be due to commit 81dc0d8b4c, which switched to using > > PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That > > pulls in a dependency on gEfiS3SaveStateProtocolGuid provider being > > available (which is asserted for in > > BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()), > > but the libraries that provide it aren't currently included in the > > build. Add them similarly to what's done for OvmfPkg. > > > > Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using > PlatformBootManagerLibGrub") > > Cc: Gerd Hoffmann > > Cc: Ray Ni > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Min Xu > > Cc: Tom Lendacky > > Signed-off-by: Michael Roth >=20 > Acked-by: Gerd Hoffmann >=20 > should be added to the stable tag. >=20 > take care, > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107923): https://edk2.groups.io/g/devel/message/107923 Mute This Topic: https://groups.io/mt/100787519/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-