From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.6918.1679379863736026334 for ; Mon, 20 Mar 2023 23:24:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=fLH6Qzya; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679379863; x=1710915863; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6logGEfxM0yO6V45rQemmOpCoYM8Le6WLfTxDgUhQZc=; b=fLH6QzyapZd8SshA0jOrRctdXUKlqXzzRqbkdCLCv6g6d/fWZ9SoZB66 sGSWZJM04jMVVgsHYJ8OjQgwS7svKlv7sennErUTgSUMC44BDPC8B+gjc kITIBPlGcStu3msYmZripQUeNt2SHxGiI1HmpvC9AONXmZsnoUZNpBwPu Qc89c6zan83YSsS0J1O1/sktjoHuisyZfgPigF15NtCkOanVIMfHnAF+U PsLIz5elsh93jR9NH0jWwtmJK8rBFxTLaxb/WS/vvo9berjixEBXVPjb4 AT0o6Nck2PALT38vQMMuv1jctuaFpuo2R/h4HRvQ+AZgpz3kQqKGKs+5W w==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="340403935" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="340403935" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 23:24:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="745721902" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="745721902" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 20 Mar 2023 23:24:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 23:24:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 20 Mar 2023 23:24:22 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 20 Mar 2023 23:24:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arGxFq8Ix9MIdk2xe/zn7je0T88zOSdcqzgMydTTeAqmCQpXfk5XvQ4E9S0b1+1aisj6l2Bz3/4n25YPnHpRsCcVzSKDqA7/oTbDXzgTUoWyhwcwT9ILlpSxjdpOTc5fcTRcq383fsBXZTjNnYc37SocKDr/Y4xnb/Z25FfTpBMYjJc7ik8TLC2SNfkMugxrD/8y6NwPZM2hWPQ+nXtg2xZnSg2eoHHYTsJ1lB+E2z0GdDHcmQpqtXsem5AAQO5LfM/mo3vKOZdv1dNVa/HD1wX0UD8Q6CtS0TOPTfQQEdH2lAsAMbM37dH2pspDakxnd+rRUU7CKXDjRk6hV6x78g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qkbuaQ4maP249W2ZJ9htc4ymETcVDVB2Rj3wdO5whDU=; b=PUtli/VtB8JjT8avSLf1PfMpLgY9srlTs2Hl+NfoNgpeUDVQPRy22YouNlI9onOFOGynjRz9xykMPnQkblT1v6CVYjFT7z5a3Ix89ac1OpXy5PaacAKIPP0LEtMAyCtd5jc5mI7o9HFvTx0aScdmyXs7MQHw0hrL1reZ6Wdckm0ARA1xlFhXudK5uLJvtMEXcICuQgBjoTOlNGISHR9YOGVzX+bh91CjrbE3ZD8UZZ0znUZQhVW/KJwI7HTbV83eoq++cl7ID5FSfLC0pUEfrqpZkJnPWtcxAHfoL1VG2qWlwWzyIEqCTHlaFLxuW+90OCNfCImGGwTNm/5UhUFIqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB7075.namprd11.prod.outlook.com (2603:10b6:510:20e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 06:24:19 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c0c0:4b46:1dd4:80d6]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c0c0:4b46:1dd4:80d6%5]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 06:24:19 +0000 From: "Yao, Jiewen" To: "kraxel@redhat.com" , "devel@edk2.groups.io" CC: Pawel Polawski , "Wang, Jian J" , Oliver Steffen , "Xu, Min M" , =?iso-8859-1?Q?Marvin_H=E4user?= , "jmaloy@redhat.com" Subject: Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2 Thread-Topic: [edk2-devel] [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2 Thread-Index: AQHZTbv5ATxtbkmMjU+2TqglVnCmYq8DipcAgAA3TICAABv9gIAAwElwgABB3wA= Date: Tue, 21 Mar 2023 06:24:19 +0000 Message-ID: References: <20230303103553.804781-1-kraxel@redhat.com> <20230320100208.xhoz7smo5fkhal26@sirius.home.kraxel.org> <20230320150013.ykcaxygkburz4m2s@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB7075:EE_ x-ms-office365-filtering-correlation-id: 8485e4f0-d883-44a1-f9a6-08db29d4e794 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cKRdASgD3KmpPuZOyb5s4M0nzY9eLyPn+Pv7cjwzkwy274Vw+59EGElJ0nb9iYFIhrY+5In2BSnVhjH0A/9ycGTNH8463ACUQX0g56rur1vpXGS7XrwJOj5gwlaPi0T/7O1rvTrUP53mvmFKgsynVhzHetS/TcrHt1PlcoIodpsL72pVeX8JvlbSu4a/F5R6ddCCP7Ywo2YbHx14lyXJx7Jcp/NlYzdK+0v0YXfIU+QzxMtDfzQee0xgqIOzBaRGB6Xem2iYJ9izlXzLt3DDSKp/AMhGlIy3AeolkLDvGJNlgyjrOHTongCM0z2jefZcQmptuZU53voM3HZy/FCWNdDr91P4ZVpj3oP0QCUEnygwJN2WlbmEr0eImhGJCSOHcLC/b+Sd5ibJ4jjrHSUr0eiSoXWSP77o333rb0iLloohHZhH3RyC+yNHz+puwsD1LchcLYenlY97I4/EzFCBxY7//yuAh2H5IRECxfw4LfGZk/pILGgwIm9NrBOIYfNN6VtkyAyYQwD/akShFaDxq3q86LfoNolilWkmjdCwapSeHS394LmlsxpO8jKPMCVbFAPVJ6cOb1fd9VDA+ukUxdVwJetCSx68wMaBg0Q142CH3rCTQvB2b0LGAbs6/tIHtw2uswP0SdAA7B2vfox4dWXxyyYgx4yr6qHDq2NO/KBj3i44owGoakI42dD9weqgdg4cCUgzMmTzqR5Tc4/a4YBD44jMWRMNWj/UbLSEln4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(376002)(396003)(346002)(136003)(451199018)(66899018)(52536014)(8936002)(15650500001)(41300700001)(2906002)(8676002)(4326008)(64756008)(76116006)(66946007)(5660300002)(6506007)(33656002)(9686003)(7696005)(66446008)(966005)(66556008)(26005)(71200400001)(53546011)(66476007)(316002)(19627235002)(83380400001)(2940100002)(55016003)(186003)(86362001)(38100700002)(478600001)(54906003)(122000001)(110136005)(82960400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZTu97WaBmvnkCoKtZFfZRBgQc7F8lQrzaowmXL/viY+mGDGjEVImeSMlf+?= =?iso-8859-1?Q?DHEHNfnZShWz/MU6QVcNByWMQrkMyf9muCkm19ACe5MrrjQNgocko/1YXM?= =?iso-8859-1?Q?BC1Cz0aLwf7SujgNDImPCTdkU6a5C1IDpBI85msdqFHJVm1uveMBp1O61P?= =?iso-8859-1?Q?mh+qkbZkjx8dH0JscpEW34A3Csvhyll+nCrJBzRYdRuCaDyOvs3BeVL5Qy?= =?iso-8859-1?Q?sJosiqK5pCiX2wOlgMRkcUHR9Hf0HoKfAWCPmDFK7HgZVlCSjSRlP8+XJj?= =?iso-8859-1?Q?Cu5igHnqML/8lxH9P+v4BwZGof5HRAGxYlbg+VA14QLfprk94m2OPcIgdv?= =?iso-8859-1?Q?EiBo2YLnYQ2t2Gnz6Y7Yb/R+FF2Go+9VbFrARvsxSCti3T/0PIm0Z9iVeS?= =?iso-8859-1?Q?yguHmxvNwtwD57QtA1ZKS7175+dpEZkxqmUenNIwNyQsH//94kMKgxZzr0?= =?iso-8859-1?Q?XydDky4N86Mgi3nESQBwIewfSke887UHG/URRYERvfB7fLf94/mwz/QKMK?= =?iso-8859-1?Q?SXoNE8eorx07UEnSqLDkCSVTedJMLB+yLHxkSriP5mrCxr/m9k5nr8mpOX?= =?iso-8859-1?Q?BScIfuNYOn5EHnmXz5R8E3UTLgloC6J5cAOJ/Yv/F9IcDJDYQ2YzehCjT9?= =?iso-8859-1?Q?QfjxjbUnvru0BkMSOj2qHhMoXcBBp6KuR/k3vfRdqxgO7IcLpSbhdPht+D?= =?iso-8859-1?Q?PzhEwn6mwJUorEKX6mmz3L3TCfL/8QP4eoFQrB5s177RPIMDZdplnEyzmc?= =?iso-8859-1?Q?bs5XukkZi0Wny23/6vM9d4XQr8FXSjHVAlvJF+sX69hrnO/Tc2+LTVkxuW?= =?iso-8859-1?Q?3U1dyfSzCNp6pzfpi0x0GgFukrT1RhbE0KL6C66h5eCYVX6b+w4YBC7xTk?= =?iso-8859-1?Q?93ZCHZpTgN29y02xjx8gSRHGfJE8FlgvRzG1ow0a5EOzyc8RZB08+LcVeR?= =?iso-8859-1?Q?LK5AFTOa50beIbGMJGAKe5/VdMzi5wTSvZARK8i6WWQ4ACcPXTId32gm38?= =?iso-8859-1?Q?vQqcvF1Kq8VlOsfodS9k2I70oC4SxFNuRROfaKKKT1i5SycOcBjxUGdMgJ?= =?iso-8859-1?Q?G73mm15EpIsLWNjmrcdbZa5MAUvfV+xBbgDJ7qihmt4DF/le9oty89UJlE?= =?iso-8859-1?Q?LUSPHNuzyti0oXyOYJOCLL9Mc2iLO+illfjE09uExwGCj9OMJ8t0fLMPis?= =?iso-8859-1?Q?kxAvtZyNRkuZsn41dZ+snhEUov5gvdIhd81L32O86KZg6A8oJQyX9luf2I?= =?iso-8859-1?Q?VCCnHaf2LMpdyIBVwn9O3G4hekcwNXW8aUb5nD9jm8UdgxI9kDMr9k/boj?= =?iso-8859-1?Q?B3aDrbRchyTKKfCsHFj3n5En8yAunxisYqgKFnqWk8BNF1TcIWQKWZRBM7?= =?iso-8859-1?Q?PtRNXqbgYvXkOo1sh/m2g5huhWAIIMkaqZkudSpTiIzAAFZ4ikNt6nuCWX?= =?iso-8859-1?Q?GcVEQvKPI9pReeakrYfXECK+h5VX0NmBI0vCpbNGH3biqSWlgLDS6he2vJ?= =?iso-8859-1?Q?v4btZJmuJOhax2hiLTRZ5d/5s6loLjRiqAey+xOes1RTZY+laUhO8JP7W0?= =?iso-8859-1?Q?EPDm0KdGvdoGWL64Dfw0ZZ1R+Ah1EJnCCjquYe1GY2aBMStDhzh6mkjUTn?= =?iso-8859-1?Q?XNb+OPOUAv4JzSET/+aoRKoqt1FAWfxYjn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8485e4f0-d883-44a1-f9a6-08db29d4e794 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 06:24:19.8005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xKrsat0QTiU+J2zgvYjQs8/HkBuOdd8sCPgGuVOl3ZB3JtIPp354A2bh9McAj7CFfBz8mQWepqjRGqzh6CrjMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7075 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/4155 > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, March 21, 2023 10:29 AM > To: kraxel@redhat.com; devel@edk2.groups.io > Cc: Pawel Polawski ; Wang, Jian J > ; Oliver Steffen ; Xu, Min M > ; Marvin H=E4user ; > jmaloy@redhat.com > Subject: RE: [edk2-devel] [PATCH v2 1/1] > SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable= 2 >=20 > Sounds good. Thanks. >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: kraxel@redhat.com > > Sent: Monday, March 20, 2023 11:00 PM > > To: devel@edk2.groups.io; Yao, Jiewen > > Cc: Pawel Polawski ; Wang, Jian J > > ; Oliver Steffen ; Xu, Min > M > > ; Marvin H=E4user ; > > jmaloy@redhat.com > > Subject: Re: [edk2-devel] [PATCH v2 1/1] > > SecurityPkg/DxeImageVerificationLib: Check result of > GetEfiGlobalVariable2 > > > > On Mon, Mar 20, 2023 at 01:20:29PM +0000, Yao, Jiewen wrote: > > > Would you please share with us what test has been done for this patch= ? > > > > Usual regression testing, including booting images with and without > > secure boot. Additionally checked images with the wrong signature > > are rejected (try boot grub.efi directly instead of using the > > shim.efi -> grub.efi chain). > > > > take care, > > Gerd > > > > > > > > Thank you > > > Yao, Jiewen > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > Gerd > > > > Hoffmann > > > > Sent: Monday, March 20, 2023 6:02 PM > > > > To: devel@edk2.groups.io > > > > Cc: Pawel Polawski ; Wang, Jian J > > > > ; Oliver Steffen ; Xu, > > Min M > > > > ; Marvin H=E4user ; Yao, > > > > Jiewen ; jmaloy@redhat.com > > > > Subject: Re: [edk2-devel] [PATCH v2 1/1] > > > > SecurityPkg/DxeImageVerificationLib: Check result of > > GetEfiGlobalVariable2 > > > > > > > > On Fri, Mar 03, 2023 at 11:35:53AM +0100, Gerd Hoffmann wrote: > > > > > Call gRT->GetVariable() directly to read the SecureBoot variable.= It is > > > > > one byte in size so we can easily place it on the stack instead o= f > > > > > having GetEfiGlobalVariable2() allocate it for us, which avoids a= few > > > > > possible error cases. > > > > > > > > > > Skip secure boot checks if (and only if): > > > > > > > > > > (a) the SecureBoot variable is not present (EFI_NOT_FOUND) > according > > to > > > > > the return value, or > > > > > (b) the SecureBoot variable was read successfully and is set to > > > > > SECURE_BOOT_MODE_DISABLE. > > > > > > > > > > Previously the code skipped the secure boot checks on *any* > > > > > gRT->GetVariable() error (GetEfiGlobalVariable2 sets the variable > > > > > value to NULL in that case) and also on memory allocation failure= s. > > > > > > > > > > Fixes: CVE-2019-14560 > > > > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2167 > > > > > Signed-off-by: Gerd Hoffmann > > > > > > > > Ping. Any comments on this patch? > > > > > > > > take care, > > > > Gerd > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > --