From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.7695.1666791969672494032 for ; Wed, 26 Oct 2022 06:46:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FAYqAlMV; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666791969; x=1698327969; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WZYmswGJfd3SNfSo0Bq+duj/ZEnvxLWQelPEWPLhdsc=; b=FAYqAlMVESBWhQgrCB2OA6TbTYYk+QzZGEzv13ASMZ31ucxp7MApDPHG rndo02dlD670r6W2NGG0FGJCDfmmNFuSCsUfX4AsZZYnHzggc9jD2DFtt ubd6lWzELsTUlJYSnhuylmhelB6NOs+RJoNqrSaIjj1Nc6u/sOHgtbtVP ZQd0bPK5VaNNjQO4bvtbgrdrf9mKH7NedL/0Ve16EtPTDLjgpw+uYL/P9 LEl4GpJEVAK4gUj/LvtP8WabV37C1wUd2rOi9GyB+FapaU+bPn1JfH8YC 2ewkXqrVxsVaQemGpvwZLHF1WnhlXdyc3QcNTEvNoHC4x/R+VEmmM8elV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="295355966" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="295355966" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 06:46:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="961212760" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="961212760" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 26 Oct 2022 06:46:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 06:46:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 26 Oct 2022 06:46:00 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 26 Oct 2022 06:45:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TsdceWw0zFF2ON3jeEOqi77SFKHeLdAetixB/vixWQeCgrsgHpF4KYH8eZyEdfeQY340+n/S9oZoo8r7IhodYnkZpTpiW2aS1ypRe4dBECWADQhlD2qWY8DDNyipqGBZ5QL1xeXKKbsu3Qg83Gw6fOC5KN5TDdEPUgTnbnSTjG71RLjxQ/lUBgHjy29t//aX3GfttflLft+qj8+oE/tkL81IRpFWv9nFgcB2cVnI9KNmEV5YNjsH+TSwBa3YLUtj9MCwjZtNpSr7M2FbsI5JYiz08w3S9WxbBksqaYp2Uf1X22UUJHEcLszLxi8c9sZ4iu1O7YkgeMEQ/9fJALlmBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sTDMkFhsyy5wGKestDKB4JEEAcbUhOObqNXobN+JwJQ=; b=Vh2QziZ3YdezFGcQn/lOLql1hIJ7JMz1N6Nv1eIi9SHu6jpFxF3QqlZ1B93pFW6ZeeJ+HffMeZ56pUFEcvCq5lhSAxq3DzyciQ/kOS5sGPudyj4fYvnYQ7KAeH9EKDubguCc2EizLXt6h3fdEkGPa3RB39DN61hXMZ0WPmcUcERVgPKmE8QJvVMzEPp7N+QNfPT9w7eNutZI4u/kQw6D27kl0KXCblL40/scsYS2VGtLyTh3oX/2t7/XHuJ8VzEwSWbXyyC+IFtHgxVF7CS7GneNDK0tsllt01EQQYTtsVdSK/Gr7krVGpXcLrTSOGWZSL2VNEinz7Gl5gVbfyE5Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM4PR11MB7279.namprd11.prod.outlook.com (2603:10b6:8:109::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 26 Oct 2022 13:45:53 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::8a27:e262:8996:473]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::8a27:e262:8996:473%7]) with mapi id 15.20.5723.033; Wed, 26 Oct 2022 13:45:50 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "paul.grimes@amd.com" CC: "Zhang, Qi1" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v1 2/2] SecurityPkg: OpalPasswordDxe: uninitialized local variable. Thread-Topic: [edk2-devel] [PATCH v1 2/2] SecurityPkg: OpalPasswordDxe: uninitialized local variable. Thread-Index: AQHY5jQuPgxh0ytDk0GRVCgVai0sYa4gtgoQ Date: Wed, 26 Oct 2022 13:45:50 +0000 Message-ID: References: <20221022160010.632-1-paul.grimes@amd.com> <20221022160010.632-3-paul.grimes@amd.com> In-Reply-To: <20221022160010.632-3-paul.grimes@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM4PR11MB7279:EE_ x-ms-office365-filtering-correlation-id: 0399d24b-ba3c-45d2-a7e3-08dab7586526 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kewVPCGizEX8lQIORBhMu+9LvDnoSCP9wcgZDcybxbT4UWQDOu2wEYInALHXCXPDG+iITNoD3ASBBqZyGu8U/UqT6SjX8gVmmSt/tqDGcO8lpc1j+cZ3xxjY9PBCEe+L3h1eZIZsmNRK/sxbCNoBvXfjupNVNSZbe49eOEc0vOwuLYrbgLJKs8SXEdCCCcmnrAaayIIn11TKsN5lZw2Cz5nLFKgVTg8qiBfbV+vzM4DIrrJqh4Oqig2gLxfnifzc1WCWiqFNG6px+TlWJCVxzVMhn9rVYpKe+9s//xtHQ7eLUuUmCXUpEBhOo3trcfK8qcekqv54lWyYLLGuZ3m6g8u+wzoyfoeixXVVQX9TI/jSS6BSkLEbZrsHCwyXw4gHfiD0/3BuIUj3sL4BP4cvBoLxLyijpNHXlK1XMEykweF7G/6wCkjaYJ3xSIK24NFSd6otX2LOrrwMv+S+qKrEeNVB6nXWMusoc9zSqJsMLfqzRl63+lTZCty02J0+dClN5q8EQmO6n8y0YJidIMcR2EsE93vF6G/+5rlNP56CFGIdpcmzvoUvsn9srrQqHiMyggJvfD9+ddLC9uZe6xgapPl/2x/DRNOIzg+nC8CHcReEOdDe1G+q+2+v1BbxfrJ7PcvgywyGrTkoY1guI6RUBRJRIOQ4h4VtF78m+wvQzGOfDVKL3tZCKfwW/ziNzA+xjW49SoJPYq/DfhftD95H3VBq43Jv2sQ4LxMMauQgLl6Z0vyy8R3AN3dTO2zJo2SQcJ1hykDsAlViUIDe+7pKHKwr/meH+GLmQAmeDy9ViDWXcjUbYetUia7T+EuaLBF/jRaJk5Jlzz0oNYTc0AP5pQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(346002)(396003)(376002)(451199015)(53546011)(66446008)(55016003)(15650500001)(83380400001)(26005)(8936002)(7696005)(54906003)(41300700001)(9686003)(478600001)(5660300002)(107886003)(66556008)(6506007)(52536014)(64756008)(76116006)(316002)(966005)(4326008)(66946007)(8676002)(186003)(71200400001)(66476007)(110136005)(66899015)(86362001)(122000001)(33656002)(38070700005)(38100700002)(2906002)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ix7JVXAcAMofanW+MrQhJwGcTRLP4MKrg+/LnQ7GJDWX5wCKFPHNJh2F8nPc?= =?us-ascii?Q?AYIZx8/A1OPeY/4VFE5alqRMmRTPRXcBEm2bYKZ3PdLlW2gbVJhoQ+Rod+PT?= =?us-ascii?Q?FsXZZh+0oSx7k6J6iGj+OITiaxdSyvqwYKDOE8zLDfZs1HiCKl2/ZNdXJ+ZR?= =?us-ascii?Q?nuNuhevBZuIXVPw/4hxRO+VxI8eMdqn7o2r6tBnxVTlcVt5zPtzQhoM053mH?= =?us-ascii?Q?zxbg+ivWDofCX+NV4XY9M4AWuZIA8xyphwLYlEa2mlNweS7774Y8lEdAUm+x?= =?us-ascii?Q?htuDQQdUoQUIRvYw9eMXjKSqNa1Gz+yWv5gpgdZu1E7W7MFgWBswB6/EQ74Q?= =?us-ascii?Q?Lv4JiC9/JDrCxE/CRRYMHgen/2OjVpkJJoO4CoTzm9SQIPK5rMbIH4FrzhbN?= =?us-ascii?Q?C79OZuNuBXzs9pq/nBLcFF++YPeEw2mSM1D4gOjsQ4o0lkxvo3uVYHABw15Z?= =?us-ascii?Q?jxXHDY1HaHN8Gk+RWRSosPMSGmCzfUxxjGFRgjsdNyh9rH8/Cpp/ZaLDtNUM?= =?us-ascii?Q?HPl85W7ce2gXpjMqg9p4SlNg4B9BqC5MQtiERU0b4PeFDmxJWLNwVXJRtIK8?= =?us-ascii?Q?RpHXqXXuw+fcsxJtT1hBEbpx+Mx+fH94iRf9aK149z1edTLsvTrFeM2PYjm2?= =?us-ascii?Q?6TnemQwuq00v4rN+tvRuPCwAOZpGWAvH0DSpLEY57zG0nN7K2kJEBKbIjZma?= =?us-ascii?Q?Pf3dYntx6gTXcaeydQO9o55t5HMO2rjP8jZCmbbiwb6pA0ELUNU5SwNuUIdh?= =?us-ascii?Q?Sv1oJhJgKyDvX9GUgX58DOouoXKFPnG3kDn9zyDFmLoWFe4gfD/5xK8C09Mm?= =?us-ascii?Q?yqm7J/4FdYPTIcyAKkL4ffmWYYZJ0L5RCleV4czs+evW+SlBi8RfOQNwd+sW?= =?us-ascii?Q?94Sl+85Zr2XJaJH9f1e7mp3fBq1zsggzK762INsGbcPSiGcDuQ1k6DYSQdAQ?= =?us-ascii?Q?W7tgiIqlb3+DQhC25mW5HBFnD6pQTeE7M74sZ6GUocvjtp2EVPN4FjXe51bs?= =?us-ascii?Q?E/wM3yKoB/UByZLw29P+XdhaqaNuI3Zgrwid36YI1jICAUXWo2xZtT3zCQDu?= =?us-ascii?Q?JPVkhsyx3O082xlywkKvfGQfm+XnHZhsArhFP/jl9NLqFwJ2SbajO5XbmAeY?= =?us-ascii?Q?ryBP0qkM1hfPUzpdPXUPT7hC259giahpFJPkwmrwCAJ/HdmHvRGHDsC28foq?= =?us-ascii?Q?o7Kd5opXQyEawF1FGvjIi4sJQzc0TXc3ySnftuiZYsNhi5MW9ggKOVoiO1zP?= =?us-ascii?Q?HCyKdvVvDepIRDQEJ80b3oGAe5U4ivuBURn0lMeLi2KFIsiYmGa5SUAWwoLc?= =?us-ascii?Q?IOjpqAi1ny3Gr43YFlK+HWPiJ8lusRTDfj4bJuOs07Wq7Y1UuHWm2Zrw8C1H?= =?us-ascii?Q?P5eaYOEG1VkV8Fkpl402OrhfrkRiyJkEke0uOCZDr2Re75RxTawH8i1pYwgO?= =?us-ascii?Q?PpbcZj4bWXDFAMKMN65w9exD/DJ3aiwokThuv8HfjqYY5Z8pzQJuMaR/UbiA?= =?us-ascii?Q?dwDO2mcyUmLyqsPGFShnD8bKShqEbyYf0OgXNmchnzyzRxwmhaao3YuCJhYV?= =?us-ascii?Q?ycQP6+F8LKKPJQJ6a985b1GkOnzetyWj5X7+5WF3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0399d24b-ba3c-45d2-a7e3-08dab7586526 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 13:45:50.8227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iWZNFEnSL2edTkO1xqvfU4TTOG8uIXTJQLCUSN2NHr0qHv603TF18FnDWXJb6pRlIX7A2idTyCPH4AFwbSoehQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7279 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Paul via > groups.io > Sent: Sunday, October 23, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kumar, Rahul R > > Subject: [edk2-devel] [PATCH v1 2/2] SecurityPkg: OpalPasswordDxe: > uninitialized local variable. >=20 > From: Paul Grimes >=20 > In ProcessOpalRequest(), VariableSize is used prior to being > initialized. This change initializes the variable. >=20 > Cc: Qi Zhang > Cc: Rahul Kumar > Signed-off-by: Paul Grimes > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index f127757ad9f0..d827cea23868 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -2184,6 +2184,7 @@ ProcessOpalRequest ( >=20 > DEBUG ((DEBUG_INFO, "%a() - enter\n", __FUNCTION__)); >=20 > + VariableSize =3D 0; > if (mOpalRequestVariable =3D=3D NULL) { > Status =3D GetVariable2 ( > OPAL_REQUEST_VARIABLE_NAME, > -- > 2.24.0.windows.2 >=20 >=20 >=20 >=20 >=20