From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.8239.1675382535040097872 for ; Thu, 02 Feb 2023 16:02:15 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=askB35bH; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675382535; x=1706918535; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R+ASZ1SzWYf8vzIE+kiz5dtQRLE1Kd4IvEkgg5CIa3w=; b=askB35bH6jJL8MG3UYoXKK813cMQB4R93apZ3Ij6/IDP5dtEK4Quhaio dlhy0j9ZpdCXif79GMI8uNnyLLzQNPeItvZMM2O/mHYwh0dDKD9pFvqcs stgXAdW4CvIIAaiO3U+qjnh4AcwxxPjByQCciY3wkd1TPTk8cv+dJ9fpJ TIUwLg5gG0LFmfx3jZeXwn1tcfG+ekvxufGbeyFcmmsZB9RallodMhthN +Vf8p5dd4FF5GPjPu7cX5ivz2/6oU+EoA0C10VbqKPrR89NeTkxhAaWtZ SyEiH5eBZBuxAHSlMFa3uiJqVzj6gXlV4NIAmKRf5CKk6wCJHMhoyf6JK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="328624730" X-IronPort-AV: E=Sophos;i="5.97,268,1669104000"; d="scan'208";a="328624730" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 16:02:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="734121355" X-IronPort-AV: E=Sophos;i="5.97,268,1669104000"; d="scan'208";a="734121355" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2023 16:02:14 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 16:02:14 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 16:02:14 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 16:02:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DRkaNJ+MbDA/fLxSc5MfZEuWpURAeXhmXezEnri6E9U+u3h+MYh6tdIgWpjKCeFiHh1ZpvS71/NcaAmNhea/eI4Rgco5+5FwgOatCyA6fTc1k9/4XODRAnucRBJh2SCW0B3BW1vlFjDDuIV5m4uTQb45NevOlnAMcNYC1OcWFpRfzGrUnKVuvzxFngXjuB5QKrPC4GngdHbG267R1gnwhzeqqxF7V0d4SBwK4N6cZQ6DBWBKREM/aUSE8oPSYpal56mJQRbnwRtaKMWuRhZ1befA1NZVrLUvBv9xcFWbm+TH4e6oo711uR890+f5388OxN9TB8lGz7zkWxIn0Bhi7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ECdpk4jnpZ64FJWi9In4t9S8TbUIZH/gQdRYgs+AeU=; b=Q3QMvoygGGVrRwHvhtfxbwy4vrEpmHJyiYGL9uXxunhEe5MyKoZ2d4CVpV0XzIGgOPhXzVIqF/lQVpPqUIui+TnzTsnQDFujkF7zF3E+ditBGEkCySyMi2ik6apC3fInD4JPQhk1muvh2y9D2UMViRnszchQydI6As9GgBx37jZlcgpLdwUaKU6hjasianSjWxeMGVbxgAeS4xmJI3cNAQEsA200bEh3JqjZsj9SY2V/A0QO5ptDpfFoVlLGXa9/w3pZDJTcQBdBJTt1aIym2GpHBEiiz1QVIoARvIywxAUsCcLD/NuSJ7Usa1AnDotDiwzOsbU7moAvZO0hfGH/OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS0PR11MB7960.namprd11.prod.outlook.com (2603:10b6:8:fe::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.23; Fri, 3 Feb 2023 00:02:12 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d%3]) with mapi id 15.20.6064.023; Fri, 3 Feb 2023 00:02:11 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH V1 1/1] SecurityPkg/TdTcg2Dxe: td-guest shall halt when CcMeasurement install fail Thread-Topic: [PATCH V1 1/1] SecurityPkg/TdTcg2Dxe: td-guest shall halt when CcMeasurement install fail Thread-Index: AQHZNuWLFSgN0VBY10Gg7mWkkpeOxa68V60w Date: Fri, 3 Feb 2023 00:02:11 +0000 Message-ID: References: <20230202090414.20-1-min.m.xu@intel.com> In-Reply-To: <20230202090414.20-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS0PR11MB7960:EE_ x-ms-office365-filtering-correlation-id: 2a712dca-0e86-460e-2783-08db0579e657 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7LjkhZcosfzxe1BMTtFn8G8vjszV41E8szW7pl/8ylmL9jUXJbVhG7EmFYaIFCvzxSr8WYJ8rwi/WyEuEK+b8r7+KbDgFe3Uq4AIoFL60qytGLrkHG9woM9PfeUWt/yVqCRAkNQNZtrKNf0FNWon2rWAv8TqLqY+mgr3pZyA+YwsyrnaC5sreLctp17ucQlTzn4rIN33LTF8dwYuyPFANcC3BVISkjN2AtHjm/gbAsOQDojupyQIfEzqfWUVCiHoi1sjNaswjkzavEllYIRkwrGtYbenMKu3PZ0sNR619PM4KhETzmKgA+aEl9saNqDzqVY3Orvk4gvC8YaX4+huNJUIq0qin9oH2fF3azLr8rs4Ke0l6NWVk3ng8D83tdDDOv2vRBGo6OBkI/1jHIetZaJTJib3E4lcFbFr+3a83yy5h6fP+KxghmIOYBYxupb0BvEAjXMjv8RBJGnxiVyC3Im4RQ7EjMUpxOjEFKozr74vq96C0zXcPKM4ldz/XWDQHFewNRC+0skJTQoZhry1UXBXNsCCfBoEkhv9o8V6y7kiZEUnxMyuEx3+CJcPaluzbLbGAdOa3x9ZE1YIVdXI/7vQDJ/eCnbsrSDdf4/HZIfZslOEBwkChDxOL9ZMizWJbqzkmOIJs3MIKQqB8yzi7/2CUwEpMBMRgBuG+24ZZfD6O/1DLxUXfuHWh2Gq8pTP3KgINN2JsLl4FkZLgbJizDxVZq65QH8jhjAadoTOO8s= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199018)(82960400001)(6506007)(966005)(26005)(53546011)(38100700002)(9686003)(66946007)(122000001)(107886003)(186003)(83380400001)(66476007)(66556008)(64756008)(66446008)(55016003)(38070700005)(33656002)(8936002)(4326008)(41300700001)(86362001)(316002)(110136005)(52536014)(76116006)(7696005)(478600001)(71200400001)(8676002)(19627235002)(5660300002)(15650500001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9BoE+v+yMM5pl3M/RZG45uTkp4gucu6G8siqOy+xzQ1pUwF4Uvjy5CRjpsJB?= =?us-ascii?Q?ClN30K5RwwrCCDFXwmR3SwV3PO3mbNKbANpqo3cjcegsZFD5cOdjrzmwgTCL?= =?us-ascii?Q?tss/i74etslq4CYnhJXR72ZedD/un620wZm8MSn96F6skvGPHltji2ST61qf?= =?us-ascii?Q?dgvjoQVBjGca3JCxvq1uEfsHIYrbjAw0x78cygppg8Eqe53/xtBvDj3xJes9?= =?us-ascii?Q?tpX6uKM5LJWNsnjrutDtxk1S1K+esawDiDWVNM1TUQcdBmYRnDPn+jX2Sges?= =?us-ascii?Q?nRu2UflpW4lCQ31GUn2i7mt+rUo8ccAQZNSvBSRhRrKpu8D/u+RosnxmtPnv?= =?us-ascii?Q?sUvgfTysTeDxug9C+CpHhLv2VxbPtQOkP4X5N+c9yXLclKHZf52AteGRYX3G?= =?us-ascii?Q?YB6Knt8aniVOHCnxFEX4iDhrS/RqxXxKRn3O78sCadluc6bsz/C4tdCnlMN5?= =?us-ascii?Q?xVnI7A+N4H30wOg/qeZUie67BljvTHOK5ig1+FgYx0dGAi66woTv7YvXQ8lO?= =?us-ascii?Q?///D4q9GcRaLcTOTF6nHRbtrVu9DmYdcOYhABCw3kFnayiSdq7qxnaxM+kLD?= =?us-ascii?Q?SGjurzEROkqjwQd2U1cHLKzTdqbh39zoq7e4bwSlcvx50k7gDCdlM6lDjmoQ?= =?us-ascii?Q?KyrpT3F4wFj8TlUqWExfD588kURd+tLEItM3gXb/7YHc2GtQ+18HizPOq/WH?= =?us-ascii?Q?FtQx6TEOpkEzrsVW8kPbIDMF6jKaHphKpGrU3if5425g3n3hVKgjlSWvnG+p?= =?us-ascii?Q?Qiz2lxRaYyPWRvTfSx23yn0QtjwgXUfnqh4h5djo1o/Gk5Ebqxn+yzApDqCJ?= =?us-ascii?Q?gj2JzrKUWkwcBDNw0Z3+nElrB62j40PBmNZz4WMyxmfGls2JIOp5nGeGz8SY?= =?us-ascii?Q?ENX2N1jRp6GXylyJtnurREfNrtIL3Jd3Xexwx2K15isLJBnpCqdTv3LTVpo5?= =?us-ascii?Q?6+b+bTywB4psmQyub8heRN9ouyUkyM3hxkIER6VfilW9PKo3j3uursTHKLjh?= =?us-ascii?Q?GNKFS/uzQ8g+81HRvw2EDCshpETOSLjQjxIhg59AO+9EjROuZmX/SYK2cLHn?= =?us-ascii?Q?7v8QwEBpjvH7BLgaIHwmuaGgS0boKRJxVW1blVkdvvuiKhn9fAyg5B0kgyqC?= =?us-ascii?Q?LYzA0zZnpk7FtDzvPMA6aTi98K4BqzLA5t98daDC3R89EYsTmH77MTGCYhKY?= =?us-ascii?Q?Ard/vPJpf7frdIbA9EgNPzvnkHgWA2rHmyRyv9NA2pFHPjuPQu7ZlNAD63eX?= =?us-ascii?Q?WDHO8O2TOZeTwqttlwORGIiVQuef528NN0faYZy/7vqld4iIhazh76WUw4nv?= =?us-ascii?Q?7LRRXKKKnklv0kywMyoL3/SqctuMGPgOUiEa3s0t1kzgIB5qTRPgd+5tKhf8?= =?us-ascii?Q?4kMPNue5eJiKNayY7bgXThQS/8Uj04XO+OTeYXy2YmxKF2gE4EhIQVkuPOAA?= =?us-ascii?Q?TxHMLLXyiHgU/fidQ5ja473bKhKFwhuy5nuv2gIKbbmbe7T/lFkXFQOJeoWk?= =?us-ascii?Q?HGaPTw2sluoGmjCFuqpbeTD31qJpkQSdEYehRs3XZYihcAPQg1MbDWpQL3y1?= =?us-ascii?Q?2HgwNOlnd6fWixgxpTjGiY6iMvd3slzZ4yrZpZwp?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a712dca-0e86-460e-2783-08db0579e657 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 00:02:11.6085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xrfjySrfgugnAufxRauwk8Qf3WBtaMwxl+3mJVsLDLcHRy+Jl2INh28zvUDCHGE0TwSCdr/XSgjM5kf7mPt2WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7960 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Thursday, February 2, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J > Subject: [PATCH V1 1/1] SecurityPkg/TdTcg2Dxe: td-guest shall halt when > CcMeasurement install fail >=20 > From: Min M Xu >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4335 >=20 > CcMeasurement protocol is installed when it is supported in a td-guest. I= f > the installation of the protocol failed, the guest shall go into > CpuDeadLoop. Because the measurement feature is crucial to a td-guest and > it shall stop running immediately at this situation. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Signed-off-by: Min Xu > --- > SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > index 59341a8c0250..b34da724ac42 100644 > --- a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > +++ b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > @@ -2510,6 +2510,12 @@ DriverEntry ( > // > // Create event callback to install CC EventLog ACPI Table > EfiCreateProtocolNotifyEvent (&gEfiAcpiTableProtocolGuid, TPL_CALLBA= CK, > InstallAcpiTable, NULL, &Registration); > + } else { > + // > + // Cc measurement feature is crucial to a td-guest and it shall stop= running > immediately > + // when it is failed to be installed. > + DEBUG ((DEBUG_ERROR, "%a: CcMeasurement protocol failed to be > installed - %r\n", __FUNCTION__, Status)); > + CpuDeadLoop (); > } >=20 > return Status; > -- > 2.29.2.windows.2