From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.3628.1680920562342371913 for ; Fri, 07 Apr 2023 19:22:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nOMm8ztM; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680920562; x=1712456562; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ud6clf2lLVqWxK7xUepRZJBqTgJ/Bgx1MMggJy3vKOg=; b=nOMm8ztM3MRMZQX5Haq4f5gPFizznrMsrzTux/urcVEyzvZuCD/bgCeb 45I5Myg+eXclx7IkEkXWCG+VATuQpTB2FQ9lsPChIQRL8bWb0pvTVYn9l Udu4iiFICmt3wkGnjCyg3sOcuf32ibKXPEOeroW5SuWyRA5V7ZdFxeUbL hf6OhjOcwa4jt77erazfDE6iuk3wmVHQT2iNIZOkcwKPFITWncny4XNNO PmhxEsA89gabzRfg5qMIa3LCcBB5MIJxXbFTZkbG/fgjhd9EuPPKwknkC ik44sUJQjX3YdTMtSeFwYOFGfQATEVsvug2jpqJx+cAz80a6J3tbCGC/a Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="344881451" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="344881451" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2023 19:22:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="718006495" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="718006495" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 07 Apr 2023 19:22:41 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 7 Apr 2023 19:22:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 7 Apr 2023 19:22:40 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 7 Apr 2023 19:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YhDaEaUdVjglFt33A9lagBI4zeg8yGKW6tjvVg2fCxirD/uNXBNvTvXO+3EX+dekjGUXi6IXux3w942+0xVpx/GevzQG3t0sq0zlbhdAobibxRdL5ua4epMFSriu1EVMWtof/U6bO5mC6mS96xTYQcJiNK70O7dvLyIGD5x5sA1UjnWhHo8N/655fUDyiFSBYmOOo9dYsTJ0gkFBUd5Zv9Y/pI0Dgz2+LSFkkuCjISNVtPJz1xkq+BX7NKacIxSSp5OpcYzkFMyCc/T/9b2z8mhw7tbHcfVdjBcQtw4uPhilCmkZYqAsakyvHpiPgz/KubYCuuUTIZQmFkarH16RNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TuC36IhK/yDXCs2IC+qMRa6cJMm0JLPM3q3nER2Z83s=; b=XWonf0e8uXy8+aZKsD1UUYxW3jwqTnJ6JpidzG8b052zRPs/vKA3W+YNNVDmB5ikH+LX4kq0AzdENY5h0sadigoaPcO8e3/S5WsCnv0HXBXQANmmOSedB51R5SCyeZEYQ1DUNvba18zJccxiNE8e8jbnsuIgcZJole8cc2bvwQmyba0x4aB/v9xWPa6u18aEnIu7h9LPerYaJrCg424uQErc8hK0NUNyADpNi7N37bbLqdldEWuaLECBVwLXOyKBugoPlCK+NUb5NAlw+vVSoH61lT6xjPtL4lE2ub2ndjML6jAaeumOzJT/6VR+T6MVl8XqbOJtYYgBWF3zz/+Yqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS7PR11MB6125.namprd11.prod.outlook.com (2603:10b6:8:9f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Sat, 8 Apr 2023 02:22:38 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388%5]) with mapi id 15.20.6277.035; Sat, 8 Apr 2023 02:22:37 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Warkentin, Andrei" CC: Daniel Schaefer , Sunil V L Subject: Re: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Thread-Topic: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Thread-Index: AQHZaZpLjh4dBqZKckaFRDFCeuwFlq8grrcQ Date: Sat, 8 Apr 2023 02:22:37 +0000 Message-ID: References: <20230407214425.4360-1-andrei.warkentin@intel.com> <20230407214425.4360-4-andrei.warkentin@intel.com> In-Reply-To: <20230407214425.4360-4-andrei.warkentin@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS7PR11MB6125:EE_ x-ms-office365-filtering-correlation-id: 05e84e94-4717-406e-be6f-08db37d81f0d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HMVNc31d2K4FYFT+iPu7XSyUFQNuRJtfocrmlix7065QNvCW6Hq7Y9m+dbPpGeehvO5soWGNEoweK7l+58pxMHVYeiWsksVraBc6nKEE3S/RhMqHJwbfjfx2qzMboIAfqL+5j/cGHvHKZmQ6Hcggyy6s8rIs2Y5HKpLOaLdj+fRk0FEpElPVlmpnrhgzjfdM/4x6i0W8mLOrHjFwHbIEzA6nh8idgUdlqT1/GhUzOILmjhVdSBhWUYVyNqxoE5xTZtD6aqVQj2Hk8KnCnEl7qWpRFQI35F9SoiQUPL0tU7L0HDSomc0HoH4YIecM+xf1/RUgS0IoR6w9LiJ3hAb4CVyNdgTGMlm+lr9YqvfPfUVVjV5pe62B+HJF/Fb/kzWJJ+TjABVF3xKaaEpQHuoy8ap8QfADfNt1YqVIOmnVnCukOOS4v/CEhmqmHC8PR0EpnNhN5/Q2QrM5pfc9hSSzrYF3jLGanjLvSxUrvHCA7giN0W9OYiyQhDu5PQcM2HsgT/fcQOnE1xwA0grPJNm+h2lcV+7Ee4uvpSvl+mSKRkY/FmEvNNuvLrX99tRKsfALXFxzm2X3sgzEYACDzAj85ZFoqZoIxlWHXuXbc2tRMRcKUnKFiXPNi60zVlch4blBbcCgQPCcuf0dofSsaZ6zXw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(6506007)(9686003)(26005)(53546011)(186003)(66946007)(122000001)(41300700001)(7696005)(71200400001)(966005)(83380400001)(66899021)(478600001)(54906003)(110136005)(6636002)(316002)(38100700002)(55016003)(4326008)(86362001)(33656002)(76116006)(64756008)(66476007)(82960400001)(8676002)(66446008)(66556008)(2906002)(38070700005)(5660300002)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Trv1Ui1OR1OtJTB07RUISEPzz/cvQFkrvReNrat2REUda4hKLjxJ277AXRC/?= =?us-ascii?Q?AecAPtufzDYYhKeO8MwrVkX6ZNhxwRa8riHABZKx619GwD2zUIrHT5WnLvYu?= =?us-ascii?Q?5geVojERwf+pQ4SILL8v69+gTb2mMITu29KGee96jLX7KVUIZBZ0L+EbY1VD?= =?us-ascii?Q?/GEPFl8z03oipLmzlqOuEwZn+9j5gsYxGrZGpFOIlF6j6hyNdNyKQ1148n0e?= =?us-ascii?Q?7G3uDYAf1o8r0+rZIQl7dcUYpjU1FXzimv5mYHDkGM97wYbfBLnhdLl6liDn?= =?us-ascii?Q?P5u1c7zNAR8TaOaPxCE+vSb2wrjZyVwNYMfVDMaQqr1VGDWUi+WyCOErE8pz?= =?us-ascii?Q?QxY93CV77FvcndZbzrAVGW4t3a3ijIiJnOXsMLaWnxYN560OoImGd/uqtdIg?= =?us-ascii?Q?6GjJrzyZCWLjN5W78un9AkclOW34Z5iizY851PE2eChfz25trgJZRbeyoDtO?= =?us-ascii?Q?0Phs07i5zimZOMucIveEHJRf0B0JVk3VLXEKVkoS9xcbXwP32MS/grVj2mtu?= =?us-ascii?Q?VWizPY8b0H6RwhcOifBA33VqapnagFtXBw2tgXqp9JdJwci1EZfrt3smfj0f?= =?us-ascii?Q?m2/7dUxHgbthbrU83W/otFfsGZEz1bU+xvrVjDg8mec1liPJDJGLE7wzO0gd?= =?us-ascii?Q?M6j5rbD8HmnzBQ44XF5XdbNy/Y9Vha2VXvkEFQNqnFP/F0n9Mq7xfTij7X0Q?= =?us-ascii?Q?LS16tW+yE0Axds+cCQgJwHlV1Hu/KfVlTPBeM9X/YOxYNn4c7msjV97iYdhT?= =?us-ascii?Q?GbCPIbnHRuVdCibgnUVnNzJIsF/AfVUKEpVb+hHhxAP7hFmjHhxlbnlmeAIR?= =?us-ascii?Q?6WD6QQDl520GLLvmsB6HlimWblIccxhVlIBrwGjvtjpz7U+VPegqeBd37zUh?= =?us-ascii?Q?6A4++dv0gxSoaG64MYztryEKCwMSSeoDu5698ALEt3mGKVSHRI0v5FKUaQrn?= =?us-ascii?Q?w50eD/g7+BrRvZHzu66fiDKsE4AjcGdPLfLwgADMgvPD3JQzz1NYJAU2Q9x1?= =?us-ascii?Q?c8nDUEno7YY8xFg8qZooco40EG/gobMZkMsisAgoztaVe9qrfkD/aoDt1EMU?= =?us-ascii?Q?7Xv7MTa/cocV288mJ98vkU1CQjmw73qWxG3pNoxpjZ3ZuBkUWIZc9ejvNMgj?= =?us-ascii?Q?C7bKEskAjcVsYM0JJiiPLpM3IzUzPfjZvCt4dO+bnhL5ZFh+sNfYNMmJeHev?= =?us-ascii?Q?/Xt3NDg2TfpI0xDdZCTHwzkQQCBzHvd8kuUQdAiGv8a24Y0Ff/rFyPieiU8b?= =?us-ascii?Q?Awgew0Gp9yS/kKf7Nb+oup7EqckpJKwET1KE+eZAYGupPj1E+Ar6H1vRr8OB?= =?us-ascii?Q?2Ve9x5UHJtRhkFuZ2hf+lAzrk0ckHFBZssmXAnC4a1YagjXFAB788aJF8mk+?= =?us-ascii?Q?BFk9PfXW4dOKgLGlac3RGqLx9w1CbBjicfUUp3OAWXeXPGaSKAyUIOYqWOtu?= =?us-ascii?Q?VpxyrJ0QNy932bxr3+tgF2k5oIi8FP0s94LyfRqHMfBbUGV7raiehiNU5nt6?= =?us-ascii?Q?38HfgVC3fSV0PHGLPEyoWLVPbR5YhUflbEvOUjjUjy7EApf67O57fuDAt8Rp?= =?us-ascii?Q?p3yTyhv1RwrQn4D08lXd2VzyHlmVtIcug161vmmn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05e84e94-4717-406e-be6f-08db37d81f0d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2023 02:22:37.6270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5M/S8LQPr8ea5Rlcs8cuN+GGlmQ/W0FLq8a+mIUsSlrhBqejcl16VoCLWdi900MprAnZFplbUCtBUm335alEpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6125 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Andrei > Warkentin > Sent: Saturday, April 8, 2023 5:44 AM > To: devel@edk2.groups.io > Cc: Warkentin, Andrei ; Daniel Schaefer > ; Sunil V L > Subject: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing > SerialPortInitialize to Sec >=20 > If the SerialPortLib had any initialization needed, this > would be skipped in the RiscVVirt Sec. Follow the example > seen elsewhere (ArmVirtPkg PrePi). >=20 > Seen with BaseSerialPortLibRiscVSbiLibRam not using DBCN in Sec, > yet using DBCN elsewhere. >=20 > Cc: Daniel Schaefer > Reviewed-by: Sunil V L > Signed-off-by: Andrei Warkentin > --- > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 + > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 + > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +++- > 3 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf > b/OvmfPkg/RiscVVirt/Sec/SecMain.inf > index aed35d3af596..0e2a5785e8a4 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf > @@ -48,6 +48,7 @@ [LibraryClasses] > FdtLib > MemoryAllocationLib > HobLib > + SerialPortLib >=20 > [Ppis] > gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h > b/OvmfPkg/RiscVVirt/Sec/SecMain.h > index 83a8058efe40..7c7650f0d298 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.h > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include >=20 > /** > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c > b/OvmfPkg/RiscVVirt/Sec/SecMain.c > index adf73f2eb66c..b35c77774510 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.c > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c > @@ -1,7 +1,7 @@ > /** @file > RISC-V SEC phase module for Qemu Virt. >=20 > - Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2008 - 2023, Intel Corporation. All rights reserved.
> Copyright (c) 2022, Ventana Micro Systems Inc. All rights reserved. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -57,6 +57,8 @@ SecStartup ( > UINT64 StackBase; > UINT32 StackSize; >=20 > + SerialPortInitialize (); > + > // > // Report Status Code to indicate entering SEC core > // > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20