From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web08.6379.1650452987226157366 for ; Wed, 20 Apr 2022 04:09:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ChyXx3nC; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650452987; x=1681988987; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=j8xmBaDyJHtM+n1OB/mjdtDXKH61etFt1Axxfd41Qpo=; b=ChyXx3nCI00A5tlxS24pYHKrBUjiO7PkSvUFAI1kxJr795x9ocwKayR/ M85P4KTYLqDbVQ7R9XtKmh346XNJLzocHfTtb1LT51Ap0DkgfBLgKLGKU k2K5hmXknvCsdsZU3664QrMDeO9t3ibiHWPqsUKeHVqYfUYsJpWDg1cIq 9AGeIN1+/RAiAbDKAkKJ2VuRwXbPpw1m02ce6bypdXoMhsskNcbyi2efT 7ZX98N+yg9P2i5kRYGG0ToT4jq6+3RFI4R6al+IbSC74f5t/brkHZRnuR 7lR856jPf+wwFE75vtXk7Awb7T0oj0EQpuIPZ1lKxjGBn3dpo6STyud0o g==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="245893652" X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="245893652" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 04:09:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="626020930" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 20 Apr 2022 04:09:45 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Apr 2022 04:09:45 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Apr 2022 04:09:45 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 20 Apr 2022 04:09:45 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Apr 2022 04:09:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVw5SGvfWDXv6ilb0WKPyL4WriwjsyhmRcpDAZt8+1psSi7plIZQDk/3T/X8eAXiaXyxc7kZA0orXe0I/rH/cl0D/zEjOy5T4H1IkdMQyjVLR/FIS6GcpzvTerFtBRurYxbsZxWzLuXxYHVdVVYHL/0Gx9LW9p96toqH0ST7vCqJsCYTPGSURIT7izzDmF12dDXfWdZMabDMHUd01DY51hIPCAafbYNAhHOcUZKnmEyqdiCz2GvVvAAUr35VItWv9dsdTPjp/BXJt0tHsJ7EILwv8P/4cdCTZyM91tYn7m8tNkL/M5CiLF3aNzn/EZMBdwHoLw4QSukWRuR5sphyKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WfyBKJaxFp6bekob/zEgdiDqBB61amueA/WIO3mlTKA=; b=E/riCqu55WpLOTfpuNX2N8c1a7f2nSoYc37QmiVX0dal0VQSEeEHxdKEW6xXVfDC/zuSdUs1XrF1/qPe1O4N4k0U00Df4xKGTYzUAxBPCsl7qog2UYS7bKr4YwC1C7+TP223WNFMXR8WtZcJlktUSqAo5WWBXWb7JgeyfS58bZ95UX0wkzNj4ib2RW8jvGqQoxmhLfnQPyHx8s9/qrJBnyFKQSedd0CmSLaQsvmSfYkpOtKRbAtdC1tCYorDdUmr7hY7+Rmvbfs/yKXBZf1PMEn2dUOxi9G9CNu3xJO4Kd90Wv+9c28+XeI6rbkROu0J9BrXpQ8KhqR835LnjMhktg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BY5PR11MB4194.namprd11.prod.outlook.com (2603:10b6:a03:1c0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 20 Apr 2022 11:09:42 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022 11:09:42 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , Gerd Hoffmann CC: "Lu, Xiaoyu1" , Oliver Steffen , Pawel Polawski , "Jiang, Guomin" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers Thread-Topic: [edk2-devel] [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers Thread-Index: AQHYVH5Mu0kXOTGVakaHSh9Y892O+qz4X6XAgABFmgA= Date: Wed, 20 Apr 2022 11:09:42 +0000 Message-ID: References: <20220420061656.822368-1-kraxel@redhat.com> <16E788A8F8121061.23693@groups.io> In-Reply-To: <16E788A8F8121061.23693@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d42a9b3-a88a-4584-7f14-08da22be454b x-ms-traffictypediagnostic: BY5PR11MB4194:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BQjXotHYHPGcIBmyMkZqhSebaF+s4WA+p8g0qSbHutGqbvYo6tJnZkaa3UwJRFJxymP/Zr/PfEe/iAtkKiK6Zayw0+zh+qUO6z3w9DLQS1bN8uEyoEF1gIgEYcxG6XGHZK+yFIKrdteii1usGAeHXbUpQ5iUh98mCDD2us7ROJ/fka6buyC8jdn/SvPEtJUSaavY8+bEQEzN/fA95PJcb2LyRHXaSffTlWMxVK0lm4rCPTv0I+Was8NPCoaTNrCEiQW08B/9iSTYK7/opkC2Nb+E9etLfsU1IvjODv0dYnLMpNvHdcCcozbW7h5apSkmwxauvQL5FqQfXXqrzPnRIP4SDgNKz6pFH5Yz4n+6CwGidbNJw9k40B2gVIOnNHV+Ty+tG0zuK+FUyPqVpjFgG67PGJwLf/yDJ03TYXOREJ7hdIY438/usJaep69tg7HI2wxfAZ73kNTwYr701FNdmIwxwVRzlF25q7sLkiwGvbnIPAUkpt83tFcsudrzz9BKMGmNZFoV12GLJonvfwic8UUjMdmEIFQd8tZTpPEmu4ALx00rz7emRzwzHukgie6+Ah3ZmTp4C9uUYukElOcElyH9RtyhEuaQ4xtLL3zAjciW9QRMqywaAWCScRiRctn2k2HsT+wlxTGq8FaVTjIfdTprrMxeKhBSU83YGIFqgt4UHXXzol4cN9Cmbrv0GyiE9FW+704H1+/HusGyRx0s/YGm2Y7SVYNaY5T/YHF6V7XHSUFldUzDR+k9zlqrTpcGDNyGFQ2P9wbQSxwyznOzt9Df/9VswvcTxm+xHcmc8JdmPWT1pndSqwsKRAm+VtZq+osMj+F30hYVKtPX86qddA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(66476007)(66446008)(64756008)(4326008)(7696005)(8676002)(966005)(6506007)(76116006)(110136005)(107886003)(316002)(508600001)(83380400001)(71200400001)(54906003)(55016003)(86362001)(33656002)(8936002)(38100700002)(2906002)(38070700005)(5660300002)(53546011)(9686003)(82960400001)(186003)(26005)(52536014)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lkoofdzcAdkMFbU68DJHTvI9k8vD35pnTR3PY3Gf/wVfHns5dTOvZX8f1giB?= =?us-ascii?Q?djbFWsAxSr+Hld/Dh3jOYpVjcA1mQZWsM1gkC9c8BKgCGoIfqCPto2OusZXu?= =?us-ascii?Q?E1SHqul7rf8yRGWRdZIC2u+mhYyX2k/p1cVkv46tMoC3LM4D9aFrpdw8cWNp?= =?us-ascii?Q?O4vGmkRr0QaIXnYtLKJ4+wVAPhSWPHs9lQiR0AN/miwQWvf94hY0SrpaMubX?= =?us-ascii?Q?ksDj0R5yCO9BT+J9IhuVid0UC9GKuucQeoQEzRFeoCZ7K3hd/QfQ02VZjdnY?= =?us-ascii?Q?7Tv8Jfd295RQLrZkqOBZZZ/tSbfSyIKTjloK1U4tSpca1a0HoHPhmNevjFLl?= =?us-ascii?Q?XSlb2B6dAgTIWOsU6zbNKBs+UF6X3QhYplHN88p2jo2j4CARu4R36LY+h2gK?= =?us-ascii?Q?O8VxMOozhDkPOhG2fMsXfMYSd5hOWCn0UsS/WBx2DSyyMkyQAsRBhhDuTspY?= =?us-ascii?Q?ZW4FNcRTh0bGs0L7r7sZugEe6hgF7sV90VG/j9XXOf/++qEnC0oU2Igf2e39?= =?us-ascii?Q?rkPY4FjkdwTtsu75MbVBV+oZsI/QImS6DSb92TkEZOZ84fIXnDYtuGb/dm/Y?= =?us-ascii?Q?WqQEGr5mhUsuhYOuqYU63NUplW/tg1rYz4ecwENtJPVRXfcefIPKzA4LrNfZ?= =?us-ascii?Q?73GM0jo1uSYzArws/cmI0Y73HZEJgJ6MoZGdOxctIwkcE2UtJaltOLZ7pC23?= =?us-ascii?Q?vW8FBBjXCRs2ZNbhu3y3sLjSgVKhgP/xkanVWIesO5BnblCImnGWOa4SQMKF?= =?us-ascii?Q?iez5XKiaKpyXfUkti/+6Aaj2I6RLKqyhT1dL9ddECZO3yqA0JT9PXU03uvEW?= =?us-ascii?Q?UXZi6yzB9vHixk9pRx89ZIE0wLHolQlrdclFq6lE9knAqzKq1DlAcD/SQWDZ?= =?us-ascii?Q?4z9dgRojPeH0IHa/Jdf+KfYihC+eC6nr0KBcVqOLyfUaEhzaKeHeGhBSQprN?= =?us-ascii?Q?4ZWwleOYVMkN6Zr2dJxiuGf1u1OFamNVYGe+bFn2q7t4jkFI4Ez3WBwmP7A6?= =?us-ascii?Q?v41+knTs4lMmhAiE3j2e7dEwIxQK0AH0xJYtWqnvhH3AbMgZ6CMYz7k+7F/9?= =?us-ascii?Q?KLyM2SKvNL6awukjX3dZXHTmUZCM7PkEtngbd04gFtJqtthLviHePj+U5Ame?= =?us-ascii?Q?HadOcNtgljeJwDK1iBVKGRUNTlJRnvEkx6Mubm04wEfHe7V5Rp+lVpIW+4CR?= =?us-ascii?Q?5+5KW4rnpIWkMERj5kZLb/maj2i71DfctTlAI8xTq4hk4w0k3QYQK1f+So7L?= =?us-ascii?Q?xlmHjARU5A1s4ouJsoyKQkNaKTaF1R2AdDWYm5p6BBH2yHvDGSM4ExBx1VPE?= =?us-ascii?Q?6Y3V2Y87aD+Km1ZTf+9N4CmOhV+R3jLSStGUSGDznz8Nv4L1s4qsJlAxTp4Q?= =?us-ascii?Q?rKc6uWzPrfOn8RmOJGDpPttgG5Gt5FI+APcjJ0b8IREqLKLk/3GoDAUa8dug?= =?us-ascii?Q?tXLRG+WwISQbUvLPSa9HeOx7KvMpTyljGxFaEflJnqFzjvbYFL7bsUNijaIm?= =?us-ascii?Q?wjt7w0WMyBQoix5O01DdJc53UFxcF44BbfAz1tXGeQ2jGgXLWBfg/XS11gxf?= =?us-ascii?Q?e/8L1KZSLcYWKHKlpTGsrMfoA5mUeN6tR/GrywrO6qiOb+vvN1sfT+4pMlOH?= =?us-ascii?Q?/OBmlFr23k1zuxzl3ZTmy1vS3qMNxEX22HmaU/fSGT/PmQppBWPkkNqiNt8M?= =?us-ascii?Q?xaPBpdGx0cHJZ8K+f5Z8WXrluRfN8SwcrFMeeVKYMosoI+MTS+bE3Xj5NEAx?= =?us-ascii?Q?VHeEhXZBzg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d42a9b3-a88a-4584-7f14-08da22be454b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 11:09:42.7896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HU0Z/49nOWtOWS7cTadWyIGnqrL9/NSXnXAv/yr5Ee61a3bMFonQUNj73ajfJ0xwCRVEIBDY7sz/ykMaSY/BTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4194 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged - https://github.com/tianocore/edk2/pull/2805 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Wednesday, April 20, 2022 3:01 PM > To: Gerd Hoffmann ; devel@edk2.groups.io > Cc: Lu, Xiaoyu1 ; Oliver Steffen ; > Pawel Polawski ; Jiang, Guomin > ; Wang, Jian J > Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on = older VS > compilers >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Gerd Hoffmann > > Sent: Wednesday, April 20, 2022 2:17 PM > > To: devel@edk2.groups.io > > Cc: Lu, Xiaoyu1 ; Oliver Steffen > ; > > Pawel Polawski ; Yao, Jiewen > ; > > Jiang, Guomin ; Wang, Jian J > > ; Gerd Hoffmann > > Subject: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compil= ers > > > > Drop 'restrict' keyword which older visual studio compiler > > versions complain about. > > > > Fixes: fab6285a73c4 ("CryptoPkg/CrtLibSupport: fix strcpy") > > Signed-off-by: Gerd Hoffmann > > --- > > CryptoPkg/Library/Include/CrtLibSupport.h | 4 ++-- > > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > > b/CryptoPkg/Library/Include/CrtLibSupport.h > > index bdc2654b6eef..e49060124ff6 100644 > > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > > @@ -397,8 +397,8 @@ inet_pton ( > > > > char * > > strcpy ( > > - char *restrict strDest, > > - const char *strSource > > + char *strDest, > > + const char *strSource > > ); > > > > // > > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > index 6fcbe5885e7b..c1fc33538f9b 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > @@ -267,8 +267,8 @@ strcspn ( > > > > char * > > strcpy ( > > - char *restrict strDest, > > - const char *strSource > > + char *strDest, > > + const char *strSource > > ) > > { > > AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource); > > -- > > 2.35.1 >=20 >=20 >=20 >=20 >=20