From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C3D70D80419 for ; Wed, 24 Apr 2024 22:56:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=b+DFJKmSlZh9qiyvDmzBDr9Ti4FSLk8Qt9IdMzNaaSM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713999396; v=1; b=mCtDuO/T0hxE4TLquvZkZgq9T8BACbRoWdB31b5Fmqumn4Wi6PLQ/tZmUPa1zoeHgdWR6alt 6HPJtuvsO0XQKHrcqr96H/fnk90l9wEyguqjc6c8vN+2LcicrDA+wQT4LQIXw7lB3UWutC0E7UT 7t/XRSvh4O7MBN/6Uw8IvLekfvG0qXkGAvPKqrTXOo/90A8gk8qskSrf6OucPBk8VmYPk3htEoM ibet/KsHfaORRGGI3lAl/SgA0Ve746GbIqjkz4ZJ116vQW9J4Nhyl2kkHs9LODdaovA2Gsnwcm+ 89WdoomSugLFuY22Mo80Y2/AjyeDOhMa62ElL4G9VpcNg== X-Received: by 127.0.0.2 with SMTP id bFUJYY7687511xPQDkNcZSRE; Wed, 24 Apr 2024 15:56:36 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mx.groups.io with SMTP id smtpd.web11.3580.1713999395200857931 for ; Wed, 24 Apr 2024 15:56:35 -0700 X-CSE-ConnectionGUID: WZBtYKUcSKy2f5xk1iC2Hw== X-CSE-MsgGUID: 4rFvU8K2QLK+SqhHcpJuag== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9770329" X-IronPort-AV: E=Sophos;i="6.07,227,1708416000"; d="scan'208";a="9770329" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 15:56:36 -0700 X-CSE-ConnectionGUID: 5tUC9ZamQFCvqZr/B1QCuQ== X-CSE-MsgGUID: ZvT2tpYfTxOhDtvOTrD5EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,227,1708416000"; d="scan'208";a="24814582" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Apr 2024 15:56:35 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 15:56:34 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 15:56:34 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Apr 2024 15:56:34 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Apr 2024 15:56:33 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Wed, 24 Apr 2024 22:56:31 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7519.021; Wed, 24 Apr 2024 22:56:31 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Kinney, Michael D" , Sean Brogan CC: Gerd Hoffmann , Ard Biesheuvel , Oliver Steffen , Ard Biesheuvel , Srikanth Aithal Subject: Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests Thread-Topic: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests Thread-Index: AQHalgzZXK/pb0dUtkOD3j7sbeU47rF2+cwQgACif4CAAAJ4oIAACD0AgABhuwA= Date: Wed, 24 Apr 2024 22:56:31 +0000 Message-ID: References: <20240424060029.1330637-1-kraxel@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH0PR11MB4824:EE_ x-ms-office365-filtering-correlation-id: c344d303-a8ba-41dc-06c9-08dc64b1c8a1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?+iPC653AJ+hDCe9S9hw0atFwtegDjYxiF5eSFvdiyVSyKomwCVaKIwgKFqMn?= =?us-ascii?Q?y5W9RH5crS7MajYNEzWvwqEwEuFNU+prPpjWLh15GFCJc3N7iOLUqBznoKQn?= =?us-ascii?Q?Z1bvwGj5EgqmoVk1J3IUlXKwwPjYtPQU1qu85JlTih2dxrc0N4VCvemGsAiT?= =?us-ascii?Q?/gAwuAp2++VMyp9Gk0ylxB/muLdKAs/ij8UYUvRbBHhrPRWv43IXG9Mty8Sl?= =?us-ascii?Q?rEzBFQqPbY6f80D0iclHwVWFv8SE7MdF9cwE6BkSWB3MwWJjZzT+Y/zgEuWw?= =?us-ascii?Q?ELev7dz3sqHyea9+GidbXCHlnbIvVKmdblYnUmEnACvR92PG+MXBIKFgysJT?= =?us-ascii?Q?ITkoewAZwuD6+GiIEBQLPAZNxBwuRFuTCFI8zq5uNvlAVaPgdMkGqbIKMeb6?= =?us-ascii?Q?7kfH1nzpPBVrhRZwsODLJ9MFOtaVulkytTkaGWEzT56AJyqEFrt1rTe0l2Ml?= =?us-ascii?Q?6RA0q5OLcizsM8lmbTl+xWwM3mqoF0eYSwbGzWnWcqJyMXNNC2eSsvocoVJn?= =?us-ascii?Q?OmpRotPHY+eIlFNVCoNVD6DyBRie5oAi4cTHK4vt/EeZsNbcIx7Iq3Il4+wh?= =?us-ascii?Q?zGvvjAsOVk4sr4ZMY6uhtJDwPCOH2nyHNSIDqxHBjs9TiHbPidQMK7TWxQxX?= =?us-ascii?Q?EG3gdP6ok5ETwTVLQ+lHvEDuPqu4UhDSXp16TWuLPknbsPOi1Tr41M1EVq/j?= =?us-ascii?Q?yaTh69+nWPsvrXMMnBKrdGG8bDvmjWWSDNG1UyeRMvHPojbp7YfNqC8kb4ct?= =?us-ascii?Q?XvSIjdrqUXc1mvzWlhXC/khzo5Gt2EX97trMYqqGo9tAzPuK+sHQpyDRdrj8?= =?us-ascii?Q?1E19a84wkWlOfCeUKH5NWqxJabIu53lCiAtzu5FWIss3tPZozxfhsTepZxSI?= =?us-ascii?Q?zc1dsbUK8+jOfDLusn3CswS2kl6etIw4PeqfVDAeasSLgjJWe81T8lHiUSOe?= =?us-ascii?Q?n5IrkGbbWQYPzs6/YLU0vr9z6gHQl1Xrf1YqxxBtnNwaJR2ux78bHd178P/L?= =?us-ascii?Q?/QgOTM524eQU1sQXiwe94FZgGaOyFBvzrlYkgv78ANPgpkfvUsTZ43THXJLX?= =?us-ascii?Q?F5TT1UZi8r6zgq5x3LC4g1APte0q+am6/SrcXf5isAuRLsg7A27t/52t9ECo?= =?us-ascii?Q?QgIX1CY6agedG7T/R7dKJaX3shIXPFLv8izzScymgpZtpOSIxSxt4q086Jpp?= =?us-ascii?Q?ysQIsEma97g3PCLrcy7JUtne4Gq4AnzMD/esJZJy+Rq/czO/rnjgUqfqnFDM?= =?us-ascii?Q?3JupUcN02sZtsh5nmNnbsxL+Ko9VmCmmCuZBzogZJt+w60kgwnis1e8fqFjA?= =?us-ascii?Q?EqzeKlRpCMWjtCJX5mElJ60LTCWikcGZDzyRlvm+yHXotw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SuMNJNn0cIofWHJYyKJSCykGesmzNOXdB1ThT99InZh+FqL8pFA659xPL+n7?= =?us-ascii?Q?ZD7J7B7AbrPLXpfDByNYgRmy990pJo6DAkYPUiCxHpRn8yJKZ5ax5+u4N39f?= =?us-ascii?Q?ITLZ/5nu/PLqacypjxgNNXF3Ie/xjKe/1kFs61IFTmyMPZqQVWUGqPKBhSls?= =?us-ascii?Q?lQMUfIf/5r965QvQumm3cy6hfEZgp4/ijdCwgFZMVXqntiDLkxSXSCXqZn3f?= =?us-ascii?Q?XiHpyhx92ZsXpQ4XZ1GrXyr/lVPcn1AtN9Wq5iVz/m1zZdLU8UgS2jWIq6he?= =?us-ascii?Q?ZXx/p1ALd7dZ+/akrWc0kIyGv0nDtY7CHkaipKfVHZ3pKLf+GUkPPsprIBhg?= =?us-ascii?Q?XQloUtHW8HLK4owTk3qjpb92G/zuuXYQXn4x0E7rAAyNIeRhmMdlDNfyp6pI?= =?us-ascii?Q?dhDn0M5I3xKt599hv7JAuiGS42zeb/+D02Cdn5W5MZC5AyksrrLIY08pdB6B?= =?us-ascii?Q?5oLsZDo2zRvd4nmAGIlcezRr13pYbximQhxB15YmifnOB02is52PDnNI09dz?= =?us-ascii?Q?BvcijUfYcaBA6NzvxvwNWOdghNeCVUXko7+k5Aw0vR+OuVO0r7bzUyXqe8aB?= =?us-ascii?Q?fOdFxtjyeWXcG0+htFHQpfhjZEqrY3Qq2esoIo3hHaNrHCXKg3ZwAyFqgpl6?= =?us-ascii?Q?0YuIupEi5aYNUTxJgkf90i3gzdr9VRNhCRc2TEO05SsLzPq2jFaPhCB/83HH?= =?us-ascii?Q?j00QZNZTYv5Di0RRQttV0ZKG0vyrRykZdvo9DVFtuey/8r6TUJUl7mM07TeV?= =?us-ascii?Q?JgHAUJK9zypOxnD0RmwNDS1kNxzneqJxztUliDFenLobTz20ygv027MsCO1y?= =?us-ascii?Q?sxAIQLYL37ZBrw40sS/CySRxaDrVqQ2qe+FQTH3+ErmJD6Fn1GFpFw900Tx8?= =?us-ascii?Q?N/smuOqC8jPvGdnMCcEBdVjvGEF/ED92fa44gTatJMuw4ankvl4O2uj2bms2?= =?us-ascii?Q?MnQuhEaqUBpmZlmwq13V/wW61CditiPPtoHm87swtdBX2DiUJl6iJPUl2D8N?= =?us-ascii?Q?qoeaCBztnYQFljHpAd2jsLaGYBNXlE4Le6NhToA049AH6/0f/5hBJ/n3kXh0?= =?us-ascii?Q?Ddf4qH8btNZuMwUpEdWIxDKlSapkTLf6OZntxoqBjZBBSGf201C18Mn0BwD1?= =?us-ascii?Q?AS/EDrRG86ZZvM5PBdGa2zvvmo0jZRxHhvHKT/5h2WpFMI5W+sGe/3/s/HBB?= =?us-ascii?Q?4FCm0MDjGuvp4bFEEBGrUZGpt74V61IEft7R6QohDIvF2GxKqRFDpr3IS7H0?= =?us-ascii?Q?SjzzQPJlLrqIqjwpGADh5MJOlCiFzsPuMf8z32J88va1cBzOpsxoZXR4AXBe?= =?us-ascii?Q?LlNd6AYOP6b56S/fQoGLYHMFvmZvGOpo3gDfX+XBkYtsMUrOE08wnXKBVbwd?= =?us-ascii?Q?HX8YS9OGtQWa5L8dd8w9qwnX7wcgVOamVHx0cNRnQ1PEYxI6BdkqRuJ4LJPW?= =?us-ascii?Q?5hTogeqUFoVjm6D0YQeZUG+E7hivPCqKimMtwOXkdEhVCbt6BOPgvFOjR5qW?= =?us-ascii?Q?rTzsOjg4sE9XFuObcuCQAzyO8TX+nOLOfPepwW7Wzcqh6+min8b5SbKIlD6F?= =?us-ascii?Q?O4QUBM8omkegbkmTo7tEHaorayu6Z6VcoDPo7FgL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c344d303-a8ba-41dc-06c9-08dc64b1c8a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 22:56:31.7539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4F/2OX6u1vDbiH5gRN8cKO6wAhOae/RwnABiuQjcwhfru8nfyVDU39Ub7jMW96AMn6udEkq0DnsfuK9jbww0QA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4824 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 24 Apr 2024 15:56:35 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hVnS6UbZgx2hFx4ScmEANIKPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="mCtDuO/T"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Hi Mike/Sean Can someone look at the EDKII CI? My PR has been blocked for 9 hours - https://github.com/tianocore/edk2/pull= /5595. Thank you Yao, Jiewen > -----Original Message----- > From: Ard Biesheuvel > Sent: Thursday, April 25, 2024 1:05 AM > To: Yao, Jiewen > Cc: Gerd Hoffmann ; devel@edk2.groups.io; Oliver Steff= en > ; Ard Biesheuvel ; Srikan= th > Aithal > Subject: Re: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in > confidential guests >=20 > On Wed, 24 Apr 2024 at 18:36, Yao, Jiewen wrote: > > > > Thanks Ard. > > > > I have submitted https://github.com/tianocore/edk2/pull/5595 3 hours ag= o. > > But it seems the CI stops working... > > >=20 > OK, I have dropped my PR. >=20 >=20 >=20 > > > > > > > -----Original Message----- > > > From: Ard Biesheuvel > > > Sent: Thursday, April 25, 2024 12:27 AM > > > To: Yao, Jiewen > > > Cc: Gerd Hoffmann ; devel@edk2.groups.io; Oliver > Steffen > > > ; Ard Biesheuvel ; > Srikanth > > > Aithal > > > Subject: Re: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver i= n > > > confidential guests > > > > > > On Wed, 24 Apr 2024 at 08:45, Yao, Jiewen wrot= e: > > > > > > > > Reviewed-by: Jiewen Yao > > > > > > > > > > Thanks, I've queued this up. > > > > > > > > > > > -----Original Message----- > > > > > From: Gerd Hoffmann > > > > > Sent: Wednesday, April 24, 2024 2:00 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Oliver Steffen ; Gerd Hoffmann > > > > > ; Ard Biesheuvel ; = Yao, > > > Jiewen > > > > > ; Srikanth Aithal > > > > > Subject: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver i= n > > > confidential > > > > > guests > > > > > > > > > > The VirtHstiDxe does not work in confidential guests. There also= isn't > > > > > anything we can reasonably test, neither flash storage nor SMM mo= de will > > > > > be used in that case. So just skip driver load when running in a > > > > > confidential guest. > > > > > > > > > > Cc: Ard Biesheuvel > > > > > Cc: Jiewen Yao > > > > > Fixes: 506740982bba ("OvmfPkg/VirtHstiDxe: add code flash check") > > > > > Signed-off-by: Gerd Hoffmann > > > > > Tested-by: Srikanth Aithal > > > > > --- > > > > > OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 1 + > > > > > OvmfPkg/VirtHstiDxe/VirtHstiDxe.c | 6 ++++++ > > > > > 2 files changed, 7 insertions(+) > > > > > > > > > > diff --git a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf > > > > > b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf > > > > > index 9514933011e8..b5c237288766 100644 > > > > > --- a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf > > > > > +++ b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf > > > > > @@ -49,6 +49,7 @@ [FeaturePcd] > > > > > gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire > > > > > > > > > > [Pcd] > > > > > + gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr > > > > > gUefiOvmfPkgTokenSpaceGuid.PcdBfvBase > > > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageVariableBase > > > > > > > > > > diff --git a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c > > > > > b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c > > > > > index b6e53a1219d1..efaff0d1f3cb 100644 > > > > > --- a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c > > > > > +++ b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c > > > > > @@ -17,6 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > > > > > > #include > > > > > @@ -140,6 +141,11 @@ VirtHstiDxeEntrypoint ( > > > > > EFI_STATUS Status; > > > > > EFI_EVENT Event; > > > > > > > > > > + if (PcdGet64 (PcdConfidentialComputingGuestAttr)) { > > > > > + DEBUG ((DEBUG_INFO, "%a: confidential guest\n", __func__)); > > > > > + return EFI_UNSUPPORTED; > > > > > + } > > > > > + > > > > > DevId =3D VirtHstiGetHostBridgeDevId (); > > > > > switch (DevId) { > > > > > case INTEL_82441_DEVICE_ID: > > > > > -- > > > > > 2.44.0 > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118237): https://edk2.groups.io/g/devel/message/118237 Mute This Topic: https://groups.io/mt/105705705/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-