public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"osteffen@redhat.com" <osteffen@redhat.com>
Cc: Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	"Ni, Ray" <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	"Chen, Christine" <yuwei.chen@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	"chris.fernald@outlook.com" <chris.fernald@outlook.com>,
	"Kubacki, Michael" <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v11 04/17] OvmfPkg: CI: use Python version from defaults template
Date: Tue, 17 Jan 2023 00:14:34 +0000	[thread overview]
Message-ID: <MW4PR11MB5872E7FA34DD9702FEF953398CC69@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230116174044.3346383-5-osteffen@redhat.com>

Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oliver
> Steffen
> Sent: Tuesday, January 17, 2023 1:41 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>;
> Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com; Oliver
> Steffen <osteffen@redhat.com>; Kubacki, Michael
> <michael.kubacki@microsoft.com>
> Subject: [edk2-devel] [PATCH v11 04/17] OvmfPkg: CI: use Python version
> from defaults template
> 
> Use the default Python version from the defaults template
> (.azurepipelines/templates/defaults.yml) in the Windows and
> Linux CI jobs.
> 
> Previous changes to the CI job templates make it necessary
> to specify a version number, if Python shall be pulled
> at CI runtime.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml    | 4 ++++
>  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 +++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 7160d95f7e04..6dd90711ac70 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,6 +15,9 @@ pr:
>    - master
>    - stable/*
> 
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>  jobs:
>    - job: Platform_CI
>      variables:
> @@ -187,6 +190,7 @@ jobs:
>          build_file: $(Build.File)
>          build_flags: $(Build.Flags)
>          run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>          extra_install_step:
>          - bash: sudo apt-get install qemu
>            displayName: Install qemu
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 7d6344d6383d..7e63f419b26b 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -14,6 +14,10 @@ trigger:
>  pr:
>    - master
>    - stable/*
> +
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>  jobs:
>    - job: Platform_CI
>      variables:
> @@ -133,6 +137,7 @@ jobs:
>          build_file: $(Build.File)
>          build_flags: $(Build.Flags)
>          run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>          extra_install_step:
>          - powershell: choco install qemu --version=2021.5.5; Write-Host
> "##vso[task.prependpath]c:\Program Files\qemu"
>            displayName: Install QEMU and Set QEMU on path # friendly name
> displayed in the UI
> --
> 2.39.0
> 
> 
> 
> 
> 


  reply	other threads:[~2023-01-17  0:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 17:40 [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 01/17] CI: make Python version configurable Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 02/17] ArmVirtPkg: CI: use Python version from defaults template Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 03/17] EmulatorPkg: " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 04/17] OvmfPkg: " Oliver Steffen
2023-01-17  0:14   ` Yao, Jiewen [this message]
2023-01-16 17:40 ` [PATCH v11 05/17] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 06/17] CI: Allow running in a container Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 07/17] CI: Use Fedora 35 container (Linux only) Oliver Steffen
2023-01-17 17:27   ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 08/17] ArmVirtPkg: " Oliver Steffen
2023-01-17 17:27   ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 09/17] EmulatorPkg: " Oliver Steffen
2023-01-17 17:28   ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 10/17] OvmfPkg: " Oliver Steffen
2023-01-17  0:14   ` [edk2-devel] " Yao, Jiewen
2023-01-17 17:28   ` Michael Kubacki
2023-01-16 17:40 ` [PATCH v11 11/17] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 12/17] BaseTools: remove ext_dep files for gcc Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 13/17] ArmVirtPkg: CI: use ubuntu-22.04 vm_image (Linux only) Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 14/17] EmulatorPgk: " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 15/17] OvmfPkg: " Oliver Steffen
2023-01-17  0:15   ` [edk2-devel] " Yao, Jiewen
2023-01-16 17:40 ` [PATCH v11 16/17] CI: use ubuntu-22.04 image " Oliver Steffen
2023-01-16 17:40 ` [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell Oliver Steffen
2023-01-17  0:16   ` Yao, Jiewen
2023-01-17 10:37     ` [edk2-devel] " Oliver Steffen
2023-01-17 12:20       ` Yao, Jiewen
2023-01-17 12:38         ` Gerd Hoffmann
2023-01-17 14:49           ` Yao, Jiewen
2023-01-17 14:52             ` Oliver Steffen
2023-01-17 18:22 ` [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872E7FA34DD9702FEF953398CC69@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox