From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.5283.1663921550306896589 for ; Fri, 23 Sep 2022 01:25:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QSwUSMVN; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663921550; x=1695457550; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kLJ4lKg7mBpkuMdsUuQBlgg/H56nNHJpOXrFdXK4Ugs=; b=QSwUSMVNXdL0KJa1LKn/pftyxjSCSCfsa0LNW2wX3du+zeoRomJ4XQPq kbPHxzrrUWaVANq2BY8pHY4pM4pDuSBVk/qChYQnqBw+XryVFIa9rU83E yo52zOj7JZzj72kJ7fnc6cgWyEwK8rQR6XawbMBKDl9N+U5uSMxD5wsnR aSM8IUGAqxX9NC8A7wGKAnJFTxpPXHqEzjj/RHP527anHDX5/Qd5rineu tx2tqe24Vl/a5LfskpmOEgdfXIGflCAAn7CgczDrgA9ugPUG0ChqNdeFU Cf9rdhbrR4/Ra41SkgUJ4IvJG+i4Y266TdkqxhwFTwcdlmJz83EDTKZKu w==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="362354018" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="362354018" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 01:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="653325088" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 23 Sep 2022 01:25:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 01:25:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 01:25:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 01:25:48 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 01:25:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X98yLKcWhwyV8UnQ/FkwjvtHqb0ufckgY17USr3hWUVqS3662awFFwhqLSFNrhQVVETsjI6kA37CFbCqhsZTIhDcmqfV9hU1jS9pS1XRY9Pe1wMpAx/Pk+Crj7kK0H9Lq6XwXumfpO96AHQbJEAhOhMuXrDd+s0Ynuw7Jy0PtD6ATS1FSuvTU0DzwGP2RM6aAU66ufV15+vnUP7glrAC5eooSk0NoAXeMKX8emsA4fSGdikArADCw5705Qb6Nuk9mEgLjA0UKnIYfDR9pNXShp+MYNlladUEciRCUaGZOJkM3ez8P9IDwAE6QjbI/l+uSDiw7qt6b60ToW+jo+AuSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e8iu63hVgMajkY3IaOwubuLamVpYVk5vii9zT7WZpgE=; b=drYcLcaTQcrIsLZevZ/vxAGFa5rW+1fsHr05Va8Muh9EguYmpUNKk9Wm8JEXndBU24N4D80fyp7K682wZlmmg+18caC550Pzguleq0oSDsACoRmAhhBVwB/6DdT8feVjB+V1a/wXRBmQUUwIJhaFPxCiZmbTlZ7n3LsWa/NbE3AlybcZ8ma8y2E2cBSasvJ+b29+Hdd9jvdJAQdZUMlfpKCSuIPjCO9J7vprEUa3Fh0zJG9CBwwSEJ3apaSx5SVSIhkyn7Esn5JEnxYPk6oWFteMNpJ7f4UVruEnMtn0jTUuRHQTotd5c9taDi+yI2HJscajJ9rTgDazaA/1QgeCiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ0PR11MB5867.namprd11.prod.outlook.com (2603:10b6:a03:42a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Fri, 23 Sep 2022 08:25:47 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 08:25:47 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH V2 0/4] CryptoPkg: add AeadAesGcm support. Thread-Topic: [PATCH V2 0/4] CryptoPkg: add AeadAesGcm support. Thread-Index: AQHYzxZFqOdSpZ1zE0u7s9vk/4pP363srerQ Date: Fri, 23 Sep 2022 08:25:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SJ0PR11MB5867:EE_ x-ms-office365-filtering-correlation-id: 9e91e368-bfed-427a-f429-08da9d3d371d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YDUYurzkE8Yzjp9R8d53CQR0VYWmgnMaqUez/dXS4lSHR5OitmFGPYa09S4KbBL/K19c4KoUfFcL7hfzPtl1NlY3rE83B6b3XMIN2TZdsty9+wP7RcyzWyMQ0qbteMwXmMOH7+PqwTS68oVaz8nnbwOe4FFasNTZ1JUJgT0tivqMyL7BPvO/tPwCr3Zj2LImhtov6gZTbWCB8kGrWJmHpmoXJeVGRmm3v+oU7YL3CQmwjQGnGpHUlZaNr8NugFs2WQAg/X8ciXog3E7KzSW2B8RQ0mLjcWyajr6lTqZnx2+r0Z12y7py3UUPIU/HgJtefdFdNpYcJJcGnxk3X2ggilBpxuHjLuGA1RB2+hsCR6sXkKU5PJiZj4u/PZJj24OMRFuYGA2FGNe1MRKKOqcF4dS9KJkVbdLHQtfmU9BxKoCtbt+UkOqLiCsnNFDO7RfQeuuvRXJ0WWeZhcsUeXcUqnZbLGZM389fP+u+uuoI0FP5E6K+0UmHTNBP9S6/+fk1LvhrZQSYY2WmiLAia0MAdvRuytJACyKxPxeDD2Yg/GiA95OGHx7rO3qTt40LD207UIukZn5/5t2GOGZ47UtfNNPhzn8j15urXPZfIrYrVPJQmNNkU7qrnT2e90ftZ5oquX6Ebt6FJ0q0mLAFbqEjcdBEiPei4TwXtOfe+cDtvoTd6PcqsdQm39sJPtXNXEkUlPJMVw0igBbDV9P+b4Z+9/TCXWR9E7Mx9IVFGWsAPgvcJReSZBoGABVFqyik4FWNlfMndv3R2aEPkj6hozvHqQPRQddA1+arIsvOkn7SL2oPxwu/BFQ0y7IWpDdot1sKEcYAFQFBYPM2SO2mvwQyxA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(39860400002)(136003)(346002)(451199015)(8936002)(66946007)(83380400001)(5660300002)(71200400001)(54906003)(8676002)(110136005)(478600001)(66556008)(76116006)(66446008)(66476007)(64756008)(41300700001)(33656002)(107886003)(316002)(966005)(38100700002)(52536014)(82960400001)(122000001)(55016003)(38070700005)(26005)(186003)(9686003)(6506007)(53546011)(86362001)(7696005)(2906002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IRaIxJ1hrv7QKZ1rst63Rih7GJ7k7w74APPMvUXBQKseBfHr2QKONJ8CfX1y?= =?us-ascii?Q?LXS+4+bwX6a6e+uJ8f5TkfjJzrOlDM5wykVcz+tOS2mc88R7MgBcl8ouYS/3?= =?us-ascii?Q?Fn0DWliqozaBKwR8eMdTJsm5HXi916fl6du9GoFJZdebKChcA2zcuuyhlsvP?= =?us-ascii?Q?Wdv4yK5KtWGbZYt2BytLcTAXViHWiCKhv+pdVxkI8uNqcgRXnfgVQiruZ0tm?= =?us-ascii?Q?bAmefEzNMa9ElXT540Ltg7jdLlJtzHx8taOO9T3/j85+pSyY7DQ3bG2CCelf?= =?us-ascii?Q?PhkQQKVDjZfrlMqFl/dWVdZXDEBnRVocCMZzSG1K/Yt7O6GeyptvuXusygC7?= =?us-ascii?Q?p//B3U/y1mlYScQQZlH8n8EzDsG9vVAVaWbxFU8rDhKt6QtS/Fd6ih92pxd8?= =?us-ascii?Q?Du3qf5yMrRvk6sEaj4ehBlYVQZKIUKgUH98/0cCg3smuFLcv/j1Mc2P9opV3?= =?us-ascii?Q?cbEjkzRHEEk6WsQBRj3H7gCrnPgeiIPbNe4wBsqjRABPSVJrNUFwFokYKHXH?= =?us-ascii?Q?eeZXfq+F9UnOeMIoY8PqJg8GuvWFw6MvS0/r3FZgjHX32aoGWlLRHO6oX8Vx?= =?us-ascii?Q?hyZ8vDsuecW+dIC+Hqg2yUZy+pE1HY6T40HGej8QZTpjsK+s94qaIYWnCacQ?= =?us-ascii?Q?xBxFo4BjG3nX8k0RW73aU977GeVtBGS3Wjvp5A9sWxVBUSVUYxt82TetqdmU?= =?us-ascii?Q?rsGY3SjWF2nGuUoKtmeLbUBmgIW0csc/y/Tlhvz3LWDw4kCCAP5ElXd+OA0P?= =?us-ascii?Q?KMGZ7ia7Slx/sH+yGOBqxQNia6GFqGJJzYpcT+11Ax6AQU0MaLb9mXmPrRs2?= =?us-ascii?Q?HextrNQX/EIWZpCLihVaA2+nhgXMZSG/Fd95bSNHWJZ8wqzUmxxRSpn1s22G?= =?us-ascii?Q?IJO5jx3GRFb7B0SoaasWWT2gmpkGEchFzerEaIV63TzzjhBsWTIRGHeEjc7a?= =?us-ascii?Q?MxoO4pO9lqY1LX2zK+HpBxhGLFjJ+T5ncjFJDajCPkpea0wELDUpLWKRTWXo?= =?us-ascii?Q?GJrNvcEOt9kFIXjeazf7ldx4d6/wiU/64pCsPszeuH6q+nF3BU7eMOCC+0YD?= =?us-ascii?Q?ODDtBXq5ztfVWlNGlBVgczlDct+cLhAoOg1LyGRsvYiy+JEzMICCteOMPuKk?= =?us-ascii?Q?tjQ5ZD1e1R9RSzRhM73vr/yrhuCuRrAjVw8wAz9Yy7uXGlemop9zu4BF7S8y?= =?us-ascii?Q?mX5P0R0SqxdIM5QmgA7VpKTk/IgdfBJ535lDNH0nUOLWSZIRApGi5Nx5l7oW?= =?us-ascii?Q?4Ivdz/FR85YY61OtUoz/h/IuDEoy3NilOSs00NM/pfiO0zUtz2c1EYaSr/pA?= =?us-ascii?Q?gT0dxJ8dr4YDIjWHNaPJz/T3VkR4+tTyMOcizFLH7JxVlIIPUrVEiUpQeTjL?= =?us-ascii?Q?XVLxRcuY0vJ+G9cFDl8oci8uoRORibGb2Z+Q245INLZ4C6jEWkQ0GJG7FncD?= =?us-ascii?Q?jAI2AUhpVfYQbri1n2auOA9z54/NhXGPWIf5ZWDNieltzBhn5G7RqJe6F0ja?= =?us-ascii?Q?Wh0YI6rdK5Njjwl9cVC71ENMVhUQ7VpirWlXGOrI5pikUwC/p4hgXzG9ImtC?= =?us-ascii?Q?ym2fxBT3QEBKowa7alJXawoS9NWMY9nk/fFQfV5o?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e91e368-bfed-427a-f429-08da9d3d371d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 08:25:46.9309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pvwaadefCALYMe4aMoFcyBLdefl9lbmnDKs69lxwQf/p7z2I9YxDRgdV8hVwSJ0Q/Gmtnlbj+dBJchxqfazJ5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5867 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3388 > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, September 23, 2022 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen > ; Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: [PATCH V2 0/4] CryptoPkg: add AeadAesGcm support. >=20 > Add AeadAesGcm Encrypt and Decrypt. > With this change, the size increase of BaseCyrptLib is about 60K bytes. > The new functions are verifed by the Host UnitTest. > And also it has been integratd in > https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been > verified. >=20 > All the code change is on the PR > https://github.com/tianocore/edk2/pull/3224. >=20 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4036 >=20 > Signed-off-by: Qi Zhang > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Reviewed-by: Jiewen Yao >=20 > Qi Zhang (4): > CryptoPkg: add AeadAesGcm function() definition. > CryptoPkg: add AeadAesGcm support. > CryptoPkg: add AeadAesGcm to Crypto Service. > CryptoPkg: add UnitTest for AeadAesGcm. >=20 > CryptoPkg/CryptoPkg.dsc | 2 + > CryptoPkg/Driver/Crypto.c | 94 +++++- > CryptoPkg/Include/Library/BaseCryptLib.h | 87 ++++++ > .../Pcd/PcdCryptoServiceFamilyEnable.h | 7 + > .../Library/BaseCryptLib/BaseCryptLib.inf | 1 + > .../BaseCryptLib/Cipher/CryptAeadAesGcm.c | 279 > ++++++++++++++++++ > .../BaseCryptLib/Cipher/CryptAeadAesGcmNull.c | 100 +++++++ > .../Library/BaseCryptLib/PeiCryptLib.inf | 1 + > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > .../Library/BaseCryptLib/SmmCryptLib.inf | 1 + > .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 1 + > .../BaseCryptLibNull/BaseCryptLibNull.inf | 1 + > .../Cipher/CryptAeadAesGcmNull.c | 100 +++++++ > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 93 ++++++ > CryptoPkg/Private/Protocol/Crypto.h | 88 +++++- > .../Library/BaseCryptLib/AeadAesGcmTests.c | 112 +++++++ > .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 + > .../Library/BaseCryptLib/TestBaseCryptLib.h | 3 + > .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 + > .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 + > 20 files changed, 972 insertions(+), 2 deletions(-) > create mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcm.c > create mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptAeadAesGcmNull.c > create mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptAeadAesGcmNull.c > create mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/AeadAesGcmTests.c >=20 > -- > 2.26.2.windows.1