Re: [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub

["Yao, Jiewen" <jiewen.yao@intel.com>]

We should remove duplication.

Acked-by: Jiewen Yao <Jiewen.yao@intel.com>


> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Thursday, May 4, 2023 9:33 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; Xu, Min M <min.m.xu@intel.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Stefan Berger <stefanb@linux.ibm.com>; Julien
> Grall <julien@xen.org>; Anthony Perard <anthony.perard@citrix.com>;
> Marc-André Lureau <marcandre.lureau@redhat.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Oliver Steffen <osteffen@redhat.com>;
> James Bottomley <jejb@linux.ibm.com>; Pawel Polawski
> <ppolawsk@redhat.com>; Michael Roth <michael.roth@amd.com>; Gerd
> Hoffmann <kraxel@redhat.com>
> Subject: [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub
> 
> An attempt to reduce code duplication a bit.  PlatformBootManagerLibGrub
> is an (outdated) copy of PlatformBootManagerLib with some policy
> changes.  Add a PCD to enable this policy and add support for that to
> PlatformBootManagerLib, which in turn allows to remove
> PlatformBootManagerLibGrub.
> 
> Gerd Hoffmann (3):
>   OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware
>   OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub
>   OvmfPkg: drop PlatformBootManagerLibGrub
> 
>  OvmfPkg/OvmfPkg.dec                           |    3 +
>  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   10 +-
>  .../PlatformBootManagerLib.inf                |    2 +
>  .../PlatformBootManagerLibGrub.inf            |   73 -
>  .../PlatformBootManagerLibGrub/BdsPlatform.h  |  185 --
>  .../PlatformBootManagerLib/BdsPlatform.c      |   70 +-
>  .../PlatformBootManagerLibGrub/BdsPlatform.c  | 1604 -----------------
>  .../PlatformBootManagerLibGrub/PlatformData.c |  212 ---
>  .../PlatformBootManagerLibGrub/QemuKernel.c   |   55 -
>  9 files changed, 79 insertions(+), 2135 deletions(-)
>  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformBootManagerLibGr
> ub.inf
>  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
>  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
>  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformData.c
>  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c
> 
> --
> 2.40.1