From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.14381.1671612885116493995 for ; Wed, 21 Dec 2022 00:54:45 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=A0g80r9p; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671612885; x=1703148885; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QDtyVEwyP0J4zJshNAMlb2t1v0ZWNOzF5JLhz/P7VHw=; b=A0g80r9phMOtQcvwj+ou6cNgfq3ROAI3GI0QED58PytYNHEhES/Bsbnf lBbzK+7VM1cJjRTXciIlg6WIFrOuOlkwM0oHq4Arg3K1qCCAroQj2aruu tLkfXHzkys7fMxfHYLmWS1kixVtZWPBy85oXBASQMvs/9339N+dJXV+SJ zc4ZBLzfF9rkIZvU4pftn59n10s+H0KHAYraMwQ69TXfpEBVBlpxeT1LU WpIRWwFXyIvsDjPrK5u9hhU1zPuruVQ3XJPc0+om0FJUDLCWXnKp+Pf9I GMPIMNdCIHHjdFK2vDb6OoNE5A9J6mYZKdDT8MF83cwM9L7PktMoLIhH+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="299500617" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="299500617" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:54:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="681962732" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="681962732" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 21 Dec 2022 00:54:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 21 Dec 2022 00:54:42 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 21 Dec 2022 00:54:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 21 Dec 2022 00:54:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VaUTCF6Lwr5fQVYLwGp8ZI+pyDLHbrNCciDvPTOlNXHMEcTtUV5l+MmiiUbI/Fqq16eqjb0sbWdr7FdDq7HvWwUN+FN4ok00+t6yKWFc+WA597EfQjQDqD3R5enz+NcY3FbCWT2YIi+BtAPGXjXQ9XbASDM2ha0qNlgdpN0J65DQ8jtV/i+m02QTodpgO0GlgF7FKHVZ3L2Z4NX/tg2VdHFUbnwUugEg3hGXgsj6APiEaVrqOqdMKDY3/vcEOnMUR7oqD3EQ1qE2YsLUeEr9Mm4ZNMYjpYvVRzSdCEZRsb37eAbYTxRrwlV8mt9hkBYKqwRNJ7RIpZPY65bn1lHPoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JSX9S71Nfi0J28pYVsRbaRmmbwEiTxxFJDD/X+wXIjA=; b=P2HWPNBPzul+00BqxUWuFWjG5/3UR/A0I2EavfODSR//HSz3sT4BzvH6ADnbklZ2XI0GIc2/pCrobLMRHGDXE0ySbbkhcegkpQg1JsUqCGgN22HoSEHz7bEWmOogyMNQ3eK98EulYmNjI9JL8RFCPv4FdvX6OXfuzm3TSrfp/A1gHOCMWmofvW6Uis2QhAFL8OEF066RCq3VTVtidJpYjSvh7duWaNDWOY6v0GTe7tL8WRhaWP0d5hmHdzoQnIXIdhgRDRkgtS1RBl78m+IjMqcJL35rc9+1lxtT2L/hKgqPdOZVpU341bTILK/TYR7YOYJmH+aWecoXXoPINW2YVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CO1PR11MB4771.namprd11.prod.outlook.com (2603:10b6:303:9f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:54:35 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%8]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 08:54:35 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , Gerd Hoffmann , "anthony.perard@citrix.com" CC: Ard Biesheuvel , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei Thread-Index: AQHZE8gaMgMXFf0lHkG82YPVos7wqq52YQsAgAGfYWCAAAuukA== Date: Wed, 21 Dec 2022 08:54:35 +0000 Message-ID: References: <20221219163620.20155-1-anthony.perard@citrix.com> <20221220072558.6af73qvo43gngqvs@sirius.home.kraxel.org> <1732C0C7E7695AF7.27785@groups.io> In-Reply-To: <1732C0C7E7695AF7.27785@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CO1PR11MB4771:EE_ x-ms-office365-filtering-correlation-id: 316baa37-7851-414e-5d32-08dae330fc36 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7MYEMG8iML31/H9/Sp94Kur7rkk76Pz1KcCus9lLkZqnxzNBROFoBpESjX0mkD4w5zY0KY+5eZp6l2kzPhbIF+BcSSM7KAxj6IC4sHbZH+fR7aXQ808C/zH+3TCmdliUoMVDwmZDFCGJRsmhGtaYU/iWp3mN7zT1dHQSt8jm5WiplENtkVqwbQ6LTeZI5QtAqiSqg3ElxMn5EbIor5Cu2S/Wc6QD7Le0GeCJ/ct2AIDo7+KVx9P1LGpcDtWqjAQciWtyBoQbQn+sxGHf3WpyxGOUI7q9xAbDDejU6YV0AWa6Py+Vo0xawMGsmwXDEQ2zsW0hDCD9DmCt6F5UW9knFazqpabD3FrCK+wP005BOLOcBQCwQW+P9sq6qVm5OhyNp2Ozd7zyUfW+jXChazQmfK5SS3GsT/bVvsfVgbnhbMYTXLF1x+pwP0TPl/c6z/KL4Z0ofgTkhulTReY6OURu064oKPGbc8BCPUupEOJaIQvPlIzzUHGnFGIRpMDUKh5YVclS/j/3BqSvSQ981xzTSxNfxAzweYqZyW4cFvAfJBdcJYK93rKIcMHob0mW0tu6D5U5XjNniwIuYUNHe5y9I9Zx4fKxl73W0ZgXNlHhUAab2B3MKmzF+G5nHvSJ/o2fLH1F2UCnTkdcHRTsOZIyVyl5Chx+gZufkG7+oAeWcLT/i/XeXc+mWtWmEqRDjvVtbS7mkKUkdcul7L204Lc7d6+pHYd5KVlMAOcWLrWH6Lg7iPxHOT8t03PS3RzqS2vxNjXoXQDp165qMtV6ZQVZhA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199015)(33656002)(82960400001)(38100700002)(71200400001)(122000001)(107886003)(186003)(9686003)(53546011)(26005)(966005)(6506007)(7696005)(478600001)(83380400001)(66899015)(66446008)(4326008)(8936002)(110136005)(66476007)(8676002)(64756008)(41300700001)(52536014)(66556008)(5660300002)(316002)(86362001)(54906003)(2906002)(55016003)(66946007)(76116006)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ALx8HvFiyHGq4zcDqAsFXCdVIzZD4m6H/EG0pqg2yBeO+zjfpMwkm8VLy7g?= =?us-ascii?Q?oB8TJDEYO1AQo+25oZnPRD0sGCEYFw0i8jO77tRr0Xsx8TZarnTmA2vkVD+Z?= =?us-ascii?Q?fPKZgnHN81NDLAIwJgTShiyOxIVoBaTDIB96ewOxcxdzTYMK+d8Hpc0Pbw6V?= =?us-ascii?Q?yArPD8+qLIZBzDpPn1Pr3JDqfwj+yD2fxti8hwNHzbkOlcoHQTxt+ukHOob7?= =?us-ascii?Q?6RR7O5S+K6LAS0Gw4fBYgR5Kyf6WhZOVD2kmF7FVPFRO6bSEnedwN2Tbe3xC?= =?us-ascii?Q?FoZpF3QbD5G85eJZjlqfF7DnfUbZOoUT/zOarRX87bG9KPhPiscNGwdZi8QM?= =?us-ascii?Q?wMLHRiTwmfO3cqfPgjRYKDfCsYWuhyT8xSewHBHH2oSrqVaJ4NzPisrL/ltb?= =?us-ascii?Q?UE194pzekSxXSoWuBU3KTrqc1Di7P69rjmd63XpKyoZgPwJOcITYMS8wCFtA?= =?us-ascii?Q?QN9DKVIK/6uDBUvrjP/JK5ncrcNaRBa061IbZATEr9jA/+5Y36rN7Ve54PJR?= =?us-ascii?Q?PP+1q6Q7VclKhMSwQHxXOdY2lmh1HCvgMHpI5GZIdc/r7HbPhwIn8GR7nXuH?= =?us-ascii?Q?3ResltBYDEAJsynYbmMS7CvNVAaX4HnIB6+lBrjPIA3il5OZFim7On5Iq4Zr?= =?us-ascii?Q?NB7XISARpOMfrTRRYBVgZFwcJ3Fw7WUw06eEyzcnZWUjGxApHhkdwOurm4aF?= =?us-ascii?Q?UzvK8l04CgMeaLIqEriVftDne0A6vLzrctqSOqu2gOWae1OPWLVn+u2Vji4t?= =?us-ascii?Q?N3nk/iHowDg1z7zbScboGEqWPeEQt+SBYnAm0UUGfILCmCWKgX9ysKWW0QA4?= =?us-ascii?Q?LBYpcbdkhccWKhOFt1l9STonFLoyrOVYieY1nDCX47Ztd56uTl+E3inAIjC9?= =?us-ascii?Q?YV9HnM2dtqGZIDrJt5Ln20qVKsJ0GdjuLkbCZyZiSTwJVwIGnvvideLVCuNB?= =?us-ascii?Q?lQrqnPXEQqp3mf2GWu17mI+ANcdtDM5MxlpcuDDBTaG4j64QN/U/jpXdjQm/?= =?us-ascii?Q?LSD//ja0Ex1j8JZF8CWZ6pRQ97CmLuFHMvUgYBA4+TMMkIKIe42t4CgJLxyM?= =?us-ascii?Q?Xv5XXotLWMpZB0IhRQeD17oT9LrIHKL1VX1/U6di0VkkxLdMrEvYKWBzyhqf?= =?us-ascii?Q?mFIE+qEVYxK8LqrcOOknVj8EnTx85fssLmMCg6VY6Z9fKOXskeXy5jEx8vXB?= =?us-ascii?Q?Tc8v21dUBUzfQUtTbojMP8TEVAlBoFFO6d5/Om2W+gOZ91zXD+iNenpwS71T?= =?us-ascii?Q?R4P+sxOznisTz7axNK0CnMdK63BjZft9QDnO/gzk4PG+1GwrmL3ArJBFMtOe?= =?us-ascii?Q?61QeA4y9w2nHZjmhvPeJA5zT3bjpwb4YCJVWUCvvlW7/NUwfDeanO5bQ7QN6?= =?us-ascii?Q?dY9PQDXBRVH+vNpAeAQVb3HZ5IS6tBXgUstlJxz7h7e5wYxxIeI+K9hGRGyP?= =?us-ascii?Q?7Gp6C9wzBAVgJXQvoc6nwzjBWhBZU/lLb4sgz2YpldsnrLSCTSi18r45prxS?= =?us-ascii?Q?41lYTNd40sUutUTU8Arv++iFVTHJprwglN1m0LhVOVAIluLyvHAgQ1Lwc2xA?= =?us-ascii?Q?USJSXgX0Qk66GaFDf11+qWwsCWscn++gYr3AIxGW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 316baa37-7851-414e-5d32-08dae330fc36 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 08:54:35.5390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1bVvMdG93axhc9HLytzWity0CgJ54c7Gc7EK0zwtiTwES9K1JrQQ85DVGU7G/SiZ0TVX2vthZ7vC7Y6b7LjYnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4771 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3814 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Wednesday, December 21, 2022 4:13 PM > To: Gerd Hoffmann ; devel@edk2.groups.io; > anthony.perard@citrix.com > Cc: Ard Biesheuvel ; Justen, Jordan L > > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform inf= o > HOB in XenPlatformPei >=20 > Acked-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Gerd Hoffmann > > Sent: Tuesday, December 20, 2022 3:26 PM > > To: devel@edk2.groups.io; anthony.perard@citrix.com > > Cc: Ard Biesheuvel ; Yao, Jiewen > > ; Justen, Jordan L > > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform > info > > HOB in XenPlatformPei > > > > On Mon, Dec 19, 2022 at 04:36:20PM +0000, Anthony PERARD via groups.io > > wrote: > > > From: Anthony PERARD > > > > > > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. > > > > > > QemuFwCfgLib expect this HOB to be present, or fails to do anything. > > > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not > > > check if the HOB is actually present for example and try to use a NUL= L > > > pointer. > > > > > > Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove > > mQemuFwCfgSupported + mQemuFwCfgDmaSupported") > > > Signed-off-by: Anthony PERARD > > > > Reviewed-by: Gerd Hoffmann > > > > You might also consider moving global variables to the PlatformInfoHob > > or use PlatformInitLib functions instead of your own copy or both. > > > > take care, > > Gerd >=20 >=20 >=20 >=20 >=20