Re: [edk2-devel] [PATCH v3 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR

["Yao, Jiewen" <jiewen.yao@intel.com>]

MdePkg *can* provide implementation. But usually, it is for a generic interface, which may be implemented by multiple architecture.

But here the TrngLib is very ARM specific, what it follows is "ARM TRNG firmware interface". For example, GetVersion, GetUUID.

As such, I suggest to name it ArmTrngLib and move to ArmPkg.

Thank you
Yao, Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Wednesday, January 19, 2022 2:44 PM
> To: devel@edk2.groups.io; pierre.gondois@arm.com; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>;
> 'Sami Mujawar' <sami.mujawar@arm.com>; 'Rebecca Cran'
> <quic_rcran@quicinc.com>
> Subject: 回复: [edk2-devel] [PATCH v3 0/2] MdePkg,SecurityPkg: Add
> support to RngDxe and BaseRngLib for AARCH64 RNDR
> 
> Pierre:
>   MdePkg can provide the arch specific implementation. BaseRngLib places
> the arch specific code into its Arch directory. If the arch logic is generic
> enough, new API can be defined in BaseLib.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> > PierreGondois
> > 发送时间: 2022年1月18日 17:24
> > 收件人: devel@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Jian
> J
> > Wang <jian.j.wang@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>;
> > Rebecca Cran <quic_rcran@quicinc.com>
> > 主题: Re: [edk2-devel] [PATCH v3 0/2] MdePkg,SecurityPkg: Add support
> to
> > RngDxe and BaseRngLib for AARCH64 RNDR
> >
> > Hello all,
> > I have a question about the this patch, and more generically the
> organization
> > of the MdePkg. The current organization, for the BaseRngLib, is as:
> >  - the BaseRngLib implements the library functions of
> >    MdePkg/Include/Library/RngLib.h
> >  - the BaseRngLib contains Ia32, X64 and AARCH64 implementations
> >
> > This means the BaseRngLib contains arch specific functions. It comes that I
> > would like to re-use one of these arch specific functions. My question is
> > then, shouldn't the BaseRngLib contains an arch agnostic implementation,
> > and the arch specific implementation be placed in arch specific folders
> > (ArmPkg for arm, I am not sure for other architectures) ?
> >
> > Another possibility for me is to me is to move the function that I want
> > to use to the ArmPkg, but this means the MdePkg would be dependent
> > on the ArmPkg. Would this be a viable option ?
> >
> > Regards,
> > Pierre
> >
> > On 5/10/21 11:53 PM, Rebecca Cran via groups.io wrote:
> > > Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for
> > > the AARCH64 RNDR instruction.
> > >
> > > Changes from v2 to v3:
> > >
> > > o Fixed the default value of
> > gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm
> > >   to be an empty GUID.
> > > o Removed RNDRRS since it wasn't being used.
> > > o Fixed the commit message to remove mention of BaseLib.
> > >
> > > Rebecca Cran (2):
> > >   MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions
> > >   SecurityPkg: Add support for RngDxe on AARCH64
> > >
> > >  MdePkg/MdePkg.dec
> > |   9 +-
> > >  SecurityPkg/SecurityPkg.dec                                   |
> > 2 +
> > >  MdePkg/MdePkg.dsc
> > |   4 +-
> > >  SecurityPkg/SecurityPkg.dsc                                   |
> > 11 +-
> > >  MdePkg/Library/BaseRngLib/BaseRngLib.inf                      |
> > 23 ++-
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
> > |  24 ++-
> > >  MdePkg/Library/BaseRngLib/AArch64/ArmRng.h
> > |  43 +++++
> > >  MdePkg/Library/BaseRngLib/BaseRngLibInternals.h               |
> > 78 +++++++++
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.h |
> > 0
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.h  |
> > 17 --
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h    |
> > 117 ++++++++++++++
> > >  MdePkg/Library/BaseRngLib/AArch64/Rndr.c                      |
> > 139 ++++++++++++++++
> > >  MdePkg/Library/BaseRngLib/BaseRng.c
> > |  87 +++++-----
> > >  MdePkg/Library/BaseRngLib/Rand/RdRand.c
> > | 131 +++++++++++++++
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
> > | 127 +++++++++++++++
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.c |
> > 0
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.c  |
> > 45 +-----
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
> > | 146 +++++++++++++++++
> > >  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
> > | 170 ++++++++------------
> > >  MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S            |
> > 31 ++++
> > >  MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm          |
> > 30 ++++
> > >  MdePkg/Library/BaseRngLib/AArch64/ArmRng.S
> > |  37 +++++
> > >  MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm
> > |  39 +++++
> > >  MdePkg/Library/BaseRngLib/BaseRngLib.uni                      |
> > 6 +-
> > >  24 files changed, 1086 insertions(+), 230 deletions(-)
> > >  create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.h
> > >  create mode 100644
> MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > >  rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
> > Rand}/AesCore.h (100%)
> > >  rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
> > Rand}/RdRand.h (72%)
> > >  create mode 100644
> > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h
> > >  create mode 100644 MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> > >  create mode 100644 MdePkg/Library/BaseRngLib/Rand/RdRand.c
> > >  create mode 100644
> > SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
> > >  rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
> > Rand}/AesCore.c (100%)
> > >  rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
> > Rand}/RdRand.c (71%)
> > >  create mode 100644
> > SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
> > >  create mode 100644
> > MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S
> > >  create mode 100644
> > MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm
> > >  create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.S
> > >  create mode 100644
> MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm
> > >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>