public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification
Date: Wed, 23 Feb 2022 13:11:17 +0000	[thread overview]
Message-ID: <MW4PR11MB5872EEF4237687BB30E745C58C3C9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <adecb9035af6e791c8fdd0765a36fca6ed1bab1d.camel@intel.com>

If you want to support PVH-only, that means you *defeature* the CloudHv in *edk2-stable202202* tag according to https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning.
I hope that is stated clearly, with justification why we choose PVH-only. Something like: "In edk2-stable202202, CloudHv supported xxx. In edk2-stable202205 or future, CloudHv for non-TDX will only support PVH, because xxxxxx. The CloudFv for TDX will continue support xxx." An ASCII table is preferred to clarify the combination.

If possible, please create a similar README under https://github.com/tianocore/edk2/tree/master/OvmfPkg/CloudHv to record such info. (configuration, feature, supported v.s. unsupported, URL link, how to build, how to launch, etc)


FYI: The readme in Microvm is a good example - https://github.com/tianocore/edk2/blob/master/OvmfPkg/Microvm/README.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
> Sent: Wednesday, February 23, 2022 8:20 PM
> To: kraxel@redhat.com; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification
> 
> On Wed, 2022-02-23 at 13:02 +0100, kraxel@redhat.com wrote:
> >   Hi,
> >
> > > Well that's a good question. If we expect the same target (CloudHv)
> > > to
> > > support both TDX and non-TDX, that means the generated TDVF will be
> > > a
> > > PVH ELF binary, which will require some special handling from Cloud
> > > Hypervisor.
> > > Having two separate targets would simplify things a lot. What's the
> > > plan for QEMU? Will the same OVMF target cover both use cases?
> >
> > Yes, there will be a single binary supporting both tdx and non-tdx,
> > some
> > configs add sev to the mix.  Doing the same for cloudhv shouldn't be
> > much
> > of a problem I think.
> >
> > In tdx mode the firmware uses the tdhob for memory detection, in non-
> > tdx
> > mode qemu fw_cfg is used instead.  The cloudhv build could switch
> > between tdhob and pvhinfo in a simliar way.
> 
> Sounds good :)
> 
> >
> > take care,
> >  Gerd
> >


  reply	other threads:[~2022-02-23 13:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 15:53 [PATCH 0/3] CloudHv: Rely on PVH boot specification Boeuf, Sebastien
2022-02-23  0:00 ` Yao, Jiewen
2022-02-23  9:59   ` Boeuf, Sebastien
2022-02-23 12:02     ` [edk2-devel] " Gerd Hoffmann
2022-02-23 12:20       ` Boeuf, Sebastien
2022-02-23 13:11         ` Yao, Jiewen [this message]
2022-02-23 14:03           ` Boeuf, Sebastien
2022-02-23 14:14             ` Yao, Jiewen
2022-02-23 16:54               ` Boeuf, Sebastien
2022-02-25 11:09               ` Boeuf, Sebastien
2022-02-25 14:21                 ` Yao, Jiewen
2022-02-25 14:22                   ` Boeuf, Sebastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872EEF4237687BB30E745C58C3C9@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox