From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.51.1650336856338691176 for ; Mon, 18 Apr 2022 19:54:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Hy+5JorU; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650336857; x=1681872857; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V+YCXhZwZI7kt6Z9u1nn5yDiysekIGHXdiKBVzSxTZU=; b=Hy+5JorUIMwMWEhrk/oITGCjTxx9U+k75oTirMr/ZH/67bCrWpUUxy4H S6jov2TaaVBdSAR0fVB9Cq1aZDUo2RuOs3x6gmG49sKolB8JsPMpybmhT ORKdHDR5q6FsKlViJekoRs/tmpuWs3vEsU5G2hqXqttIxfXVws6LYyaNG 4i4ctosbNg1Ky/xaAPpUZgkk/+mGCTOoe86Ty5QF8LKFvtXGzAiLzVrv4 tM1I4TW5p57gYZFmlKl+7LMN6zEoYhdNCOeY8B9QVy+uS39h+j111fCvL y1CLCmALOqRHhjsvJYGe9EefuSa+wC0kmoROC8w0SWAkXUc55XVrQo7Iz Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="250963092" X-IronPort-AV: E=Sophos;i="5.90,271,1643702400"; d="scan'208";a="250963092" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2022 19:54:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,271,1643702400"; d="scan'208";a="529120410" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 18 Apr 2022 19:54:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr 2022 19:54:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Apr 2022 19:54:11 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Apr 2022 19:54:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xm9hkTs+L60hUIYGyMkbbufSp87VfkhrcCEnAMsFWfiHTEy/jz9U78JIHcUplidht6q4Yj87bVbe95IqQqDjFq9DhMCTuiDsdWP1WHJQUkB/5YqVvgVv78c1yudHnqWn+bPrRKyZ/Q0iFOOD46BXT6ecKMlMPd5Mp4OFF+MG1tJ+PlkX4KIsCyIOtRH6UOCdjmlARz63n2nBdlFW3gwfJxsLd4Oj7yZD7BoTOGtKKp7+c4UxY4NrSLoMuKbpWCHJNi5pQfpRPbzuy5D5YQDclc9QSjNQiv7eziMAvoERiZ5nCYWumWgdtREgql1xljlx2hTm/+ZzgNK6ASe2fPPV0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=McOYaasR/JHY6798KLlaTJP0AuSwgSDrKQAYtz2M7x0=; b=RH1MjT5TEFw7pru47oKVILwwEDdrr0P9EVa9cXbx1Kl0UTs5Ij1najLJenhi1qqbqSk0zLHTSmkKKRJDbvOiruv/LC9sMm96RJ/dIvJ+ihFmTz2IbYe8LaSlWMjXI14+sFeNEaUZ/YSLJeuwApZZQjnQVjA0qt7K81fom10aMS93Y6rcHk0J/4SzRtMKblplg9qw48h+KRsMcls2GedDE+8R2MKviVcPVipaYnRNBWlhrrVImQasDIGAR6MqwWbsYxknfEqrieA7DjeRa09gu92L9EGJ//a1Rc17sisnKwRyJu80g652bkTdWplr1VPmgnl1N17CtFvGBkai6fHRUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SN6PR11MB3246.namprd11.prod.outlook.com (2603:10b6:805:c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 02:54:08 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a%4]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 02:54:08 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: Brijesh Singh , "Aktas, Erdem" , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver Thread-Topic: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver Thread-Index: AQHYU5EF52tkA5TcwEGoABwxC84FI6z2fNawgAAKJwCAAAIdkA== Date: Tue, 19 Apr 2022 02:54:07 +0000 Message-ID: References: <20220419015828.899-1-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc612e71-9106-4b45-e5fe-08da21afdf8f x-ms-traffictypediagnostic: SN6PR11MB3246:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zzI4w85QS2kAQEfZRrfacLqXEq/BSAlXlg4KBblWCYQnBFjUwhPsO+2knmhxV9yCDc0ltKuK3TrxqM5IGJl2R8xKHJ/fbd0lb2wDafFFKJlULiFK0hhyzk7rQG1A2KNXmF4VyAXOtZF868sdRUEdY6jCHVG2oAbVCqr7ox9NeDtGu+CkZuGXJeAKqTzh04BnLD1JZBaJtEBEGLlAfdBzNUsCMz1upgS7udr1zH+6ng0Fn2+VSgFFbtEuU02XN//fWiRrH3WWpGusEdpw1d6K30d/lrke/RP4KVGQuyNYoCzngFCFpISwTKToCKFZk3n6h6oJscceThDQW2rAkQkUD8PbVHuPkM1k2dxv4lvmofzz93mRCDEZyOq/9+Zl93/qzu0MJDeIopJap6E4PNULixzggeZTjiSmXS5gw7CyPRdjP0xnSRv/9sKbPzFY02JSVbz7+mRA/eHZYDI6kbOTT3zhJjcWaxkziC7jmYsBSaU3t+Kkg9AKYS8I9JDen6R877SCR6oWdwuPLxZbQRqGTQ+ONAEjmEqY5agqgZAIs/9/JEb6aFRrGDc/awTaZ9T0TSY0scF138htwzeXQBmhpHh33s1hlZ5YBDIvaDj+490F+aJ4JbaOkatTXhxc7ey6xS8opHDiIpL8zkM77nLgFqkJBYgnQHU9Lft9RQ8LVAbKePEuQmQ5mQ+UN+EfbbVsiO0MYtfVlDBenmQA3h20zdTaE1Y3M1X0anzHyQorJWTGiDRdJX1SlpZ5J+86AGI2nrDRHnL4jIg8igSHmRZsnIi49oFT1C0aFRsxCZaI5ns= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(19627235002)(66446008)(7696005)(26005)(6506007)(316002)(966005)(71200400001)(508600001)(186003)(83380400001)(86362001)(55016003)(33656002)(64756008)(66946007)(66556008)(76116006)(8676002)(122000001)(4326008)(82960400001)(110136005)(2906002)(52536014)(9686003)(53546011)(54906003)(8936002)(38100700002)(5660300002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+CUWzTbKoVYuAwgxmG2h1An9bO1dn9rUg5kxkjXi5eTUDo87kLego/JXyMDy?= =?us-ascii?Q?/Q7EP6/y0zOtBSPfd6N3KkmoHGZandpSEWXsr8/eE7qiodMd/5nYg2Udpruf?= =?us-ascii?Q?EYcF5LAVOJ6iI0v5cxJSFSRoNg3N3BFSKWoe+fluZwI5dnIECrsn5zqPKr9a?= =?us-ascii?Q?Nm2/Au6bSSpeOq+OwTZ+PvZnE5QhdISNpr0Foh8FOKACw8KNxuYzFw24prl+?= =?us-ascii?Q?CZ3quZESVAb7n3+J6hnp0yIsrTCh9DGWrEOEqCTNZzGce6pOin2sOoQvW8p4?= =?us-ascii?Q?wVPHMikE0wcHMnRCkTOZGrBXjcDhtDFUNP4/VU50LmwIIQ1qFxeO0TTkPtv4?= =?us-ascii?Q?JBpt2LK72RxNW2Z1TJJbTzfPK+5N46cqoHgkRnwLfGoC7BBeNDah2Dve5nRc?= =?us-ascii?Q?41RYqDOsCl62hn91aYQJxth9E1OK010Gynh3zdZihm2k+Pt1PPidRDAAN6tU?= =?us-ascii?Q?IFZ1g/R4jxb62z6X4e6SiXnMmkzBBy4JWUx8Cw4RcTQs45bSHDIOVEIb2HZN?= =?us-ascii?Q?kNKtZOYFEx9y9/uFDICh/n9TCoBJpC998BB30aMz3OJ/pHePKzwPsVwgQ2Kn?= =?us-ascii?Q?cGeq1+m+ovWmjMMeiEandfNM6W0SM+c5721qWcmw11Ttk0eB/24SRQlqD9/R?= =?us-ascii?Q?60efro+cxkDm/XI+xTPOqnPDquFTgwWlfsouY9FHZenfhIQrVe1AYd4b0CKo?= =?us-ascii?Q?tuip7IBE0ImmlrdOX89Ui0PdxFRSXw1GnjCYqQEffXY28YKr413Tr9QA87nu?= =?us-ascii?Q?SfMQYvyZTi5J+vjM4xn4hF1w7IL1tsDlcqqPSiHvZ+bcLpcGbKBjsXDicgh8?= =?us-ascii?Q?DTyTwc13qs+gvO2dldXzgZKfECaML9QQk1Lv+fLTt1h0dPCRBC7RkV1+DgSr?= =?us-ascii?Q?2bXO38qwl/9Ur13pfokRW+89AzxfLcUkT5JIwwMsVCV5JsBD9DvAuTy9m6VS?= =?us-ascii?Q?ROKGrYzUY3LeUy5awT5N9+pfVevkNKD3UU/7AtHQhEsNMyXqqEoSV5u7SrSr?= =?us-ascii?Q?LpiQIYI3Cv2WqRKwqJXMLSbgQOf/taHCPiWAj3y3M8ih0PfWuxmlZDoSy2Xm?= =?us-ascii?Q?DMSeBuLMu6JxlH8ZoTSyaWWUeRHVXCQxZJ3/yeg93p1/ULJN5IZl/jc8g21q?= =?us-ascii?Q?aoUauQckNwwcPrl1axFYJvzcm3bXVfnMmyLNQdRA4RrnC8KY5x8eXw95OiPX?= =?us-ascii?Q?5hshfatKuCXiW1QLdLLrx8f6xMpKHlZ5ofYAPjj/qp9xVUzxG/UPhhN0VJaW?= =?us-ascii?Q?VPmcCc60IeR15asIjoqdxaurA/seTwJ1OyQ0PxcbUW1ZfOcUFA+Enh/6YP/w?= =?us-ascii?Q?2ga7w5r5pWr3EU2NGesFv1djPILshfUe/mzhCqEU2L4lXlYuqO5znzF4dJU6?= =?us-ascii?Q?iLTW2qDPYMCANk4j/hZmpvhUVAfqxwUzLoP3uKkhTUpxNLG3RdZOfHZIRGQD?= =?us-ascii?Q?7dcyzqtmnWGgS6w40unN9YW9bbXENEa89+F6xjUdb8XYpmuuZexlWP9foBZI?= =?us-ascii?Q?njKUGmRwLCgMQ16vsqaU0m1vzXXHR99zTTZGUQX7pPjfK2e50+FBwt+UmwF1?= =?us-ascii?Q?KQfZiqCY8bW/n+wZaPPMz6p+NssJiFwdyhRVdV8MdPlhRiZPoelZLXaruD5O?= =?us-ascii?Q?ZBQmK5P7AgeIQHV7WE/o6f37u/Cng0j0gvaywMpbfjO6mH639URdgMCGD0XX?= =?us-ascii?Q?7yf5Z6ds5Eo8XZHJLO7U/4yNeT74Yf41XjHsqzA1/4kljj+qkWp7RuqUdGlg?= =?us-ascii?Q?n8klCzettA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc612e71-9106-4b45-e5fe-08da21afdf8f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 02:54:07.9151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Epfce28AE6G3BfGcNwEj708AQuE+p5iJcVM3fUXZgLCs7oWgVdv8bIfjwnIfrohoh/B7jzRWed6dWuCQOAYsTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3246 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Why does TdxDxe call TdxMailbox in an SEV platform? Or why does TdxMailbox call SynchronizationLib in an SEV platform? There are many places we can do CcProbe to stop action. Why we need do it i= n DSC? In general, DSC lib override should be the last option, because it requires= the platform integrator aware such tricky thing. I strongly discourage to = use this, although it is architecturally support.=20 I do believe we have many other ways to achieve the same goal. Thank you Yao Jiewen > -----Original Message----- > From: Xu, Min M > Sent: Tuesday, April 19, 2022 10:42 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Brijesh Singh ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver >=20 > On April 19, 2022 10:08 AM, Yao Jiewen wrote: > > > > If TdxDxe breaks SEV, should we skip the TdxDxe in SEV path? > > > > I don't understand why we need use Cfg8. > > > In TdxDxe driver we need to relocate APs and it requires the TdxMailboxLi= b. > The lib chain is that TdxMailbox -> SynchronizationLib -> TimerLib (whic= h is > DxeAcpiTimerLib) -> PciLib (Which was DxePciLibI440FxQ35). > TdxDxe driver was loaded before AmdSevDxe so its lib constructors are cal= led > even it is in SEV-ES guest. In other words those lib constructor cannot b= e skipped > in SEV-ES guest. >=20 > The analysis of the root cause (why DxePciLibI440FxQ35 trigger the broken= ) is in > below link: > https://edk2.groups.io/g/devel/message/88968 >=20 > Thanks > Min