From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 61CA2AC0841 for ; Wed, 13 Sep 2023 02:04:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Mpl7G1g9thfF7axnVoms75pTdUGggGFLoEzQPP1RZ2c=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694570667; v=1; b=k4Dtt9tDXliz/w1A6HOub9I7r4d7iiirhvCZyk9arkfMoytWStvfZoaoRvhBKhr/Lm/+gqIG YuEtnqx3kyTaZY9ko+4378BNoi1XrLqew+4CDS3D2w6/NhnK7OsRkdGP0RAezCRziczMEzKXuIg 4Nm5GKwJ4H8nYA9xX3bBYiX0= X-Received: by 127.0.0.2 with SMTP id xAL5YY7687511x2LkHiuqgJU; Tue, 12 Sep 2023 19:04:27 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.2751.1694570666392542874 for ; Tue, 12 Sep 2023 19:04:26 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="377450176" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="377450176" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 19:04:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="779025614" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="779025614" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Sep 2023 19:04:25 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 12 Sep 2023 19:04:25 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 12 Sep 2023 19:04:24 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 12 Sep 2023 19:04:24 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 12 Sep 2023 19:03:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaJ4mWiGDEnxUhWIVY6IINwe6/0Q2lp/GnN2mbq95xz6rO8vz4pWrmy07SQhJS4GG6UqXUW0ytiD9QT+8iIGI0ZT55Afjv+8hn3KlNb4ZS+UucNlt1IhqhwAG8CExTxugi5oRYc8somlS28JsSkP2VG9v2fhIynZjg4JOkqCZLZDl+3iLvOKSVyKxouB/zBN6LDadj5X+PLrdZ4Ho2nGH4NX8jmsLN3ceTNnIOflYqZj3TRrAjSAZbQSGhKAwuOll1l/tz7NIHCaI0pNcMd0Ag45SC9PP41wC3MJTcYyLAUparMd2G8bmKEicF2XuMXcfdnXIIdT1Kr4IMWyyVBIlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kn8nd+0id6b4UseuYdCn0f7LFSO5HY1g2SUevZ8ZnmA=; b=mQUjri6ISinA6MR1lejv5obNQAUTsqSXye50gz0pjN06yp793VXwljvtVEb/G7xeS50c6/grl/qolceOtFQSJQXF08uNzrsGouzxvLSQlJleRCTVYs9jzrs5cqiu1Iyhz7sHqFEtUelvGgw000Xjzb1GwkYghocTek3HWBsCfSgya4XqGTjrdx0NpGkH4sxQ5qDuYpcA7Tma+ctdhIDVporgkfgBmFeglwURKeRpXxYs2ghf8HLeSWuLGLUiwT/C9Tx4Kw6XBb6AGjqAYOQKRbUXcjICd2sXdtfjPlC8VQPQrVSZbRPSMNAwyqGp3q30Rwkc9kqjtaExw88WQRjyTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB4721.namprd11.prod.outlook.com (2603:10b6:5:2a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Wed, 13 Sep 2023 02:03:47 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6768.029; Wed, 13 Sep 2023 02:03:47 +0000 From: "Yao, Jiewen" To: "Liu, Linus" , "devel@edk2.groups.io" CC: "Zhang, Qi1" , "Kumar, Rahul R" , "Chen, Tina" , "Chen, Xiao X" Subject: Re: [edk2-devel] [PATCH v3] Pyrite support - Secure erase is only available if encryption is supported. Thread-Topic: [PATCH v3] Pyrite support - Secure erase is only available if encryption is supported. Thread-Index: AQHZ5RpbiLBGCshncEiu2hDM9Fp0NLAYAskA Date: Wed, 13 Sep 2023 02:03:47 +0000 Message-ID: References: <20230912014159.513-1-linus.liu@intel.com> In-Reply-To: <20230912014159.513-1-linus.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM6PR11MB4721:EE_ x-ms-office365-filtering-correlation-id: 4927fe74-123a-4e45-717a-08dbb3fdaac6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pq5yr21IzBQsK8JT7qVmZoGV6NbCN8qvPLPVJN34pk2sYB6Es93CQqZPzdONaXXTq6AmB2BnGbOK+6J77QkEPhw9UXO3pWgwstH2GcWb48O4MDxzkIilcoBDgofJtOEoekpjPHBvyxaspy0lHZmX6Xar1qwxyEnKgLZ97tCe/3E8Hs/TDL+NRwR/wT3fWyhfYBxbaeCaihyGBl3Q3alrC6xsXKdYfvebRGDn9uGINOKZl5t92VkWZKE8qiV0tsv4nhNqwLA84+0/n5m4q5y9rP7ZcsNUhf3c/KTr3CrO5W0jzq74jWQ+9rGMBRXITA45F1f1RCocmhTd2y2rSqp7OqNwGNFgdYL532XpyJBmDMZWa+YHu3jFw6ew0Oi0jXb178OFFvhSFwyZTvO9Q+1vO9hRXIgViHuXffX6N4I6VAnIqyJmIQ5rbHY8+gbABvMZ0JnxjBTJZrIKE/1jr2vVfh+u6t1GX/ZKr3WNnj4mwiH03b0DMvpo8syQ96fFhkApJl+0RrIhs88nlkDqDDLfcOuliIbSGuojuPVxD43sTfgDlaWV814VFgx0jnr2wSyCa9cny9V6SOsFb00dUEB0uEtXOHIBdw9hO+5cMlXnU/Y= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vThS8DqT+oyI4slIm7uUtSJsVmtGsSsXHfjwm+99YNLmgi92Z21A//auGREO?= =?us-ascii?Q?gJTUhlFtrXn2rKzQJ3pb/0/eyzwVeVXofUYq/yWkoxMU05riTSafhL7PtSf+?= =?us-ascii?Q?1S9iyenZ7tGdq6d6Ooa+0MlhXtSH9Fvk2JszSlGlyPhd5vV7+JEYk5QO5REy?= =?us-ascii?Q?Q3dJAgQnn+jDPPcroyTgELfmDSdgWwSm8Tz2Dm2wOzklzRbhDIx3cul6bWK4?= =?us-ascii?Q?u4rw1QrE2W4qi+jDoz+Zk4Oo4wjDcehKsWlJ3HDfgNSnYVFuMbVq3e76ZHMU?= =?us-ascii?Q?i+YE3EKyKaLHDKjaPdVb4mvGRccmkKBWmYgXOjqNomSCPW4ySVIpqQeeHDjF?= =?us-ascii?Q?4mrJP6aKl71PlOdJBYx53Ox1DO1pYct13xAzNmLq3p2n5xCAVst6VgPiDiGn?= =?us-ascii?Q?ethAIHAP4DKulg6MwrhFjR/6Gy0uErdlwCCLVjHA0ARMwNQ7jTgDpRnUrc6r?= =?us-ascii?Q?auoPAB5CKPFuh8kLPLs0MDMmaf7FQFGbjry1aRQ4KFTDxBbBhblOgpFpKWco?= =?us-ascii?Q?R975Acvh+TA0JmBkM0sNYsqnLw7oaifp6IG9VAGJ3Kidx11NvuPbu9SFIf0v?= =?us-ascii?Q?OdtJc1frklVgQNR0pDCwAdXj7uo9uX62ZZXhQBeMbslRZvnyKzVcb/jI2xuu?= =?us-ascii?Q?NVnYyreTngOmuN3bzKql/PeWdInvhc3z/4wEtJr/NdPhBgmwG0Jmcaes60Qh?= =?us-ascii?Q?2MiNZGFFHfyJ9vOXsRvASkhhnAkmCk7uwzugsgjWQjjQ65fmQLEiwoQeKUEa?= =?us-ascii?Q?BL4n9tFj7I6EwRqtIb4nkhKg3MSouZZfNDXvfu+Cv9XSJn3xLH4Qt3JLDyjT?= =?us-ascii?Q?MjtfQCT2Oea7sRU7WGVpybC8AYUaoT8jg5wQKfwY/nlf0K7uyHKo+++uniYE?= =?us-ascii?Q?Q50NQ89OxJD+4UcD+by+rg7QeEOVg6GmAyT+mqQKX22ZwJf047RqaWRX0+lM?= =?us-ascii?Q?ODwlFR0GI1M2lJ9KWOF7PMbq8R6dP1oXAJiy2kKrdi0S81bsnnIKue+z57Uz?= =?us-ascii?Q?rDI8ZTKYaccx3BIVp3SspzdsbC5X4+RlzVbdqpiO7VoJOIWFcIDW+XV6wAr5?= =?us-ascii?Q?K0Y40tl5f3KlkbiAzGXu1yrHIj9LpEmslNr/NDxbh8MizH/qhETmf9xLC98K?= =?us-ascii?Q?4U4KqxHxsONZKTwl3KirznDPdJeLNGOUOkApLPkWnxLykWEo9/lIsu0A7716?= =?us-ascii?Q?fKRtz8bGpCHdF7OMNEzGJUq8w9QSUQXy7ApaabF1ctWeqMKEOd2LIF/sBQ2O?= =?us-ascii?Q?+I2f3/gDrVHCqedFF8F1EpueYPeu7Bag1pbzAzlO0+aNUZ1+5DByg6v+sr4D?= =?us-ascii?Q?dwb6czp+NH0wGtwEwI7qJFv3fp3KyKnB+HrtQ0lCVJ55+hgXJIpx4YKqv2M3?= =?us-ascii?Q?IrbWBC1poWD59Uv0xAr5j4a68kuGUpKepDBjTQ5LXJc2Zfz1qHfmmk6sCfvy?= =?us-ascii?Q?LaWXBmWAiqMBcXvAZAr27Uqzlx/WOFs48KKS4ek5dqrazncNL0+iBQGS/Wpq?= =?us-ascii?Q?NnQB4Ydb26JyeG4l0G66/ZKdPjUJROrc4or/FhLgas5NDLmFCZqwbWAcSaeW?= =?us-ascii?Q?OoGy8rJ4XKC4wpU3TqyMMneggcZuntCVmJtCyBWx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4927fe74-123a-4e45-717a-08dbb3fdaac6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2023 02:03:47.6235 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F9HPbqjO7r8u+mIaI5xDCXkDBL97BhyBi7WtbQK4n76rysFmfyL+cXoU8w/hjc6Hv/zb5/96HiMkyUJ4Y0+QkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4721 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GCvqqLXtOKyfqUDJdDez5sXex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=k4Dtt9tD; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Jiewen Yao > -----Original Message----- > From: Liu, Linus > Sent: Tuesday, September 12, 2023 9:42 AM > To: devel@edk2.groups.io > Cc: Liu, Linus ; Zhang, Qi1 ; K= umar, > Rahul R ; Yao, Jiewen ; Ch= en, > Tina ; Chen, Xiao X > Subject: [PATCH v3] Pyrite support - Secure erase is only available if en= cryption is > supported. >=20 > From: Linus Liu >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3004 >=20 > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > Cc: Tina Chen > Cc: Xiao X Chen > Signed-off-by: Linus Liu > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..ba9fa66c60 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key >=20 > // this is only available if encryption is supported >=20 > // >=20 > - AvalDiskActions->SecureErase =3D 1; >=20 > + if (SupportedAttributes->MediaEncryption) { >=20 > + AvalDiskActions->SecureErase =3D 1; >=20 > + } else { >=20 > + AvalDiskActions->SecureErase =3D 0; >=20 > + } >=20 > } else { >=20 > AvalDiskActions->PsidRevert =3D 0; >=20 > AvalDiskActions->SecureErase =3D 0; >=20 > -- > 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108555): https://edk2.groups.io/g/devel/message/108555 Mute This Topic: https://groups.io/mt/101307436/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-