Re: [PATCH V3 0/3] CryptoPkg: Extend Tls library

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thanks for the update.
For all patches, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

I think we need MdePkg owner to give R-B or A-B for TLS definition in MdePkg. Mike or Liming?

Thank you
Yao Jiewen


> -----Original Message-----
> From: Li, Yi1 <yi1.li@intel.com>
> Sent: Monday, October 10, 2022 10:40 AM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [PATCH V3 0/3] CryptoPkg: Extend Tls library
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
> 
> Review PR: https://github.com/tianocore/edk2/pull/3400
> This patch sequence is used to extend Tls library, which are wrapped
> over OpenSSL. The implementation provides library functions for EFI
> DXE dirver and Protocol.
> 
> All APIs passed unit test and fuzzing test, detail as:
> 1. Unit test:
> New Tls APIs tested on Intel platform as part of WIFI WPA3 feature.
> 2. Fuzzing test:
> Various Fuzz Testing are employed across the all introduced APIs, and the
> test is used AFL (2.52b) and Libfuzzer (clang+llvm-11.0.0) as the fuzzer,
> based on HBFA.
> Fuzzing Pass Rate is 100%;
> The Code Coverage of new APIs is 91%.
> All test case show in:
> https://github.com/liyi77/edk2-
> staging/tree/HBFA/HBFA/UefiHostFuzzTestCasePkg/TestCase/CryptoPkg
> 
> V2 change:
> Move the newly added APIs to the end of struct PCD.
> V3 change:
> Corrected tls specification reference and tls cipher suite names.
> 
> Tested-by: Yi Li <yi1.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Yi Li <yi1.li@intel.com>
> 
> Yi Li (3):
>   MdePkg: Add Tls configuration related define
>   CryptoPkg: Extend Tls function library
>   CryptoPkg: Add new Tls APIs to DXE and protocol
> 
>  CryptoPkg/Driver/Crypto.c                     | 155 +++++++-
>  CryptoPkg/Include/Library/TlsLib.h            | 126 +++++-
>  .../Pcd/PcdCryptoServiceFamilyEnable.h        |   5 +
>  .../BaseCryptLibOnProtocolPpi/CryptLib.c      | 146 ++++++-
>  CryptoPkg/Library/TlsLib/InternalTlsLib.h     |   4 +
>  CryptoPkg/Library/TlsLib/TlsConfig.c          | 366 +++++++++++++++++-
>  CryptoPkg/Library/TlsLib/TlsProcess.c         |  32 ++
>  CryptoPkg/Library/TlsLibNull/TlsConfigNull.c  | 123 +++++-
>  CryptoPkg/Library/TlsLibNull/TlsProcessNull.c |  23 ++
>  CryptoPkg/Private/Protocol/Crypto.h           | 136 ++++++-
>  MdePkg/Include/IndustryStandard/Tls1.h        | 112 ++++--
>  11 files changed, 1177 insertions(+), 51 deletions(-)
> 
> --
> 2.31.1.windows.1