From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.2140.1665369999128400538 for ; Sun, 09 Oct 2022 19:46:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=L3ET789U; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665369999; x=1696905999; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VGipiRBvkHkS1RlSoWzph1mjh7UF8CNp9z/EqyXWGN0=; b=L3ET789UFW5C+/w+ASYQB7LhTyrGCIi5HJut63dVlT90hTNqetXxQd+0 9Ih9PiQwgHhJrm1vCndqcMCIS+F/8y37NU3pCC/ssUvviMk1YkR/aMJ/I TmRGolSirE2J/ChaYV/SV0qEhePQWXI6u+iokWgoA0CJ3gPMa5f0/x0d+ FnFhs1w6wRG6WygdAMRtGgEBTAnXQJrTchF4SYglOOIj9XhfupVc0JnPl zVBYfKi05W4IEJ4Jbt2ie4K5c4x3hgE6jZM78GWodS8l+HdGQvX6pwutX cvSIx2o0Tpc0qZftJB+Dj6XyPH8t1fdMu0cjYFvEe4o2sn1kjv0izICxy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="291413190" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="291413190" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 19:46:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="659003503" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="659003503" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 09 Oct 2022 19:46:38 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 19:46:38 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 19:46:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 9 Oct 2022 19:46:37 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 9 Oct 2022 19:46:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAsXUch7XQqOVULh0t9+pw8Pjxno4wBhCXcZ813lh7J/TLgu4Czrv/V8jjxsEaxC+Ge2RJS+qXc+0UxvMLUMd1LLsOcwQ4jXmZtvA/GPq85k+w7kXhoF+2cTcQ5d81fiAl8OUEZolmXocDxa6ecpzR1Y3Yz6sMIwDsUxZReDikfX124gQ+MMehAzCiH+1my5DHNqdB9JoEYiBAPgbl9C4qv4tbd5Y7WaoCfSEOPi+AHnSQNk4UMJBIhKv1HomALXjCjlfKnXuePCf6AumRTX49Z9BeaEd7W4gyHILEFoJuSFHx6VlhxaaEOY2zWH8b6/OFKbbnga7arkW+hAeDnOlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KUwj+OEpAGOQ76NwEqFktTiv8hCU/HJFAWYY14CO/lI=; b=gI9KdTdzQe/FHOSqClSgwbGjZvjps2/JVaUh+Rj0MEOmv5EHkxTH07nBU6qeeKXoubZnEQoGc2ji+oLeGrsytIqi90Uj9yWkV84A0n5HnmioBtqdhEG3o0wS/HWrR47vNBfVtd/EFK+YTtcSYu5qoHYF9ZlsHAOnASU6JtWFyZRf7g5bOjxtWEbUl6lZlX9cC0arDmmxn+2ncLSFYQeWj9pjw6dgeQvar82cAnfEfo8Sz95ONiahzVIc4U/H1zICq0ZdutFUvBqwVzX6v4yZQxOOTS8/3mkPIJqbEOrRoQp9zMxYhqxbi4+y3XGTO6fyqoEGgDTKrMk09VuR93dV5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB4627.namprd11.prod.outlook.com (2603:10b6:5:2a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 02:46:34 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf%6]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 02:46:34 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [PATCH V3 0/3] CryptoPkg: Extend Tls library Thread-Topic: [PATCH V3 0/3] CryptoPkg: Extend Tls library Thread-Index: AQHY3FGsSRLTJWwvK02JJCfsi+Tz1q4G6+xA Date: Mon, 10 Oct 2022 02:46:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM6PR11MB4627:EE_ x-ms-office365-filtering-correlation-id: 62ca5d14-e072-4cc2-2830-08daaa69a507 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yXqudtQxHxOwu5OdIGcOG70ALUMdbDCrLxqwTILaT7pLngzR0DBzRcHg820QoGWjCHxR9e/huTbbmRVX7PBDuJifxJdtgBouvzln0x1ymhop8PIdlTu4rNN5ZJ7rX3qIs3NN9/dcRPiFnTK26kRlRISkg99WyT7ti4pghcIE50CYLxh/FvZk2PAAL/fQki9zH0PSBTymfVT3qknptwL35xBjQmu6XoHmbCFH45GQDaeuovNa/qmAUaL3P1jMrAkxyKfTFCiI4vWSj5ZlriRma2ETJj8RfS36cL9RHj0JOAV/sX330YHL9L9tHtnYFLQZEttvg5iK6makXdFwajieQKXZJEz7LS1uWuUcIh/Myjb7i3RwJxW9j9v79QWs/DYzOjWZyG6dKd4f6oAN33jA3+j0gvO3vzCnin8KckM49tIcHyJdYsa3cOAfZxGTEnSH70MqIOl0lDUak0Qy/bzzO0zIdhFQli/sgRd7Mv2nj9r0F8i+eLFTKtVJxT/Xgh1EyTU9Tlu+GacBKIjwZFwTNgPDMYM/D5YPk4t7Ia9Zp5A8Kj4YdqXvadftPfwFyekV86Pylxi1rENip/GD47CcLGLLCVG+nuz7sT1vZISIXdEcon99qeFunsU3iM0O4rpd+0GZ1xWNSwXA5BoGjynQVq/DnB7adeesag+OsciHxOO3GY2MdqCTRrBpDiMi5D3z+nlUArrGIUKu8eihSWk1qB493FXVZobwxMCXsPluGETyRQRoCu2CGzXFWNixa4kwymEXlXcsLTr7NrkS6aGWGctDj5GhhWwX/PTFXVkZzVhBq7UgPI9ES2HnHYCZ8RYFbrr8uS3GSWlTC2rpPao/gQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199015)(38070700005)(38100700002)(110136005)(316002)(19627235002)(122000001)(82960400001)(8936002)(54906003)(5660300002)(86362001)(2906002)(66556008)(66446008)(66476007)(66946007)(4326008)(76116006)(52536014)(64756008)(186003)(41300700001)(8676002)(53546011)(9686003)(7696005)(6506007)(26005)(71200400001)(966005)(83380400001)(478600001)(55016003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HWmf1SsPTFcn3KKDyILFAtwNakqHwAueVyVK1mbb79tqoI+et9qRR4OhWDUM?= =?us-ascii?Q?ybnFnstAKceP1Sryknh8Eh3B24mhF6UI/FfotIOeXfSjQIH6/FqPL7el/Aol?= =?us-ascii?Q?wR6F3JU8FJPvAFmKs1MAH7ioQIhvK0lV0v4lBCK/DwpX7c4AOmlupp1bkgT3?= =?us-ascii?Q?7FPYzjEECevme9KU0vp+EXILq31clfr/kmLJRGNuTCFDQzbWflVJjMR4wGTm?= =?us-ascii?Q?0bXnexg9xcmpuZWswW9NVN/LKRxkbhns4l4zWj5ib44LJoJgU6f9uVrrrLE3?= =?us-ascii?Q?rP+lD43tfyRrP0IAeU6vJTsdRm5IhLwTcxysycGI8QwEaoAD/V84fT3ubQKz?= =?us-ascii?Q?+69ktJPiT1L0DKnaDS5XZAnmVrHeaVmpFDS46R+0IEoLLTf4ziKozUecGtqk?= =?us-ascii?Q?cBcu2WkoZUGeA0NN+0T7EY0+QoFsQUtZBGbIwY0oSccM/TmhpStEJe5nNN8A?= =?us-ascii?Q?jm3gTPLsQbCOs+9FLpC0lmzSdOP2wmQMCVADNRtPWDtEob2ufz4gaL+NyHZI?= =?us-ascii?Q?8vevF3aPKr1BIJPZn353grpEiwFlWoLzggLLtWUkqmB3eXH31qhxXr0nDBou?= =?us-ascii?Q?l2PC13ISN9SJXPbQ6Q1svLtnkgaboSty9LszBWradmSP8mo/6/RkwkUB/QLr?= =?us-ascii?Q?M7WJFcoteTcwCiBgcs/+SqqfyQpwEVxqTqfzc0k3U3BA00vuvywyATjRjujU?= =?us-ascii?Q?OCE1mndXRgLPiYnX0cAuHpYj7RwVSBWRQJcbBlSsvpaz9upwbpksR7gFHTbm?= =?us-ascii?Q?m4AVQRgCJzTPr0E2qVfI/Bx0Zc02hT1iU3OoILLsykqxPzajlz4tkZHMqh5Q?= =?us-ascii?Q?VWMvjccj9WPpcyNz1mYl5dT2Q9gjEtUic/jggwdWT3/ZbHLq8efPHmf5jDPB?= =?us-ascii?Q?hRctU3zwVnhAyGWEB8DGCHeb2B9i0+5y1+QBuSMgzij2qQd7IyStAgni7S71?= =?us-ascii?Q?i0kz0QnTNBW3ytMn1TTXrdYG7O+FhAcer263HtPAtZJNiZcSVTLJeTIFINxm?= =?us-ascii?Q?3KGbDoymY0bilJqAI4JkE2qcdRGOBqc5IVjgUOyBknXYSOmOIv84v+QqjmpN?= =?us-ascii?Q?fDRbh4K7By1iIxPCg6SxLhxyhBviPtU1L8MGrXrpwZk23Om+gIIrmWDqO1Mj?= =?us-ascii?Q?5R0Llg3UvbR1KZzd7cpQJywNkgejG3SHng/65PSmRb8UYupNHnkZVowHegRb?= =?us-ascii?Q?w4ThEAlI7sHS3AMtvfc6qyabrV6fRQZci52D65EaKcv/xYr/XPm22ZlDzhnO?= =?us-ascii?Q?pOOQSajvC0zeIgQKIIo0hh8GSU21iN2M0pFmgpASnpHqCCotRNK3H+L8P8qB?= =?us-ascii?Q?GTzUSoEv50sEZG3WZWXNFVq3GwRNInE8aJDO42EteTq5NPOFForad3u7SkZn?= =?us-ascii?Q?M+lA6Aj9xYGuFKETU3bWwvBorSOnzXuYy+7MD7TswOb5kxx+b8/Lo+v/b+RB?= =?us-ascii?Q?edepToPiIJn5Cngg14KHxf52u3BcBnABxXjIF9H7xqL8nii5l0pjdomGBeXC?= =?us-ascii?Q?b5xyrX9hv0zXTDP1Zh13IzKzwnf7RJcuVFGv07kUljRfQVZt1aC3NR2t2bMN?= =?us-ascii?Q?k9+uaItfhxuzVC13j/TV+pjRYa8jC3JtlzuGKoHz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62ca5d14-e072-4cc2-2830-08daaa69a507 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 02:46:34.2718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: urJKJGD158gFWFtlukawCuPL+1rmrb2DIEtwzrSyRmj366zWQFF1eLPRpUVMApW8/T7MD5L9ZBAgnVgfkwCNIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4627 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the update. For all patches, reviewed-by: Jiewen Yao I think we need MdePkg owner to give R-B or A-B for TLS definition in MdePk= g. Mike or Liming? Thank you Yao Jiewen > -----Original Message----- > From: Li, Yi1 > Sent: Monday, October 10, 2022 10:40 AM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang, > Jian J ; Lu, Xiaoyu1 ; Jiang= , > Guomin ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH V3 0/3] CryptoPkg: Extend Tls library >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3892 >=20 > Review PR: https://github.com/tianocore/edk2/pull/3400 > This patch sequence is used to extend Tls library, which are wrapped > over OpenSSL. The implementation provides library functions for EFI > DXE dirver and Protocol. >=20 > All APIs passed unit test and fuzzing test, detail as: > 1. Unit test: > New Tls APIs tested on Intel platform as part of WIFI WPA3 feature. > 2. Fuzzing test: > Various Fuzz Testing are employed across the all introduced APIs, and the > test is used AFL (2.52b) and Libfuzzer (clang+llvm-11.0.0) as the fuzzer, > based on HBFA. > Fuzzing Pass Rate is 100%; > The Code Coverage of new APIs is 91%. > All test case show in: > https://github.com/liyi77/edk2- > staging/tree/HBFA/HBFA/UefiHostFuzzTestCasePkg/TestCase/CryptoPkg >=20 > V2 change: > Move the newly added APIs to the end of struct PCD. > V3 change: > Corrected tls specification reference and tls cipher suite names. >=20 > Tested-by: Yi Li > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Michael D Kinney > Cc: Liming Gao >=20 > Signed-off-by: Yi Li >=20 > Yi Li (3): > MdePkg: Add Tls configuration related define > CryptoPkg: Extend Tls function library > CryptoPkg: Add new Tls APIs to DXE and protocol >=20 > CryptoPkg/Driver/Crypto.c | 155 +++++++- > CryptoPkg/Include/Library/TlsLib.h | 126 +++++- > .../Pcd/PcdCryptoServiceFamilyEnable.h | 5 + > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 146 ++++++- > CryptoPkg/Library/TlsLib/InternalTlsLib.h | 4 + > CryptoPkg/Library/TlsLib/TlsConfig.c | 366 +++++++++++++++++- > CryptoPkg/Library/TlsLib/TlsProcess.c | 32 ++ > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 123 +++++- > CryptoPkg/Library/TlsLibNull/TlsProcessNull.c | 23 ++ > CryptoPkg/Private/Protocol/Crypto.h | 136 ++++++- > MdePkg/Include/IndustryStandard/Tls1.h | 112 ++++-- > 11 files changed, 1177 insertions(+), 51 deletions(-) >=20 > -- > 2.31.1.windows.1