From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.15054.1682581854282739272 for ; Thu, 27 Apr 2023 00:50:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QEnmyUzD; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682581854; x=1714117854; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GHEl0vlrro9x0qDvabs9XRm0PuepeNCLgMeFTMixZ98=; b=QEnmyUzDJlgF7yTRGF0m9o0lghZe4g0kxNsSfsyPjbJDYBOAb3Mpsw5/ K7L2h3GC79Lc9s0VK9SmMYC+4NBEx291Tt2fjpgQc6DWUUHABMNybxD6g 18pcipLrIFIIrWjhO/CxQ3dBOooFuzy7QJpBOlczmkwVovkqhXzBACS4B 1FGlBKDooH96KmzlvevBHBcRt/Nf5AugFl+nak9GI9qBdT01Qb8ujsNRY 6tNUTybrjMFl1xq92JnTr6l1J+d0HQOTSQN/yzFmAL0hGtp8aeV/yDlAu lphjR/ADRzz1qlyZxxkHmO2zDVKtIzBlQ7cdQczTzN/sGFL3XDt7LwN6e A==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="433645669" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="433645669" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 00:50:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="1023977525" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="1023977525" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2023 00:50:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 00:50:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 00:50:43 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 00:50:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 00:50:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdMDzQkuISfrpQIEcUhe5KpyK4Y5Q/91Rv5K1U0OsLnG32A3xDd/hzNLdGzmFvIs9QnprlBRkGj8qDPB7M5CcgqI4jugbv13vwKHxnNrBuGGAbO/bmdM6o51K1ZIybmT0qBW3EHZIS8Kf1Rd9MyLa8SLdsPgp0LLzmdeST83I59507a4iHQO6SJG4X4k/AH5PyMlmQ3keZGVSRy2HAVpLjkEpojlB5F32E8nmy/x7rz1YSnZ0NjdqzsVJUhatF0i2EFqbPLSzauc5kJ0W0MfWOjrI5rtSobzlEd1TPFO59MKtE36oDiXdeW4U+AEkq7WC2siW3TBh6wxYKJFoUvewA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aLAxluLieCRxFDpeIkWQhz12waMue4+p889ExAQ5bGQ=; b=bizNC9vVW0yIKrFHB82X9IlD12kcIWIGL6+spwfYkpI1uzLLdXQmGZMNN+GFQdS2DRJFajR06k794jY91TnYoMdYHet+7DaJGX/46wzHdlzfRaUfBdgiswlVKBGsA1HV/hEBJnOseSOleeY9mw/lvKHLnV7PqW3E8zDnp3ive9y01kS1ddtyqCJ4R1p7mdszaEM2X7cYGowQL5C2JHQ/ot7WHZZJVUnwSIQtLBiRrCTpuR2lxhQbyFx7vJqwerjBXHS0GLwbWVYUbznmvHwJi+3KKprimIbwxnUtTHy99ITLH6NP9pNfmhobr0QFb7m6UY/DYB6FUfkKStMjtJddFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM4PR11MB5279.namprd11.prod.outlook.com (2603:10b6:5:38a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 07:50:41 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388%6]) with mapi id 15.20.6319.022; Thu, 27 Apr 2023 07:50:41 +0000 From: "Yao, Jiewen" To: "Lu, Pen-ChunX" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Topic: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Index: AQHZeNXMJtPvBOVXr0GNyctV11trcq8+yAdA Date: Thu, 27 Apr 2023 07:50:40 +0000 Message-ID: References: <20230427065830.29735-1-pen-chunx.lu@intel.com> In-Reply-To: <20230427065830.29735-1-pen-chunx.lu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DM4PR11MB5279:EE_ x-ms-office365-filtering-correlation-id: de43b6a1-e4e7-4f5f-271a-08db46f4190b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sr+ENdxA6auMpdIi3MLqWi7LyDivrMEcjCIzY9FHO2odcjBB0T3me65O4Abt0nf1c0VzE4R/5bNbj80j65mpzVi4aLGx8Y/JjZmbIwyjkfpVhUBylCi3ocsQT1oSmrjEBmiAq0YMIj9BorcjviRaHZxy4FNfv8gT0V4CjpjaujjuUF5AQOJh4jiCuOL2S3BJm4kYxETY1YLCXAeY2riuaYMIOK/8FnTz0oZ6TjyX18Tep5s4rd8wh4cywKA4i6Ym95wWOlwRCapghTIYbF5fLtS06rYzZoBt0uk7uq8anthPPZXzaItJpmYV7PAM4bH+EYWcH9aB1MVXiy0Mt7XPSHnX/SMhPV6Go6DSF0qRgDvwaq2vp7Kc35k4vjUhEwjbTkMrA8xqx+HswvJnNvWod6CxxCaH8EPDoPtUMrPYxMeICGOi1KtcNOthjkLriJxlBjhnfOewR6+TNfiJcQ/52cPb5vIhfKCIUUOLMmn6yFjJLGVGxDReWir58nVrdhLLv+jbHJkL62KVqFcTHmrdd4fiSwC9t56hcfigbxq8PRcKvFqtI1oDrL/QByb1O0rJ1w7NJHJkYbckXi7XXaM/xIPldTiukia9aacoPZDm7jkQHeVJRFSEHLu5oXnCqnBo x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(396003)(376002)(136003)(39860400002)(451199021)(4326008)(82960400001)(66446008)(76116006)(66556008)(66946007)(316002)(66476007)(64756008)(83380400001)(186003)(71200400001)(110136005)(7696005)(478600001)(41300700001)(8676002)(122000001)(8936002)(38100700002)(38070700005)(5660300002)(52536014)(26005)(53546011)(9686003)(107886003)(6506007)(2906002)(15650500001)(55016003)(33656002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XLKTyaglC3p85wvi/+xrH4TRHsRKkfgz0ufNktV+Rp4SqbCiKYtSl84fn3f8?= =?us-ascii?Q?6h9G4Fb9s8bJdaLmUH5Shhl0lYGFw40RpQLyYMh6SccMevq+9tl2295h8UYI?= =?us-ascii?Q?gQmkSWQ+LoSmfpIOAS8HIFo2/3PyG2FwDAkRoJc6YnjDPNCOhEjFMcMf7X8F?= =?us-ascii?Q?Aler546BPfrUxTcW+5rFzIqIXmXTJXKoy4uHaMfSfQzLpcFncsdV4wZ62NEO?= =?us-ascii?Q?c709PzXVSMHiL2nr5d80Z2HlRqGOD+zJisZtMIV/8seq3F4csNiXuLLvBs3j?= =?us-ascii?Q?vk21fRcz/kavdxhdFbnDlVFXJmT6AlKovOxJquectIfq6KCAFMiaJEAeeaxy?= =?us-ascii?Q?DcbRDfo/yf9MBdEffCUGmoU96u1qyDJFdE1JhdpMIDf3aL8Sm6JxPdmtSE1i?= =?us-ascii?Q?KFKgdwq2ezKSc4EfsnLRMe+QdhwsjTF1QApbJ4uUfKFGkZGYJukHYEvfZQw5?= =?us-ascii?Q?D+EBfJoEfpmuenYudTnlXlMb8rLrvcH5EvRiafw9WtkfhfUtfMCJXfVqxUD/?= =?us-ascii?Q?tgIYnaBb1jm4kUUl4GRMM5idunr7lcGxXhGR5gn/6F3qJZFkpLZzQNx14ucy?= =?us-ascii?Q?0h3+VqE8L0fK6v3TFsbUB5KBzbvYnQftXbj3t3avwP/yj5VE00hHUcFMmn7x?= =?us-ascii?Q?sWNBw1C11dW7nVq0FLwila6aHpsiFbs0peuhJt+jQp4lnbTaC85SB8eiXrrv?= =?us-ascii?Q?F+uaOY9EymJcImc3yrf8XL1tEZG8gOjXeiFWtv0eic3k18xOfMUwrALlCLSA?= =?us-ascii?Q?znnSL4dZqbfN5D5wedCizlfTWryWJx2j/TCZA0ua+0uV17FJ+Y1F9fU2+Upy?= =?us-ascii?Q?JG1f86IrujURMrJz+EGlCRMmRRFzEUh6pbv2Se8DBg5sSMvhSWCl/cqHHXkl?= =?us-ascii?Q?+JKYcv9TWMXzrVqxY4TLFg8CqxkM8BpobEuunQUtOB9wXWaZOcECedCpjmcY?= =?us-ascii?Q?YtGUStfQrtajvdHWVMKE4Nj3y48zILsAduPdl71oQO0lZuy7vwUewbdX/GV/?= =?us-ascii?Q?JMiC5TXC7Sax/svHC5BhMfQI/TlnjnqmfPq5A0cqCqgqnNjPU3/OBufSr8Jq?= =?us-ascii?Q?q3hLPUn9Vpr6EeIfTUBZd6B5NGcrbT/iye5j9vdmYeq2uf/3F94+JAoqefo+?= =?us-ascii?Q?Ng/cGMjOw+3kP3JwyiQNSoxurq+VD8EJGbEhBsIVw5/lSOYDebuLxJQpLJ4+?= =?us-ascii?Q?PhDYx2phPAgJi8ZIZ5JKzWCV5OPxdHwxCKUdjBE5PBc/d+iyJ/kxjH/UiWLc?= =?us-ascii?Q?cPxzT/cKNofUmMxFa6COMpLvdhRY/IS+dEi6VzD/g9egsMzXGs2mhjcYU0Ni?= =?us-ascii?Q?xIO46d2KrYOKAWEif+1/H5KoK7YKdjZuqf7U4+XVDPD82Uftv3TQeo5Zp4Qh?= =?us-ascii?Q?9lAsUOGkZqpvje+aqET9ltFci+ZYAHTWYKfjJ8RmefAWafmUF5FU4BTXrj+o?= =?us-ascii?Q?jbpbWxxozXZP/+jQQxVy/smdy34+mOvyka8PioN9dF+fYMVTv46UJYjOjlNY?= =?us-ascii?Q?ZsWUVkkJ3Paqjq0UpwUisNFV7Fwf5vJlQe8bkGS3xWU5UI6fR2Gx75brtmTD?= =?us-ascii?Q?KMDiKsyqAfFbxcaxDz4EZKUd/8Yi075mujPyAoPl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de43b6a1-e4e7-4f5f-271a-08db46f4190b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 07:50:40.8789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WMKM7opkHfBcfWX1fUMKA02hStFYfU1csvXPvyZr4CVYzJ9FfcBveYiY452wma/EKS9b0+oe4NqtoEkNaDkOEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5279 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi I am not sure if I can understand the patch. Would you please clarify what the problem is in the original code? > -----Original Message----- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Lu, Pen-ChunX ; Yao, Jiewen > ; Wang, Jian J > Subject: [PATCH] Release build in GCC5 has warning message Wreturn-local- > addr in HashPeiLib >=20 > CC: Jiewen Yao > CC: Jian J Wang > Signed-off-by: JoeX Lu > --- > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > index eeb424b6c3..bf7a5fc65c 100644 > --- > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > +++ > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > EFI_GUID *Identifier > ) > { > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *HobBuffer; >=20 > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > + HobBuffer =3D NULL; > + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof > (HASH_INTERFACE_HOB)); > + if (LocalHashInterfaceHob =3D=3D NULL) { > + return NULL; > + } > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > + HobBuffer =3D (HASH_INTERFACE_HOB*) BuildGuidDataHob > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > (LocalHashInterfaceHob)); > + if (LocalHashInterfaceHob !=3D NULL) { > + FreePool (LocalHashInterfaceHob); > + } > + return HobBuffer; > } >=20 > /** > -- > 2.31.1.windows.1