From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>
Cc: James Bottomley <jejb@linux.ibm.com>,
"Xu, Min M" <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Aktas, Erdem" <erdemaktas@google.com>,
Michael Roth <Michael.Roth@amd.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"aaron.young@oracle.com" <aaron.young@oracle.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup
Date: Mon, 28 Feb 2022 02:47:04 +0000 [thread overview]
Message-ID: <MW4PR11MB5872F6AC8874C6247E06DA1F8C019@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <16D7D2238C7EE163.30539@groups.io>
Merged - 534e411, 3a60389
https://github.com/tianocore/edk2/pull/2553
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Monday, February 28, 2022 10:27 AM
> To: Brijesh Singh <brijesh.singh@amd.com>; devel@edk2.groups.io
> Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Aktas, Erdem <erdemaktas@google.com>; Michael Roth
> <Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>;
> aaron.young@oracle.com
> Subject: Re: [edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup
>
> Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Brijesh Singh <brijesh.singh@amd.com>
> > Sent: Monday, February 21, 2022 10:59 PM
> > To: devel@edk2.groups.io
> > Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> <min.m.xu@intel.com>;
> > Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> > <thomas.lendacky@amd.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> > Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
> > <erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>; Gerd
> > Hoffmann <kraxel@redhat.com>; aaron.young@oracle.com; Brijesh Singh
> > <brijesh.singh@amd.com>
> > Subject: [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup
> >
> > This is the first of cleanup for SEV MemEncryptLib. The library uses
> > the CPUID followed by the MSR read to determine whether SEV is enabled.
> >
> > Now that we have a workarea concept, the logic can be simplified to
> > store the msr status in workarea and use that to build PCDs and then
> > later simply use the PCDs instead of going through the CPUID and RDMSR.
> >
> > The complete branch is available at
> > https://github.com/codomania/edk2/tree/sev-workarea-cleanup
> >
> > The series also fixes one of the issue raised in the bug
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3582
> >
> > Changes since v1:
> > * Cache the PCD reads so that we can avoid reading PCD while performing the
> > virtual pointer conversion.
> >
> > Brijesh Singh (2):
> > OvmfPkg/ResetVector: cache the SEV status MSR value in workarea
> > OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from
> workarea
> >
> > .../DxeMemEncryptSevLib.inf | 1 +
> > .../PeiMemEncryptSevLib.inf | 1 +
> > .../SecMemEncryptSevLib.inf | 1 +
> > OvmfPkg/Include/WorkArea.h | 12 +-
> > .../DxeMemEncryptSevLibInternal.c | 145 ++++++++----------
> > .../PeiMemEncryptSevLibInternal.c | 139 ++++++-----------
> > .../SecMemEncryptSevLibInternal.c | 80 +++++-----
> > OvmfPkg/Sec/AmdSev.c | 2 +-
> > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 38 +++--
> > OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm | 3 +-
> > OvmfPkg/ResetVector/ResetVector.nasmb | 3 +
> > 11 files changed, 194 insertions(+), 231 deletions(-)
> >
> > --
> > 2.25.1
>
>
>
>
>
prev parent reply other threads:[~2022-02-28 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 14:59 [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup Brijesh Singh
2022-02-21 14:59 ` [PATCH v2 1/2] OvmfPkg/ResetVector: cache the SEV status MSR value in workarea Brijesh Singh
2022-02-21 14:59 ` [PATCH v2 2/2] OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea Brijesh Singh
2022-02-28 2:27 ` [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup Yao, Jiewen
[not found] ` <16D7D2238C7EE163.30539@groups.io>
2022-02-28 2:47 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5872F6AC8874C6247E06DA1F8C019@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox